Re: [pulseaudio-discuss] [PATCH] UI form enhancement (question)

2018-03-23 Thread Nikita Zlobin
In Fri, 23 Mar 2018 23:03:29 +0200 Tanu Kaskinen wrote: > On Sat, 2018-03-24 at 01:03 +0500, Nikita Zlobin wrote: > > It appeared, that i already made commit, while email in git was set > > to nick877...@gmail.com. Should i revert and commit with current > > email, or this is

Re: [pulseaudio-discuss] [PATCH] UI form enhancement (question)

2018-03-23 Thread Pali Rohár
On Friday 23 March 2018 23:03:29 Tanu Kaskinen wrote: > On Sat, 2018-03-24 at 01:03 +0500, Nikita Zlobin wrote: > > It appeared, that i already made commit, while email in git was set to > > nick877...@gmail.com. Should i revert and commit with current email, or > > this is acceptable? > > We

Re: [pulseaudio-discuss] [PATCH] UI form enhancement (question)

2018-03-23 Thread Tanu Kaskinen
On Sat, 2018-03-24 at 01:03 +0500, Nikita Zlobin wrote: > It appeared, that i already made commit, while email in git was set to > nick877...@gmail.com. Should i revert and commit with current email, or > this is acceptable? We don't mind what email address you use, but if there's some reason why

[pulseaudio-discuss] [PATCH] UI form enhancement (question)

2018-03-23 Thread Nikita Zlobin
It appeared, that i already made commit, while email in git was set to nick877...@gmail.com. Should i revert and commit with current email, or this is acceptable? ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org

[pulseaudio-discuss] What could cause "Assertion '!e->next' failed at pulsecore/queue.c:104, function pa_queue_pop(). Aborting." ?

2018-03-23 Thread wellington wallace
Hi! PulseEffects developer here. Every now and then when my applications starts it crashes with: Assertion '!e->next' failed at pulsecore/queue.c:104, function pa_queue_pop(). Aborting. This error is one of those that almost never happens and when it does it has no obvious reason. What could be

[pulseaudio-discuss] [PATCH] UI form enhancement (description)

2018-03-23 Thread Nikita Zlobin
Hello. Just to add some comment with screenshots. Old screenshot is a bit outdated, as i did it for release, not get version (really i just replaced installed glade file with new). E.g., get version has fixed tabs, while old showes them as from release 3.0. new: http://i.imgur.com/KXSnzMz.png

[pulseaudio-discuss] [PATCH] UI form enhancement

2018-03-23 Thread Nikita Zlobin
From: Nikita Zlobin Padding around scrollviews inside notebook is removed - bottom panel now top padding as well and both are visually separated. --- src/pavucontrol.glade | 66 --- 1 file changed, 57 insertions(+), 9

Re: [pulseaudio-discuss] [PATCH v3] Fix memory leaks

2018-03-23 Thread Tanu Kaskinen
On Fri, 2018-03-23 at 17:26 +0900, Jungsup Lee wrote: > The returned string of the dbus_message_iter_get_signature() must be freed > with dbus_free(). > --- > src/modules/module-stream-restore.c | 7 ++- > src/pulsecore/dbus-util.c | 7 ++- > src/pulsecore/protocol-dbus.c

[pulseaudio-discuss] [PATCH v3] Fix memory leaks

2018-03-23 Thread Jungsup Lee
The returned string of the dbus_message_iter_get_signature() must be freed with dbus_free(). --- src/modules/module-stream-restore.c | 7 ++- src/pulsecore/dbus-util.c | 7 ++- src/pulsecore/protocol-dbus.c | 6 +- 3 files changed, 17 insertions(+), 3 deletions(-)

Re: [pulseaudio-discuss] [PATCH v3 1/4] bluetooth: ofono: Use Acquire method if available

2018-03-23 Thread Tanu Kaskinen
On Thu, 2018-03-22 at 14:56 +0200, Luiz Augusto von Dentz wrote: > +static int card_connect(struct hf_audio_card *card) { > +DBusMessage *r; > +DBusError err; > + > +if (card->connecting) > +return -EAGAIN; > + > +card->connecting = true; > + > +dbus_error_init(); > +