Re: [pulseaudio-discuss] [PATCH 3/4] Add A2DP aptX, aptX HD codecs support

2018-12-13 Thread Pali Rohár
On Thursday 13 December 2018 18:42:11 Pasi Kärkkäinen wrote: > On Thu, Dec 13, 2018 at 04:36:59PM +0100, Pali Rohár wrote: > > What is the purpose of adding aptX codec (non HD variant)? It is not > > better then default and mandatory SBC codec. > > > > When using AptX codec one can be certain it's

Re: [pulseaudio-discuss] [PATCH 3/4] Add A2DP aptX, aptX HD codecs support

2018-12-13 Thread Pasi Kärkkäinen
On Thu, Dec 13, 2018 at 04:36:59PM +0100, Pali Rohár wrote: > What is the purpose of adding aptX codec (non HD variant)? It is not > better then default and mandatory SBC codec. > When using AptX codec one can be certain it's always 352 kbps bitrate. with SBC you never know what you end up using..

Re: [pulseaudio-discuss] [PATCH 3/4] Add A2DP aptX, aptX HD codecs support

2018-12-13 Thread Huang-Huang Bao
It's just a ability. If we want to disable aptx or adjust it's priority, just modify enum pa_a2dp_codec_index or using pa_a2dp_set_max_priority(), pa_a2dp_set_disable(). On 12/13/18 11:36 PM, Pali Rohár wrote: > What is the purpose of adding aptX codec (non HD variant)? It is not > better then de

Re: [pulseaudio-discuss] [PATCH 3/4] Add A2DP aptX, aptX HD codecs support

2018-12-13 Thread Huang-Huang Bao
People want using aptx(HD) early. So I decide to use ffmpeg. 90 samples are only 90/44100 s = 2ms , which is ignorable. On 12/13/18 11:43 PM, Pali Rohár wrote: > On Thursday 13 December 2018 19:43:38 EHfive wrote: >> diff --git a/src/modules/bluetooth/a2dp/a2dp-codecs.h >> b/src/modules/blueto

Re: [pulseaudio-discuss] [PATCH 1/4] A2DP api with multi-codec support

2018-12-13 Thread Huang-Huang Bao
"a2dp-codecs.h" copied from bluez, then added a2dp_aptxhd_t, a2dp_ldac_t. I don't want to debate too much about naming. On 12/13/18 11:35 PM, Pali Rohár wrote: > On Thursday 13 December 2018 19:43:36 EHfive wrote: >> +#define A2DP_CODEC_SBC 0x00 >> +#define A2DP_CODEC_MPEG12

Re: [pulseaudio-discuss] [PATCH 3/4] Add A2DP aptX, aptX HD codecs support

2018-12-13 Thread Pali Rohár
On Thursday 13 December 2018 19:43:38 EHfive wrote: > diff --git a/src/modules/bluetooth/a2dp/a2dp-codecs.h > b/src/modules/bluetooth/a2dp/a2dp-codecs.h > index aefafb635..a6f054aec 100644 > --- a/src/modules/bluetooth/a2dp/a2dp-codecs.h > +++ b/src/modules/bluetooth/a2dp/a2dp-codecs.h > @@ -141,6

Re: [pulseaudio-discuss] [PATCH 3/4] Add A2DP aptX, aptX HD codecs support

2018-12-13 Thread Pali Rohár
What is the purpose of adding aptX codec (non HD variant)? It is not better then default and mandatory SBC codec. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: PGP signature ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.

Re: [pulseaudio-discuss] [PATCH 1/4] A2DP api with multi-codec support

2018-12-13 Thread Pali Rohár
On Thursday 13 December 2018 19:43:36 EHfive wrote: > +#define A2DP_CODEC_SBC 0x00 > +#define A2DP_CODEC_MPEG120x01 > +#define A2DP_CODEC_MPEG240x02 > +#define A2DP_CODEC_ATRAC 0x03 This is incorrect, Atrac codec has A2DP ID 0x04, see: http

[pulseaudio-discuss] [PATCH 1/4] A2DP api with multi-codec support

2018-12-13 Thread EHfive
Separate A2DP processes from bluez5-util, module-bluez5-device. Add prop "bluetooth.a2dp_codec" to pulseaudio sink/source properties. --- src/Makefile.am | 15 +- src/modules/bluetooth/a2dp-codecs.h | 115 --- src/modules/bluetooth/a2dp/a2dp-api.h

[pulseaudio-discuss] [PATCH 1/4] A2DP api with multi-codec support

2018-12-13 Thread Huang-Huang Bao
Separate A2DP processes from bluez5-util, module-bluez5-device. Add prop "bluetooth.a2dp_codec" to pulseaudio sink/source properties. --- src/Makefile.am | 15 +- src/modules/bluetooth/a2dp-codecs.h | 115 --- src/modules/bluetooth/a2dp/a2dp-api.h

[pulseaudio-discuss] [PATCH 3/4] Add A2DP aptX, aptX HD codecs support

2018-12-13 Thread EHfive
Optional (build with --disable-bluez5-aptx-codec) --- configure.ac | 18 +- src/Makefile.am | 8 + src/modules/bluetooth/a2dp/a2dp-api.h| 12 + src/modules/bluetooth/a2dp/a2dp-codecs.h | 3 + src/modules/bluetooth/a2dp/a2dp_aptx.c |

[pulseaudio-discuss] [PATCH 0/4] [bluetooth] Adds A2DP AAC, aptX(HD), LDAC codecs (v2)

2018-12-13 Thread EHfive
Dependent on FDK-AAC >= 0.1.5, ffmpeg >= 4.0, libldac (https://android.googlesource.com/platform/external/libldac, https://github.com/EHfive/ldacBT) Configure codec by ` load-module module-bluetooth-discover a2dp_config="ldac_eqmid=sq" `, etc. Origin: https://github.com/EHfive/pulseaudio-modules-

[pulseaudio-discuss] [PATCH 2/4] Add A2DP AAC codec support

2018-12-13 Thread EHfive
Optional (build with --disable-bluez5-aac-codec) AAC User Configurations: KEY VALUEDESC DEFAULT aac_bitrate_mode[1, 5] Variable Bitrate (VBR) (encoder) 5 0Constant Bitrate (CBR) (encoder)

[pulseaudio-discuss] [PATCH 4/4] Add A2DP LDAC codec source support

2018-12-13 Thread EHfive
Require https://github.com/EHfive/ldacBT Optional (build with --disable-bluez5-ldac-codec) LDAC User Configurations KEY VALUEDESC DEFAULT ldac_eqmid hq High Quality (encoder)auto

Re: [pulseaudio-discuss] [PATCH 0/4] [bluetooth] Adds A2DP AAC, aptX(HD), LDAC codecs

2018-12-13 Thread Huang-Huang Bao
Please approve [PATCH 1/4] A2DP api with multi-codec support. The mail is just too big. On 12/13/18 6:53 PM, Huang-Huang Bao wrote: > Dependent on FDK-AAC >= 0.1.5, ffmpeg >= 4.0, libldac > (https://android.googlesource.com/platform/external/libldac, > https://github.com/EHfive/ldacBT) > > Config

[pulseaudio-discuss] [PATCH 2/4] Add A2DP AAC codec support

2018-12-13 Thread Huang-Huang Bao
Optional (build with --disable-bluez5-aac-codec) AAC User Configurations: KEY VALUEDESC DEFAULT aac_bitrate_mode[1, 5] Variable Bitrate (VBR) (encoder) 5 0Constant Bitrate (CBR) (encoder) aac_fmt s16 16-

[pulseaudio-discuss] [PATCH 3/4] Add A2DP aptX, aptX HD codecs support

2018-12-13 Thread Huang-Huang Bao
Optional (build with --disable-bluez5-aptx-codec) --- configure.ac | 18 +- src/Makefile.am | 8 + src/modules/bluetooth/a2dp/a2dp-api.h| 12 + src/modules/bluetooth/a2dp/a2dp-codecs.h | 3 + src/modules/bluetooth/a2dp/a2dp_aptx.c |

[pulseaudio-discuss] [PATCH 4/4] Add A2DP LDAC codec source support

2018-12-13 Thread Huang-Huang Bao
Require https://github.com/EHfive/ldacBT Optional (build with --disable-bluez5-ldac-codec) LDAC User Configurations KEY VALUEDESC DEFAULT ldac_eqmid hq High Quality (encoder) auto sq Standard Quality (encoder)

[pulseaudio-discuss] [PATCH 0/4] [bluetooth] Adds A2DP AAC, aptX(HD), LDAC codecs

2018-12-13 Thread Huang-Huang Bao
Dependent on FDK-AAC >= 0.1.5, ffmpeg >= 4.0, libldac (https://android.googlesource.com/platform/external/libldac, https://github.com/EHfive/ldacBT) Configure codec by ` load-module module-bluetooth-discover a2dp_config="ldac_eqmid=sq" `, etc. Origin: https://github.com/EHfive/pulseaudio-modules-

Re: [pulseaudio-discuss] [PATCH 2/4] move stream after default sink is changed.

2018-12-13 Thread Tanu Kaskinen
On Mon, 2018-11-05 at 09:47 +0800, Hui Wang wrote: > When default sink changes, the stream should be moved to new > default_sink too. Except if the stream's preferred sink is the old default sink. > If it is user to call change default function, > all stream will move to new default sink uncondit