Re: [pulseaudio-discuss] [PATCH 1/4] A2DP api with multi-codec support

2018-12-15 Thread Huang-Huang Bao
On 12/16/18 5:48 AM, Pali Rohár wrote: > On Thursday 13 December 2018 19:43:36 EHfive wrote: >> diff --git a/src/modules/bluetooth/a2dp/a2dp-api.h >> b/src/modules/bluetooth/a2dp/a2dp-api.h >> new file mode 100644 >> index 0..b357555d0 >> --- /dev/null >> +++ b/src/modules/bluetooth/a2dp/

Re: [pulseaudio-discuss] [PATCH 1/4] A2DP api with multi-codec support

2018-12-15 Thread Pali Rohár
On Saturday 15 December 2018 23:15:14 Pasi Kärkkäinen wrote: > On Fri, Dec 14, 2018 at 12:01:57PM +0100, Pali Rohár wrote: > > > > > > > > Therefore that priority list is not always enforced. > > > > > > How do you know? > > > > Because I wrote my own implementation of aptX and FastStream codec >

Re: [pulseaudio-discuss] [PATCH 1/4] A2DP api with multi-codec support

2018-12-15 Thread Pali Rohár
On Thursday 13 December 2018 19:43:36 EHfive wrote: > diff --git a/src/modules/bluetooth/a2dp/a2dp-api.h > b/src/modules/bluetooth/a2dp/a2dp-api.h > new file mode 100644 > index 0..b357555d0 > --- /dev/null > +++ b/src/modules/bluetooth/a2dp/a2dp-api.h > @@ -0,0 +1,170 @@ > +#ifndef fooa2d

Re: [pulseaudio-discuss] [PATCH 1/4] A2DP api with multi-codec support

2018-12-15 Thread Pasi Kärkkäinen
On Fri, Dec 14, 2018 at 12:01:57PM +0100, Pali Rohár wrote: > > > > > > Therefore that priority list is not always enforced. > > > > How do you know? > > Because I wrote my own implementation of aptX and FastStream codec > support for pulseaudio. Also I played with bluez a lot. In summer I sent >

Re: [pulseaudio-discuss] [PATCH 1/4] A2DP api with multi-codec support

2018-12-15 Thread Pasi Kärkkäinen
On Fri, Dec 14, 2018 at 06:48:05PM +0800, Huang-Huang Bao wrote: > I don't want to debate too much about naming. In this state, we should pay > attention to codes function. > > Broken codes and useless codes could be cleaned up after this patches set > applied. > The common practice in opensour

Re: [pulseaudio-discuss] [PATCH 3/4] Add A2DP aptX, aptX HD codecs support

2018-12-15 Thread Pasi Kärkkäinen
On Thu, Dec 13, 2018 at 08:53:05PM +0100, Pali Rohár wrote: > On Thursday 13 December 2018 18:42:11 Pasi Kärkkäinen wrote: > > On Thu, Dec 13, 2018 at 04:36:59PM +0100, Pali Rohár wrote: > > > What is the purpose of adding aptX codec (non HD variant)? It is not > > > better then default and mandato

Re: [pulseaudio-discuss] [PATCH 3/4] Add A2DP aptX, aptX HD codecs support

2018-12-15 Thread Pali Rohár
On Friday 14 December 2018 00:16:24 Huang-Huang Bao wrote: > 90 samples are only 90/44100 s = 2ms , which is ignorable. Yes, this not a problem. Problem is that first 90 samples is just "garbage" or rather initialization data for predictor. And to prevent hearing such "garbage" when decoding stre

Re: [pulseaudio-discuss] front-panel headphones not working with Intel PCH and Realtek ALC892 [solved]

2018-12-15 Thread Peter F. Patel-Schneider
Well, if not really solved at least I patched the problem, which is not really about pulseaudio at all. The Realtek ALC892 has a pin group that is by default a second line-in but can be switched to be an output pin. So there are four inputs by default, two mic-level inputs and two line-level inp

Re: [pulseaudio-discuss] [PATCH 1/4] change bool save_sink to char *preferred_sink

2018-12-15 Thread Hui Wang
On 2018/12/12 下午9:39, Tanu Kaskinen wrote: Thanks for working on this! Sorry for slow review, I hope I'll be much quicker to comment on subsequent iterations. On Mon, 2018-11-05 at 09:47 +0800, Hui Wang wrote: And don't move the stream in the module-stream-restore anymore, And the preferred_sin