This patch also adds a description how the heuristic works and mentions that
there is a scaling factor that can be adjusted if there is audible clipping.
---
src/modules/module-virtual-surround-sink.c | 57 +-
1 file changed, 40 insertions(+), 17 deletions(-)
diff
Hello Alexander,
On Tuesday 11 March 2014, 15:00:31, Tanu Kaskinen wrote:
On Sun, 2014-03-09 at 00:57 +0600, Alexander E. Patrakov wrote:
Hello.
[Do not blindly apply patches from this e-mail! They mutually exclusive,
and I don't have a firm opinion which one of them is correct.]
Hello Alexander,
I wrote that module some time ago. And I had the same problems that you
describe, i. e. when I tried to avoid clipping in the worst possible case, the
output was way too quiet.
Therefore I tried to come up with a heuristic and the 1.2 fudge factor seemed
to work for me. But
Since commit e32a408b3cdd46857fdf12210c1bf5bdbf3a96f8, we silence the
input memblock in order to give the resampler enough input samples, if
necessary.
But if there is no need to resample the hrir, the resampled memblock is
actually the same as the input memblock. Thus, we have to make sure that
Hello,
please consider to also merge version 2 of my patch module-virtual-surround-
sink: add silence to hrir if necessary.
The problem is, that the libsndfile based resamplers do not guarantee to output
any samples for too short input sequences. Thus, we should append silence to
the hrir if
---
src/modules/module-virtual-surround-sink.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/modules/module-virtual-surround-sink.c
b/src/modules/module-virtual-surround-sink.c
index 14a666f..0690769 100644
--- a/src/modules/module-virtual-surround-sink.c
+++
Otherwise, the hrir might be too short to get completely resampled
---
src/modules/module-virtual-surround-sink.c | 47 --
1 file changed, 38 insertions(+), 9 deletions(-)
diff --git a/src/modules/module-virtual-surround-sink.c
Otherwise, the hrir might be too short to get completely resampled
v2: take different sample rates into account
---
src/modules/module-virtual-surround-sink.c | 47 --
1 file changed, 38 insertions(+), 9 deletions(-)
diff --git
v2: better log message
---
src/modules/module-virtual-surround-sink.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/modules/module-virtual-surround-sink.c
b/src/modules/module-virtual-surround-sink.c
index 50f101d..e5c5dc1 100644
--- a/src/modules/module-virtual-surround-sink.c
.
Regards,
OleFrom b97e66866ef7a21b874f858ca6a90804ce2470a6 Mon Sep 17 00:00:00 2001
From: Niels Ole Salscheider niels_...@salscheider-online.de
Date: Sun, 8 Jan 2012 21:22:35 +0100
Subject: [PATCH] add module-virtual-surround-sink
It provides a virtual surround sound effect
v2: Normalize hrir
to store
the channel map in the wav header.
Because of that I provided a way to specify the channel map of the hrir wav.
Is there a better solution?
Regards,
OleFrom c124c11f82051a835e695b94392eba8b63e27254 Mon Sep 17 00:00:00 2001
From: Niels Ole Salscheider niels_...@salscheider-online.de
Date
the output signal I compute.
I hope I got it right now. I have attached a new version of my patch.
Regards,
OleFrom 56ac4d4a95971818657202677bf0646b3626a2a4 Mon Sep 17 00:00:00 2001
From: Niels Ole Salscheider niels_...@salscheider-online.de
Date: Sun, 8 Jan 2012 21:22:35 +0100
Subject: [PATCH] add
.
I forgot to add a small fix to my last patch; I have attached a new version.
Regards,
OleFrom 4e8a09d44ca8df7a7cc32662d0a784c77f09523c Mon Sep 17 00:00:00 2001
From: Niels Ole Salscheider niels_...@salscheider-online.de
Date: Sun, 8 Jan 2012 21:22:35 +0100
Subject: [PATCH] add module-virtual
Hello,
OK, so in the future we need a different algorithm for desktop speakers.
Something like find out stereo sound that, when convolved with the
HRIR and summed for each ear, produces the same result as the original
5.1 sound convolved with the appropriate HRIR, but at high-enough
that should help
you to find a suitable impulse response.
Regards,
OleFrom c391c1ef13e9d6b67303ee56680e2dbadd33ed9f Mon Sep 17 00:00:00 2001
From: Niels Ole Salscheider niels_...@salscheider-online.de
Date: Sun, 8 Jan 2012 21:22:35 +0100
Subject: [PATCH] add module-virtual-surround-sink
It provides
15 matches
Mail list logo
