Re: [pulseaudio-discuss] [PATCH] alsa-mixer: Take channel mask of volume element into account when finding a subset path

2012-01-28 Thread Tanu Kaskinen
On Fri, 2011-12-30 at 16:01 +, Dave Williams wrote: > > > > Actually, if my reasoning above makes sense, there's no need to > > implement anything. Just remove the lfe-on-mono path from the mappings > > in profile-sets/default.conf that don't have lfe in their channel map. > > > > Can someone

Re: [pulseaudio-discuss] [PATCH] alsa-mixer: Take channel mask of volume element into account when finding a subset path

2011-12-30 Thread Dave Williams
> > Actually, if my reasoning above makes sense, there's no need to > implement anything. Just remove the lfe-on-mono path from the mappings > in profile-sets/default.conf that don't have lfe in their channel map. > > Can someone say why lfe-on-mono would be needed on mappings without > separate

Re: [pulseaudio-discuss] [PATCH] alsa-mixer: Take channel mask of volume element into account when finding a subset path

2011-11-10 Thread Tanu Kaskinen
On Mon, 2011-10-24 at 22:29 +0300, Tanu Kaskinen wrote: > On Wed, 2011-10-19 at 20:47 +0200, Maarten Bosmans wrote: > > The patch looks simple, but I'm not entirely sure the concept is > > sound. Please review. > > > > The problem I'm trying to solve is that analog-output-mono is (in my > > view i

Re: [pulseaudio-discuss] [PATCH] alsa-mixer: Take channel mask of volume element into account when finding a subset path

2011-10-24 Thread Tanu Kaskinen
On Wed, 2011-10-19 at 20:47 +0200, Maarten Bosmans wrote: > The patch looks simple, but I'm not entirely sure the concept is > sound. Please review. > > The problem I'm trying to solve is that analog-output-mono is (in my > view incorrectly) seen as a subset of analog-output-lfe-on-mono. The patc

Re: [pulseaudio-discuss] [PATCH] alsa-mixer: Take channel mask of volume element into account when finding a subset path

2011-10-19 Thread David Henningsson
On 10/19/2011 08:47 PM, Maarten Bosmans wrote: The patch looks simple, but I'm not entirely sure the concept is sound. Please review. The problem I'm trying to solve is that analog-output-mono is (in my view incorrectly) seen as a subset of analog-output-lfe-on-mono. Relevant debug output: D: [

Re: [pulseaudio-discuss] [PATCH] alsa-mixer: Take channel mask of volume element into account when finding a subset path

2011-10-19 Thread Maarten Bosmans
The patch looks simple, but I'm not entirely sure the concept is sound. Please review. The problem I'm trying to solve is that analog-output-mono is (in my view incorrectly) seen as a subset of analog-output-lfe-on-mono. Relevant debug output: D: [lt-pulseaudio] alsa-mixer.c: Path analog-output-m

[pulseaudio-discuss] [PATCH] alsa-mixer: Take channel mask of volume element into account when finding a subset path

2011-10-19 Thread Maarten Bosmans
--- src/modules/alsa/alsa-mixer.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/modules/alsa/alsa-mixer.c b/src/modules/alsa/alsa-mixer.c index 3f27fdc..f390119 100644 --- a/src/modules/alsa/alsa-mixer.c +++ b/src/modules/alsa/alsa-mixer.c @@ -2956,6 +2956,10 @@ s