Re: [pulseaudio-discuss] [PATCH] core, modules: Remove useless EINTR tests

2020-01-16 Thread Pali Rohár
On Thursday 16 January 2020 17:31:17 Tanu Kaskinen wrote: > Resurrecting this old patch... > > On Mon, 2019-06-03 at 15:43 +0200, Pali Rohár wrote: > > On Tuesday 28 May 2019 16:49:19 Frédéric Danis wrote: > > > Since commit ad447d14682 (in 2009) pa_read and pa_write take care of > > > handling

Re: [pulseaudio-discuss] [PATCH] core, modules: Remove useless EINTR tests

2020-01-16 Thread Tanu Kaskinen
Resurrecting this old patch... On Mon, 2019-06-03 at 15:43 +0200, Pali Rohár wrote: > On Tuesday 28 May 2019 16:49:19 Frédéric Danis wrote: > > Since commit ad447d14682 (in 2009) pa_read and pa_write take care of > > handling EINTR error. > > So, pa_read, pa_write, pa_iochannel_read and

Re: [pulseaudio-discuss] [PATCH] core, modules: Remove useless EINTR tests

2019-06-03 Thread Pali Rohár
On Tuesday 28 May 2019 16:49:19 Frédéric Danis wrote: > Since commit ad447d14682 (in 2009) pa_read and pa_write take care of > handling EINTR error. > So, pa_read, pa_write, pa_iochannel_read and pa_iochannel_write can not > exit with errno set to EINTR, and testing it is useless. > --- >

[pulseaudio-discuss] [PATCH] core, modules: Remove useless EINTR tests

2019-05-28 Thread Frédéric Danis
Since commit ad447d14682 (in 2009) pa_read and pa_write take care of handling EINTR error. So, pa_read, pa_write, pa_iochannel_read and pa_iochannel_write can not exit with errno set to EINTR, and testing it is useless. --- src/modules/bluetooth/module-bluez5-device.c | 16 +---