Re: [pulseaudio-discuss] [PATCH] role-ducking: Add support for ducking group

On Fri, 2016-03-25 at 01:38 +0900, Sangchul Lee wrote: > > > +roles = pa_modargs_get_value(ma, "trigger_roles", NULL); > > > +if (roles) { > > > +const char *group_split_state = NULL; > > > +char *roles_in_group = NULL; > > > +i = 0; > > > +while

Re: [pulseaudio-discuss] [PATCH] role-ducking: Add support for ducking group

Thanks for your comment. Before making new version of patch, I replied inline. 2016-03-24 20:46 GMT+09:00 Tanu Kaskinen : > On Fri, 2016-02-19 at 22:22 +0900, Sangchul Lee wrote: >> struct userdata { >> pa_core *core; >> const char *name; >> -pa_idxset *trigger_roles;

Re: [pulseaudio-discuss] [PATCH] role-ducking: Add support for ducking group

2016-03-24 18:51 GMT+09:00 Tanu Kaskinen : > On Thu, 2016-03-24 at 00:14 +0900, Sangchul Lee wrote: >> Hi, Tanu >> >> I added more explanation of this patch in the commit message as below. >> (I may update this patch again as upstream codes are changed recently...) >> >> Thanks in

Re: [pulseaudio-discuss] [PATCH] role-ducking: Add support for ducking group

On Fri, 2016-02-19 at 22:22 +0900, Sangchul Lee wrote: >  struct userdata { >  pa_core *core; >  const char *name; > -pa_idxset *trigger_roles; > -pa_idxset *ducking_roles; > -pa_idxset *ducked_inputs; > +uint32_t n_group; I'd prefer "n_groups". > +pa_idxset

Re: [pulseaudio-discuss] [PATCH] role-ducking: Add support for ducking group

On Thu, 2016-03-24 at 00:14 +0900, Sangchul Lee wrote: > Hi, Tanu > > I added more explanation of this patch in the commit message as below. > (I may update this patch again as upstream codes are changed recently...) > > Thanks in advance for your review. > > Best regards, > Sangchul Lee > >

Re: [pulseaudio-discuss] [PATCH] role-ducking: Add support for ducking group

Hi, Tanu I added more explanation of this patch in the commit message as below. (I may update this patch again as upstream codes are changed recently...) Thanks in advance for your review. Best regards, Sangchul Lee 2016-03-23 20:41 GMT+09:00 Tanu Kaskinen : > Hi, sorry for the

Re: [pulseaudio-discuss] [PATCH] role-ducking: Add support for ducking group

Hi, sorry for the long delay. On Fri, 2016-02-19 at 22:22 +0900, Sangchul Lee wrote: > Now, trigger_roles, ducking_roles and volume can be divided into several > groups by slash. > That means each group can be affected by its own volume policy. > And it works in the same way as before without

Re: [pulseaudio-discuss] [PATCH] role-ducking: Add support for ducking group

Hi, All I want to get reviewed the below patch for role-ducking. I think it'll be useful if there are several volume levels(%/db) to be applied for each ducking role. Could you give any feedback about it? And I knew there are patches regarding role-ducking/cork from Mr.Chini. Regardless it

[pulseaudio-discuss] [PATCH] role-ducking: Add support for ducking group

Now, trigger_roles, ducking_roles and volume can be divided into several groups by slash. That means each group can be affected by its own volume policy. And it works in the same way as before without any slash. Signed-off-by: Sangchul Lee ---