Re: [pulseaudio-discuss] [PATCH] sndfile-util: fix format for 24bit depth wav files

2013-10-12 Thread Kiran Krishnappa
Hi Tanu, Can you please review my new patchset? Regards, Kiran On Thu, Oct 10, 2013 at 8:01 PM, Kiran Krishnappa kira...@gmail.com wrote: Hi, I tested both paplay and parecord for 24bit files. Looks to be working fine now. Regards, Kiran On Wed, Oct 9, 2013 at 11:30 PM, Kiran

Re: [pulseaudio-discuss] [PATCH] sndfile-util: fix format for 24bit depth wav files

2013-10-12 Thread Tanu Kaskinen
On Thu, 2013-10-10 at 20:01 -0700, Kiran Krishnappa wrote: Hi, I tested both paplay and parecord for 24bit files. Looks to be working fine now. How can it be working fine, if the read/write functions don't exist for 24-bit files? I looked at the code, and it seems that if the read/write

Re: [pulseaudio-discuss] [PATCH] sndfile-util: fix format for 24bit depth wav files

2013-10-12 Thread Tanu Kaskinen
[Added pulseaudio-discuss back to CC.] On Sat, 2013-10-12 at 09:31 -0700, Kiran Krishnappa wrote: Ok. I got it. I didn't think much about wav file header. Just played 24 bit file and also recorded 24 bit file, there were no aborts and when I played 24bit file, it couldn't make out difference.

[pulseaudio-discuss] [PATCH] sndfile-util: fix format for 24bit depth wav files

2013-10-10 Thread Kiran Krishnappa
PA_SAMPLE_24NE generated in pa_sndfile_read_sample_spec is not handled in pa_sndfile_readf and writef function. paplay/parecord used to get aborted for 24bit depth wav files --- src/pulsecore/sndfile-util.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/pulsecore/sndfile-util.c

Re: [pulseaudio-discuss] [PATCH] sndfile-util: fix format for 24bit depth wav files

2013-10-10 Thread Kiran Krishnappa
Hi, I tested both paplay and parecord for 24bit files. Looks to be working fine now. Regards, Kiran On Wed, Oct 9, 2013 at 11:30 PM, Kiran Krishnappa kira...@gmail.com wrote: PA_SAMPLE_24NE generated in pa_sndfile_read_sample_spec is not handled in pa_sndfile_readf and writef function.

Re: [pulseaudio-discuss] [PATCH] sndfile-util: fix format for 24bit depth wav files

2013-10-09 Thread Tanu Kaskinen
On Mon, 2013-10-07 at 09:43 -0700, Kiran Krishnappa wrote: PA_SAMPLE_24NE generated in pa_sndfile_read_sample_spec is not handled in pa_sndfile_readf_function. paplay used to get aborted for 24bit depth wav files How does paplay now behave? I suppose it still isn't able to play 24bit files, so

Re: [pulseaudio-discuss] [PATCH] sndfile-util: fix format for 24bit depth wav files

2013-10-08 Thread Kiran K
Hi, Can someone review my patch for the bug: https://bugs.freedesktop.org/show_bug.cgi?id=70096 Regards, Kiran On Mon, Oct 7, 2013 at 9:43 AM, Kiran Krishnappa kira...@gmail.com wrote: PA_SAMPLE_24NE generated in pa_sndfile_read_sample_spec is not handled in pa_sndfile_readf_function.

[pulseaudio-discuss] [PATCH] sndfile-util: fix format for 24bit depth wav files

2013-10-07 Thread Kiran Krishnappa
PA_SAMPLE_24NE generated in pa_sndfile_read_sample_spec is not handled in pa_sndfile_readf_function. paplay used to get aborted for 24bit depth wav files --- src/pulsecore/sndfile-util.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/pulsecore/sndfile-util.c