Hi,
On Fri, Dec 14, 2018 at 12:07:27AM +0800, Huang-Huang Bao wrote:
>"a2dp-codecs.h" copied from bluez, then added a2dp_aptxhd_t, a2dp_ldac_t.
>
Pali sent patches to upstream bluez, and now the codec IDs are in latest bluez
git tree,
also the endianess issues are fixed.
Could you please
On Friday 14 December 2018 00:07:27 Huang-Huang Bao wrote:
> "a2dp-codecs.h" copied from bluez
I sent fixes for a2dp-codecs.h from bluez to
linux-blueto...@vger.kernel.org list.
So wait until it is fixed and we would not need to fix these problems in
two different projects...
--
Pali Rohár
On 12/16/18 5:48 AM, Pali Rohár wrote:
> On Thursday 13 December 2018 19:43:36 EHfive wrote:
>> diff --git a/src/modules/bluetooth/a2dp/a2dp-api.h
>> b/src/modules/bluetooth/a2dp/a2dp-api.h
>> new file mode 100644
>> index 0..b357555d0
>> --- /dev/null
>> +++
On Saturday 15 December 2018 23:15:14 Pasi Kärkkäinen wrote:
> On Fri, Dec 14, 2018 at 12:01:57PM +0100, Pali Rohár wrote:
> > > >
> > > > Therefore that priority list is not always enforced.
> > >
> > > How do you know?
> >
> > Because I wrote my own implementation of aptX and FastStream codec
On Thursday 13 December 2018 19:43:36 EHfive wrote:
> diff --git a/src/modules/bluetooth/a2dp/a2dp-api.h
> b/src/modules/bluetooth/a2dp/a2dp-api.h
> new file mode 100644
> index 0..b357555d0
> --- /dev/null
> +++ b/src/modules/bluetooth/a2dp/a2dp-api.h
> @@ -0,0 +1,170 @@
> +#ifndef
On Fri, Dec 14, 2018 at 12:01:57PM +0100, Pali Rohár wrote:
> > >
> > > Therefore that priority list is not always enforced.
> >
> > How do you know?
>
> Because I wrote my own implementation of aptX and FastStream codec
> support for pulseaudio. Also I played with bluez a lot. In summer I sent
On Fri, Dec 14, 2018 at 06:48:05PM +0800, Huang-Huang Bao wrote:
> I don't want to debate too much about naming. In this state, we should pay
> attention to codes function.
>
> Broken codes and useless codes could be cleaned up after this patches set
> applied.
>
The common practice in
On 12/14/18 7:01 PM, Pali Rohár wrote:
> On Friday 14 December 2018 18:48:05 Huang-Huang Bao wrote:
>> I don't want to debate too much about naming. In this state, we should pay
>> attention to codes function.
>>
>> Broken codes and useless codes could be cleaned up after this patches set
>>
On Friday 14 December 2018 18:48:05 Huang-Huang Bao wrote:
> I don't want to debate too much about naming. In this state, we should pay
> attention to codes function.
>
> Broken codes and useless codes could be cleaned up after this patches set
> applied.
>
> If someone want to add another
I don't want to debate too much about naming. In this state, we should pay
attention to codes function.
Broken codes and useless codes could be cleaned up after this patches set
applied.
If someone want to add another codec, he/she can just modify "a2dp-codeces.h"
or others.
On 12/14/18
On Friday 14 December 2018 00:07:27 Huang-Huang Bao wrote:
> "a2dp-codecs.h" copied from bluez, then added a2dp_aptxhd_t, a2dp_ldac_t.
This does not excuse having broken code in pulseaudio. Atrac or big
endian definition seems to be really wrong.
Is not it stupid to copy+paste broken code from
"a2dp-codecs.h" copied from bluez, then added a2dp_aptxhd_t, a2dp_ldac_t.
I don't want to debate too much about naming.
On 12/13/18 11:35 PM, Pali Rohár wrote:
> On Thursday 13 December 2018 19:43:36 EHfive wrote:
>> +#define A2DP_CODEC_SBC 0x00
>> +#define A2DP_CODEC_MPEG12
On Thursday 13 December 2018 19:43:36 EHfive wrote:
> +#define A2DP_CODEC_SBC 0x00
> +#define A2DP_CODEC_MPEG120x01
> +#define A2DP_CODEC_MPEG240x02
> +#define A2DP_CODEC_ATRAC 0x03
This is incorrect, Atrac codec has A2DP ID 0x04, see:
Separate A2DP processes from bluez5-util, module-bluez5-device.
Add prop "bluetooth.a2dp_codec" to pulseaudio sink/source properties.
---
src/Makefile.am | 15 +-
src/modules/bluetooth/a2dp-codecs.h | 115 ---
src/modules/bluetooth/a2dp/a2dp-api.h
Separate A2DP processes from bluez5-util, module-bluez5-device.
Add prop "bluetooth.a2dp_codec" to pulseaudio sink/source properties.
---
src/Makefile.am | 15 +-
src/modules/bluetooth/a2dp-codecs.h | 115 ---
src/modules/bluetooth/a2dp/a2dp-api.h
15 matches
Mail list logo
