Re: [pulseaudio-discuss] [PATCH 1/4] change bool save_sink to char *preferred_sink

2018-12-25 Thread Hui Wang
On 2018/12/23 上午3:06, Tanu Kaskinen wrote: On Sat, 2018-12-15 at 16:47 +0800, Hui Wang wrote: On 2018/12/12 下午9:39, Tanu Kaskinen wrote: Thanks for working on this! Sorry for slow review, I hope I'll be much quicker to comment on subsequent iterations. On Mon, 2018-11-05 at 09:47 +0800, Hui

Re: [pulseaudio-discuss] [PATCH 1/4] change bool save_sink to char *preferred_sink

2018-12-22 Thread Tanu Kaskinen
On Sat, 2018-12-15 at 16:47 +0800, Hui Wang wrote: > On 2018/12/12 下午9:39, Tanu Kaskinen wrote: > > Thanks for working on this! Sorry for slow review, I hope I'll be much > > quicker to comment on subsequent iterations. > > > > On Mon, 2018-11-05 at 09:47 +0800, Hui Wang wrote: > > > And don't

Re: [pulseaudio-discuss] [PATCH 1/4] change bool save_sink to char *preferred_sink

2018-12-15 Thread Hui Wang
On 2018/12/12 下午9:39, Tanu Kaskinen wrote: Thanks for working on this! Sorry for slow review, I hope I'll be much quicker to comment on subsequent iterations. On Mon, 2018-11-05 at 09:47 +0800, Hui Wang wrote: And don't move the stream in the module-stream-restore anymore, And the

Re: [pulseaudio-discuss] [PATCH 1/4] change bool save_sink to char *preferred_sink

2018-12-12 Thread Tanu Kaskinen
Thanks for working on this! Sorry for slow review, I hope I'll be much quicker to comment on subsequent iterations. On Mon, 2018-11-05 at 09:47 +0800, Hui Wang wrote: > And don't move the stream in the module-stream-restore anymore, > And the preferred_sink is only set when user is calling the >

[pulseaudio-discuss] [PATCH 1/4] change bool save_sink to char *preferred_sink

2018-11-04 Thread Hui Wang
And don't move the stream in the module-stream-restore anymore, And the preferred_sink is only set when user is calling the move_to() and the module-stream-restore maintains the saving and deleting of preferred_sink. If the target of move_to() is default_sink, preferred_sink will be cleared and