Re: [pulseaudio-discuss] [PATCH 3/4] Add A2DP aptX, aptX HD codecs support

2018-12-15 Thread Pasi Kärkkäinen
On Thu, Dec 13, 2018 at 08:53:05PM +0100, Pali Rohár wrote: > On Thursday 13 December 2018 18:42:11 Pasi Kärkkäinen wrote: > > On Thu, Dec 13, 2018 at 04:36:59PM +0100, Pali Rohár wrote: > > > What is the purpose of adding aptX codec (non HD variant)? It is not > > > better then default and mandato

Re: [pulseaudio-discuss] [PATCH 3/4] Add A2DP aptX, aptX HD codecs support

2018-12-15 Thread Pali Rohár
On Friday 14 December 2018 00:16:24 Huang-Huang Bao wrote: > 90 samples are only 90/44100 s = 2ms , which is ignorable. Yes, this not a problem. Problem is that first 90 samples is just "garbage" or rather initialization data for predictor. And to prevent hearing such "garbage" when decoding stre

Re: [pulseaudio-discuss] [PATCH 3/4] Add A2DP aptX, aptX HD codecs support

2018-12-13 Thread Pali Rohár
On Thursday 13 December 2018 18:42:11 Pasi Kärkkäinen wrote: > On Thu, Dec 13, 2018 at 04:36:59PM +0100, Pali Rohár wrote: > > What is the purpose of adding aptX codec (non HD variant)? It is not > > better then default and mandatory SBC codec. > > > > When using AptX codec one can be certain it's

Re: [pulseaudio-discuss] [PATCH 3/4] Add A2DP aptX, aptX HD codecs support

2018-12-13 Thread Pasi Kärkkäinen
On Thu, Dec 13, 2018 at 04:36:59PM +0100, Pali Rohár wrote: > What is the purpose of adding aptX codec (non HD variant)? It is not > better then default and mandatory SBC codec. > When using AptX codec one can be certain it's always 352 kbps bitrate. with SBC you never know what you end up using..

Re: [pulseaudio-discuss] [PATCH 3/4] Add A2DP aptX, aptX HD codecs support

2018-12-13 Thread Huang-Huang Bao
It's just a ability. If we want to disable aptx or adjust it's priority, just modify enum pa_a2dp_codec_index or using pa_a2dp_set_max_priority(), pa_a2dp_set_disable(). On 12/13/18 11:36 PM, Pali Rohár wrote: > What is the purpose of adding aptX codec (non HD variant)? It is not > better then de

Re: [pulseaudio-discuss] [PATCH 3/4] Add A2DP aptX, aptX HD codecs support

2018-12-13 Thread Huang-Huang Bao
People want using aptx(HD) early. So I decide to use ffmpeg. 90 samples are only 90/44100 s = 2ms , which is ignorable. On 12/13/18 11:43 PM, Pali Rohár wrote: > On Thursday 13 December 2018 19:43:38 EHfive wrote: >> diff --git a/src/modules/bluetooth/a2dp/a2dp-codecs.h >> b/src/modules/blueto

Re: [pulseaudio-discuss] [PATCH 3/4] Add A2DP aptX, aptX HD codecs support

2018-12-13 Thread Pali Rohár
On Thursday 13 December 2018 19:43:38 EHfive wrote: > diff --git a/src/modules/bluetooth/a2dp/a2dp-codecs.h > b/src/modules/bluetooth/a2dp/a2dp-codecs.h > index aefafb635..a6f054aec 100644 > --- a/src/modules/bluetooth/a2dp/a2dp-codecs.h > +++ b/src/modules/bluetooth/a2dp/a2dp-codecs.h > @@ -141,6

Re: [pulseaudio-discuss] [PATCH 3/4] Add A2DP aptX, aptX HD codecs support

2018-12-13 Thread Pali Rohár
What is the purpose of adding aptX codec (non HD variant)? It is not better then default and mandatory SBC codec. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: PGP signature ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.

[pulseaudio-discuss] [PATCH 3/4] Add A2DP aptX, aptX HD codecs support

2018-12-13 Thread EHfive
Optional (build with --disable-bluez5-aptx-codec) --- configure.ac | 18 +- src/Makefile.am | 8 + src/modules/bluetooth/a2dp/a2dp-api.h| 12 + src/modules/bluetooth/a2dp/a2dp-codecs.h | 3 + src/modules/bluetooth/a2dp/a2dp_aptx.c |

[pulseaudio-discuss] [PATCH 3/4] Add A2DP aptX, aptX HD codecs support

2018-12-13 Thread Huang-Huang Bao
Optional (build with --disable-bluez5-aptx-codec) --- configure.ac | 18 +- src/Makefile.am | 8 + src/modules/bluetooth/a2dp/a2dp-api.h| 12 + src/modules/bluetooth/a2dp/a2dp-codecs.h | 3 + src/modules/bluetooth/a2dp/a2dp_aptx.c |