On Tuesday 21 January 2020 16:17:16 Georg Chini wrote:
> > +/* choose remote capabilities which are compatible and its bitpool
> > range is nearest to one from capabilities table */
> > PA_HASHMAP_FOREACH_KV(key, a2dp_capabilities, capabilities_hashmap,
> > state) {
> > -if
On Sunday 02 February 2020 18:46:24 Georg Chini wrote:
> On 02.02.20 14:08, Pali Rohár wrote:
> > On Thursday 23 January 2020 12:29:15 Georg Chini wrote:
> > > > On Tuesday 21 January 2020 16:17:16 Georg Chini wrote:
> > > ...
> > > > > > +}
> > > > > > +
> > > > > > +static bool
On 02.02.20 14:08, Pali Rohár wrote:
On Thursday 23 January 2020 12:29:15 Georg Chini wrote:
On Tuesday 21 January 2020 16:17:16 Georg Chini wrote:
...
+}
+
+static bool can_accept_capabilities_xq2(const uint8_t *capabilities_buffer,
uint8_t capabilities_size, bool for_encoding) {
+
On Thursday 23 January 2020 12:29:15 Georg Chini wrote:
> >
> > On Tuesday 21 January 2020 16:17:16 Georg Chini wrote:
> ...
> > > > +}
> > > > +
> > > > +static bool can_accept_capabilities_xq2(const uint8_t
> > > > *capabilities_buffer, uint8_t capabilities_size, bool for_encoding) {
> > > > +
On 22.01.20 20:15, Pali Rohár wrote:
Hello! Thank you for review. Comments are below inlined. Remarks about
return values of API is I guess out of scope of this patch as patch just
implements API. API is already in pulseaudio git master, so it needs to
be changed first there if really needed.
Hello! Thank you for review. Comments are below inlined. Remarks about
return values of API is I guess out of scope of this patch as patch just
implements API. API is already in pulseaudio git master, so it needs to
be changed first there if really needed.
On Tuesday 21 January 2020 16:17:16
Finally managed to review this one. The general remarks concerning the
return
values of the API functions apply here as well. Sorry for the delay.
On 06.10.19 19:58, Pali Rohár wrote:
Specify configuration for Low, Middle, High and eXtreme Quality of SBC
codec. SBC codec in eXtreme Quality has
Explained in other email. We cannot change Automatic SBC profile to not
break some existing devices (with broken A2DP implementation).
One of the main objections against SBC codec is that user does not "what
version of SBC quality is in use" and therefore other proprietary codecs
with fixed
Hi Pali,
I believe that the average user SHOULD be provided a high quality sound by
default. And legacy low quality bitrates SHOULD be a workaround.
IMHO, an "AUTOMATIC mode with max XQ bitrates and DUAL CHANNEL mode prefered"
(aka : max negociated bitpool = 38 per channel) : SHOULD be the
Specify configuration for Low, Middle, High and eXtreme Quality of SBC
codec. SBC codec in eXtreme Quality has higher quality than aptX.
Automatic Quality mode matches configuration of SBC codec which was used
before this change. Which means that it accept configuration between Low
and High
10 matches
Mail list logo
