Re: [pulseaudio-discuss] [PATCH v2 2/6] card: don't allow the CARD_NEW hook to fail

2016-06-13 Thread Alexander E. Patrakov
13.06.2016 01:12, Tanu Kaskinen пишет: I'd prefer to not add an assertion. Most of pa_hook_fire() calls in the code base don't check the return value, and none of the calls use an assertion. OK. -- Alexander E. Patrakov ___ pulseaudio-discuss mailing

Re: [pulseaudio-discuss] [PATCH v2 2/6] card: don't allow the CARD_NEW hook to fail

2016-06-12 Thread Tanu Kaskinen
On Sun, 2016-06-12 at 18:19 +0500, Alexander E. Patrakov wrote: > 10.06.2016 22:55, Tanu Kaskinen пишет: > > There is currently no use for allowing modules to cancel card creation, > > and I don't see need for that in the future either. Let's simplify > > things by removing the failure handling cod

Re: [pulseaudio-discuss] [PATCH v2 2/6] card: don't allow the CARD_NEW hook to fail

2016-06-12 Thread Alexander E. Patrakov
10.06.2016 22:55, Tanu Kaskinen пишет: There is currently no use for allowing modules to cancel card creation, and I don't see need for that in the future either. Let's simplify things by removing the failure handling code. --- src/pulsecore/card.c | 7 +-- 1 file changed, 1 insertion(+), 6

[pulseaudio-discuss] [PATCH v2 2/6] card: don't allow the CARD_NEW hook to fail

2016-06-10 Thread Tanu Kaskinen
There is currently no use for allowing modules to cancel card creation, and I don't see need for that in the future either. Let's simplify things by removing the failure handling code. --- src/pulsecore/card.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/pulsecore/