Re: [pulseaudio-discuss] [PATCH v3 2/4] Add A2DP AAC codec support

2019-01-12 Thread Pali Rohár
On Saturday 29 December 2018 23:48:06 Huang-Huang Bao wrote: > diff --git a/src/modules/bluetooth/a2dp/a2dp_aac.c > b/src/modules/bluetooth/a2dp/a2dp_aac.c > new file mode 100644 > index 0..a1d7bf1d2 > --- /dev/null > +++ b/src/modules/bluetooth/a2dp/a2dp_aac.c > @@ -0,0 +1,762 @@ > +/***

Re: [pulseaudio-discuss] [PATCH v3 2/4] Add A2DP AAC codec support

2019-01-11 Thread Pali Rohár
On Friday 11 January 2019 15:32:44 Luiz Augusto von Dentz wrote: > Hi Pali, > > On Fri, Jan 11, 2019 at 2:49 PM Pali Rohár wrote: > > > > On Friday 11 January 2019 14:23:21 Luiz Augusto von Dentz wrote: > > > Im little worried about the maintainance of a2dp_util.c if we keedp > > > the practice

Re: [pulseaudio-discuss] [PATCH v3 2/4] Add A2DP AAC codec support

2019-01-11 Thread Luiz Augusto von Dentz
Hi Pali, On Fri, Jan 11, 2019 at 2:49 PM Pali Rohár wrote: > > On Friday 11 January 2019 14:23:21 Luiz Augusto von Dentz wrote: > > Im little worried about the maintainance of a2dp_util.c if we keedp > > the practice of #ifsef every codec, imo it would be much cleaner if we > > just have a

Re: [pulseaudio-discuss] [PATCH v3 2/4] Add A2DP AAC codec support

2019-01-11 Thread Pali Rohár
On Friday 11 January 2019 14:23:21 Luiz Augusto von Dentz wrote: > Im little worried about the maintainance of a2dp_util.c if we keedp > the practice of #ifsef every codec, imo it would be much cleaner if we > just have a mechanism to register the codecs, maybe we load them as > separate plugins

Re: [pulseaudio-discuss] [PATCH v3 2/4] Add A2DP AAC codec support

2019-01-11 Thread Luiz Augusto von Dentz
Hi, On Sat, Dec 29, 2018 at 12:49 PM Huang-Huang Bao wrote: > > Optional (build with --disable-bluez5-aac-codec) > > AAC User Configurations: >KEY VALUEDESC > DEFAULT >aac_bitrate_mode[1, 5] Variable Bitrate (VBR) (encoder)