Re: [pulseaudio-discuss] pactl percentage bug fix

2022-06-06 Thread Tanu Kaskinen
On Sat, 2022-06-04 at 23:05 -0700, Sean Greenslade wrote: > On Sun, Jun 05, 2022 at 01:51:55AM +0100, Patrick May wrote: > > On 04/06/2022 08:48, Sean Greenslade wrote: > > > > > While debugging, I did notice another issue that I was uncertain of how > > > to solve. The detection of absolute

Re: [pulseaudio-discuss] pactl percentage bug fix

2022-06-05 Thread Sean Greenslade
On Sun, Jun 05, 2022 at 01:51:55AM +0100, Patrick May wrote: > On 04/06/2022 08:48, Sean Greenslade wrote: > > > While debugging, I did notice another issue that I was uncertain of how > > to solve. The detection of absolute values vs. relative values is based > > on the presence of a plus or

Re: [pulseaudio-discuss] pactl percentage bug fix

2022-06-04 Thread Patrick May
I tested it with pactl -- set-sink-volume 0 0db and it sets the volume to 100%. So the ability to specify absolute decibel values is only useful if you like blasting stuff at greater than or equal to 100% volume On 04/06/2022 08:48, Sean Greenslade wrote: While debugging, I did notice

Re: [pulseaudio-discuss] pactl percentage bug fix

2022-06-04 Thread Sean Greenslade
On Fri, Jun 03, 2022 at 06:19:20PM +0100, Patrick May wrote: > Here is the problem: > > https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/blob/master/src/utils/pactl.c > > In src/utils/pactl.c: > > Between line 2530 and line 2535, in function parse_volume: > > These two 'if' statements

[pulseaudio-discuss] pactl percentage bug fix

2022-06-03 Thread Patrick May
Here is the problem: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/blob/master/src/utils/pactl.c In src/utils/pactl.c: Between line 2530 and line 2535, in function parse_volume: These two 'if' statements will BOTH execute if the input string contains both a '.' and ends with a '%'.