Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-05-01 Thread Georg Chini
On 30.04.19 23:37, Alexander E. Patrakov wrote: вт, 30 апр. 2019 г. в 23:46, Georg Chini : On 30.04.19 19:23, Alexander E. Patrakov wrote: Please don't treat the FIR for module-virtual-surround-sink as a set of reconfigurable parameters. At least for now. Just hard-code the contents of

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-30 Thread Alexander E. Patrakov
вт, 30 апр. 2019 г. в 23:46, Georg Chini : > > On 30.04.19 19:23, Alexander E. Patrakov wrote: > >> /* If set, this function is called in thread context when an update > >> of the > >>* filter parameters is requested, may be NULL. The function must > >> replace > >>* the

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-30 Thread Georg Chini
On 30.04.19 20:46, Georg Chini wrote: On 30.04.19 19:23, Alexander E. Patrakov wrote:   /* Callback to process a chunk of data by the filter. May be NULL */   void (*process_chunk)(float *src, float *dst, unsigned count, void *filter_handle);   /* Callback to retrieve

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-30 Thread Georg Chini
On 30.04.19 19:23, Alexander E. Patrakov wrote: вт, 30 апр. 2019 г. в 16:31, Georg Chini : uint64_t min_latency; /* Minimum latency allowed for the sink, 0 if unused */ uint64_t max_latency; /* Maximum latency allowed for the sink, 0 if unused

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-30 Thread Alexander E. Patrakov
вт, 30 апр. 2019 г. в 16:31, Georg Chini : > uint64_t min_latency; /* Minimum latency > allowed for the sink, 0 if unused */ > uint64_t max_latency; /* Maximum latency > allowed for the sink, 0 if unused */ Why would these fields be needed? >

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-30 Thread Georg Chini
On 27.04.19 17:14, Georg Chini wrote: On 27.04.19 12:55, Georg Chini wrote: On 27.04.19 12:04, Tanu Kaskinen wrote: On Fri, 2019-04-26 at 11:40 +0200, Georg Chini wrote: On 26.04.19 10:56, Tanu Kaskinen wrote: On Tue, 2019-04-23 at 21:20 +0200, Georg Chini wrote: The current scheme for

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-27 Thread Georg Chini
On 27.04.19 12:55, Georg Chini wrote: On 27.04.19 12:04, Tanu Kaskinen wrote: On Fri, 2019-04-26 at 11:40 +0200, Georg Chini wrote: On 26.04.19 10:56, Tanu Kaskinen wrote: On Tue, 2019-04-23 at 21:20 +0200, Georg Chini wrote: The current scheme for updating parameters I have in mind should

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-27 Thread Georg Chini
On 27.04.19 12:04, Tanu Kaskinen wrote: On Fri, 2019-04-26 at 11:40 +0200, Georg Chini wrote: On 26.04.19 10:56, Tanu Kaskinen wrote: On Tue, 2019-04-23 at 21:20 +0200, Georg Chini wrote: The current scheme for updating parameters I have in mind should work for any of the existing filters and

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-27 Thread Tanu Kaskinen
On Fri, 2019-04-26 at 11:40 +0200, Georg Chini wrote: > On 26.04.19 10:56, Tanu Kaskinen wrote: > > On Tue, 2019-04-23 at 21:20 +0200, Georg Chini wrote: > > > The current scheme for > > > updating > > > parameters I have in mind should work for any of the existing filters > > > and relies on > >

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-27 Thread Georg Chini
On 26.04.19 11:40, Georg Chini wrote: On 26.04.19 10:56, Tanu Kaskinen wrote: On Tue, 2019-04-23 at 21:20 +0200, Georg Chini wrote: The current scheme for updating parameters I have in mind should work for any of the existing filters and relies on passing around parameter structures:  

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-26 Thread Georg Chini
On 26.04.19 10:56, Tanu Kaskinen wrote: On Tue, 2019-04-23 at 21:20 +0200, Georg Chini wrote: The current scheme for updating parameters I have in mind should work for any of the existing filters and relies on passing around parameter structures: /* The following functions can be

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-26 Thread Tanu Kaskinen
On Tue, 2019-04-23 at 21:20 +0200, Georg Chini wrote: > On 22.04.19 09:34, Tanu Kaskinen wrote: > > On Sat, 2019-04-20 at 11:38 +0200, Georg Chini wrote: > > > PA uses malloc() in the IO-thread, so are we doing things wrong? > > > I think using malloc() when a parameter changes is not interfering

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-24 Thread Tanu Kaskinen
On Mon, 2019-04-22 at 11:23 +0200, Georg Chini wrote: > On 22.04.19 09:34, Tanu Kaskinen wrote: > > On Sat, 2019-04-20 at 11:38 +0200, Georg Chini wrote: > > > PA uses malloc() in the IO-thread, so are we doing things wrong? > > > I think using malloc() when a parameter changes is not interfering

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-22 Thread Georg Chini
On 22.04.19 09:34, Tanu Kaskinen wrote: On Sat, 2019-04-20 at 11:38 +0200, Georg Chini wrote: PA uses malloc() in the IO-thread, so are we doing things wrong? I think using malloc() when a parameter changes is not interfering with real-time operation because the filter must be reset after a

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-22 Thread Tanu Kaskinen
On Sat, 2019-04-20 at 11:38 +0200, Georg Chini wrote: > On 20.04.19 11:06, Tanu Kaskinen wrote: > > On Fri, 2019-04-19 at 17:52 +0200, Georg Chini wrote: > > > On 19.04.19 16:56, Tanu Kaskinen wrote: > > > > Changing the number of eq bands isn't quite like changing regular > > > > control values.

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-20 Thread Alexander E. Patrakov
сб, 20 апр. 2019 г. в 15:20, Georg Chini : > > On 20.04.19 12:14, Alexander E. Patrakov wrote: > > [forgot to CC the list - sorry for any duplicates] > > > > сб, 20 апр. 2019 г. в 14:39, Georg Chini : > > > >> I think using malloc() when a parameter changes is not interfering > >> with real-time

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-20 Thread Georg Chini
On 20.04.19 12:14, Alexander E. Patrakov wrote: [forgot to CC the list - sorry for any duplicates] сб, 20 апр. 2019 г. в 14:39, Georg Chini : I think using malloc() when a parameter changes is not interfering with real-time operation because the filter must be reset after a parameter change

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-20 Thread Georg Chini
On 20.04.19 12:14, Alexander E. Patrakov wrote: [forgot to CC the list - sorry for any duplicates] сб, 20 апр. 2019 г. в 14:39, Georg Chini : I think using malloc() when a parameter changes is not interfering with real-time operation because the filter must be reset after a parameter change

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-20 Thread Alexander E. Patrakov
[forgot to CC the list - sorry for any duplicates] сб, 20 апр. 2019 г. в 14:39, Georg Chini : > I think using malloc() when a parameter changes is not interfering > with real-time operation because the filter must be reset after > a parameter change anyway. The parameter changes allowed during

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-20 Thread Georg Chini
On 20.04.19 11:06, Tanu Kaskinen wrote: On Fri, 2019-04-19 at 17:52 +0200, Georg Chini wrote: On 19.04.19 16:56, Tanu Kaskinen wrote: On Fri, 2019-04-19 at 12:03 +0200, Georg Chini wrote: On 19.04.19 11:13, Tanu Kaskinen wrote: On Tue, 2019-04-16 at 21:40 +0200, Georg Chini wrote: On

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-20 Thread Alexander E. Patrakov
сб, 20 апр. 2019 г. в 05:54, Georg Chini : > But what you are basically saying is that the equalizer does > not hold what Andrea claims it can do and that it is only useful > as a 10-band equalizer. I wonder why her work was then > accepted as a master thesis. I don't know the Italian

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-20 Thread Tanu Kaskinen
On Fri, 2019-04-19 at 17:52 +0200, Georg Chini wrote: > On 19.04.19 16:56, Tanu Kaskinen wrote: > > On Fri, 2019-04-19 at 12:03 +0200, Georg Chini wrote: > > > On 19.04.19 11:13, Tanu Kaskinen wrote: > > > > On Tue, 2019-04-16 at 21:40 +0200, Georg Chini wrote: > > > > > On 16.04.19 19:19, Tanu

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-19 Thread Georg Chini
On 20.04.19 01:02, Alexander E. Patrakov wrote: сб, 20 апр. 2019 г. в 00:15, Georg Chini : On 19.04.19 18:23, Alexander E. Patrakov wrote: пт, 19 апр. 2019 г. в 14:13, Tanu Kaskinen : If the plugin gets the number of bands during the initialization, it can create the appropriate number of

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-19 Thread Alexander E. Patrakov
сб, 20 апр. 2019 г. в 00:15, Georg Chini : > > On 19.04.19 18:23, Alexander E. Patrakov wrote: > > пт, 19 апр. 2019 г. в 14:13, Tanu Kaskinen : > >> If the plugin gets the number of bands during the > >> initialization, it can create the appropriate number of non-array > >> control ports.

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-19 Thread Alexander E. Patrakov
пн, 8 апр. 2019 г. в 15:05, Alexander E. Patrakov : > > пн, 8 апр. 2019 г. в 13:08, Alexander E. Patrakov : > > > I have looked again at the paper, and have a DSP question. > > > > The thesis starts with designing a shelf filter. That is, a filter > > that contains a flat area at low frequencies,

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-19 Thread Georg Chini
On 19.04.19 18:23, Alexander E. Patrakov wrote: пт, 19 апр. 2019 г. в 14:13, Tanu Kaskinen : If the plugin gets the number of bands during the initialization, it can create the appropriate number of non-array control ports. Interleaved audio ports aren't needed either, because PulseAudio can do

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-19 Thread Alexander E. Patrakov
пт, 19 апр. 2019 г. в 14:13, Tanu Kaskinen : > If the plugin gets the number of bands during the > initialization, it can create the appropriate number of non-array > control ports. Interleaved audio ports aren't needed either, because > PulseAudio can do the deinterleaving before passing the

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-19 Thread Georg Chini
On 19.04.19 16:56, Tanu Kaskinen wrote: On Fri, 2019-04-19 at 12:03 +0200, Georg Chini wrote: On 19.04.19 11:13, Tanu Kaskinen wrote: On Tue, 2019-04-16 at 21:40 +0200, Georg Chini wrote: On 16.04.19 19:19, Tanu Kaskinen wrote: On Thu, 2019-04-11 at 20:42 +0200, Georg Chini wrote: On

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-19 Thread Tanu Kaskinen
On Fri, 2019-04-19 at 12:03 +0200, Georg Chini wrote: > On 19.04.19 11:13, Tanu Kaskinen wrote: > > On Tue, 2019-04-16 at 21:40 +0200, Georg Chini wrote: > > > On 16.04.19 19:19, Tanu Kaskinen wrote: > > > > On Thu, 2019-04-11 at 20:42 +0200, Georg Chini wrote: > > > > > On 11.04.19 19:36, Tanu

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-19 Thread Georg Chini
On 19.04.19 11:13, Tanu Kaskinen wrote: On Tue, 2019-04-16 at 21:40 +0200, Georg Chini wrote: On 16.04.19 19:19, Tanu Kaskinen wrote: On Thu, 2019-04-11 at 20:42 +0200, Georg Chini wrote: On 11.04.19 19:36, Tanu Kaskinen wrote: If you want a better plugin standard, are you aware of LV2 and

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-19 Thread Tanu Kaskinen
On Tue, 2019-04-16 at 21:40 +0200, Georg Chini wrote: > On 16.04.19 19:19, Tanu Kaskinen wrote: > > On Thu, 2019-04-11 at 20:42 +0200, Georg Chini wrote: > > > On 11.04.19 19:36, Tanu Kaskinen wrote: > > > > If you want a better plugin standard, are you aware of LV2 > > > > and PipeWire's SPA (the

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-16 Thread Georg Chini
On 16.04.19 21:40, Georg Chini wrote: On 16.04.19 19:19, Tanu Kaskinen wrote: On Thu, 2019-04-11 at 20:42 +0200, Georg Chini wrote: On 11.04.19 19:36, Tanu Kaskinen wrote: On Thu, 2019-04-11 at 15:16 +0200, Georg Chini wrote: On 08.04.19 09:27, Georg Chini wrote: On 05.04.19 13:29, Tanu

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-16 Thread Georg Chini
On 16.04.19 19:19, Tanu Kaskinen wrote: On Thu, 2019-04-11 at 20:42 +0200, Georg Chini wrote: On 11.04.19 19:36, Tanu Kaskinen wrote: On Thu, 2019-04-11 at 15:16 +0200, Georg Chini wrote: On 08.04.19 09:27, Georg Chini wrote: On 05.04.19 13:29, Tanu Kaskinen wrote: On Tue, 2019-04-02 at

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-16 Thread Tanu Kaskinen
On Thu, 2019-04-11 at 20:42 +0200, Georg Chini wrote: > On 11.04.19 19:36, Tanu Kaskinen wrote: > > On Thu, 2019-04-11 at 15:16 +0200, Georg Chini wrote: > > > On 08.04.19 09:27, Georg Chini wrote: > > > > On 05.04.19 13:29, Tanu Kaskinen wrote: > > > > > On Tue, 2019-04-02 at 20:28 +0200, Georg

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-11 Thread Georg Chini
On 11.04.19 19:36, Tanu Kaskinen wrote: On Thu, 2019-04-11 at 15:16 +0200, Georg Chini wrote: On 08.04.19 09:27, Georg Chini wrote: On 05.04.19 13:29, Tanu Kaskinen wrote: On Tue, 2019-04-02 at 20:28 +0200, Georg Chini wrote: On 06.11.18 22:14, Andrea A wrote: Hi Andrea, maybe there is

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-11 Thread Tanu Kaskinen
On Thu, 2019-04-11 at 15:16 +0200, Georg Chini wrote: > On 08.04.19 09:27, Georg Chini wrote: > > On 05.04.19 13:29, Tanu Kaskinen wrote: > > > On Tue, 2019-04-02 at 20:28 +0200, Georg Chini wrote: > > > > On 06.11.18 22:14, Andrea A wrote: > > > > > Thanks a lot for the reply > > > > > > > > > >

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-08 Thread Alexander E. Patrakov
пн, 8 апр. 2019 г. в 13:08, Alexander E. Patrakov : > I have looked again at the paper, and have a DSP question. > > The thesis starts with designing a shelf filter. That is, a filter > that contains a flat area at low frequencies, a flat area at high > frequencies (but with a different gain),

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-08 Thread Alexander E. Patrakov
пн, 8 апр. 2019 г. в 12:27, Georg Chini : > > On 05.04.19 13:29, Tanu Kaskinen wrote: > > On Tue, 2019-04-02 at 20:28 +0200, Georg Chini wrote: > >> On 06.11.18 22:14, Andrea A wrote: > >>> Thanks a lot for the reply > >>> > If the preset files are expected to be shared between users, then

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-08 Thread Georg Chini
On 05.04.19 13:29, Tanu Kaskinen wrote: On Tue, 2019-04-02 at 20:28 +0200, Georg Chini wrote: On 06.11.18 22:14, Andrea A wrote: Thanks a lot for the reply If the preset files are expected to be shared between users, then the database.h stuff isn't good, because different users can have

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-05 Thread Tanu Kaskinen
On Tue, 2019-04-02 at 20:28 +0200, Georg Chini wrote: > On 06.11.18 22:14, Andrea A wrote: > > Thanks a lot for the reply > > > > > If the preset files are expected to be shared between users, then the > > database.h stuff isn't good, because different users can have their > > pulseaudio

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2019-04-02 Thread Georg Chini
On 06.11.18 22:14, Andrea A wrote: Thanks a lot for the reply >If the preset files are expected to be shared between users, then the database.h stuff isn't good, because different users can have their pulseaudio configured with different database formats. I like the "ini- style" configuration

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2018-11-18 Thread Jason Newton
Just some comments on this thread, mainly towards Andrea. I tried looking over the thesis, but Italian is not my language, and google translate seems to give up midway through. Certainly welcome new blood and a new project to make equalization a better experience. Extra points for making it a

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2018-11-08 Thread Tanu Kaskinen
On Tue, 2018-11-06 at 21:14 +, Andrea A wrote: > Thanks a lot for the reply > > > If the preset files are expected to be shared between users, then the > database.h stuff isn't good, because different users can have their > pulseaudio configured with different database formats. I like the

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2018-11-06 Thread Alexander E. Patrakov
Andrea A : > My fear is that a LADSPA plugin will be too hard to use for a lot of desktop > users. I think that a GNU desktop user would like to have a fully working > audio equalizer in his distribution and PA is default in almost all GNU > distributions. Configuring a LADSPA plugin may be

Re: [pulseaudio-discuss] R: New equalizer module (module-eqpro-sink), some questions

2018-11-05 Thread Alexander E. Patrakov
Andrea A : > > I’ve just added the thesis link at the end of the first module comment, I can > change its position if you want: > > https://github.com/andrea993/audioeqpro/blob/afb986711f5125083351cc4f7dac1ca84409f501/pulsemodule/module-eqpro-sink.c#L21 Thank you very much, I will look. It will