Re: [pulseaudio-discuss] [PATCH v2 1/2] Modular API for Bluetooth A2DP codec

2019-01-12 Thread Pali Rohár
Hi Tanu! I'm working on a new version of this patch series. Below are comments, I'm fixing problems which you pointed. Thank you for review. Also, on bluez mailing list are patches which add support for profile switching, so I'm implementing it for this patch series. Once I have implemented it,

[pulseaudio-discuss] [PATCH v3 6/7] bluetooth: Add A2DP aptX codec support

2019-01-12 Thread Pali Rohár
This patch provides support for aptX codec in bluetooth A2DP profile. It uses open source LGPLv2.1+ licensed libopenaptx library which can be found at https://github.com/pali/libopenaptx. Only standard aptX codec is supported for now. Support for other variants like aptX HD or aptX Low Latency

[pulseaudio-discuss] [PATCH v3 4/7] bluetooth: Update a2dp-codecs.h from upstream bluez project

2019-01-12 Thread Pali Rohár
--- src/modules/bluetooth/a2dp-codecs.h | 354 +++- src/modules/bluetooth/bluez5-util.c | 6 +- 2 files changed, 349 insertions(+), 11 deletions(-) diff --git a/src/modules/bluetooth/a2dp-codecs.h b/src/modules/bluetooth/a2dp-codecs.h index 8afcfcb24..0bdd29110

[pulseaudio-discuss] [PATCH v3 7/7] bluetooth: Add A2DP FastStream codec support

2019-01-12 Thread Pali Rohár
Now only main channel, voice backchannel is not implemented yet. --- src/Makefile.am | 2 + src/modules/bluetooth/a2dp-codec-faststream.c | 401 ++ src/modules/bluetooth/a2dp-codec-util.c | 2 + 3 files changed, 405 insertions(+)

[pulseaudio-discuss] [PATCH v3 3/7] bluetooth: policy: Reflect a2dp profile names

2019-01-12 Thread Pali Rohár
In next patches, codec name is appended end the end of a2dp profile names. --- src/modules/bluetooth/module-bluetooth-policy.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/modules/bluetooth/module-bluetooth-policy.c

[pulseaudio-discuss] [PATCH v3 2/7] bluetooth: policy: Remove BlueZ 4 related code

2019-01-12 Thread Pali Rohár
--- src/modules/bluetooth/module-bluetooth-policy.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/modules/bluetooth/module-bluetooth-policy.c b/src/modules/bluetooth/module-bluetooth-policy.c index 4d3126f65..0a6d59d28 100644 ---

[pulseaudio-discuss] [PATCH v3 0/7] New API for Bluetooth A2DP codecs

2019-01-12 Thread Pali Rohár
This is 3rd version of my patch series for modular A2DP codec API and aptX support. v2 link: https://patchwork.freedesktop.org/series/46058/ This patch series provides new modular API for Bluetooth A2DP codecs, clean up module-bluez5-device and bluez5-util to be codec independent and convert SBC

[pulseaudio-discuss] [PATCH v3 1/7] switch-on-port-available: Fix null pointer dereference

2019-01-12 Thread Pali Rohár
Sometimes on pulseaudio startup card->active_profile is NULL. --- src/modules/module-switch-on-port-available.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/module-switch-on-port-available.c b/src/modules/module-switch-on-port-available.c index

Re: [pulseaudio-discuss] [PATCH v2 2/2] Bluetooth A2DP aptX codec support

2019-01-12 Thread Pali Rohár
On Wednesday 05 September 2018 13:57:08 Tanu Kaskinen wrote: > On Sat, 2018-07-28 at 17:34 +0200, Pali Rohár wrote: > > This patch provides support for aptX codec in bluetooth A2DP profile. In > > pulseaudio it is implemented as a new profile a2dp_aptx_sink. For aptX > > encoding it uses open

Re: [pulseaudio-discuss] Bluetooth A2DP aptX codec quality

2019-01-12 Thread Pali Rohár
On Friday 14 September 2018 15:28:55 ValdikSS wrote: > I made a patch for Android LineageOS for Dual Channel support, and thinking > on adding this functionality to Pulseaudio. > https://review.lineageos.org/#/c/LineageOS/android_system_bt/+/228548/ I think this "SBC HD" should be possible to

Re: [pulseaudio-discuss] [PATCH v2 0/2] Bluetooth A2DP aptX codec support

2019-01-12 Thread Pali Rohár
On Friday 03 August 2018 15:32:01 Pali Rohár wrote: > On Friday 03 August 2018 16:22:05 ValdikSS wrote: > > When I try to switch to aptX profile from "off" profile, pulseaudio crashes: > > > > E: [pulseaudio] module-bluez5-device.c: Assertion '!u->thread' failed at > >

Re: [pulseaudio-discuss] [PATCH v3 4/4] Add A2DP LDAC codec source support

2019-01-12 Thread Pali Rohár
On Saturday 29 December 2018 23:48:08 Huang-Huang Bao wrote: > diff --git a/src/modules/bluetooth/a2dp/a2dp_ldac.c > b/src/modules/bluetooth/a2dp/a2dp_ldac.c > new file mode 100644 > index 0..8095d2435 > --- /dev/null > +++ b/src/modules/bluetooth/a2dp/a2dp_ldac.c > @@ -0,0 +1,605 @@ >

[pulseaudio-discuss] Per device volume control?

2019-01-12 Thread Joel Cornuz
Hi Everyone, I hope this is an appropriate place to ask for a general PA usage question - my googleing efforts have proven fruitless :/ I am planning on using PA as part of an interpretation setup (simultaneous language translation) for which I need two interpreters to share one audio input

Re: [pulseaudio-discuss] [PATCH v3 2/4] Add A2DP AAC codec support

2019-01-12 Thread Pali Rohár
On Saturday 29 December 2018 23:48:06 Huang-Huang Bao wrote: > diff --git a/src/modules/bluetooth/a2dp/a2dp_aac.c > b/src/modules/bluetooth/a2dp/a2dp_aac.c > new file mode 100644 > index 0..a1d7bf1d2 > --- /dev/null > +++ b/src/modules/bluetooth/a2dp/a2dp_aac.c > @@ -0,0 +1,762 @@ > +/***