[pulseaudio-discuss] [PATCH v15 02/10] bluetooth: Do not export pa_a2dp_codecs array

2020-04-15 Thread Pali Rohár
It is not used directly outside of a2dp-codec-util.c file. --- src/modules/bluetooth/a2dp-codec-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/bluetooth/a2dp-codec-util.c b/src/modules/bluetooth/a2dp-codec-util.c index 94d01e7bd..aff6589ca 100644 ---

[pulseaudio-discuss] [PATCH v15 03/10] bluetooth: Change codec API for choosing remote endpoint

2020-04-15 Thread Pali Rohár
Current codec API for choosing remote endpoint was not suitable for implementing fallback to another endpoint when first chosen one was not possible to establish. To overcome this problem change codec API to rather provide generic method for comparing two endpoints by their capabilities. Return

[pulseaudio-discuss] [PATCH v15 05/10] bluetooth: Implement A2DP codec switching and backchannel support

2020-04-15 Thread Pali Rohár
Some A2DP codecs (like FastStream or aptX Low Latency) are bi-directional and can be used for both music playback and audio calls. This patch implements usage of backchannel if A2DP codec provided by pulseaudio API supports it. A2DP codec switching needs new version of bluez as older version does

[pulseaudio-discuss] [PATCH v15 06/10] bluetooth: Set initial A2DP profile which bluez already activated

2020-04-15 Thread Pali Rohár
Bluez and remote device decide which A2DP codec would use. Use this selected A2DP codec as initial profile in pulseaudio. In most cases it is either last used codec or codec with higher priority by defined by remote device. To detect which A2DP profile was activated by bluez, look at bluez

[pulseaudio-discuss] [PATCH v15 09/10] bluetooth: Add A2DP FastStream codec support

2020-04-15 Thread Pali Rohár
This patch provides support for FastStream codec in bluetooth A2DP profile. FastStream codec is bi-directional, which means that it supports both music playback and microphone voice at the same time. FastStream codec is just SBC codec with fixed parameters. For playback are used following

[pulseaudio-discuss] [PATCH v15 07/10] bluetooth: policy: Treat bi-directional A2DP profiles as suitable for VOIP

2020-04-15 Thread Pali Rohár
Previously module-bluetooth-policy was switching from A2DP to HSP profile when VOIP application started recording of source. Now it switch to profile with the highest priority which has both sink and source. In most cases it is HSP profile, but it can be also bi-directional A2DP profile (e.g.

[pulseaudio-discuss] [PATCH v15 04/10] bluetooth: policy: Reflect a2dp profile names

2020-04-15 Thread Pali Rohár
In next patches, codec name is appended end the end of a2dp profile names. --- src/modules/bluetooth/module-bluetooth-policy.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/modules/bluetooth/module-bluetooth-policy.c

[pulseaudio-discuss] [PATCH v15 01/10] bluetooth: Add missing newlines into inline XML document

2020-04-15 Thread Pali Rohár
When calling introspection function, newlines in XML document makes it better readable. There are already leading spaces for indentation but newlines were probably forgotten. --- src/modules/bluetooth/bluez5-util.c | 44 ++--- 1 file changed, 22 insertions(+), 22

[pulseaudio-discuss] [PATCH v15 00/10] Bluetooth A2DP codecs

2020-04-15 Thread Pali Rohár
Changes in v15: * Added patch: Do not export pa_a2dp_codecs array * Added patch: Change codec API for choosing remote endpoint * Use pa_assert_se() for expression with side effects In this patch series was changed API for choosing remote endpoint to allow possible fallback to another codec

[pulseaudio-discuss] [PATCH v15 10/10] bluetooth: Add more variants of SBC codec

2020-04-15 Thread Pali Rohár
Specify configuration for Low, Middle, High and eXtreme Quality of SBC codec. SBC codec in eXtreme Quality has higher quality than aptX. Automatic Quality mode matches configuration of SBC codec which was used before this change. Which means that it accept configuration between Low and High

[pulseaudio-discuss] [PATCH v15 08/10] bluetooth: Add A2DP aptX and aptX HD codecs support

2020-04-15 Thread Pali Rohár
This patch provides support for aptX and aptX HD codecs in bluetooth A2DP profile. It uses open source LGPLv2.1+ licensed libopenaptx library which can be found at https://github.com/pali/libopenaptx. aptX for s24 stereo samples provides fixed 6:1 compression ratio and bitrate 352.8 kbit/s, aptX

[pulseaudio-discuss] module-echo-cancel vad

2020-04-15 Thread Stuart Naylor
Been trying to work out what voice_detection does I know its VAD but in terms of pulseaudio struggling to work out any effect or process? Is it me?  If you look at https://github.com/freedesktop/pulseaudio-webrtc-audio-processing/tree/master/webrtc/common_audio/vad Then also much is the same.

Re: [pulseaudio-discuss] module-echo-cancel vad

2020-04-15 Thread Arun Raghavan
Hey Stuart, On Wed, 15 Apr 2020, at 7:34 AM, Stuart Naylor wrote: > > Been trying to work out what voice_detection does I know its VAD but in > terms of pulseaudio struggling to work out any effect or process? > Is it me?  > > If you look at >