Re: [pulseaudio-discuss] [PATCH webrtc-audio-processing] Proper detection of cxxabi.h and execinfo.h

2016-08-19 Thread Arun Raghavan
On Thu, 11 Aug 2016, at 12:59 AM, Thomas Petazzoni wrote: > Hello, > > On Wed, 10 Aug 2016 20:34:54 +0530, Arun Raghavan wrote: > > > Hmm, this one's a bit tricky. Again, changing our copy of the webrtc.org > > code will make maintenance a pain, so I'd prefer for such changes to go > > upstream.

Re: [pulseaudio-discuss] [PATCH] bluetooth: separate HSP and HFP

2016-08-19 Thread James Bottomley
On Fri, 2016-08-19 at 22:33 +0300, Tanu Kaskinen wrote: > On Thu, 2016-08-18 at 11:14 -0700, James Bottomley wrote: > > When all headsets supported both HSP and HFP, life was good and we > > only needed to implement HSP in the native backend. Unfortunately > > some headsets have started supporting

[pulseaudio-discuss] Bluetooth Headset Problem with BlueZ-5.38 and Pulseaudio 8.0

2016-08-19 Thread Hieu Le
Hello, I'm trying to get a SPK-ProHT Bluetooth speaker and headset working on an embedded Linux board but when I failed to use pacmd set-card-profile to choose headset_head_unit profile. Checking pulseaudio lof file, it seems backend-native cannot connect to SCO socket. Sorry this is a very long m

Re: [pulseaudio-discuss] [PATCH] bluetooth: separate HSP and HFP

2016-08-19 Thread Tanu Kaskinen
On Thu, 2016-08-18 at 11:14 -0700, James Bottomley wrote: > When all headsets supported both HSP and HFP, life was good and we > only needed to implement HSP in the native backend.  Unfortunately > some headsets have started supporting HFP only.  Unfortuantely, we > can't simply switch to HFP only

Re: [pulseaudio-discuss] update-card-properties? Possible?

2016-08-19 Thread Tanu Kaskinen
On Thu, 2016-08-18 at 08:41 +1000, Bernd Wechner wrote: > c) at the pulseaudio level there are already description properties  > available (on sinks, cards and ports) and all it would take to allow  > tweaking them is an interface of sorts (update-sink-description,  > update-card-description, updat

Re: [pulseaudio-discuss] Adding support for bluetooth headsets that only have HFP

2016-08-19 Thread James Bottomley
On Fri, 2016-08-19 at 20:24 +0300, Tanu Kaskinen wrote: > On Thu, 2016-08-18 at 07:51 -0700, James Bottomley wrote: > > I recently switched from a JBL Flip 2 which supports both HSP and > > HFP > > to an Ultimate Ears Boom 2 which is HFP only. Needless to say this > > currently means that the Ulti

Re: [pulseaudio-discuss] Adding support for bluetooth headsets that only have HFP

2016-08-19 Thread Tanu Kaskinen
On Thu, 2016-08-18 at 07:51 -0700, James Bottomley wrote: > I recently switched from a JBL Flip 2 which supports both HSP and HFP > to an Ultimate Ears Boom 2 which is HFP only.  Needless to say this > currently means that the Ultimate Ears fails to work with pulseaudio > because we only support HS

Re: [pulseaudio-discuss] [PATCH 6/6] sample: RFC: Assert validity of sample_spec

2016-08-19 Thread Tanu Kaskinen
On Thu, 2016-08-18 at 18:17 +0200, Peter Meerwald-Stadler wrote: > passing an invalid sample_spec to > pa_sample_size_of_format(), > pa_frame_size(), > pa_bytes_per_second(), > pa_bytes_to_usec(), > pa_usec_to_bytes() > currently gives a result of 0 > > this is problematic as > (a) it leads to man

Re: [pulseaudio-discuss] [PATCH 4/6] source-output: Avoid potential NULL dereference

2016-08-19 Thread Tanu Kaskinen
On Thu, 2016-08-18 at 18:17 +0200, Peter Meerwald-Stadler wrote: > if data->source is NULL, pa_source_output_new_data_set_source() may > fail to set data->source; > the false retval is ignored, leading to a NULL dereference in > pa_source_get_state(data->source) below > > CID 1323590 > --- >  src/

Re: [pulseaudio-discuss] [PATCH 5/6] sink-input: Avoid potential NULL dereference

2016-08-19 Thread Tanu Kaskinen
On Thu, 2016-08-18 at 18:17 +0200, Peter Meerwald-Stadler wrote: > if data->sink is NULL, pa_sink_input_new_data_set_sink() may fail to set > data->sink; > the false retval is ignored, leading to a NULL dereference in > pa_sink_get_state(data->sink) below > > CID 1323591 > --- >  src/pulsecore/s

Re: [pulseaudio-discuss] [PATCH 3/6] tests: Assert granularity range in stripnul.c

2016-08-19 Thread Tanu Kaskinen
On Thu, 2016-08-18 at 18:17 +0200, Peter Meerwald-Stadler wrote: > CID 1138482 > --- >  src/tests/stripnul.c | 1 + >  1 file changed, 1 insertion(+) The commit message is lacking an explanation of why this is done, and why 1024 is a good limit. If it's done to avoid overrun of the buffer, it seems

Re: [pulseaudio-discuss] [PATCH 2/6] core: PA_PAGE_SIZE using sysconf() may return a negative number

2016-08-19 Thread Tanu Kaskinen
On Thu, 2016-08-18 at 18:17 +0200, Peter Meerwald-Stadler wrote: > instead of calling sysconf() directly, add function pa_page_size() > which uses the guestimate 4096 in case sysconf(_SC_PAGE_SIZE) fails > > using PA_ONCE to only evaluate sysconf() once > > the name macro.h/.c is a bit unfortunat

Re: [pulseaudio-discuss] [PATCH 1/6] padsp: Fix flush

2016-08-19 Thread Tanu Kaskinen
On Thu, 2016-08-18 at 18:17 +0200, Peter Meerwald-Stadler wrote: > read() can return a number of bytes read less than k There seem to be other fixes too, which are not mentioned in the commit message: handling of EAGAIN (but not EINTR - looks like pa_read() would be suitable here too), fix for the

Re: [pulseaudio-discuss] Sink (input) format negotiation concept

2016-08-19 Thread Arun Raghavan
On Fri, 19 Aug 2016, at 01:17 PM, Rémi Denis-Courmont wrote: > Le vendredi 19 août 2016, 12:16:57 Arun Raghavan a écrit : > > On Fri, 19 Aug 2016, at 01:29 AM, Pierre-Louis Bossart wrote: > > > On 8/18/16 11:43 AM, Rémi Denis-Courmont wrote: > > > > Hello, > > > > > > > > For a number of