Re: [pulseaudio-discuss] Odd app behavior with PULSE_PROP="filter.want=echo-cancel"
In my testing, Zoiper's echo cancellor does not work as well as PA's. On Tue, Feb 13, 2018 at 10:24 AM, Russell Treleaven <rtrelea...@bunnykick.ca> wrote: > Also zoiper will have its own echo cancellor. > Why not use that? > > On Tue, Feb 13, 2018 at 10:21 AM, Georg Chini <ge...@chini.tk> wrote: >> >> On 12.02.2018 20:15, Raman Gupta wrote: >>> >>> When I start Zoiper with PULSE_PROP="filter.want=echo-cancel", it >>> demonstrates some odd behavior. It ends up creating many Echo-Cancel >>> Sink and Source streams, and I am unable to select my USB headset as >>> the source of any of them. >>> >>> I think, based on the discussion around a recent crasher bug I >>> reported, Zoiper is trying to be too clever, without being clever >>> enough, and is actually trying to open up various streams to all of >>> the Pulse Input and Output devices. Is this just a Zoiper issue, or is >>> there something I can do on the Pulse side to solve this? >>> >>> I think one option is load the echo-cancellation module once in >>> /etc/pulse/default.pa and then use the volume control to manually hook >>> up Zoiper to that module. >>> >>> Regards, >>> Raman >>> ___ >> >> Hi, >> >> can't you tell zoiper which devices to use? And can you provide >> a log (beginning when you start zoiper) so that we can see what >> actually happens? >> >> Regards >> Georg >> >> ___ >> pulseaudio-discuss mailing list >> pulseaudio-discuss@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss > > > > > -- > Sincerely, > > Russell Treleaven > sip:rtrelea...@sip.bunnykick.ca > > > ___ > pulseaudio-discuss mailing list > pulseaudio-discuss@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss > ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] Odd app behavior with PULSE_PROP="filter.want=echo-cancel"
On Tue, Feb 13, 2018 at 10:21 AM, Georg Chini <ge...@chini.tk> wrote: > On 12.02.2018 20:15, Raman Gupta wrote: >> >> When I start Zoiper with PULSE_PROP="filter.want=echo-cancel", it >> demonstrates some odd behavior. It ends up creating many Echo-Cancel >> Sink and Source streams, and I am unable to select my USB headset as >> the source of any of them. >> >> I think, based on the discussion around a recent crasher bug I >> reported, Zoiper is trying to be too clever, without being clever >> enough, and is actually trying to open up various streams to all of >> the Pulse Input and Output devices. Is this just a Zoiper issue, or is >> there something I can do on the Pulse side to solve this? >> >> I think one option is load the echo-cancellation module once in >> /etc/pulse/default.pa and then use the volume control to manually hook >> up Zoiper to that module. >> >> Regards, >> Raman >> ___ > > Hi, > > can't you tell zoiper which devices to use? And can you provide > a log (beginning when you start zoiper) so that we can see what > actually happens? > > Regards > Georg It looks like going back to a global echo cancellor works better -- PA allows me to do the expected thing which is to have one echo cancellor source/sink which I can hook up to a device source/sink. And then hook up Zoiper to that echo cancellor source/sink. The reason I don't give Zoiper specific devices to access is that I don't want to have to configure every application individually -- to me, this ability is one of the main benefits of PulseAudio. I'll try and capture a log later when I won't disrupt a bunch of work by killing the PA daemon and causing my mic to fail in every app that uses PA (it sucks that this is a problem too). Regards, Raman ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
[pulseaudio-discuss] Odd app behavior with PULSE_PROP="filter.want=echo-cancel"
When I start Zoiper with PULSE_PROP="filter.want=echo-cancel", it demonstrates some odd behavior. It ends up creating many Echo-Cancel Sink and Source streams, and I am unable to select my USB headset as the source of any of them. I think, based on the discussion around a recent crasher bug I reported, Zoiper is trying to be too clever, without being clever enough, and is actually trying to open up various streams to all of the Pulse Input and Output devices. Is this just a Zoiper issue, or is there something I can do on the Pulse side to solve this? I think one option is load the echo-cancellation module once in /etc/pulse/default.pa and then use the volume control to manually hook up Zoiper to that module. Regards, Raman ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH 0/2] module-echo-cancel fixes
On 09/11/17 07:12 AM, Tanu Kaskinen wrote: > Tanu Kaskinen (2): > echo-cancel: ignore remaining canceller messages after the module has > been unloaded > echo-cancel: fix a memory leak > > src/modules/echo-cancel/module-echo-cancel.c | 22 ++ > 1 file changed, 22 insertions(+) Tanu, is it possible to add unit tests that will help ensure this isn't broken again in the future? This is the second or third time I've had an issue related to this. Regards, Raman ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH 0/7] Fix for an echo-cancel related crash
On 03/22/2016 09:41 AM, Tanu Kaskinen wrote: > This is my second attempt at fixing bug 93443[1]. The first attempt[2] > had a nasty side effect of killing streams connected to any filter > sink while the filter sink was removed. This second attempt is an > entirely different approach. As per my comment on bug 93443, I tested the first three patches of this series on PulseAudio 7.1 (Fedora 23), and I can verify that an echo-cancelled stream does not get killed any longer. Regards, Raman ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH 0/7] Fix for an echo-cancel related crash
Is there a Fedora copr repo where I can get the patched version for testing? If not, can I apply this patch to v7.1? Thanks! Raman On 03/22/2016 09:41 AM, Tanu Kaskinen wrote: > This is my second attempt at fixing bug 93443[1]. The first attempt[2] > had a nasty side effect of killing streams connected to any filter > sink while the filter sink was removed. This second attempt is an > entirely different approach. > > The first patch is the "main" fix, but I think the second patch must > be applied together with it, because after implementing the first fix, > the result was that module-device-manager went into some infinite > stream moving loop that was only stopped by a crash in > module-echo-cancel (that crash is a separate issue, which I'll try to > fix next). > > When trying to reproduce the use case of bug 93443, I found that > module-device-manager can easily break the filtering set up by > module-filter-apply. The third patch fixes that. > > The last four patches refactor stream proplist updating. The third > patch has code that sets a property, and getting the property update > logging just the way I want was frustrating, so I changed the core > property updating code to take care of the logging. > > [1] https://bugs.freedesktop.org/show_bug.cgi?id=93443 > [2] http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/24735 > > Tanu Kaskinen (7): > echo-cancel: rework move handling > don't move streams to devices that are going away > device-manager, filter-apply: don't reroute streams that have a filter > sink-input, source-output: rework property setting > sink-input, source-output: remove set_name() > loopback: refactor proplist updating > filter-apply: simplify proplist updating > > src/modules/echo-cancel/module-echo-cancel.c | 28 ++ > src/modules/module-device-manager.c | 14 +++ > src/modules/module-filter-apply.c| 11 +- > src/modules/module-loopback.c| 28 +++--- > src/pulsecore/protocol-native.c | 4 +- > src/pulsecore/sink-input.c | 145 > +-- > src/pulsecore/sink-input.h | 4 +- > src/pulsecore/sink.c | 7 +- > src/pulsecore/sink.h | 6 ++ > src/pulsecore/source-output.c| 145 > +-- > src/pulsecore/source-output.h| 4 +- > src/pulsecore/source.c | 5 + > src/pulsecore/source.h | 6 ++ > 13 files changed, 304 insertions(+), 103 deletions(-) > ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] Filters, autoloading, profile changes and crashes
Arun, I am the OP for bug #90416. I can't comment on the details/implementation of your patch, but I will note that the patch series does indeed fix the problem. Very cool! Regards, Raman Gupta On 06/09/2015 03:08 AM, a...@accosted.net wrote: This fixes bug #90416. Details of the problem and the fix are on the bug and patch #3. This does feel a bit sub-optimal to me, but I couldn't think of a better way to maintain consistency of state. If anyone has better ideas, I'm all ears. Cheers, Arun ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] Filters, autoloading, profile changes and crashes
On 06/09/2015 01:21 PM, Raman Gupta wrote: Arun, I am the OP for bug #90416. I can't comment on the details/implementation of your patch, but I will note that the patch series does indeed fix the problem. Very cool! One minor note: after applying this patch, when the card profile is switched, the PulseAudio Volume Control application shows Unknown Input on the echo-cancelled stream in the Recording tab. Restarting the volume control app resets it. Kmix does not show the same behavior. Regards, Raman ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
