[pulseaudio-discuss] [PATCH v2 08/21] device-port: Generate monitor nodes for output ports

2013-12-05 Thread Tanu Kaskinen
--- src/pulsecore/device-port.c | 31 +++ src/pulsecore/device-port.h | 1 + src/pulsecore/node.h| 3 ++- 3 files changed, 34 insertions(+), 1 deletion(-) diff --git a/src/pulsecore/device-port.c b/src/pulsecore/device-port.c index 9801e35..cf62ec3 100644

[pulseaudio-discuss] [PATCH v2 21/21] New module: module-experimental-router

2013-12-05 Thread Tanu Kaskinen
Software + Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 + USA. +***/ + +#ifdef HAVE_CONFIG_H +#include config.h +#endif + +#include module-experimental-router-symdef.h + +#include pulsecore/i18n.h +#include pulsecore/module.h +#include pulsecore/namereg.h + +PA_MODULE_AUTHOR(Tanu

[pulseaudio-discuss] [PATCH v2 19/21] sink-input, source-output: Allow pa_node_put() to do routing

2013-12-05 Thread Tanu Kaskinen
pa_node_put() will tell the router module, if there is one loaded, that a new node is being created. The router module can then set the initial routing for the new node. To set the initial routing for a stream, the device pointer needs to be set and the format needs to be negotiated. This patch

[pulseaudio-discuss] [PATCH v2 16/21] core-format: Add pa_format_info_negotiate()

2013-12-05 Thread Tanu Kaskinen
Currently format negotiation is done in pa_sink_input_new_data_set_sink(), but the new data won't be available when a router module needs to connect a sink input node to some other node, so a different function is needed. It would probably otherwise be possible to convert also

[pulseaudio-discuss] [PATCH v2 05/21] sink: Create the sink node before creating the monitor source

2013-12-05 Thread Tanu Kaskinen
The sink node object will be used during the monitor source creation to figure out whether the monitor source should create a node for itself. --- src/pulsecore/sink.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/pulsecore/sink.c

[pulseaudio-discuss] [PATCH v2 06/21] Don't create nodes for monitor sources if the sink has ports

2013-12-05 Thread Tanu Kaskinen
The monitor source node should be created only if the sink has a node. If the sink has ports, then a separate monitor node should be created for each of the sink ports (will be implemented later). --- src/pulsecore/node.c | 6 ++ src/pulsecore/node.h | 2 ++ src/pulsecore/source.c | 5

[pulseaudio-discuss] [PATCH v2 09/21] sink-input, source-output: Use goto fail for error handling in new()

2013-12-05 Thread Tanu Kaskinen
In a later patch the sink input/source output structure will be allocated in the very beginning of the function. This patch prepares for that by making sure that the allocated structure will always be properly cleaned up in case of a failure. --- src/pulsecore/sink-input.c| 102

Re: [pulseaudio-discuss] [PATCH] alsa: Disable timer-scheduling for PCMs with the BATCH flag

2013-12-06 Thread Tanu Kaskinen
On Sat, 2013-11-30 at 18:07 +0100, Lars-Peter Clausen wrote: PCM Devices which have the BATCH flag set update the PCM pointer only with period size granularity. Using timer based scheduling does not have any advantage in this mode. For one devices which have that flag set usually update the

[pulseaudio-discuss] Patch review status wiki page updated

2013-12-06 Thread Tanu Kaskinen
Patch review status updated: http://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/User/Software/PulseAudio/PatchStatus/ Statistics: * 2013-12-06: * 99 patches are pending review (not counting the in a github branch patches). * The oldest pending patch is 143 days old. *

Re: [pulseaudio-discuss] HFP profile of Bluetooth headset is not recognized

2013-12-06 Thread Tanu Kaskinen
On Tue, 2013-12-03 at 23:51 +0100, Karol Babioch wrote: Hi, I'm not particularly familiar with the whole Linux Bluetooth stack (especially in combination with PulseAudio and the desktop manager gluing all of this together), but since the upgrade to BlueZ 5.x along with GNOME 3.10 a couple

[pulseaudio-discuss] [PATCH v2 03/10] card: Add pa_card_new_data_add_profile()

2013-12-09 Thread Tanu Kaskinen
Currently the function doesn't do anything fancy, but I'll need the function for automatically adding the device prototypes in the card profile to the card. --- src/modules/alsa/module-alsa-card.c | 24 +--- src/modules/bluetooth/module-bluetooth-device.c | 4 ++--

[pulseaudio-discuss] [PATCH v2 02/10] card: Add recreate_devices_on_profile_change flag

2013-12-09 Thread Tanu Kaskinen
I intend to write a router module that rescues streams from removed devices when a card profile changes. If a device is part of both the old and new profile, it may or may not get recreated (alsa doesn't recreate such devices, bluetooth does). If it's not recreated, then rescuing is not needed, so

[pulseaudio-discuss] [PATCH v2 04/10] card, sink, source: Introduce pa_device_prototype

2013-12-09 Thread Tanu Kaskinen
The active profile of a card determines which sinks and sources of the card are active, and a sink or source being active means here to exist. When switching the profile, sinks and sources that are not part of the new profile are deleted. It's not nice that the sinks and sources are deleted like

[pulseaudio-discuss] [PATCH v2 10/10] alsa: Remove the stream rescue policy from module-alsa-card

2013-12-09 Thread Tanu Kaskinen
This logic is now provided by module-skoa-router. --- src/modules/alsa/module-alsa-card.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/src/modules/alsa/module-alsa-card.c b/src/modules/alsa/module-alsa-card.c index 9e22696..103a8fa 100644 ---

[pulseaudio-discuss] [PATCH v2 01/10] Add PA_CORE_HOOK_CARD_SET_PROFILE

2013-12-09 Thread Tanu Kaskinen
This hook allows router modules to intercept profile change requests. A router might want, for example, to move streams elsewhere when the current sink or source disappears due to a profile switch. For more explanation, see the documentation that I added to core.h for this hook. ---

[pulseaudio-discuss] [PATCH v2 05/10] alsa: Add device prototype support

2013-12-09 Thread Tanu Kaskinen
Each mapping corresponds to a device prototype, except some mappings can correspond to two prototypes, because some mappings create both a sink and a source. --- src/modules/alsa/alsa-mixer.c | 1 - src/modules/alsa/alsa-mixer.h | 2 ++ src/modules/alsa/alsa-sink.c| 3 +++

[pulseaudio-discuss] [PATCH v2 08/10] card: Remove n_sinks and n_sources from pa_card_profile

2013-12-09 Thread Tanu Kaskinen
Those fields are redundant, because the same information can be inferred from sink_prototypes and source_prototypes. --- src/modules/alsa/module-alsa-card.c | 4 src/modules/bluetooth/module-bluetooth-device.c | 8 src/modules/dbus/iface-card-profile.c | 8

[pulseaudio-discuss] [PATCH v2 07/10] bluetooth: Add device prototype support

2013-12-09 Thread Tanu Kaskinen
There is only one sink prototype and only one source prototype, because regardless of the chosen profile, the sink and source will always use the same name, therefore they should be treated as the same entity. In the SCO over PCM mode we have to manage the sink/source pointer lifecycle in the

[pulseaudio-discuss] [PATCH v2 06/10] bluetooth: Fix profile information in the SCO over PCM mode

2013-12-09 Thread Tanu Kaskinen
In the SCO over PCM mode the HSP and HFGW profiles don't create any sinks and sources, so n_sinks, n_sources, max_sink_channels and max_source_channels should be 0. --- src/modules/bluetooth/module-bluetooth-device.c | 24 1 file changed, 16 insertions(+), 8 deletions(-)

Re: [pulseaudio-discuss] [PATCH v2 01/10] Add PA_CORE_HOOK_CARD_SET_PROFILE

2013-12-10 Thread Tanu Kaskinen
On Mon, 2013-12-09 at 20:31 +0200, Tanu Kaskinen wrote: diff --git a/src/pulsecore/core.h b/src/pulsecore/core.h index 8b4bf05..f8863ae 100644 --- a/src/pulsecore/core.h +++ b/src/pulsecore/core.h @@ -115,6 +115,37 @@ typedef enum pa_core_hook { PA_CORE_HOOK_CARD_NEW

Re: [pulseaudio-discuss] [PATCH v2 04/10] card, sink, source: Introduce pa_device_prototype

2013-12-11 Thread Tanu Kaskinen
On Mon, 2013-12-09 at 20:31 +0200, Tanu Kaskinen wrote: @@ -45,7 +64,13 @@ typedef struct pa_card_profile { unsigned priority; pa_available_t available; /* PA_AVAILABLE_UNKNOWN, PA_AVAILABLE_NO or PA_AVAILABLE_YES */ -/* We probably want to have different properties later

Re: [pulseaudio-discuss] [PATCH pavucontrol] ellipsize labels to fix window resizing

2013-12-13 Thread Tanu Kaskinen
On Fri, 2013-12-06 at 20:02 +0600, Alexander E. Patrakov wrote: 2013/12/5 Sebastian Wick sebast...@sebastianwick.net: ellipsize labels to make the window resizable even with long label text and add tooltips to provide a way to read the full text --- src/mainwindow.cc | 6 ++

Re: [pulseaudio-discuss] [PATCH pavucontrol] ellipsize labels to fix window resizing

2013-12-13 Thread Tanu Kaskinen
On Fri, 2013-12-13 at 17:53 +0600, Alexander E. Patrakov wrote: 2013/12/13 Tanu Kaskinen tanu.kaski...@linux.intel.com: How did you apply the patch? By hand? It doesn't apply on my fresh checkout of the pavucontrol master branch. I have saved the e-mail from gmail web interface. Indeed

[pulseaudio-discuss] Patch review status wiki page updated

2013-12-13 Thread Tanu Kaskinen
Patch review status updated: http://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/User/Software/PulseAudio/PatchStatus/ Statistics: * 2013-12-13: * 101 patches are pending review (not counting the in a github branch patches). * The oldest pending patch is 150 days old. *

Re: [pulseaudio-discuss] Pause a audio stream

2013-12-13 Thread Tanu Kaskinen
On Wed, 2013-12-11 at 15:28 +0530, sathishkumar sivagurunathan wrote: Hi, I have been trying to look into pulse audio to find if it is possible only to cork a stream (No priority handling). My requirement is 1) I have a routing policy manager which would like to

Re: [pulseaudio-discuss] The Perfect Setup page is confusing

2013-12-13 Thread Tanu Kaskinen
On Fri, 2013-12-13 at 15:20 +0100, Damir Jelić wrote: On Fri, Dec 06, 2013 at 03:50:22PM +0200, Nikos Chantziaras wrote: The documentation: http://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/User Has a link to the Perfect Setup: After doing your first steps

Re: [pulseaudio-discuss] [PATCH 00/25] raop2 support for module-raop-sink

2013-12-13 Thread Tanu Kaskinen
On Sun, 2013-12-08 at 00:11 -0600, Hajime Fujita wrote: Hi Tanu and Martin, Sorry for the late reply. I just pushed a new series of patches to raop2-for-merge2 branch. https://github.com/hfujita/pulseaudio-raop2/commits/raop2-for-merge2 Nothing has really been changed from

Re: [pulseaudio-discuss] [PATCH] alsa: Disable timer-scheduling for PCMs with the BATCH flag

2013-12-13 Thread Tanu Kaskinen
On Mon, 2013-12-09 at 13:23 +0800, Raymond Yau wrote: 2013/12/6 Tanu Kaskinen tanu.kaski...@linux.intel.com On Sat, 2013-11-30 at 18:07 +0100, Lars-Peter Clausen wrote: PCM Devices which have the BATCH flag set update the PCM pointer only with period size granularity. Using timer

[pulseaudio-discuss] [PATCH] volume-test: Increase the allowed number of rouding errors

2013-12-13 Thread Tanu Kaskinen
--- src/tests/volume-test.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/tests/volume-test.c b/src/tests/volume-test.c index a2daf3e..1ab0b5c 100644 --- a/src/tests/volume-test.c +++ b/src/tests/volume-test.c @@ -138,7 +138,13 @@ START_TEST (volume_test) {

Re: [pulseaudio-discuss] The Perfect Setup page is confusing

2013-12-16 Thread Tanu Kaskinen
On Sat, 2013-12-14 at 08:01 +0200, Tanu Kaskinen wrote: On Fri, 2013-12-13 at 15:20 +0100, Damir Jelić wrote: On Fri, Dec 06, 2013 at 03:50:22PM +0200, Nikos Chantziaras wrote: The documentation: http://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/User Has

Re: [pulseaudio-discuss] Pause a audio stream

2013-12-16 Thread Tanu Kaskinen
On Sat, 2013-12-14 at 14:25 +0530, sathishkumar sivagurunathan wrote: Thanks Tanu for the reply, I have been trying to some simple analysis for the past on this question below I raised before you last time.. 1) I have a routing policy manager which would like to cork/pause a stream. No

[pulseaudio-discuss] [PATCH v2 02/18] core-format: Add pa_format_info_get_sample_format()

2013-12-18 Thread Tanu Kaskinen
--- src/pulse/format.c | 9 ++--- src/pulsecore/core-format.c | 27 +++ src/pulsecore/core-format.h | 5 + 3 files changed, 34 insertions(+), 7 deletions(-) diff --git a/src/pulse/format.c b/src/pulse/format.c index 9c7e13e..0b87560 100644 ---

[pulseaudio-discuss] [PATCH v2 00/18] Format negotiation fixing

2013-12-18 Thread Tanu Kaskinen
, so why should the volume channel map be? Also, the volume has nothing to do with the stream format, so putting the channel map to a format info would mean basically abusing the extensible format info structure for passing arbitrary extra parameters for the stream. Tanu Kaskinen (18): Move

[pulseaudio-discuss] [PATCH v2 03/18] core-format: Add pa_format_info_get_rate()

2013-12-18 Thread Tanu Kaskinen
This also fixes an issue in pa_format_info_to_sample_spec(): it did no validation for the rate value. Now the validation is taken care of in pa_format_info_get_rate(). --- src/pulse/format.c | 5 ++--- src/pulsecore/core-format.c | 22 ++ src/pulsecore/core-format.h

[pulseaudio-discuss] [PATCH v2 01/18] Move pa_format_info_to_sample_spec_fake() to core-format

2013-12-18 Thread Tanu Kaskinen
I will need to use the function from outside libpulse. I added the channel map argument, because the function will be called from another function that is expected to initialize the channel map. I don't know if it's in practice necessary, but it shouldn't do any harm either. --- src/Makefile.am

[pulseaudio-discuss] [PATCH v2 04/18] core-format: Add pa_format_info_get_channels()

2013-12-18 Thread Tanu Kaskinen
This also fixes an issue in pa_format_info_to_sample_spec(): it did no validation for the channels value. Now the validation is taken care of in pa_format_info_get_channels(). --- src/pulse/format.c | 5 + src/pulsecore/core-format.c | 22 ++

[pulseaudio-discuss] [PATCH v2 05/18] core-format: Add pa_format_info_get_channel_map()

2013-12-18 Thread Tanu Kaskinen
--- src/pulse/format.c | 14 ++ src/pulsecore/core-format.c | 23 +++ src/pulsecore/core-format.h | 5 + 3 files changed, 30 insertions(+), 12 deletions(-) diff --git a/src/pulse/format.c b/src/pulse/format.c index 424df0e..4f4b342 100644 ---

[pulseaudio-discuss] [PATCH v2 08/18] core-format: Add pa_format_info_from_sample_spec2()

2013-12-18 Thread Tanu Kaskinen
The function will be used in pa_sink_input_new() and pa_source_output_new() to convert the sample spec given by the client to a format info object. The set_format, set_rate and set_channels will be set according to the stream flags (PA_SINK_INPUT_FIX_FORMAT etc.). --- src/pulsecore/core-format.c

[pulseaudio-discuss] [PATCH v2 10/18] format, core-format: Constify some function parameters

2013-12-18 Thread Tanu Kaskinen
--- src/pulse/format.c | 18 +- src/pulse/format.h | 18 +- src/pulsecore/core-format.c | 14 +++--- src/pulsecore/core-format.h | 14 +++--- 4 files changed, 32 insertions(+), 32 deletions(-) diff --git a/src/pulse/format.c

[pulseaudio-discuss] [PATCH v2 16/18] stream: Improve pa_stream_connect_playback() documentation

2013-12-18 Thread Tanu Kaskinen
--- src/pulse/stream.h | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/pulse/stream.h b/src/pulse/stream.h index 9821ab8..9bf7dd2 100644 --- a/src/pulse/stream.h +++ b/src/pulse/stream.h @@ -466,7 +466,16 @@ int pa_stream_set_volume_channel_map( * an absolute

[pulseaudio-discuss] [PATCH v2 14/18] stream: Add pa_stream_set_volume_channel_map()

2013-12-18 Thread Tanu Kaskinen
The purpose is explained in the function documentation in stream.h. --- src/map-file | 1 + src/pulse/internal.h | 1 + src/pulse/stream.c | 28 +--- src/pulse/stream.h | 31 +++ 4 files changed, 58 insertions(+), 3 deletions(-)

[pulseaudio-discuss] [PATCH v2 17/18] stream: Mention pa_stream_new_extended() in the high-level stream creation documentation

2013-12-18 Thread Tanu Kaskinen
--- src/pulse/stream.h | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/pulse/stream.h b/src/pulse/stream.h index 9bf7dd2..f80dd7b 100644 --- a/src/pulse/stream.h +++ b/src/pulse/stream.h @@ -52,9 +52,14 @@ * \section create_sec Creating * * To access a

[pulseaudio-discuss] [PATCH v2 11/18] stream-util: Add pa_stream_get_volume_channel_map()

2013-12-18 Thread Tanu Kaskinen
The new function isn't used yet, but it soon will. --- src/Makefile.am | 1 + src/pulsecore/stream-util.c | 87 + src/pulsecore/stream-util.h | 50 ++ 3 files changed, 138 insertions(+) create mode 100644

[pulseaudio-discuss] [PATCH v2 06/18] format: Simplify pa_format_info_to_sample_spec()

2013-12-18 Thread Tanu Kaskinen
--- src/pulse/format.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/pulse/format.c b/src/pulse/format.c index 4f4b342..9b42cdb 100644 --- a/src/pulse/format.c +++ b/src/pulse/format.c @@ -218,8 +218,6 @@ pa_format_info*

[pulseaudio-discuss] [PATCH v2 15/18] def, format: Document how to leave PCM parameters to be decided by the server

2013-12-18 Thread Tanu Kaskinen
--- src/pulse/def.h| 38 src/pulse/format.h | 56 +- 2 files changed, 85 insertions(+), 9 deletions(-) diff --git a/src/pulse/def.h b/src/pulse/def.h index 58190cb..a01c902 100644 --- a/src/pulse/def.h

[pulseaudio-discuss] [PATCH v2 09/18] sink-input, source-output: Do routing related validity checks immediately after routing

2013-12-18 Thread Tanu Kaskinen
It's more logical that way. --- src/pulsecore/sink-input.c| 11 +++ src/pulsecore/source-output.c | 9 - 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/src/pulsecore/sink-input.c b/src/pulsecore/sink-input.c index b002467..2085916 100644 ---

[pulseaudio-discuss] [PATCH v2 13/18] sink-input, source-output: Interpret missing PCM parameters in format info as a request to decide those parameters at the server end

2013-12-18 Thread Tanu Kaskinen
The fix flags (PA_SINK_INPUT_FIX_FORMAT etc.) don't work properly with the pa_stream_new_extended() interface. This patch fixes it so that the same effect can be achieved by leaving some of the PCM parameters unspecified in format info objects. Also, when converting a sample spec to a format info

[pulseaudio-discuss] [PATCH v2 18/18] format: Add some error logging

2013-12-18 Thread Tanu Kaskinen
--- src/pulse/format.c | 31 ++- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/src/pulse/format.c b/src/pulse/format.c index 6c34594..729c2d2 100644 --- a/src/pulse/format.c +++ b/src/pulse/format.c @@ -323,10 +323,13 @@ int

Re: [pulseaudio-discuss] [PATCH v2 00/18] Format negotiation fixing

2013-12-18 Thread Tanu Kaskinen
On Wed, 2013-12-18 at 19:28 +0200, Tanu Kaskinen wrote: Changes in v2: - Support clients that want to set the stream volume while at the same leaving the stream channel map unspecified. - Support setting mono volume even if the stream has multiple channels (the volume

Re: [pulseaudio-discuss] [PATCH v2 00/18] Format negotiation fixing

2013-12-18 Thread Tanu Kaskinen
On Wed, 2013-12-18 at 22:56 +0100, Peter Meerwald wrote: Hello Tanu, I had a look at the patches, I only have very minor comments (1) as a matter of style, in most places in PA there is no newline between an assignment and the conditional statement checking the assigned value OK, fair

Re: [pulseaudio-discuss] [PATCH 0/5] stream documentation update

2013-12-20 Thread Tanu Kaskinen
On Mon, 2013-12-16 at 14:18 +0100, Peter Meerwald wrote: From: Peter Meerwald p.meerw...@bct-electronic.com patches 1 and 2 fix bugs in the documentation patches 3 and 4 changes documentation to match the implementation patch 5 enables pa_simple_flush() to be called on record streams

Re: [pulseaudio-discuss] [PATCH] thread-mq: Initialize thread_mainloop to NULL if not in use

2013-12-20 Thread Tanu Kaskinen
On Tue, 2013-12-17 at 00:07 +0100, Jan Alexander Steffens (heftig) wrote: Fixes a crash when unloading module-zeroconf-publish. Signed-off-by: Jan Alexander Steffens (heftig) jan.steff...@gmail.com --- src/pulsecore/thread-mq.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [pulseaudio-discuss] [PATCH 00/13] coverity fixes

2013-12-20 Thread Tanu Kaskinen
On Mon, 2013-12-16 at 18:20 +0100, Peter Meerwald wrote: From: Peter Meerwald p.meerw...@bct-electronic.com fix some issues shown by coverity Peter Meerwald (13): modules: Fix resource leak in stream-restore modules: Fix resource leak in alsa-card modules: Fix resource leak in

Re: [pulseaudio-discuss] [PATCH 00/13] coverity fixes

2013-12-20 Thread Tanu Kaskinen
On Fri, 2013-12-20 at 13:08 +0200, Tanu Kaskinen wrote: On Mon, 2013-12-16 at 18:20 +0100, Peter Meerwald wrote: From: Peter Meerwald p.meerw...@bct-electronic.com fix some issues shown by coverity Peter Meerwald (13): modules: Fix resource leak in stream-restore modules: Fix

[pulseaudio-discuss] Patch review status wiki page updated

2013-12-20 Thread Tanu Kaskinen
Patch review status updated: http://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/User/Software/PulseAudio/PatchStatus/ Statistics: * 2013-12-20: * 77 patches are pending review (not counting the in a github branch patches). * The oldest pending patch is 157 days old. *

Re: [pulseaudio-discuss] Pause a audio stream

2013-12-20 Thread Tanu Kaskinen
[Why is every line that you write prefixed with ? That's usually only used for quoted text.] On Fri, 2013-12-20 at 09:48 +0530, sathishkumar sivagurunathan wrote: Hi , I am trying to add a new function pa_context_set_sink_input_paused to the pulseaudio introspect.c file. I was able to

Re: [pulseaudio-discuss] [PATCH] Documentation of known misuse of PulseAudio API

2013-12-20 Thread Tanu Kaskinen
On Tue, 2013-10-22 at 00:19 +0100, Alexander E. Patrakov wrote: Hello. Over time, I became aware of several instances of tempting but semantically incorrect usage of PulseAudio API (one from my own bad proposal of improving Wine, one from Parole media player and one from Webkit-GTK). I want

Re: [pulseaudio-discuss] Pause a audio stream

2013-12-20 Thread Tanu Kaskinen
On Fri, 2013-12-20 at 20:24 +0530, sathishkumar sivagurunathan wrote: Thanks Tanu, I followed your instructions. I was able to solve this problem. I had made the new function “GLOBAL”. I edited the “map-file” in src folder of pulseaudio to include the newly created function. I was

Re: [pulseaudio-discuss] [PATCH v2 01/18] Move pa_format_info_to_sample_spec_fake() to core-format

2013-12-30 Thread Tanu Kaskinen
On Fri, 2013-12-27 at 15:27 +0530, Arun Raghavan wrote: On Wed, 2013-12-18 at 19:28 +0200, Tanu Kaskinen wrote: I will need to use the function from outside libpulse. I added the channel map argument, because the function will be called from another function that is expected

[pulseaudio-discuss] [PATCH 17/17] sink, source: Add ports in pa_sink/source_set_prototype()

2013-12-30 Thread Tanu Kaskinen
Card implementations don't need to care about adding the ports to sinks and sources, so a lot of code can be removed. --- src/modules/alsa/alsa-mixer.c | 72 - src/modules/alsa/alsa-sink.c| 5 +- src/modules/alsa/alsa-source.c

[pulseaudio-discuss] [PATCH 09/17] alsa: Add pa_alsa_profile_set_create_ports()

2013-12-30 Thread Tanu Kaskinen
Currently, card ports, device prototypes and profiles are all created together in an interleaved manner. My goal is to split that process so that first all ports are created, then all device prototypes are created and finally all profiles are created. This patch is the first major step in that

[pulseaudio-discuss] [PATCH 16/17] alsa: Separate intended role initialization from adding ports

2013-12-30 Thread Tanu Kaskinen
Adding ports will not be necessary in the future, but setting the intended roles will stay relevant. For that reason it makes sense to have those two operations separate. --- src/modules/alsa/alsa-sink.c | 7 --- src/modules/alsa/alsa-source.c | 7 --- src/modules/alsa/alsa-ucm.c|

[pulseaudio-discuss] [PATCH 05/17] alsa: Fix boolean style (int-bool)

2013-12-30 Thread Tanu Kaskinen
--- src/modules/alsa/alsa-ucm.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/modules/alsa/alsa-ucm.c b/src/modules/alsa/alsa-ucm.c index b1f1518..f4a6a84 100644 --- a/src/modules/alsa/alsa-ucm.c +++ b/src/modules/alsa/alsa-ucm.c @@ -792,7 +792,7 @@ static

[pulseaudio-discuss] [PATCH 12/17] bluetooth: Store port pointers instead of port names in userdata

2013-12-30 Thread Tanu Kaskinen
It's more convenient that way. --- src/modules/bluetooth/module-bluetooth-device.c | 89 +++-- 1 file changed, 39 insertions(+), 50 deletions(-) diff --git a/src/modules/bluetooth/module-bluetooth-device.c b/src/modules/bluetooth/module-bluetooth-device.c index

[pulseaudio-discuss] [PATCH 10/17] alsa: Add a ports array to pa_alsa_ucm_mapping_context

2013-12-30 Thread Tanu Kaskinen
Currently UCM ports are created at the same time with profiles, but I want to create the ports before the profiles. This new array will allow creating the ports separately from the profiles. --- src/modules/alsa/alsa-ucm.c | 8 src/modules/alsa/alsa-ucm.h | 1 + 2 files changed, 9

[pulseaudio-discuss] [PATCH 02/17] dynarray: Add PA_DYNARRAY_FOREACH

2013-12-30 Thread Tanu Kaskinen
The PA_DYNARRAY_FOREACH macro requires that pa_dynarray_get() returns NULL if the index is out of bounds. --- src/pulsecore/dynarray.c | 4 +++- src/pulsecore/dynarray.h | 5 + src/pulsecore/tokenizer.c | 3 --- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git

[pulseaudio-discuss] [PATCH 14/17] card: Add ports hashmap to pa_device_prototype

2013-12-30 Thread Tanu Kaskinen
This will allow simplifying card implementations in later patches. Ports can be added automatically to sinks and sources via the prototype, and profiles can be added automatically to ports. --- src/modules/alsa/alsa-mixer.c | 26 +

[pulseaudio-discuss] [PATCH 06/17] alsa: Remove an unused function parameter

2013-12-30 Thread Tanu Kaskinen
--- src/modules/alsa/alsa-ucm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/modules/alsa/alsa-ucm.c b/src/modules/alsa/alsa-ucm.c index f4a6a84..ce10970 100644 --- a/src/modules/alsa/alsa-ucm.c +++ b/src/modules/alsa/alsa-ucm.c @@ -793,7 +793,6 @@ static int

[pulseaudio-discuss] [PATCH 01/17] alsa: Add a ports array to pa_alsa_path

2013-12-30 Thread Tanu Kaskinen
One path can be the basis for multiple ports. Having just a single port pointer in pa_alsa_path doesn't make sense, and I'll remove that pointer once I have converted the users of that pointer to use this new ports array. --- src/modules/alsa/alsa-mixer.c | 7 +++

[pulseaudio-discuss] [PATCH 07/17] alsa: Move the port name and description logic

2013-12-30 Thread Tanu Kaskinen
I think the new place makes more sense. Or if nothing else, at least the parameter list of device_port_alsa_init() is now shorter. --- src/modules/alsa/alsa-mixer.c | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git

[pulseaudio-discuss] [PATCH 04/17] alsa: Remove pa_alsa_path.port

2013-12-30 Thread Tanu Kaskinen
It's fully superseded by pa_alsa_path.ports --- src/modules/alsa/alsa-mixer.c | 2 +- src/modules/alsa/alsa-mixer.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/modules/alsa/alsa-mixer.c b/src/modules/alsa/alsa-mixer.c index e7d137a..316f546 100644 ---

Re: [pulseaudio-discuss] [PATCH] alsa-card: Don't free the modargs in pa_init.

2013-12-30 Thread Tanu Kaskinen
On Wed, 2013-12-25 at 10:14 +0100, Peter Meerwald wrote: The modargs are in both cases (a succesfull as well as a failed module initialization) freed already in pa_done(). the alsa module keeps a pointer to the modargs; hence, they MUST NOT be freed in the success case in the fail

Re: [pulseaudio-discuss] [PATCH] caps: Fix warnings.

2013-12-30 Thread Tanu Kaskinen
On Wed, 2013-12-25 at 11:20 +0100, poljar (Damir Jelić) wrote: Since this commit: 1da34e99b203de14a45c94ec768faf04d41eca5b gcc was spewing out some warnings: ../../src/daemon/caps.c:89:7: warning: __FreeBSD__ is not defined [-Wundef] #elif __FreeBSD__

Re: [pulseaudio-discuss] [PATCH] alsa-card: Don't free the modargs in pa_init.

2013-12-31 Thread Tanu Kaskinen
On Mon, 2013-12-30 at 20:09 +0100, Peter Meerwald wrote: Hi, The modargs are in both cases (a succesfull as well as a failed module initialization) freed already in pa_done(). the alsa module keeps a pointer to the modargs; hence, they MUST NOT be freed in the success case

Re: [pulseaudio-discuss] [PATCH] Documentation of known misuse of PulseAudio API

2014-01-03 Thread Tanu Kaskinen
On Fri, 2013-12-20 at 21:39 +0600, Alexander E. Patrakov wrote: Tanu Kaskinen wrote: This is the only bit that I'd change in some way: + * is too high. With flat volumes disabled (the default in Ubuntu), it means + * the maximum hardware volume attenuated by the sink volume. In most

Re: [pulseaudio-discuss] Error when I compile pulseaudio 4.0

2014-01-03 Thread Tanu Kaskinen
On Fri, 2013-12-20 at 17:19 +0100, Martial TUR wrote: Hi, I try to compile pulseaudio on ubuntu 12.04. I have download pulseaudio 4.0, bluez 5.12 and sbc sources. bluez and sbc compile are OK. pulseaudio configure are OK with this command line.

Re: [pulseaudio-discuss] [PATCH 1/2] bluez5-util: Free the adapter_path in device_free().

2014-01-03 Thread Tanu Kaskinen
On Tue, 2013-12-24 at 22:35 +0100, poljar (Damir Jelić) wrote: --- src/modules/bluetooth/bluez5-util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/modules/bluetooth/bluez5-util.c b/src/modules/bluetooth/bluez5-util.c index c7fb6ae..7eecc18 100644 ---

Re: [pulseaudio-discuss] [PATCH] module-rtp-recv: Add an argument for latency

2014-01-03 Thread Tanu Kaskinen
On Thu, 2013-12-26 at 15:46 +0200, Laurentiu Nicola wrote: --- src/modules/rtp/module-rtp-recv.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) Thanks! Applied. -- Tanu ___ pulseaudio-discuss mailing list

Re: [pulseaudio-discuss] bluez5 with bluetooth headsets

2014-01-03 Thread Tanu Kaskinen
On Fri, 2013-12-27 at 17:56 +, Chris Mason wrote: Hi everyone, I have a plantronics PLT_M55 headset that supports HSP, but I'm unable to use the microphone. A little searching around shows this was removed from bluez5, and it hasn't yet been enabled via profiles in pulseaudio. Do

[pulseaudio-discuss] Patch review status wiki page updated

2014-01-03 Thread Tanu Kaskinen
Patch review status updated: http://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/User/Software/PulseAudio/PatchStatus/ Statistics: * 2014-01-03: * 95 patches are pending review (not counting the in a github branch patches). * The oldest pending patch is 171 days old. *

Re: [pulseaudio-discuss] [PATCH] volume-test: Increase the allowed number of rouding errors

2014-01-03 Thread Tanu Kaskinen
On Sat, 2013-12-14 at 09:21 +0200, Tanu Kaskinen wrote: --- src/tests/volume-test.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/tests/volume-test.c b/src/tests/volume-test.c index a2daf3e..1ab0b5c 100644 --- a/src/tests/volume-test.c +++ b/src/tests

Re: [pulseaudio-discuss] Pause a audio stream

2014-01-03 Thread Tanu Kaskinen
On Mon, 2013-12-30 at 22:33 +0530, sathishkumar sivagurunathan wrote: Hi Tanu, Thanks for the reply.. I was able to get over the problem.. I have added the new function to cork to pulseaudio.. Compiled pulseaudio.. Hence I currently have a local copy of pulseaudio.. The problem I am

[pulseaudio-discuss] [PATCH v3 03/17] core-format: Add pa_format_info_get_rate()

2014-01-08 Thread Tanu Kaskinen
This also fixes an issue in pa_format_info_to_sample_spec(): it did no validation for the rate value. Now the validation is taken care of in pa_format_info_get_rate(). --- src/pulse/format.c | 5 ++--- src/pulsecore/core-format.c | 21 + src/pulsecore/core-format.h |

[pulseaudio-discuss] [PATCH v3 09/17] sink-input, source-output: Do routing related validity checks immediately after routing

2014-01-08 Thread Tanu Kaskinen
It's more logical that way. --- src/pulsecore/sink-input.c| 11 +++ src/pulsecore/source-output.c | 9 - 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/src/pulsecore/sink-input.c b/src/pulsecore/sink-input.c index e45ecf1..c396770 100644 ---

[pulseaudio-discuss] [PATCH v3 08/17] core-format: Add pa_format_info_from_sample_spec2()

2014-01-08 Thread Tanu Kaskinen
The function will be used in pa_sink_input_new() and pa_source_output_new() to convert the sample spec given by the client to a format info object. The set_format, set_rate and set_channels will be set according to the stream flags (PA_SINK_INPUT_FIX_FORMAT etc.). --- src/pulsecore/core-format.c

[pulseaudio-discuss] [PATCH v3 14/17] def, format: Document how to leave PCM parameters to be decided by the server

2014-01-08 Thread Tanu Kaskinen
--- src/pulse/def.h| 38 src/pulse/format.h | 56 +- 2 files changed, 85 insertions(+), 9 deletions(-) diff --git a/src/pulse/def.h b/src/pulse/def.h index 58190cb..a01c902 100644 --- a/src/pulse/def.h

[pulseaudio-discuss] [PATCH v3 15/17] stream: Improve pa_stream_connect_playback() documentation

2014-01-08 Thread Tanu Kaskinen
--- src/pulse/stream.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/pulse/stream.h b/src/pulse/stream.h index 40cbe64..bec668f 100644 --- a/src/pulse/stream.h +++ b/src/pulse/stream.h @@ -447,7 +447,11 @@ int pa_stream_is_corked(pa_stream *s); * making sure the

[pulseaudio-discuss] [PATCH v3 01/17] Move pa_format_info_to_sample_spec_fake() to core-format

2014-01-08 Thread Tanu Kaskinen
I will need to use the function from outside libpulse. I added the channel map argument, because the function will be called from another function that is expected to initialize the channel map. I don't know if it's in practice necessary, but it shouldn't do any harm either. --- src/Makefile.am

[pulseaudio-discuss] [PATCH v3 00/17] Format negotiation fixing

2014-01-08 Thread Tanu Kaskinen
in the beginning of pa_format_info_from_sample_spec2(). Tanu Kaskinen (17): Move pa_format_info_to_sample_spec_fake() to core-format core-format: Add pa_format_info_get_sample_format() core-format: Add pa_format_info_get_rate() core-format: Add pa_format_info_get_channels() core

Re: [pulseaudio-discuss] About PulseAudio DBUS service

2011-06-07 Thread Tanu Kaskinen
On Tue, 2011-06-07 at 07:03 +0800, Zheng, Huan wrote: If you reached here, thanks a lot for your patience, please give me some hints. All I can think of is that the session bus that Pulseaudio connects to at startup is not the same bus that is used for the actual user session. I don't know any

Re: [pulseaudio-discuss] sink-input's membockq's read-index rewound to a huge negative causing silence delay, almost 2~3 seconds

2011-06-09 Thread Tanu Kaskinen
. And then the index types could be changed from signed to unsigned... I wonder if Lennart made them signed for a purpose? -- Tanu From 5be14975db4f39fbb540714d9c1118d9e47c29b9 Mon Sep 17 00:00:00 2001 From: Tanu Kaskinen ta...@iki.fi Date: Thu, 9 Jun 2011 15:38:08 +0300 Subject: [PATCH 1/2] sink-input: (DEBUG

Re: [pulseaudio-discuss] [PATCH] protocol-native: set a minimum audio latency for a phone input stream

2011-06-13 Thread Tanu Kaskinen
On Mon, 2011-06-13 at 11:08 +0800, Lin, Mengdong wrote: I got buffer underruns when moving sinks for a live stream. Flag adjust_latency will decrease the latency each time when I move the sink and can cause buffer underrun. That sounds like a bug. It doesn't make any sense that the latency

Re: [pulseaudio-discuss] Problems starting without X11 (git master)

2011-06-13 Thread Tanu Kaskinen
On Mon, 2011-06-13 at 20:00 +0100, Colin Guthrie wrote: I: module.c: Loaded module-position-event-sounds (index: #17; argument: ). I: module.c: Loaded module-cork-music-on-phone (index: #18; argument: ). E: server-lookup.c: Unable to contact D-Bus: org.freedesktop.DBus.Error.Spawn.ExecFailed:

Re: [pulseaudio-discuss] Problems starting without X11 (git master)

2011-06-13 Thread Tanu Kaskinen
On Tue, 2011-06-14 at 07:55 +0300, Tanu Kaskinen wrote: It would be nice if also the non-X11 sessions would set up the session bus already at login time, but I guess we can't rely on that. I'd expect the user bus work to solve this problem eventually, but until that becomes ubiquitous, I think

Re: [pulseaudio-discuss] Why audio latency in loopback is divided by 3?

2011-06-29 Thread Tanu Kaskinen
On Mon, 2011-06-20 at 18:14 +0200, mar...@saepia.net wrote: Hi, I found interesting piece of code in module-loopback: int pa__init(pa_module *m) { (...) pa_sink_input_set_requested_latency(u-sink_input, u-latency/3); (...) } I understand it sets the desired latency, but what is

Re: [pulseaudio-discuss] PA re-sampling and mute/unmute query

2011-06-29 Thread Tanu Kaskinen
These questions seem to have gone unanswered... On Wed, 2011-06-22 at 17:47 +0530, Himanshu Chug wrote: Hi 1. I am trying to understand the how PA mixes two different freq streams, say I am playing 2 playback streams one is 8000hz wav and other of 44100 hz wav at the same time ? how is

Re: [pulseaudio-discuss] Remove obsolete description property from modules

2011-06-29 Thread Tanu Kaskinen
On Wed, 2011-06-22 at 16:09 +0100, Colin Guthrie wrote: 'Twas brillig, and Maarten Bosmans at 22/06/11 15:52 did gyre and gimble: Is this OK to do on the road to 1.0, or do we want to keep the description argument indefinitely? What are people's opinions? I'm happy for this to happen now.

Re: [pulseaudio-discuss] [PATCH 2/4] alsa: Reinitialise the mixer on port change.

2011-07-05 Thread Tanu Kaskinen
On Sat, 2011-07-02 at 18:27 +0100, Colin Guthrie wrote: This allows us to flip from software to hardware volume control as the port's mixer path dictates. Looks good to me. -- Tanu ___ pulseaudio-discuss mailing list

Re: [pulseaudio-discuss] [PATCH 1/8] devices: Set certain sink/source flags automatically.

2011-07-07 Thread Tanu Kaskinen
On Thu, 2011-07-07 at 10:55 +0100, Colin Guthrie wrote: Some sink flags are really just a product of what callbacks set on the sink. Rather than assert when the flags don't match the callbacks registered, just set them automatically. For the hw volume/mute flags the automation is a bit broken:

Re: [pulseaudio-discuss] [PATCH 1/8] devices: Set certain sink/source flags automatically.

2011-07-13 Thread Tanu Kaskinen
On Sat, 2011-07-09 at 11:36 +0100, Colin Guthrie wrote: 'Twas brillig, and Tanu Kaskinen at 07/07/11 20:42 did gyre and gimble: For the hw volume/mute flags the automation is a bit broken: the hw flags are enabled also for virtual devices that use the volume/mute callbacks for something

<    7   8   9   10   11   12   13   14   15   16   >