On Sun, 2017-01-29 at 23:23 +0530, Arun Raghavan wrote:
>
> On Sun, 29 Jan 2017, at 02:29 PM, Tanu Kaskinen wrote:
> > On Sun, 2017-01-29 at 10:29 +0530, Arun Raghavan wrote:
> > > This adds an "avoid-resampling" option to daemon.conf that makes the
> > >
On Mon, 2017-01-30 at 17:28 +0100, Georg Chini wrote:
> On 27.01.2017 21:40, Georg Chini wrote:
> > On 03.01.2017 18:17, Tanu Kaskinen wrote:
> > > On Thu, 2016-12-15 at 12:34 +0530, Renjith Thomas wrote:
> > > > Issue: When HFP/HSP profile is used with certain
On Mon, 2017-01-30 at 10:17 -0300, Felipe Sateler wrote:
> On 28 January 2017 at 11:24, Ahmed S. Darwish wrote:
> > On Sat, Jan 28, 2017 at 04:00:31PM +0200, Ahmed S. Darwish wrote:
> > > Unless we want a restricting directive directly inside systemd,
> > > below trick seems to work here:
> > >
>
On Mon, 2017-01-30 at 17:35 +0100, Georg Chini wrote:
> Hello,
>
> in module-bluez5-device.c and module-bluez4-device.c, latencies for
> bluetooth are defined as follows:
>
> #define FIXED_LATENCY_PLAYBACK_A2DP (25 * PA_USEC_PER_MSEC)
> #define FIXED_LATENCY_PLAYBACK_SCO (125 * PA_USEC_PER_MSEC)
On Sat, 2017-01-28 at 17:30 -0800, Klaus Badelt wrote:
> Great workaround for now.
>
> Do you see a chance of using up to 32 channels of any capture/playback are
> used, instead of ignoring it?
Yes, if you write a patch for that :)
--
Tanu
https://www.patreon.com/tanuk
On Sun, 2017-01-29 at 10:36 +0900, Takashi Sakamoto wrote:
> On Jan 29 2017 01:08, Tanu Kaskinen wrote:
> > The pa_channel_map_init_extend() call later in the function crashes if
> > if ss->channels is greater than PA_CHANNELS_MAX.
> >
> > Reported here:
> > ht
On Mon, 2017-01-30 at 14:37 +0530, Arun Raghavan wrote:
>
> On Thu, 8 Sep 2016, at 04:36 PM, Tanu Kaskinen wrote:
> > +void pa_core_update_default_sink(pa_core *core) {
> > +pa_sink *best = NULL;
> > +pa_sink *sink;
> > +uint32_t idx;
>
On Mon, 2017-01-30 at 14:54 +0530, Arun Raghavan wrote:
> On Thu, 8 Sep 2016, at 04:36 PM, Tanu Kaskinen wrote:
> > It was reported in bug 93006 that on hardware that has HDMI and analog
> > outputs on different cards, the HDMI sink is chosen by default even when
> > headphone
On Tue, 2017-01-31 at 11:18 -0300, Felipe Sateler wrote:
> On 31 January 2017 at 10:45, Tanu Kaskinen wrote:
> > On Mon, 2017-01-30 at 10:17 -0300, Felipe Sateler wrote:
> > > On 28 January 2017 at 11:24, Ahmed S. Darwish
> > > wrote:
> > > > On Sat, Ja
We disallow autospawning for root, but when using systemd socket
activation to start pulseaudio, that replaces the autospawning
mechanism, and there was no similar "root protection" in socket
activation. This patch disables the socket activation for root.
Thanks to Felipe Sateler for coming up wit
Clang didn't like the variable length array:
pulsecore/iochannel.c:358:17: error: fields must have a constant size:
'variable length array in structure' extension will never be supported
uint8_t data[CMSG_SPACE(sizeof(int) * nfd)];
^
Commit 451d1d6762 introduced the variab
On Tue, 2017-01-31 at 17:29 +0530, kranthi kumar wrote:
> Hi All,
>
> I am very new to pulseaudio environment. I have working ucm scripts for
> playback and capture in HiFi profile. The requirement is that I need to
> split the scripts into codec specific and machine specific. Codec and
> machine
On Wed, 2017-02-01 at 09:44 +0100, Ivan Kanis wrote:
> Hello,
>
> I am trying to get sound output from the speaker plugged on my computer
> and the Chromecast audio in the living room.
>
> I have launched the program pulseaudio-dlna and I can hear audio on the
> Chromecast when I select it as pla
On Wed, 2017-02-01 at 16:39 -0500, sean darcy wrote:
> On 01/28/2017 07:22 AM, Tanu Kaskinen wrote:
> > I suspect
> > {fd19a5b3f9ab48aeae18d687a1e5c0cc}unix:/run/user/1001/pulse/native
> > comes from the X server. On your Fedora laptop, module-x11-publish puts
> >
ing about what to do
about that, so I'll submit that patch separately later, or a
different patch that achieves the same goal.
Tanu Kaskinen (2):
refactor default sink/source handling
core, device-port: check availability when choosing the default device
src/modules/dbus/iface-core.c
Currently the default sink policy is simple: either the user has
configured it explicitly, in which case we always use that as the
default, or we pick the sink with the highest priority. The sink
priorities are currently static, so there's no need to worry about
updating the default sink when sink
It doesn't make sense to use a sink or source whose active port is
unavailable, so let's take this into account when choosing the default
sink and source.
---
src/pulsecore/core.c| 16
src/pulsecore/device-port.c | 8
2 files changed, 24 insertions(+)
diff --git
On Thu, 2017-02-02 at 13:02 +0530, Arun Raghavan wrote:
> On Tue, 31 Jan 2017, at 08:01 PM, Tanu Kaskinen wrote:
> > On Mon, 2017-01-30 at 14:54 +0530, Arun Raghavan wrote:
> > > I don't agree with this approach -- it conflates the priority values of
> > > two diffe
On Thu, 2017-02-02 at 11:29 +0100, Georg Chini wrote:
> On 31.01.2017 14:51, Tanu Kaskinen wrote:
> > On Mon, 2017-01-30 at 17:35 +0100, Georg Chini wrote:
> > > Hello,
> > >
> > > in module-bluez5-device.c and module-bluez4-device.c, latencies for
&g
On Tue, 2017-02-07 at 15:51 +0100, Georg Chini wrote:
> On 07.02.2017 15:28, Tanu Kaskinen wrote:
> > On Thu, 2017-02-02 at 11:29 +0100, Georg Chini wrote:
> > > On 31.01.2017 14:51, Tanu Kaskinen wrote:
> > > > On Mon, 2017-01-30 at 17:35 +0100, Geor
On Thu, 2017-02-02 at 17:29 +0530, Rinaldo Rex wrote:
> Hi,
>
> I'm working on an embedded platform which runs automotive grade Linux. I'm
> trying to use pulseaudio for a while now and it keeps failing. I've tried
> modifying the configuration files and also by removing them to regenerate
> the d
On Fri, 2017-02-03 at 10:17 -0300, Felipe Sateler wrote:
> On 3 February 2017 at 05:51, Tanu Kaskinen wrote:
> > We disallow autospawning for root, but when using systemd socket
> > activation to start pulseaudio, that replaces the autospawning
> > mechanism, and there
On Wed, 2017-02-08 at 12:41 -0500, Joe wrote:
> I'm completely out of my depth here - I program mostly in bash, but ...
>
> If you want to know if you can do something, one way is to try to do it
> and see if it fails.
>
> What would happen if you just issued something harmless like a touch
> c
On Wed, 2017-02-08 at 10:06 -0300, Felipe Sateler wrote:
> On 8 February 2017 at 09:36, Tanu Kaskinen wrote:
> > On Fri, 2017-02-03 at 10:17 -0300, Felipe Sateler wrote:
> > > On 3 February 2017 at 05:51, Tanu Kaskinen wrote:
> > > > We disallow autospawning fo
On Thu, 2017-02-09 at 20:52 +0200, Tanu Kaskinen wrote:
> On Wed, 2017-02-08 at 10:06 -0300, Felipe Sateler wrote:
> > On 8 February 2017 at 09:36, Tanu Kaskinen wrote:
> > > On Fri, 2017-02-03 at 10:17 -0300, Felipe Sateler wrote:
> > > > On 3 February 2017
We disallow autospawning for root, but when using systemd socket
activation to start pulseaudio, that replaces the autospawning
mechanism, and there was no similar "root protection" in socket
activation. This patch disables the socket activation for root.
---
src/daemon/systemd/user/pulseaudio.soc
On Thu, 2017-02-09 at 22:35 +0200, Tanu Kaskinen wrote:
> We disallow autospawning for root, but when using systemd socket
> activation to start pulseaudio, that replaces the autospawning
> mechanism, and there was no similar "root protection" in socket
> activation. This pat
On Fri, 2017-01-27 at 17:15 +0100, Wim Taymans wrote:
> Hi All,
>
> I took another look at the access control patches.
>
> There was a desire from Arun and Tanu to have the access control
> checks more integrated
> into the core objects instead of just some checks in the native protocol.
I don't
We disallow autospawning for root, but when using systemd socket
activation to start pulseaudio, that replaces the autospawning
mechanism, and there was no similar "root protection" in socket
activation. This patch disables the socket activation for root.
---
src/daemon/systemd/user/pulseaudio.soc
On Sat, 2017-02-04 at 19:34 +0100, Georg Chini wrote:
> The fixed latency for the HSP sink was set to 125 ms plus one write block
> size.
> pa_sink_get_latency() however returns 28 ms like it does for A2DP and also for
> the HSP source.
> Therefore this patch corrects the fixed latency of the HSP
On Sat, 2017-02-04 at 20:32 +0100, Georg Chini wrote:
> A recent patch changed the MTU size from the default value of 48 to the value
> returned by getsockopt(). This breaks HSP for some setups. To circumvent the
> problem, this patch introduces a boolean parameter "autodetect_mtu" for
> module-blu
On Tue, 2017-02-14 at 10:51 +0100, Georg Chini wrote:
> On 14.02.2017 10:25, Tanu Kaskinen wrote:
> > On Sat, 2017-02-04 at 19:34 +0100, Georg Chini wrote:
> > > The fixed latency for the HSP sink was set to 125 ms plus one write block
> > > size.
> > > pa_sink
On Sat, 2017-02-04 at 20:47 +0100, Georg Chini wrote:
> Subject: [PATCH] backend-native: rebase of patch to support HSP HeadeSet
> profile
Usually it's not interesting that a patch was rebased. In this case
it's good to mention it in the commit message, since the one who did
the rebasing is diffe
On Mon, 2017-02-13 at 13:50 -0300, Fatima Castiglione Maldonado 发
wrote:
> Hi,
>
> am new to this list, my name is Fatima.
Welcome to the list!
> We are using a webapp called BigBlueButton.org for conferencing.
> It work OK while using it under Firefox on Ubuntu 14.04.
> When we use it under Chr
On Tue, 2017-02-14 at 12:24 +0100, Georg Chini wrote:
> On 14.02.2017 12:08, Tanu Kaskinen wrote:
> > On Sat, 2017-02-04 at 20:47 +0100, Georg Chini wrote:
> > > Subject: [PATCH] backend-native: rebase of patch to support HSP HeadeSet
> > > profile
> >
> &
On Tue, 2017-02-14 at 13:28 +0100, Wim Taymans wrote:
> On 13 February 2017 at 13:58, Tanu Kaskinen wrote:
> > On Fri, 2017-01-27 at 17:15 +0100, Wim Taymans wrote:
> > > Hi All,
> > >
> > > I think (1) is quite ugly and requires you to modify many funct
On Tue, 2017-02-14 at 11:21 -0300, Fatima Castiglione Maldonado 发
wrote:
> > So Chrome 56 on Ubuntu 14.04 works on other machines except that one
> > notebook model?
>
> That is exactly our situation.
>
> > Does the volume meter for the microphone in pavucontrol show any activity?
>
> Yes.
>
>
On Tue, 2017-02-14 at 14:33 +0100, Georg Chini wrote:
> The PA_SINK_GET_LATENCY message handler falsely always added the A2DP latency
> as fixed
> latency instead of the profile specific constant.
>
> ---
> src/modules/bluetooth/module-bluez5-device.c | 2 +-
> 1 file changed, 1 insertion(+), 1
On Tue, 2017-02-14 at 14:33 +0100, Georg Chini wrote:
> From: Wim Taymans
>
> This is a rebase of Wim Taymans patch to support the HSP headset role that has
> somehow been forgotten. Original patch can be found at
> https://lists.freedesktop.org/archives/pulseaudio-discuss/2015-February/023242.ht
pa_core.default_sink/source a bit more verbose.
- Dropped the patch that uses the active port's priority as the
sink/source priority. The discussion is ongoing about what to do
about that, so I'll submit that patch separately later, or a
different patch that achieves the same goal.
It doesn't make sense to use a sink or source whose active port is
unavailable, so let's take this into account when choosing the default
sink and source.
---
No changes in v2 or v3.
src/pulsecore/core.c| 16
src/pulsecore/device-port.c | 8
2 files changed, 24
Currently the default sink policy is simple: either the user has
configured it explicitly, in which case we always use that as the
default, or we pick the sink with the highest priority. The sink
priorities are currently static, so there's no need to worry about
updating the default sink when sink
On Wed, 2017-02-15 at 16:44 -0300, Fatima Castiglione Maldonado 发
wrote:
> > The strange thing is that earlier you got some sound from chrome, andes
> > if I understood correctly, you had pavucontrol open. If you have
> > pavucontrol open, and you can see activity in the mic volume meter, it
> > me
On Wed, 2017-02-15 at 17:25 +0100, Ivan Kanis wrote:
> The author of the dlna plugin has told me that the combined sink feature
> is not implemented in his module. He has given me an alternative with
> the loopback module:
>
> load-module module-loopback sink=alsa_output.pci-_00_1b.0.analog-st
On Wed, 2017-02-15 at 11:34 +0100, Timothy Hobbs wrote:
> Obviously, this question reveals my total ignorance of pulseaudio
> architecture, but why are you implementing access control in pulseaudio
> itself, rather than using a firewall wrapper that parses the info being
> sent down the pulse au
On Wed, 2017-02-15 at 11:32 +0100, Georg Chini wrote:
> The PA_{SINK,SOURCE}_GET_LATENCY message handlers falsely always added the
> A2DP latency as fixed
> latency instead of the profile specific constant.
>
> ---
> src/modules/bluetooth/module-bluez5-device.c | 4 ++--
> 1 file changed, 2 inse
On Fri, 2017-02-10 at 19:08 +0100, Timothy Hobbs wrote:
> Hello,
>
> I'm trying to discover the best way to share pulse audio between linux
> containers. I have found a great deal of answers to this problem online.
> Some of them involve sharing UNIX sockets, while others suggest
> connecting v
On Fri, 2017-02-10 at 14:38 +0100, Georg Chini wrote:
> Hi,
>
> during my work on module-loopback I came upon an issue regarding the
> handling
> of the port latency offsets.
> The functions pa_{source,sink}_get_latency_within_thread() return the
> latencies
> including the offset. Those functio
On Thu, 2017-02-16 at 13:10 +0100, Georg Chini wrote:
> On 16.02.2017 12:59, Tanu Kaskinen wrote:
> > On Fri, 2017-02-10 at 14:38 +0100, Georg Chini wrote:
> > > Hi,
> > >
> > > during my work on module-loopback I came upon an issue regarding the
> > &g
On Mon, 2017-02-13 at 13:01 +0100, Georg Chini wrote:
> The variable does no longer represent the length of the whole sink input
> buffer,
> therefore it has been renamed.
>
> ---
> src/modules/module-loopback.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Looks good, applied.
On Fri, 2017-02-17 at 03:07 -0500, Paul Stone wrote:
> Hoping someone with more familiarity can shed some light or point me in the
> direction of the information I'm looking for. The basic problem is I'm
> having problems capturing a profile change signal from PA via dbus using
> Gio with CJS/GJS.
The "profile->card != c->card" check always evaluated to false, so the
CardProfileUpdated signal was never sent. The reason: call_data was
assigned to a pa_card_profile pointer, but the correct type is a pa_card
pointer.
---
src/modules/dbus/iface-card.c | 16
1 file changed, 8 in
On Sat, 2017-02-18 at 18:17 +0200, Tanu Kaskinen wrote:
> On Fri, 2017-02-17 at 03:07 -0500, Paul Stone wrote:
> > Hoping someone with more familiarity can shed some light or point me in the
> > direction of the information I'm looking for. The basic problem is I'm
> &
On Thu, 2017-02-16 at 21:26 -0300, Fatima Castiglione Maldonado 发
wrote:
> > To narrow down the problem further, you could try recording from the
> > microphone at the same time when chrome is supposed to be recording
> > from it. You can use this command:
> > parecord --device=alsa_input.pci-_
On Sun, 2017-02-12 at 05:39 +0100, Mihai Moldovan wrote:
> Make sure that we NULL pointers after freeing them. Otherwise bad things
> happen.
>
> Signed-off-by: Mihai Moldovan
> ---
> src/modules/macosx/module-coreaudio-device.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
Ca
lynx is required for generating README, so building failed when lynx was
disabled.
---
Makefile.am | 11 ---
doc/Makefile.am | 9 ++---
2 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 30b014c..6f14ab6 100644
--- a/Makefile.am
+++ b/M
On Sat, 2017-02-11 at 11:55 +0100, archli...@nicohood.de wrote:
> From: NicoHood
>
> ---
> src/paprefs.cc| 23 ---
> src/paprefs.glade | 56
> ++-
> 2 files changed, 67 insertions(+), 12 deletions(-)
Thanks! Applied.
On Sun, 2017-02-19 at 17:15 +0100, Georg Chini wrote:
> This is version 2 of the new loopback patch series.
This is actually v8 of the series, isn't it? I'd prefer you to not
reset the version numbering (I use it in local branch names, for
example). No need to resend the patches because of this, i
On Sun, 2017-02-19 at 17:15 +0100, Georg Chini wrote:
> The comments were wrong and confusing.
>
> ---
> src/modules/module-loopback.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
Thanks, applied.
--
Tanu
https://www.patreon.com/tanuk
On Sun, 2017-02-19 at 14:02 -0300, Fatima Castiglione Maldonado 发
wrote:
> > Ok, that suggests that the problem is not with chrome specifically. But
> > in your first mail you said that firefox works fine...
>
> Firefox works ok, have just tested it again to be sure.
>
> > If you record with pare
On Tue, 2017-02-21 at 09:53 +, Emil Borconi-Szedressy wrote:
> Hi.
>
> I'm trying to set up a small (and cheap) ARM SBC to operate as a HFP+A2DP
> receiver. I have read loads of documentation on how to get this done and I
> had some success on a Raspberry Pi 2 using pre-build packages from
> J
On Sun, 2017-02-19 at 17:15 +0100, Georg Chini wrote:
> The current code does not make any attempt to initialize the end-to-end
> latency
> to a value near the desired latency. This leads to underruns at startup
> because
> the memblockq is initially empty and to very long adjustment times for lo
On Tue, 2017-02-21 at 19:39 -0300, Fatima Castiglione Maldonado 发
wrote:
> Done.
> I have run both browsers and, while doing each audio test, executed pactl
> list. Output is attached for both test instances.
Chrome and firefox use the same latency configuration and the same
sample rate, so neithe
On Thu, 2017-02-23 at 17:55 +0100, Georg Chini wrote:
> On 23.02.2017 12:17, Tanu Kaskinen wrote:
> > On Sun, 2017-02-19 at 17:15 +0100, Georg Chini wrote:
> > > The current code does not make any attempt to initialize the end-to-end
> > > latency
> > > to a
On Thu, 2017-02-23 at 18:05 +0100, Georg Chini wrote:
> On 23.02.2017 12:17, Tanu Kaskinen wrote:
> > On Sun, 2017-02-19 at 17:15 +0100, Georg Chini wrote:
> > > The current code does not make any attempt to initialize the end-to-end
> > > latency
> > > to a
On Sat, 2017-02-25 at 12:13 +0100, Georg Chini wrote:
> On 24.02.2017 19:19, Tanu Kaskinen wrote:
> > On Thu, 2017-02-23 at 17:55 +0100, Georg Chini wrote:
> > > On 23.02.2017 12:17, Tanu Kaskinen wrote:
> > > > On Sun, 2017-02-19 at 17:15 +0100, Georg Chini
On Sat, 2017-02-25 at 14:01 +0100, Georg Chini wrote:
> On 25.02.2017 13:51, Tanu Kaskinen wrote:
> > On Sat, 2017-02-25 at 12:13 +0100, Georg Chini wrote:
> > > On 24.02.2017 19:19, Tanu Kaskinen wrote:
> > > > On Thu, 2017-02-23 at 17:55 +0100, Georg Chini wrote:
On Sat, 2017-02-25 at 19:21 +0200, Tanu Kaskinen wrote:
> On Sat, 2017-02-25 at 14:01 +0100, Georg Chini wrote:
> > On 25.02.2017 13:51, Tanu Kaskinen wrote:
> > > The second adjustment does the right thing regardless of whether the
> > > first adjustment was done or not
On Sat, 2017-02-25 at 22:09 +0100, Georg Chini wrote:
> On 25.02.2017 20:29, Tanu Kaskinen wrote:
> > On Sat, 2017-02-25 at 19:21 +0200, Tanu Kaskinen wrote:
> > > On Sat, 2017-02-25 at 14:01 +0100, Georg Chini wrote:
> > > > On 25.02.2017 13:51, Tanu Kaskin
On Sat, 2017-02-25 at 22:23 +0100, Georg Chini wrote:
> > > Sorry, slowly I am thinking that you don't want the patches at all and
> > > are nitpicking to discourage me. If you don't want the patches, just say
> > > so.
> >
> > I assure you, I want these patches, especially this one, because this
On Mon, 2017-02-27 at 08:44 +0100, Georg Chini wrote:
> > > > > > > > > +/* If the source has overrun, assume that
> > > > > > > > > the maximum it should have pushed is
> > > > > > > > > + * one full source latency. It may still be
> > > > > > > > > possible that
On Sat, 2017-02-25 at 10:38 +0100, Mihai Moldovan wrote:
> Make sure that we NULL pointers after freeing them. Otherwise bad things
> happen.
> ---
> src/modules/macosx/module-coreaudio-device.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
Thanks, I applied both patches.
--
T
On Fri, 2017-02-24 at 23:52 -0300, Fatima Castiglione Maldonado 发
wrote:
> > At this point I don't expect this problem to get solved, but if you want
> > to still continue debugging, you could try one more time to get a
> > PulseAudio log. Based on the earlier experiments it looks like chrome
> > d
On Thu, 2017-02-23 at 17:38 +0100, Moritz Bruder wrote:
> Both input and output device were chosen with the same device number.
> This is problematic as those numbers don't have to correspond.
> Additionally the input device was named after the output device. This
> commit adresses both issues by p
On Mon, 2017-02-27 at 13:54 +0100, Georg Chini wrote:
> case SINK_INPUT_MESSAGE_POST:
>
> -pa_sink_input_assert_io_context(u->sink_input);
> +pa_memblockq_push_align(u->memblockq, chunk);
> +
> +/* If push has not been called yet, latency adjustments i
On Tue, 2017-02-28 at 16:30 +0100, Georg Chini wrote:
> On 28.02.2017 16:11, Tanu Kaskinen wrote:
> > On Mon, 2017-02-27 at 13:54 +0100, Georg Chini wrote:
> > > case SINK_INPUT_MESSAGE_POST:
> > >
> > > -pa_sink_i
On Wed, 2017-03-01 at 15:54 +0100, Moritz Bruder wrote:
> Am 28.02.2017 um 14:40 schrieb Tanu Kaskinen:
> > On Thu, 2017-02-23 at 17:38 +0100, Moritz Bruder wrote:
> > > Both input and output device were chosen with the same device number.
> > > This is problematic as
On Sat, 2017-03-04 at 23:46 -0300, wellington wallace wrote:
> Hello,
>
> I am able to dynamically change ladspa plugin controls using pulseaudio's
> dbus interface. But as this api is not recommended I would like to do
> the same using libpulse. I have read the documentation but I could not find
On Thu, 2017-03-02 at 17:04 +0100, Georg Chini wrote:
> #define HSP_AG_PROFILE "/Profile/HSPAGProfile"
> +#define HSP_HS_PROFILE "/Profile/HSPHSProfile"
> +
> +/* RFCOMM channel for HSP headset role */
> +#define HSP_HS_DEFAULT_CHANNEL 3
The comment still doesn't explain why 3 is a good default.
On Tue, 2017-03-07 at 10:02 +0100, Peter Meerwald-Stadler wrote:
> > Ack, go ahead and push this. Do we need to modify our Coverity project
> > settings?
>
> pushed, no need to modify server side Coverity settings
You seemed to push the whole patch set without responding to the issues
that Hajime
Hi all,
A small (or maybe big? or mid-sized?) announcement:
Georg Chini kindly offered to help with reviewing patches, and we
granted him commit rights too. This should reduce our problems with
keeping up with the incoming patches.
--
Tanu
https://www.patreon.com/tanuk
On Tue, 2017-03-07 at 13:44 +0100, Georg Chini wrote:
> From: Wim Taymans
>
>
> This is a rebase of Wim Taymans patch to support the HSP headset role that has
> somehow been forgotten. Original patch can be found at
> https://lists.freedesktop.org/archives/pulseaudio-discuss/2015-February/023242
On Tue, 2017-03-07 at 13:42 +0100, Georg Chini wrote:
> On 04.02.2017 13:19, Tanu Kaskinen wrote:
> > Clang didn't like the variable length array:
> >
> > pulsecore/iochannel.c:358:17: error: fields must have a constant size:
> > 'variable length array
On Wed, 2017-03-01 at 19:29 +0100, Moritz Bruder wrote:
> Both input and output device were chosen with the same device number.
> This is problematic as those numbers don't have to correspond.
> Additionally the input device was named after the output device. This
> commit adresses both issues by p
On Thu, 2017-03-02 at 17:04 +0100, Georg Chini wrote:
> This patch changes the behavior of the headset=auto switch for
> module-bluez5-discover.
> With headset=auto now both backends will be active at the same time for the
> AG role and
> the switching between the backends is only done for the HS
On Fri, 2017-03-10 at 08:13 +0100, Georg Chini wrote:
> On 10.03.2017 00:33, Tanu Kaskinen wrote:
> > On Thu, 2017-03-02 at 17:04 +0100, Georg Chini wrote:
> > > -pa_bluetooth_backend *pa_bluetooth_native_backend_new(pa_core *c,
> > > pa_bluetooth_discovery *y) {
On Fri, 2017-03-10 at 10:19 +0100, Georg Chini wrote:
> On 10.03.2017 08:13, Georg Chini wrote:
> > On 10.03.2017 00:33, Tanu Kaskinen wrote:
> > > On Thu, 2017-03-02 at 17:04 +0100, Georg Chini wrote:
> > > > This patch changes the behavior of the headset=auto swi
On Fri, 2017-03-10 at 21:24 +0100, Georg Chini wrote:
> On 10.03.2017 19:21, Tanu Kaskinen wrote:
> > On Fri, 2017-03-10 at 08:13 +0100, Georg Chini wrote:
> > > On 10.03.2017 00:33, Tanu Kaskinen wrote:
> > > > On Thu, 2017-03-02 at 17:04 +0100, Georg Chini wrote:
&
On Fri, 2017-03-10 at 21:38 -0300, Alexandre Vicenzi wrote:
> Hi,
>
> I'm calling pa_context_get_source_info_list to get the complete source
> list and I would like to know if pa_source_info is the current default
> source.
>
> I know that I could call pulse_get_server_info to get the default sin
On Sat, 2017-03-11 at 13:30 +0100, Georg Chini wrote:
> This patch changes the behavior of the headset=auto switch for
> module-bluez5-discover.
> With headset=auto now both backends will be active at the same time for the
> AG role and
> the switching between the backends is only done for the HS
On Fri, 2017-03-10 at 21:22 +0100, Georg Chini wrote:
> Currently pressing the headset button is ignored. This patch sends a DBUS
> signal that can be caught by applications to trigger events like picking
> up or ending a phone call.
> ---
>
> No changes in v2
>
> src/modules/bluetooth/backend-n
On Sat, 2017-03-11 at 20:27 +0100, Georg Chini wrote:
> > I tried searching the net, and it looks like ButtonPress is not a
> > documented signal. Did you invent the signal yourself? If it's your
> > invention, I don't think the org.bluez.Headset interface should be
> > used. The org.bluez namespac
On Sun, 2017-03-12 at 16:45 +0100, Georg Chini wrote:
> On 16.02.2017 11:09, Tanu Kaskinen wrote:
>
> "Refactor" is the wrong word, you are changing the logic.
> Maybe redesign is a better verb.
Indeed. I think I'll change it to "improve" ("redesig
On Mon, 2017-03-13 at 16:07 +0530, Arun Raghavan wrote:
> The webrtc canceller requires that the set_stream_drift_samples() method
> be called before every call of ProcessStream(). We do kind of leak this
> into the generic bits of module-echo-cancel, but this should not be
> harmful in the general
On Mon, 2017-03-13 at 09:48 +0100, Georg Chini wrote:
> With headset=auto it is possible that AG devices are connected and handled
> via the native backend when ofono is started. Because the HS role will then
> be disabled in the native backend, AG devices must be disconnected and any
> future conn
On Mon, 2017-03-13 at 09:36 +0100, Georg Chini wrote:
> On 12.03.2017 22:46, Tanu Kaskinen wrote:
> > On Sat, 2017-03-11 at 20:27 +0100, Georg Chini wrote:
> > > The reason for this patch was that I wrote an application to handle
> > > mobile phones and it was a nice fe
On Mon, 2017-03-13 at 07:57 +0100, Georg Chini wrote:
> On 12.03.2017 23:07, Tanu Kaskinen wrote:
> > On Sun, 2017-03-12 at 16:45 +0100, Georg Chini wrote:
> > > On 16.02.2017 11:09, Tanu Kaskinen wrote:
> > >
> > > "Refactor" is the wrong word, you a
On Mon, 2017-03-13 at 18:45 +0100, Georg Chini wrote:
> On 13.03.2017 17:45, Tanu Kaskinen wrote:
> > On Mon, 2017-03-13 at 07:57 +0100, Georg Chini wrote:
> > > Yes, it is no regression. But anyway, while you are improving it, I
> > > would use a string for the user con
On Mon, 2017-03-13 at 20:34 +0100, Georg Chini wrote:
> One more thing before you push your patch: In source_put_cb()
> and sink_put_cb() you do not use the return value of
> create_dbus_object_for_*(). There should be a (void) before the
> calls to avoid warnings about the unused return value.
Di
On Tue, 2017-03-14 at 07:34 +0100, Georg Chini wrote:
> With headset=auto it is possible that AG devices are connected and handled
> via the native backend when ofono is started. Because the HS role will then
> be disabled in the native backend, AG devices must be disconnected and any
> future conn
701 - 800 of 5281 matches
Mail list logo
