On Tue, 2013-08-13 at 01:53 -0300, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
---
configure.ac| 28
src/Makefile.am | 23 ++-
2 files changed, 30 insertions(+), 21 deletions(-)
diff --git a/configure.ac
On Fri, 2013-08-16 at 09:30 -0300, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
module-bluetooth-proximity has not worked for quite a while, since it
uses pre-BlueZ4 APIs. Nobody complained since then, which is a good
indication that it doesn't have much users.
On Tue, 2013-08-13 at 01:53 -0300, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
---
src/Makefile.am| 12 +++
src/modules/bluetooth/module-bluez5-discover.c | 43
++
2 files changed, 55 insertions(+)
On Tue, 2013-08-13 at 01:54 -0300, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
---
src/modules/bluetooth/bluez5-util.c | 94
+
1 file changed, 94 insertions(+)
diff --git a/src/modules/bluetooth/bluez5-util.c
On Tue, 2013-08-13 at 01:54 -0300, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
Create the pa_bluetooth_transport structure to store information about
the bluetooth transport and utility functions to manipulate this
structure. The acquire() and release()
On Fri, 2013-08-16 at 18:32 +0300, Tanu Kaskinen wrote:
On Tue, 2013-08-13 at 01:54 -0300, jprv...@gmail.com wrote:
static void device_free(pa_bluetooth_device *d) {
+unsigned i;
+
pa_assert(d);
+for (i = 0; i PA_BLUETOOTH_PROFILE_COUNT; i
On Tue, 2013-08-13 at 01:54 -0300, jprv...@gmail.com wrote:
+struct pa_bluetooth_device {
+pa_bluetooth_discovery *discovery;
+
+int device_info_valid; /* 0: no results yet; 1: good results; -1:
bad results ... */
+
+/* Device information */
+char *path;
+char
On Tue, 2013-08-13 at 01:54 -0300, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
---
src/Makefile.am | 3 +-
src/modules/bluetooth/bluez5-util.c | 156
+++-
2 files changed, 156 insertions(+), 3
On Tue, 2013-08-13 at 01:54 -0300, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
---
src/modules/bluetooth/bluez5-util.c | 28 ++--
1 file changed, 26 insertions(+), 2 deletions(-)
diff --git a/src/modules/bluetooth/bluez5-util.c
On Tue, 2013-08-13 at 01:54 -0300, jprv...@gmail.com wrote:
+static int parse_adapter_properties(pa_bluetooth_discovery *y, const char
*adapter, DBusMessageIter *i) {
+DBusMessageIter element_i;
+
+pa_assert(y);
+pa_assert(adapter);
+
+dbus_message_iter_recurse(i,
On Tue, 2013-08-13 at 01:54 -0300, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
This code is based on previous work by Mikel Astiz.
---
src/modules/bluetooth/bluez5-util.c | 150
+++-
src/modules/bluetooth/bluez5-util.h | 1
On Tue, 2013-08-13 at 01:54 -0300, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
Get the remote device information stored in pa_bluetooth_discovery. This
also creates the mandatory parameter 'path' for module-bluez5-device,
which is used to inform the object path
On Mon, 2013-08-19 at 13:44 -0300, João Paulo Rechi Vita wrote:
On Fri, Aug 16, 2013 at 12:32 PM, Tanu Kaskinen
tanu.kaski...@linux.intel.com wrote:
On Tue, 2013-08-13 at 01:54 -0300, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
Create
On Mon, 2013-08-19 at 13:57 -0300, João Paulo Rechi Vita wrote:
On Sun, Aug 18, 2013 at 6:03 AM, Tanu Kaskinen
tanu.kaski...@linux.intel.com wrote:
On Tue, 2013-08-13 at 01:54 -0300, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
---
src/modules/bluetooth
On Mon, 2013-08-19 at 07:41 +0200, Alexander Couzens wrote:
Old module-tunnel shares duplicated functionality with libpulse because
it is implementing pulse protocol again.
module-tunnel-sink-new uses libpulse to connect to the remote server
Signed-off-by: Alexander Couzens lyn...@fe80.eu
On Mon, 2013-08-19 at 07:30 +0200, Alexander Couzens wrote:
I hope i did'nt forget too much.
Not much, but something. I recommend copying my review to a text file,
and removing those pieces of feedback that you have addressed. When the
file is empty, you know you have addressed everything.
--
client-conf is sufficient for the commit prefix, instead of
client-conf-x11|client-conf. (Sorry, I know there's no way for you to
know what the prefix should be, other than trial and error...)
On Tue, 2013-08-13 at 11:36 +0200, Alexander Couzens wrote:
Signed-off-by: Alexander Couzens
On Tue, 2013-08-13 at 11:41 +0200, Alexander Couzens wrote:
I'm not sure if these 3 seperate calls for cookie loading are better than
creating a pa_context_get_conf() call and
operating on it.
I think it's better to keep pa_client_conf as a private interface.
Signed-off-by: Alexander
On Wed, 2013-08-21 at 13:58 +0200, Alexander Couzens wrote:
Old module-tunnel shares duplicated functionality with libpulse because
it is implementing pulse protocol again. It is also not
as much tested as libpulse it.
Signed-off-by: Alexander Couzens lyn...@fe80.eu
---
src/Makefile.am
On Wed, 2013-08-14 at 16:58 +0300, Tanu Kaskinen wrote:
If a capture stream captures from a single sink input (so the capture
stream is a so called direct on input stream), then it needs to
connect to the monitor source of the sink to which the sink input is
connected. Previously the correct
On Mon, 2013-08-19 at 12:54 +0300, Tanu Kaskinen wrote:
On Tue, 2013-08-13 at 01:54 -0300, jprv...@gmail.com wrote:
+static bool exists(const char *filename) {
+const char *paths, *state = NULL;
+char *p, *pathname;
+bool result;
+
+if (!(paths = lt_dlgetsearchpath
On Mon, 2013-08-26 at 13:31 +0200, Svein Seldal wrote:
Hi
I'm working on using a [dedicated] linux box for an audio filtering use.
My intentions is to take stereo audio in, process it, and play the
result on audio out (all on the same sound device). The catch is that
this app requires as
On Mon, 2013-08-26 at 15:04 +0200, Svein Seldal wrote:
On 08/26/2013 02:36 PM, Tanu Kaskinen wrote:
No, PA doesn't offer that. Reading and writing to the sound card is
handled completely separately, from different threads, so there's no
read/write synchronization in the server either
When a sink changes its sample rate, also the monitor source rate
needs to be changed. In order to determine whether a source supports
rate changing, the code checks if the update_rate() callback is set,
but monitor sources don't have that callback set, so the old code
always failed to change the
---
src/modules/alsa/alsa-sink.c | 8
src/modules/alsa/alsa-source.c | 8
src/pulsecore/sink-input.c | 4 ++--
src/pulsecore/sink.c | 24
src/pulsecore/sink.h | 4 ++--
src/pulsecore/source-output.c | 4 ++--
If the sink rate is not updated, then the monitor source will appear
to have a different rate than the sink, but in reality there's never
any resampling done when moving data from the sink to the monitor
source, so it's a lie that the monitor source has a different rate.
The result of lying is
With very low input sample rates the memory pool max block size may
not be big enough, in which case we should return the size of one
frame. Returning zero caused crashing.
BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=68616
---
src/pulsecore/resampler.c | 18 +-
1 file
On Fri, 2013-08-30 at 08:16 +0200, David Henningsson wrote:
On 08/29/2013 04:36 PM, Tanu Kaskinen wrote:
Sometimes it would be nice to disable module-suspend-on-idle for
specific devices. For me the use case is to keep a HDMI sink running
all the time to avoid loss of audio when starting
On Tue, 2013-09-03 at 21:18 -0300, João Paulo Rechi Vita wrote:
On Sun, Aug 18, 2013 at 6:37 AM, Tanu Kaskinen
tanu.kaski...@linux.intel.com wrote:
On Tue, 2013-08-13 at 01:54 -0300, jprv...@gmail.com wrote:
static DBusMessage *endpoint_select_configuration(DBusConnection *conn
On Wed, 2013-09-04 at 15:17 -0300, João Paulo Rechi Vita wrote:
On Sun, Aug 18, 2013 at 8:15 AM, Tanu Kaskinen
tanu.kaski...@linux.intel.com wrote:
On Tue, 2013-08-13 at 01:54 -0300, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
---
src/modules/bluetooth
On Thu, 2013-07-25 at 16:39 +0200, poljar (Damir Jelić) wrote:
This patch adds the ability to restore profiles if they are added after
card creation.
Adding profiles after card creation mainly happens for bluetooth cards.
Buglink: https://bugs.freedesktop.org/show_bug.cgi?id=65349
---
On Thu, 2013-09-12 at 14:01 +0200, Alexander Couzens wrote:
The old tunnel module duplicates functionality that is in libpulse,
due to implementing the native protocol, and the protocol code in
the old tunnel module tends to get broken every now and then, because
people forget to update the
On Fri, 2013-09-13 at 13:20 +0530, Arun Raghavan wrote:
On Fri, 2013-08-30 at 15:11 +0200, David Henningsson wrote:
On 08/30/2013 09:28 AM, Tanu Kaskinen wrote:
On Fri, 2013-08-30 at 08:16 +0200, David Henningsson wrote:
On 08/29/2013 04:36 PM, Tanu Kaskinen wrote:
Sometimes it would
On Fri, 2013-09-13 at 17:45 -0300, João Paulo Rechi Vita wrote:
On Sun, Aug 18, 2013 at 10:37 AM, Tanu Kaskinen
tanu.kaski...@linux.intel.com wrote:
On Tue, 2013-08-13 at 01:54 -0300, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
Get the remote device
On Wed, 2013-09-18 at 23:09 -0500, Hajime Fujita wrote:
Hi Tanu,
Thank you so much for your advice.
Tanu Kaskinen wrote:
On Sun, 2013-09-15 at 00:24 -0500, Hajime Fujita wrote:
For those who are interested in raop2 experiments,
As Matthias pointed out [1], current volume calculation
On Wed, 2013-09-18 at 04:28 +1000, Patrick Shirkey wrote:
Hi,
Can someone shed some light on the best case and typical latency that
Pulse provides for standard operations?
What do you mean by standard operations? I'd estimate volume changes
etc. normally (on an ALSA sink) have a few
On Thu, 2013-09-19 at 22:47 -0500, Hajime Fujita wrote:
Hi Tanu,
Tanu Kaskinen wrote:
On Wed, 2013-09-18 at 23:09 -0500, Hajime Fujita wrote:
Hi Tanu,
Thank you so much for your advice.
Tanu Kaskinen wrote:
On Sun, 2013-09-15 at 00:24 -0500, Hajime Fujita wrote:
For those who
On Fri, 2013-09-20 at 09:29 +0200, David Henningsson wrote:
On 09/20/2013 05:44 AM, Arun Raghavan wrote:
We're hitting the 32 sink-input limit quite often with increasing use of
PA by web browsers, so let's increase this limit.
Does this increase the risk of us being the target of attacks;
On Fri, 2013-09-20 at 17:27 +0530, Arun Raghavan wrote:
---
src/pulsecore/hashmap.h | 4
1 file changed, 4 insertions(+)
diff --git a/src/pulsecore/hashmap.h b/src/pulsecore/hashmap.h
index ae030ed..e42732a 100644
--- a/src/pulsecore/hashmap.h
+++ b/src/pulsecore/hashmap.h
@@ -85,6
On Fri, 2013-09-20 at 17:55 +0530, Arun Raghavan wrote:
On Fri, 2013-09-20 at 15:13 +0300, Tanu Kaskinen wrote:
On Fri, 2013-09-20 at 17:27 +0530, Arun Raghavan wrote:
---
src/pulsecore/hashmap.h | 4
1 file changed, 4 insertions(+)
diff --git a/src/pulsecore/hashmap.h b
On Fri, 2013-09-20 at 17:56 +0530, Arun Raghavan wrote:
On Fri, 2013-09-20 at 15:21 +0300, Tanu Kaskinen wrote:
On Fri, 2013-09-20 at 17:27 +0530, Arun Raghavan wrote:
This will be needed if the implementation data stores pointers to
additional data that needs to be freed as well
On Wed, 2013-09-18 at 16:17 -0500, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
---
src/modules/bluetooth/bluez5-util.c | 176
+++-
src/modules/bluetooth/bluez5-util.h | 5 +
2 files changed, 179 insertions(+), 2
On Wed, 2013-09-18 at 16:17 -0500, jprv...@gmail.com wrote:
static DBusMessage *endpoint_select_configuration(DBusConnection *conn,
DBusMessage *m, void *userdata) {
+pa_bluetooth_discovery *y = userdata;
+a2dp_sbc_t *cap, config;
+uint8_t *pconf = (uint8_t *) config;
+int
On Wed, 2013-09-18 at 16:17 -0500, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
This code is based on previous work by Mikel Astiz.
---
src/modules/bluetooth/bluez5-util.c | 55
+
1 file changed, 55 insertions(+)
diff
On Wed, 2013-09-18 at 16:17 -0500, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
Parse the arguments of the InterfacesAdded signal and the
GetManagedObjects() reply.
This code is based on previous work by Mikel Astiz.
---
src/modules/bluetooth/bluez5-util.c
On Wed, 2013-09-18 at 16:17 -0500, jprv...@gmail.com wrote:
static void parse_interfaces_and_properties(pa_bluetooth_discovery *y,
DBusMessageIter *dict_i) {
DBusMessageIter element_i;
const char *path;
@@ -415,7 +474,8 @@ static void
On Wed, 2013-09-18 at 16:17 -0500, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
---
src/modules/bluetooth/bluez5-util.c | 82
-
1 file changed, 81 insertions(+), 1 deletion(-)
diff --git
On Wed, 2013-09-18 at 16:17 -0500, jprv...@gmail.com wrote:
+static int parse_adapter_properties(pa_bluetooth_adapter *a, DBusMessageIter
*i, bool is_property_change) {
+DBusMessageIter element_i;
+
+pa_assert(a);
+
+dbus_message_iter_recurse(i, element_i);
+
+while
On Sat, 2013-09-21 at 14:02 +0300, Tanu Kaskinen wrote:
On Wed, 2013-09-18 at 16:17 -0500, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
Parse the arguments of the InterfacesAdded signal and the
GetManagedObjects() reply.
This code is based on previous
On Wed, 2013-09-18 at 16:17 -0500, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
This code is based on previous work by Mikel Astiz.
---
src/modules/bluetooth/bluez5-util.c | 164
++--
src/modules/bluetooth/bluez5-util.h | 6
On Wed, 2013-09-18 at 16:17 -0500, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
---
src/modules/bluetooth/module-bluez5-device.c | 75
1 file changed, 75 insertions(+)
diff --git a/src/modules/bluetooth/module-bluez5-device.c
On Wed, 2013-09-18 at 16:17 -0500, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
---
src/modules/bluetooth/module-bluez5-device.c | 77
1 file changed, 77 insertions(+)
diff --git a/src/modules/bluetooth/module-bluez5-device.c
On Wed, 2013-09-18 at 16:17 -0500, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
---
src/modules/bluetooth/module-bluez5-device.c | 78
1 file changed, 78 insertions(+)
diff --git a/src/modules/bluetooth/module-bluez5-device.c
On Wed, 2013-09-18 at 16:17 -0500, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
For quite some time now the device driver module doesn't work well
without the discovery module, so for the BlueZ 5 support we'll prevent
the device driver module to be loaded if the
On Wed, 2013-09-18 at 16:17 -0500, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
This new function checks if a certain module name is available in the
system.
---
src/pulsecore/module.c | 49 +
On Wed, 2013-09-18 at 16:17 -0500, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
This new function checks if a certain module name is available in the
system.
---
src/pulsecore/module.c | 49 +
On Thu, 2013-09-19 at 23:54 +1000, Patrick Shirkey wrote:
On Thu, September 19, 2013 6:52 pm, Patrick Shirkey wrote:
On Thu, September 19, 2013 6:42 pm, Tanu Kaskinen wrote:
On Wed, 2013-09-18 at 04:28 +1000, Patrick Shirkey wrote:
Hi,
Can someone shed some light on the best case
On Sat, 2013-09-21 at 13:30 -0500, João Paulo Rechi Vita wrote:
On Sat, Sep 21, 2013 at 5:16 AM, Tanu Kaskinen
tanu.kaski...@linux.intel.com wrote:
On Wed, 2013-09-18 at 16:17 -0500, jprv...@gmail.com wrote:
static DBusMessage *endpoint_select_configuration(DBusConnection *conn
On Sat, 2013-09-21 at 14:17 -0500, João Paulo Rechi Vita wrote:
On Sat, Sep 21, 2013 at 7:44 AM, Tanu Kaskinen
tanu.kaski...@linux.intel.com wrote:
On Wed, 2013-09-18 at 16:17 -0500, jprv...@gmail.com wrote:
From: João Paulo Rechi Vita jprv...@openbossa.org
---
src/modules/bluetooth
On Sat, 2013-09-21 at 15:56 -0500, João Paulo Rechi Vita wrote:
On Sat, Sep 21, 2013 at 7:51 AM, Tanu Kaskinen
tanu.kaski...@linux.intel.com wrote:
On Wed, 2013-09-18 at 16:17 -0500, jprv...@gmail.com wrote:
+static int parse_adapter_properties(pa_bluetooth_adapter *a,
DBusMessageIter *i
On Sun, 2013-09-22 at 02:30 +1000, Patrick Shirkey wrote:
On Sun, September 22, 2013 1:55 am, Tanu Kaskinen wrote:
PulseAudio doesn't increase the buffering on the fly (well, some small
adjustments are done with ALSA, but you're using JACK, so that's
irrelevant). If the source produces
On Fri, 2013-09-20 at 09:41 -0500, João Paulo Rechi Vita wrote:
On Thu, Sep 19, 2013 at 4:53 PM, David Henningsson
david.hennings...@canonical.com wrote:
On 09/19/2013 01:17 PM, Damir Jelić wrote:
Sorry if I'm a little bit annoying here but I'd like to keep our from
now on with as little
On Sun, 2013-09-22 at 20:03 +1000, Patrick Shirkey wrote:
On Sun, September 22, 2013 4:37 pm, Tanu Kaskinen wrote:
If you want to get the minimum latency of this path:
jack_delay - pulseaudio - application - pulseaudio - jack_delay
then you should use an application that reports
On Mon, 2013-09-23 at 09:55 +0200, David Henningsson wrote:
According to coding style, one should have one assertion per line
and not combine assertions.
Signed-off-by: David Henningsson david.hennings...@canonical.com
---
src/modules/alsa/module-alsa-card.c |4 ++--
1 file changed, 2
On Mon, 2013-09-23 at 10:21 +0200, David Henningsson wrote:
On 09/20/2013 11:23 AM, Peter Meerwald wrote:
I think both coding styles are sane and I suggest to NOT convert to a new
style
the 'other projects' is Gnome?
Gnome, Linux Kernel, FluidSynth (as mentioned previously).
On Mon, 2013-09-23 at 08:39 -0500, João Paulo Rechi Vita wrote:
On Sun, Sep 22, 2013 at 12:19 AM, Tanu Kaskinen
tanu.kaski...@linux.intel.com wrote:
On Sat, 2013-09-21 at 13:30 -0500, João Paulo Rechi Vita wrote:
On Sat, Sep 21, 2013 at 5:16 AM, Tanu Kaskinen
tanu.kaski...@linux.intel.com
On Wed, 2013-09-25 at 23:35 +1000, Patrick Shirkey wrote:
On Tue, September 24, 2013 10:33 pm, Patrick Shirkey wrote:
On Mon, September 23, 2013 6:11 pm, Tanu Kaskinen wrote:
The audio is accumulating in some buffer, and the JACK sink in
PulseAudio doesn't have any buffer, so it's
On Fri, 2013-09-27 at 19:26 +1000, Patrick Shirkey wrote:
On Thu, September 26, 2013 2:27 am, Tanu Kaskinen wrote:
Sorry, forgot to reply earlier. Yes, you can check the stream buffer
with pactl list sink-inputs. The Buffer Latency field shows the
amount of audio in the stream buffer
On Tue, 2013-09-24 at 16:16 -0700, Fox, Kevin M wrote:
Is there a reason that the struct is:
+struct userdata {
+pa_module *bluez5_module;
+pa_module *bluez4_module;
+};
and not:
+struct userdata {
+pa_module *bluez_module;
+};
The code might be cleaner looking with the
On Fri, 2013-09-27 at 23:31 +1000, Patrick Shirkey wrote:
On Fri, September 27, 2013 10:52 pm, Tanu Kaskinen wrote:
On Fri, 2013-09-27 at 19:26 +1000, Patrick Shirkey wrote:
On Thu, September 26, 2013 2:27 am, Tanu Kaskinen wrote:
Sorry, forgot to reply earlier. Yes, you can check
On Thu, 2013-09-26 at 14:11 -0300, João Paulo Rechi Vita wrote:
On Wed, Sep 25, 2013 at 7:33 AM, Tanu Kaskinen
tanu.kaski...@linux.intel.com wrote:
On Tue, 2013-09-24 at 19:19 -0300, João Paulo Rechi Vita wrote:
On Sun, Sep 22, 2013 at 2:38 AM, Tanu Kaskinen
tanu.kaski...@linux.intel.com
On Tue, 2013-09-24 at 19:45 -0300, jprv...@gmail.com wrote:
@@ -371,11 +398,8 @@ static void adapter_remove_all(pa_bluetooth_discovery
*y) {
/* When this function is called all devices have already been freed */
-while ((a = pa_hashmap_steal_first(y-adapters))) {
-
On Tue, 2013-09-24 at 19:45 -0300, jprv...@gmail.com wrote:
+static void parse_adapter_properties(pa_bluetooth_adapter *a,
DBusMessageIter *i, bool is_property_change) {
+DBusMessageIter element_i;
+
+pa_assert(a);
+
+dbus_message_iter_recurse(i, element_i);
+
+while
On Tue, 2013-09-24 at 19:45 -0300, jprv...@gmail.com wrote:
@@ -745,6 +748,15 @@ static void
parse_interfaces_and_properties(pa_bluetooth_discovery *y, DBusMessa
dbus_message_iter_next(element_i);
}
+PA_HASHMAP_FOREACH(d, y-devices, state)
+if (!d-adapter
On Tue, 2013-09-24 at 19:45 -0300, jprv...@gmail.com wrote:
diff --git a/src/modules/bluetooth/module-bluez5-device.c
b/src/modules/bluetooth/module-bluez5-device.c
index 36d7174..013cce5 100644
--- a/src/modules/bluetooth/module-bluez5-device.c
+++
Here are some small fixes to issues that I found while reviewing the
big Bluetooth patch set from João.
Tanu Kaskinen (5):
bluetooth: Remove adapter_remove_all()
bluetooth: Fix variable constness
bluetooth: Fix notifying about new devices
bluetooth: Remove device_remove_all()
bluetooth
The string points to memory inside a DBusMessage, so we don't own the string.
---
src/modules/bluetooth/bluez5-util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/modules/bluetooth/bluez5-util.c
b/src/modules/bluetooth/bluez5-util.c
index 2be15d8..eaff4b1 100644
---
The function did two things: set device_info_valid to -1 and called
device_free() for each device in the hashmap. Setting
device_info_valid to -1 was unnecessary. The main purpose of that was
to fire DEVICE_CONNECTION_CHANGED as a side effect, but that hook is
fired anyway in device_free(), as a
Normally devices are created and their properties are parsed before
creating any transports for the device, and the
DEVICE_CONNECTION_CHANGED hook is fired when the first transport is
created. It's possible, however, that a transport is created before
the device that it belongs to, and in this
When parsing device properties, missing adapter will result in
device_info_valid being set to -1. It is then logical that if the
adapter goes missing at a later point, device_info_valid gets set to
-1.
---
src/modules/bluetooth/bluez5-util.c | 4 +++-
1 file changed, 3 insertions(+), 1
The function was redundant, because all it did was call adapter_free()
for each adapter in the hashmap, and that can be delegated to
pa_hashmap when freeing or emptying it.
---
src/modules/bluetooth/bluez5-util.c | 20
1 file changed, 4 insertions(+), 16 deletions(-)
diff
On Fri, 2013-09-20 at 17:27 +0530, Arun Raghavan wrote:
---
src/pulsecore/hashmap.h | 4
1 file changed, 4 insertions(+)
diff --git a/src/pulsecore/hashmap.h b/src/pulsecore/hashmap.h
index ae030ed..e42732a 100644
--- a/src/pulsecore/hashmap.h
+++ b/src/pulsecore/hashmap.h
@@ -85,6
On Fri, 2013-09-27 at 10:32 +0200, David Henningsson wrote:
The author of this module, Tanu Kaskinen, has said that this module
is not suitable for general use. Also, it is still causing crashes
on card removal (see bug 69871).
Qpaeq, and possibly other tools, use this module - but they can
On Tue, 2013-10-01 at 13:12 +0200, David Henningsson wrote:
On 09/23/2013 11:50 AM, Tanu Kaskinen wrote:
Hi all,
With nodes, there will be two routing layers: the higher-level node
layer and the lower-level layer with sink inputs, sinks etc. The user
will be able to still use the old
On Tue, 2013-10-01 at 15:09 +0200, David Henningsson wrote:
On 10/01/2013 02:51 PM, Tanu Kaskinen wrote:
I did not plan to allow dual-direction nodes. If you want to represent
sinks as dual-direction nodes in a UI, I'm fine with adding information
to the nodes that allows the UI to do
On Tue, 2013-10-01 at 10:43 -0300, João Paulo Rechi Vita wrote:
Ack. Same question about testing applies here, and I should have made
it more generic, actually: Do you have audio devices to be able to
test these changes?
Devices aren't a problem (I have two A2DP/HFP headsets and one HFP-only
On Tue, 2013-10-01 at 10:34 -0300, João Paulo Rechi Vita wrote:
On Sun, Sep 29, 2013 at 12:49 PM, Tanu Kaskinen
tanu.kaski...@linux.intel.com wrote:
Normally devices are created and their properties are parsed before
creating any transports for the device, and the
DEVICE_CONNECTION_CHANGED
On Thu, 2013-10-03 at 02:33 +1000, Patrick Shirkey wrote:
On Thu, October 3, 2013 12:14 am, Tanu Kaskinen wrote:
On Tue, 2013-10-01 at 00:38 +1000, Patrick Shirkey wrote:
On Sat, September 28, 2013 3:12 am, Patrick Shirkey wrote:
On Sat, September 28, 2013 12:53 am, Tanu Kaskinen wrote
On Thu, 2013-10-03 at 18:20 +1000, Patrick Shirkey wrote:
On Thu, October 3, 2013 5:14 pm, Tanu Kaskinen wrote:
On Thu, 2013-10-03 at 02:33 +1000, Patrick Shirkey wrote:
I see the following sprinkled in /var/log/messages
Sep 30 12:19:02 xxx pulseaudio[28845]: [pulseaudio] ratelimit.c
There was a question in IRC about whether pa_simple_read() blocks or
not. It's already documented on the simple API overview page, but it's
good to say it also in the function reference. As a bonus, I added
some words about the error handling as well.
---
src/pulse/simple.h | 5 -
1 file
On Fri, 2013-10-04 at 19:15 +1000, Patrick Shirkey wrote:
Hi,
Can anyone point me to instructions for connecting pulse to jack in
headless mode?
I can run jack like this:
eval dbus-launch --auto-syntax
export
From: Tanu Kaskinen ta...@iki.fi
There was a question in IRC about whether pa_simple_read() blocks or
not. It's already documented on the simple API overview page, but it's
good to say it also in the function reference. As a bonus, I added
some additional details to the documentation too
On Mon, 2013-09-16 at 13:06 +0200, Alexander Couzens wrote:
@@ -528,11 +529,14 @@ void pa__done(pa_module *m) {
pa_sink_unlink(u-sink);
if (u-thread) {
-pa_asyncmsgq_send(u-thread_mq.inq, NULL, PA_MESSAGE_SHUTDOWN, NULL,
0, NULL);
+
On Fri, 2013-10-04 at 21:49 +1000, Patrick Shirkey wrote:
On Thu, October 3, 2013 11:41 pm, Thomas Martitz wrote:
Am 03.10.2013 10:20, schrieb Patrick Shirkey:
On Thu, October 3, 2013 5:14 pm, Tanu Kaskinen wrote:
That doesn't look healthy. The message is printed when
pa_asyncmsgq_post
On Tue, 2013-10-08 at 11:19 -0300, João Paulo Rechi Vita wrote:
On Sun, Sep 29, 2013 at 1:39 PM, Tanu Kaskinen
tanu.kaski...@linux.intel.com wrote:
On Tue, 2013-09-24 at 19:45 -0300, jprv...@gmail.com wrote:
+void pa__done(pa_module* m) {
+struct userdata *u;
+
+pa_assert(m
On Mon, 2013-10-07 at 09:43 -0700, Kiran Krishnappa wrote:
PA_SAMPLE_24NE generated in pa_sndfile_read_sample_spec is not
handled in pa_sndfile_readf_function. paplay used to get aborted
for 24bit depth wav files
How does paplay now behave? I suppose it still isn't able to play 24bit
files, so
On Thu, 2013-10-10 at 20:01 -0700, Kiran Krishnappa wrote:
Hi,
I tested both paplay and parecord for 24bit files. Looks to be working fine
now.
How can it be working fine, if the read/write functions don't exist for
24-bit files?
I looked at the code, and it seems that if the read/write
I switched to Fedora, and the system headers complained to me about
defining _FORTIFY_SOURCE when compiling without optimizations. I
don't know how other Fedora users have managed to live with this all
these years...
Tanu Kaskinen (2):
build-sys: Don't define _FORTIFY_SOURCE when building
---
configure.ac | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 42cb8b8..e2465e4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -165,12 +165,17 @@ esac
Compiler flags
AX_APPEND_COMPILE_FLAGS(
-[-Wall -W -Wextra -pipe
[Added pulseaudio-discuss back to CC.]
On Sat, 2013-10-12 at 09:31 -0700, Kiran Krishnappa wrote:
Ok. I got it. I didn't think much about wav file header. Just played 24 bit
file and also recorded 24 bit file, there were no aborts and when I played
24bit file, it couldn't make out difference.
801 - 900 of 4562 matches
Mail list logo
