Re: [pulseaudio-discuss] [PATCH v3] bluetooth: Wide Band Speech implementaion for backend ofono

2018-08-20 Thread James Bottomley
On Mon, 2018-08-20 at 19:19 +0530, Sathish Narasimman wrote: > From: Sathish Narasimman > > mSBC-encoded streams for HFP. The Wide Band Speech(WBS) encoding and > decoding > is implemeted with this patch. This patch was refered from original > patch of Joao Paula Rechi Vita and was verified with

Re: [pulseaudio-discuss] [PATCH v5 1/4] bluetooth: use consistent profile names

2017-09-25 Thread James Bottomley
On Mon, 2017-09-25 at 15:49 +0200, Georg Chini wrote: > On 25.09.2017 15:31, James Bottomley wrote: > > > > On Sun, 2017-09-24 at 15:07 +0200, Georg Chini wrote: > > > > > > On 21.09.2017 21:26, James Bottomley wrote: > > > > > &g

Re: [pulseaudio-discuss] [PATCH v5 2/4] bluetooth: separate HSP and HFP

2017-09-25 Thread James Bottomley
On Sun, 2017-09-24 at 15:35 +0200, Georg Chini wrote: > On 21.09.2017 21:27, James Bottomley wrote: > > > > When all headsets supported both HSP and HFP, life was good and we > > only needed to implement HSP in the native backend.  Unfortunately > > some headsets have

Re: [pulseaudio-discuss] [PATCH v5 2/4] bluetooth: separate HSP and HFP

2017-09-25 Thread James Bottomley
On Sat, 2017-09-23 at 23:33 +0100, Rodrigo Araujo wrote: > Hi. > > First, just to say that your patches are going great. Finally I can > use > the microphone of my HFP only headset (a version of a Bluedio T2+). > > So far, I've only encontered one problem: the auto_switch option of >

Re: [pulseaudio-discuss] [PATCH v5 1/4] bluetooth: use consistent profile names

2017-09-25 Thread James Bottomley
On Sun, 2017-09-24 at 15:07 +0200, Georg Chini wrote: > On 21.09.2017 21:26, James Bottomley wrote: > > > > The PA_BLUETOOTH_PROFILE names should mirror the PA_BLUETOOTH_UUID > > names using profile_function instead of randomly made up > > names.  Fix >

Re: [pulseaudio-discuss] [PATCH v5 3/4] bluetooth: add correct HFP rfcomm negotiation

2017-09-22 Thread James Bottomley
On Fri, 2017-09-22 at 21:09 +0300, Luiz Augusto von Dentz wrote: > Hi James, > > On Thu, Sep 21, 2017 at 10:28 PM, James Bottomley > <james.bottom...@hansenpartnership.com> wrote: [...] > > +static bool hfp_rfcomm_handle(int fd, pa_bluetooth_transport

[pulseaudio-discuss] [PATCH v5 4/4] bluetooth: make native the default backend

2017-09-21 Thread James Bottomley
unless the backend is the native one, in which case the default becomes true. so that we only bind the HFP_HF end point in the native case (leaving it free for ofono in the ofono backend or auto case) Signed-off-by: James Bottomley <james.bottom...@hansenpartnership.com> --- src/modules/blu

[pulseaudio-discuss] [PATCH v5 3/4] bluetooth: add correct HFP rfcomm negotiation

2017-09-21 Thread James Bottomley
HFP 1.6 requires a stateful negotiation of AT commands. The prior version got away with initialising HFP simply by replying 'OK' to every negotiation attempt. This one actually tries to parse the state and make sure the negotiation occurs correctly Signed-off-by: James Bottomley <james.bot

[pulseaudio-discuss] [PATCH v5 2/4] bluetooth: separate HSP and HFP

2017-09-21 Thread James Bottomley
When all headsets supported both HSP and HFP, life was good and we only needed to implement HSP in the native backend. Unfortunately some headsets have started supporting HFP only. Unfortuantely, we can't simply switch to HFP only because that might break older HSP only headsets meaning we need

[pulseaudio-discuss] [PATCH v5 1/4] bluetooth: use consistent profile names

2017-09-21 Thread James Bottomley
WAY -> PA_BLUETOOTH_PROFILE_HFP_AG Signed-off-by: James Bottomley <james.bottom...@hansenpartnership.com> --- v4: update for PA 11.0 --- src/modules/bluetooth/backend-native.c | 28 +++ src/modules/bluetooth/backend-ofono.c| 4 +-- src/modules/bluetooth/bluez5-util.c

[pulseaudio-discuss] [PATCH v5 0/4] use bluetooth HFP in pulseaudio native backend when available

2017-09-21 Thread James Bottomley
the default). James Bottomley (4): bluetooth: use consistent profile names bluetooth: separate HSP and HFP bluetooth: add correct HFP rfcomm negotiation bluetooth: make native the default backend src/modules/bluetooth/backend-native.c | 169 +--- src/modules/bluetooth

Re: [pulseaudio-discuss] [PATCH v4 0/3] use bluetooth HFP in pulseaudio when available

2017-09-21 Thread James Bottomley
On Thu, 2017-09-21 at 19:15 +0300, Tanu Kaskinen wrote: > On Thu, 2017-09-21 at 17:47 +0200, Georg Chini wrote: > > > > On 21.09.2017 16:47, James Bottomley wrote: > > > > > > On Thu, 2017-09-21 at 17:28 +0300, Tanu Kaskinen wrote: > > > > >

Re: [pulseaudio-discuss] [PATCH v4 0/3] use bluetooth HFP in pulseaudio when available

2017-09-21 Thread James Bottomley
On Thu, 2017-09-21 at 17:28 +0300, Tanu Kaskinen wrote: > On Thu, 2017-09-21 at 08:13 +0200, Georg Chini wrote: > > > > On 21.09.2017 06:45, James Bottomley wrote: > > > > > > On Thu, 2017-09-21 at 06:27 +0200, Georg Chini wrote: > > > > >

Re: [pulseaudio-discuss] [PATCH v4 0/3] use bluetooth HFP in pulseaudio when available

2017-09-20 Thread James Bottomley
On Thu, 2017-09-21 at 06:27 +0200, Georg Chini wrote: > On 20.09.2017 23:12, James Bottomley wrote: > > > > On Wed, 2017-09-20 at 20:41 +0200, Georg Chini wrote: > > > > > > On 20.09.2017 20:10, James Bottomley wrote: > > > > > > >

Re: [pulseaudio-discuss] [PATCH v4 0/3] use bluetooth HFP in pulseaudio when available

2017-09-20 Thread James Bottomley
On Wed, 2017-09-20 at 20:41 +0200, Georg Chini wrote: > On 20.09.2017 20:10, James Bottomley wrote: > > > > On Wed, 2017-09-20 at 18:11 +0200, Georg Chini wrote: > > > > > > On 20.09.2017 01:27, James Bottomley wrote: > > > > > > > &g

Re: [pulseaudio-discuss] [PATCH v4 0/3] use bluetooth HFP in pulseaudio when available

2017-09-20 Thread James Bottomley
On Wed, 2017-09-20 at 18:11 +0200, Georg Chini wrote: > On 20.09.2017 01:27, James Bottomley wrote: > > > > This is round 4 of the initial bluetooth: separate HSP and HFP > > patch. > >   It includes the review feedback and a global on/off switch just > >

[pulseaudio-discuss] [PATCH v4 3/3] bluetooth: add correct HFP rfcomm negotiation

2017-09-19 Thread James Bottomley
HFP 1.6 requires a stateful negotiation of AT commands. The prior version got away with initialising HFP simply by replying 'OK' to every negotiation attempt. This one actually tries to parse the state and make sure the negotiation occurs correctly Signed-off-by: James Bottomley <james.bot

[pulseaudio-discuss] [PATCH v4 2/3] bluetooth: separate HSP and HFP

2017-09-19 Thread James Bottomley
When all headsets supported both HSP and HFP, life was good and we only needed to implement HSP in the native backend. Unfortunately some headsets have started supporting HFP only. Unfortuantely, we can't simply switch to HFP only because that might break older HSP only headsets meaning we need

[pulseaudio-discuss] [PATCH v4 0/3] use bluetooth HFP in pulseaudio when available

2017-09-19 Thread James Bottomley
out a bug in the rfcomm negotiation that was causing issues with my LG 900 headset, so I think it's now working for everything (but testing would be welcome). James Bottomley (3): bluetooth: use consistent profile names bluetooth: separate HSP and HFP bluetooth: add correct HFP rfcomm

[pulseaudio-discuss] [PATCH v4 1/3] bluetooth: use consistent profile names

2017-09-19 Thread James Bottomley
WAY -> PA_BLUETOOTH_PROFILE_HFP_AG Signed-off-by: James Bottomley <james.bottom...@hansenpartnership.com> --- v4: update for PA 11.0 --- src/modules/bluetooth/backend-native.c | 28 +++ src/modules/bluetooth/backend-ofono.c| 4 +-- src/modules/bluetooth/bluez5-util.c

Re: [pulseaudio-discuss] [PATCH v2 3/3] bluetooth: add correct HFP rfcomm negotiation

2016-08-26 Thread James Bottomley
On Wed, 2016-08-24 at 16:17 +0300, Tanu Kaskinen wrote: > On Tue, 2016-08-23 at 08:37 -0400, James Bottomley wrote: > > On Mon, 2016-08-22 at 15:12 +0300, Tanu Kaskinen wrote: > > > and AT+CHLD=?. > > > > This one is a bit weird: in theory the response should b

Re: [pulseaudio-discuss] issue with audio over headset_head_unit

2016-08-25 Thread James Bottomley
On Thu, 2016-08-25 at 16:35 +0530, Arun Raghavan wrote: > On Thu, 25 Aug 2016, at 03:10 PM, Anand Nekkunti wrote: > > Hi > > I am working audio over Bluetooth . I am able to pair and > > connect > > with > > all speakers(a2dp and HSD ). > > but audio coming only speakers which supports

Re: [pulseaudio-discuss] [PATCH v2 3/3] bluetooth: add correct HFP rfcomm negotiation

2016-08-21 Thread James Bottomley
On Sun, 2016-08-21 at 16:16 -0400, James Bottomley wrote: > The v1.6 version of the standard contains a diagram > which shows the minimum dialog you need. For this standard: https://www.bluetooth.org/docman/handlers/downloaddoc.ashx?doc_id=238193 it's figure 4.1 (service level conn

Re: [pulseaudio-discuss] [PATCH v2 3/3] bluetooth: add correct HFP rfcomm negotiation

2016-08-21 Thread James Bottomley
On Sun, 2016-08-21 at 23:01 +0300, Tanu Kaskinen wrote: > On Sat, 2016-08-20 at 15:05 -0700, James Bottomley wrote: > > +static int hfp_rfcomm_handle(int fd, pa_bluetooth_transport *t, > > const char *buf) > > +{ > > +struct hfp_config *c =

Re: [pulseaudio-discuss] [PATCH v2 2/3] bluetooth: separate HSP and HFP

2016-08-21 Thread James Bottomley
On Sun, 2016-08-21 at 21:03 +0300, Tanu Kaskinen wrote: > On Sun, 2016-08-21 at 15:19 +0300, Tanu Kaskinen wrote: > > On Sat, 2016-08-20 at 15:03 -0700, James Bottomley wrote: > > > static const char* const valid_modargs[] = { > > > "path", > > &g

[pulseaudio-discuss] [PATCH v2 3/3] bluetooth: add correct HFP rfcomm negotiation

2016-08-20 Thread James Bottomley
HFP 1.6 requires a stateful negotiation of AT commands. The prior version got away with initialising HFP simply by replying 'OK' to every negotiation attempt. This one actually tries to parse the state and make sure the negotiation occurs correctly Signed-off-by: James Bottomley <james.bot

[pulseaudio-discuss] [PATCH v2 0/3] use bluetooth HFP in pulseaudio when available

2016-08-20 Thread James Bottomley
This is round 2 of the initial bluetooth: separate HSP and HFP patch. It includes the review feedback and a global on/off switch just in case there's a problem headset with dual HFP/HSP but non-working HFP. This one now includes a proper rfcomm negotiation (see patch 3). James Bottomley (3

Re: [pulseaudio-discuss] [PATCH] bluetooth: separate HSP and HFP

2016-08-20 Thread James Bottomley
On Sat, 2016-08-20 at 21:34 +0300, Tanu Kaskinen wrote: > On Sat, 2016-08-20 at 11:18 -0700, James Bottomley wrote: On Sat, 2016-08-20 at 21:03 +0300, Tanu Kaskinen wrote: > > > Also, pulseaudio doesn't manage when profiles are connected or > > > disconnecte

Re: [pulseaudio-discuss] [PATCH] bluetooth: separate HSP and HFP

2016-08-20 Thread James Bottomley
On Sat, 2016-08-20 at 21:34 +0300, Tanu Kaskinen wrote: > On Sat, 2016-08-20 at 11:18 -0700, James Bottomley wrote: > > On Sat, 2016-08-20 at 21:03 +0300, Tanu Kaskinen wrote: > > > To clarify, is the problem that bluez has some arbitrary > > > limitation that it's n

Re: [pulseaudio-discuss] [PATCH] bluetooth: separate HSP and HFP

2016-08-20 Thread James Bottomley
On Sat, 2016-08-20 at 21:03 +0300, Tanu Kaskinen wrote: > On Sat, 2016-08-20 at 10:28 -0700, James Bottomley wrote: > > I actually ran into a problem with the approach. It's not really a > > pulseaudio problem per-se, it's a bluetooth/bluez one: bluez can't > > talk simul

Re: [pulseaudio-discuss] [PATCH] bluetooth: separate HSP and HFP

2016-08-20 Thread James Bottomley
On Fri, 2016-08-19 at 22:33 +0300, Tanu Kaskinen wrote: > On Thu, 2016-08-18 at 11:14 -0700, James Bottomley wrote: > > When all headsets supported both HSP and HFP, life was good and we > > only needed to implement HSP in the native backend. Unfortunately > > some

Re: [pulseaudio-discuss] [PATCH] bluetooth: separate HSP and HFP

2016-08-19 Thread James Bottomley
On Fri, 2016-08-19 at 22:33 +0300, Tanu Kaskinen wrote: > On Thu, 2016-08-18 at 11:14 -0700, James Bottomley wrote: > > When all headsets supported both HSP and HFP, life was good and we > > only needed to implement HSP in the native backend. Unfortunately > > some

Re: [pulseaudio-discuss] Adding support for bluetooth headsets that only have HFP

2016-08-19 Thread James Bottomley
On Fri, 2016-08-19 at 20:24 +0300, Tanu Kaskinen wrote: > On Thu, 2016-08-18 at 07:51 -0700, James Bottomley wrote: > > I recently switched from a JBL Flip 2 which supports both HSP and > > HFP > > to an Ultimate Ears Boom 2 which is HFP only. Needless to say thi

[pulseaudio-discuss] [PATCH] bluetooth: separate HSP and HFP

2016-08-18 Thread James Bottomley
When all headsets supported both HSP and HFP, life was good and we only needed to implement HSP in the native backend. Unfortunately some headsets have started supporting HFP only. Unfortuantely, we can't simply switch to HFP only because that might break older HSP only headsets meaning we need

[pulseaudio-discuss] Adding support for bluetooth headsets that only have HFP

2016-08-18 Thread James Bottomley
I recently switched from a JBL Flip 2 which supports both HSP and HFP to an Ultimate Ears Boom 2 which is HFP only. Needless to say this currently means that the Ultimate Ears fails to work with pulseaudio because we only support HSP via the native backend. The first thing to note is that we can