On Wed, 2011-10-19 at 13:11 +0300, Tanu Kaskinen wrote:
On Wed, 2011-10-19 at 13:00 +0300, Colin Guthrie wrote:
'Twas brillig, and David Henningsson at 18/10/11 20:56 did gyre and gimble:
While in general I agree that a boolean is a fine success/failure return
type, I think in Pulseaudio
On Wed, 2011-10-12 at 12:40 +0200, David Henningsson wrote:
Note: There is still no notification when status availability changes.
Signed-off-by: David Henningsson david.hennings...@canonical.com
---
[...]
diff --git a/PROTOCOL b/PROTOCOL
index 8c69190..b8b61e4 100644
--- a/PROTOCOL
+++
Thanks for the review.
On 10/20/2011 10:25 AM, Arun Raghavan wrote:
On Wed, 2011-10-12 at 12:40 +0200, David Henningsson wrote:
Note: There is still no notification when status availability changes.
Signed-off-by: David Henningssondavid.hennings...@canonical.com
---
[...]
diff --git
'Twas brillig, and David Henningsson at 18/10/11 20:56 did gyre and gimble:
While in general I agree that a boolean is a fine success/failure return
type, I think in Pulseaudio the convention is to stick just to ints.
Hmm. A quick 'grep -r return TRUE' of PulseAudio source tree seems to
give
'Twas brillig, and David Henningsson at 19/10/11 05:55 did gyre and gimble:
On 10/19/2011 12:11 AM, Pierre-Louis Bossart wrote:
Did you miss my previous explanation, or did you find it insufficient?
I'm repeating it below:
The protocol skew in Ubuntu 11.10 was actually a mistake on my part.
On Wed, 2011-10-19 at 13:00 +0300, Colin Guthrie wrote:
'Twas brillig, and David Henningsson at 18/10/11 20:56 did gyre and gimble:
While in general I agree that a boolean is a fine success/failure return
type, I think in Pulseaudio the convention is to stick just to ints.
Hmm. A quick
On Wed, 2011-10-19 at 13:11 +0300, Tanu Kaskinen wrote:
That gives a big list indeed. But did you check the context? I went
through quite a lot (but not nearly all) of the output from 'git grep -n
-e return TRUE -e return FALSE' and the overwhelming majority of the
I actually meant
git
Hi,
Looks quite good to me. Some review comments below.
On Wed, 2011-10-12 at 12:40 +0200, David Henningsson wrote:
Note: There is still no notification when status availability changes.
Signed-off-by: David Henningsson david.hennings...@canonical.com
---
The protocol skew in Ubuntu
On 10/18/2011 07:16 PM, Tanu Kaskinen wrote:
Hi,
Looks quite good to me. Some review comments below.
Thanks for the review.
On Wed, 2011-10-12 at 12:40 +0200, David Henningsson wrote:
Note: There is still no notification when status availability changes.
Signed-off-by: David
Note: There is still no notification when status availability changes.
Signed-off-by: David Henningsson david.hennings...@canonical.com
---
PROTOCOL| 10
configure.ac|2 +-
src/modules/module-tunnel.c | 91
Subject: [pulseaudio-discuss] [PATCH] Introduce available concept for
ports, and communicate that to clients. Bump protocol version to 24.
---
PROTOCOL| 10
configure.ac|2 +-
src/modules/module-tunnel.c | 91
On 10/18/2011 10:44 PM, Pierre-Louis Bossart wrote:
Subject: [pulseaudio-discuss] [PATCH] Introduce available concept for
ports, and communicate that to clients. Bump protocol version to 24.
---
PROTOCOL| 10
configure.ac|2 +-
Did you miss my previous explanation, or did you find it insufficient?
I'm repeating it below:
The protocol skew in Ubuntu 11.10 was actually a mistake on my part.
Since the UI changes that would depend on this information being
available was backed out, I probably should have backed the
On 10/19/2011 12:11 AM, Pierre-Louis Bossart wrote:
Did you miss my previous explanation, or did you find it insufficient?
I'm repeating it below:
The protocol skew in Ubuntu 11.10 was actually a mistake on my part.
Since the UI changes that would depend on this information being
available was
Note: There is still no notification when status availability changes.
Signed-off-by: David Henningsson david.hennings...@canonical.com
---
The protocol skew in Ubuntu 11.10 was actually a mistake on my part. Since the
UI
changes that would depend on this information being available was backed
15 matches
Mail list logo
