Re: [pulseaudio-discuss] [PATCH] Please review RAOP2 support :)

2014-09-28 Thread Tanu Kaskinen
On Thu, 2014-09-25 at 17:32 +0200, Colin Leroy wrote: On Thu, 25 Sep 2014 17:25:58 +0200, Martin Blanchard tch...@gmx.com wrote: Hi Martin, Subject: [PATCH] raop: Remove unimplemented code (PCM and AAC) Thanks, applied pushed to my branch. Note that the patch review status page[1]

Re: [pulseaudio-discuss] [PATCH] Please review RAOP2 support :)

2014-09-28 Thread Colin Leroy
[re-sending to the list] On 28 September 2014 at 13h47, Tanu Kaskinen wrote: Hi, Subject: [PATCH] raop: Remove unimplemented code (PCM and AAC) Thanks, applied pushed to my branch. Note that the patch review status page[1] refers to a fixed set of commits to make it clear

Re: [pulseaudio-discuss] [PATCH] Please review RAOP2 support :)

2014-09-25 Thread Martin Blanchard
Hello Colin. On Thu, 2014-09-18 at 15:27 +0200, Colin Leroy wrote: On Thu, 18 Sep 2014 19:17:53 +0600, Alexander E. Patrakov patra...@gmail.com wrote: I had a look at the diff between the master and the end result. Too much whitespace changes and other non-functional changes (e.g. I

Re: [pulseaudio-discuss] [PATCH] Please review RAOP2 support :)

2014-09-25 Thread Colin Leroy
On Thu, 25 Sep 2014 17:25:58 +0200, Martin Blanchard tch...@gmx.com wrote: Hi Martin, Subject: [PATCH] raop: Remove unimplemented code (PCM and AAC) Thanks, applied pushed to my branch. -- Colin signature.asc Description: PGP signature ___

Re: [pulseaudio-discuss] [PATCH] Please review RAOP2 support :)

2014-09-18 Thread Colin Leroy
On Thu, 18 Sep 2014 16:43:05 +0530, Arun Raghavan a...@accosted.net wrote: On 18 Sep 2014 15:35, Colin Leroy co...@colino.net wrote: On Thu, 18 Sep 2014 11:10:30 +0200, Colin Leroy co...@colino.net wrote: So what's needed to start looking at pushing this upstream? I don't have

Re: [pulseaudio-discuss] [PATCH] Please review RAOP2 support :)

2014-09-18 Thread Alexander E. Patrakov
18.09.2014 19:03, Colin Leroy wrote: On Thu, 18 Sep 2014 16:43:05 +0530, Arun Raghavan a...@accosted.net wrote: On 18 Sep 2014 15:35, Colin Leroy co...@colino.net wrote: On Thu, 18 Sep 2014 11:10:30 +0200, Colin Leroy co...@colino.net wrote: So what's needed to start looking at pushing

Re: [pulseaudio-discuss] [PATCH] Please review RAOP2 support :)

2014-09-18 Thread Colin Leroy
On Thu, 18 Sep 2014 19:17:53 +0600, Alexander E. Patrakov patra...@gmail.com wrote: I had a look at the diff between the master and the end result. Too much whitespace changes and other non-functional changes (e.g. I don't understand why the definition of struct userdata has to be moved up in

Re: [pulseaudio-discuss] [PATCH] Please review RAOP2 support :)

2014-09-18 Thread Alexander E. Patrakov
18.09.2014 19:27, Colin Leroy wrote: On Thu, 18 Sep 2014 19:17:53 +0600, Alexander E. Patrakov patra...@gmail.com wrote: I had a look at the diff between the master and the end result. Too much whitespace changes and other non-functional changes (e.g. I don't understand why the definition of

Re: [pulseaudio-discuss] [PATCH] Please review RAOP2 support :)

2014-09-18 Thread Colin Leroy
On Thu, 18 Sep 2014 19:37:49 +0600, Alexander E. Patrakov patra...@gmail.com wrote: Well, if you prefer to have them, then OK, let's have them (and only them) at the beginning and only functional changes at the end. If some patch adds badly-formatted code only to be fixed up later, please

Re: [pulseaudio-discuss] [PATCH] Please review RAOP2 support :)

2014-09-18 Thread Alexander E. Patrakov
18.09.2014 19:44, Colin Leroy wrote: On Thu, 18 Sep 2014 19:37:49 +0600, Alexander E. Patrakov patra...@gmail.com wrote: Well, if you prefer to have them, then OK, let's have them (and only them) at the beginning and only functional changes at the end. If some patch adds badly-formatted code

Re: [pulseaudio-discuss] [PATCH] Please review RAOP2 support :)

2014-09-18 Thread Colin Leroy
On Thu, 18 Sep 2014 19:52:15 +0600, Alexander E. Patrakov patra...@gmail.com wrote: That would be perfect. [...] Then git rebase -i master is your friend. Thanks, that helped :) Here's the updated result : https://github.com/colinleroy/pulseaudio/compare/raop2-v2 HTH, -- Colin