Re: [pulseaudio-discuss] [PATCH 1/3] sink_input: new volume_factor system

2012-11-26 Thread Flávio Ceolin
Hi Paul, On Mon, Nov 26, 2012 at 7:10 PM, Paul Menzel wrote: > Dear Flavio, > > > thank you for your patches. As you are asked to resend anyway, here are > some nitpicks. > > > Am Mittwoch, den 14.11.2012, 15:19 -0200 schrieb Flavio Ceolin: >> This patch makes possible to set more than one volume

Re: [pulseaudio-discuss] [PATCH 1/3] sink_input: new volume_factor system

2012-11-26 Thread Paul Menzel
Dear Flavio, thank you for your patches. As you are asked to resend anyway, here are some nitpicks. Am Mittwoch, den 14.11.2012, 15:19 -0200 schrieb Flavio Ceolin: > This patch makes possible to set more than one volume factor. The s,makes,makes it, Also starting a commit message with »This

Re: [pulseaudio-discuss] [PATCH 1/3] sink_input: new volume_factor system

2012-11-24 Thread Tanu Kaskinen
On Wed, 2012-11-14 at 15:19 -0200, Flavio Ceolin wrote: > This patch makes possible to set more than one volume factor. The > real value of the volume_factor will be the multiplication of these > values. Please avoid breaking compilation between patches. Patches 1/3 and 2/3 should be squashed, ot

[pulseaudio-discuss] [PATCH 1/3] sink_input: new volume_factor system

2012-11-14 Thread Flavio Ceolin
This patch makes possible to set more than one volume factor. The real value of the volume_factor will be the multiplication of these values. --- src/pulsecore/sink-input.c | 172 ++--- src/pulsecore/sink-input.h | 19 +++-- 2 files changed, 158 insertions