Re: [pulseaudio-discuss] [PATCH v5 3/4] bluetooth: add correct HFP rfcomm negotiation

2017-09-27 Thread Luiz Augusto von Dentz
Hi James, On Fri, Sep 22, 2017 at 9:29 PM, James Bottomley wrote: > On Fri, 2017-09-22 at 21:09 +0300, Luiz Augusto von Dentz wrote: >> Hi James, >> >> On Thu, Sep 21, 2017 at 10:28 PM, James Bottomley >> wrote: > [...] >> > +static bool hfp_rfcomm_handle(int fd, pa_bluetooth_transport *t, >> >

Re: [pulseaudio-discuss] [PATCH v5 3/4] bluetooth: add correct HFP rfcomm negotiation

2017-09-22 Thread James Bottomley
On Fri, 2017-09-22 at 21:09 +0300, Luiz Augusto von Dentz wrote: > Hi James, > > On Thu, Sep 21, 2017 at 10:28 PM, James Bottomley > wrote: [...] > > +static bool hfp_rfcomm_handle(int fd, pa_bluetooth_transport *t, > > const char *buf) > > +{ > > +struct hfp_config *c = t->config; > > +i

Re: [pulseaudio-discuss] [PATCH v5 3/4] bluetooth: add correct HFP rfcomm negotiation

2017-09-22 Thread Luiz Augusto von Dentz
Hi James, On Thu, Sep 21, 2017 at 10:28 PM, James Bottomley wrote: > HFP 1.6 requires a stateful negotiation of AT commands. The prior > version got away with initialising HFP simply by replying 'OK' to > every negotiation attempt. This one actually tries to parse the state > and make sure the

[pulseaudio-discuss] [PATCH v5 3/4] bluetooth: add correct HFP rfcomm negotiation

2017-09-21 Thread James Bottomley
HFP 1.6 requires a stateful negotiation of AT commands. The prior version got away with initialising HFP simply by replying 'OK' to every negotiation attempt. This one actually tries to parse the state and make sure the negotiation occurs correctly Signed-off-by: James Bottomley --- v4: - Up