Re: [pulseaudio-discuss] [PATCH] Add a target to the PA log feature and improve PA log core

2011-02-24 Thread Becker, VincentX
From: Maarten Bosmans [mailto:mkbosm...@gmail.com] 2011/2/23 Becker, VincentX vincentx.bec...@intel.com: Thanks for your review Maarten. So you suggest to split this into several patches (2). One for the outer implementation and the other for the inner one. I will try to attend to the irc

Re: [pulseaudio-discuss] [PATCH] Add a target to the PA log feature and improve PA log core

2011-02-24 Thread Maarten Bosmans
2011/2/24 Becker, VincentX vincentx.bec...@intel.com: From: Maarten Bosmans [mailto:mkbosm...@gmail.com] 2011/2/23 Becker, VincentX vincentx.bec...@intel.com: Thanks for your review Maarten. So you suggest to split this into several patches (2). One for the outer implementation and the other for

[pulseaudio-discuss] command-line control - increase/decrease volume of default output

2011-02-24 Thread Ng Oon-Ee
Hi all, It seems the only way to achieve the above would be to script the following:- 1. Obtain the default device using pacmd list-sinks | grep * or similar 2. Get that device's current volume using some multi-line parsing of pacmd list-sinks or pacmd info (output in %) 3. Convert the given %

Re: [pulseaudio-discuss] command-line control - increase/decrease volume of default output

2011-02-24 Thread Colin Guthrie
'Twas brillig, and Ng Oon-Ee at 24/02/11 12:07 did gyre and gimble: Hi all, It seems the only way to achieve the above would be to script the following:- 1. Obtain the default device using pacmd list-sinks | grep * or similar 2. Get that device's current volume using some multi-line

Re: [pulseaudio-discuss] command-line control - increase/decrease volume of default output

2011-02-24 Thread Ng Oon-Ee
On Thu, 2011-02-24 at 12:46 +, Colin Guthrie wrote: 'Twas brillig, and Ng Oon-Ee at 24/02/11 12:07 did gyre and gimble: Hi all, It seems the only way to achieve the above would be to script the following:- 1. Obtain the default device using pacmd list-sinks | grep * or similar

[pulseaudio-discuss] [PATCH 0/6] Volume sharing

2011-02-24 Thread Tanu Kaskinen
Here's a bunch of patches related to the volume sharing feature. The first patch is the main one. It's now tested to some degree (quite well, I believe), but of course reviewing should still be done. The rest of the patches are fixes and improvements for the virtual sink and source modules, which

[pulseaudio-discuss] [PATCH 1/6] Implement the volume sharing feature.

2011-02-24 Thread Tanu Kaskinen
When we have a filter sink that does some processing, currently the benefits of the flat volume feature are not really available. That's because if you have a music player that is connected to the filter sink, the hardware sink doesn't have any idea of the music player's stream volume. This

[pulseaudio-discuss] [PATCH 2/6] virtual-sink: Add a modarg for enabling volume sharing.

2011-02-24 Thread Tanu Kaskinen
--- src/modules/module-virtual-sink.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/src/modules/module-virtual-sink.c b/src/modules/module-virtual-sink.c index 40bab5a..ceb2697 100644 --- a/src/modules/module-virtual-sink.c +++

[pulseaudio-discuss] [PATCH 3/6] virtual-sink: Add a modarg for forcing flat volume.

2011-02-24 Thread Tanu Kaskinen
--- src/modules/module-virtual-sink.c | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/src/modules/module-virtual-sink.c b/src/modules/module-virtual-sink.c index ceb2697..e55e890 100644 --- a/src/modules/module-virtual-sink.c +++

[pulseaudio-discuss] [PATCH 4/6] virtual-sink/source: Use a more descriptive stream name.

2011-02-24 Thread Tanu Kaskinen
--- src/modules/module-virtual-sink.c |2 +- src/modules/module-virtual-source.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/module-virtual-sink.c b/src/modules/module-virtual-sink.c index e55e890..a45f4f5 100644 ---

[pulseaudio-discuss] [PATCH 5/6] virtual-sink/source: Remove an unused variable.

2011-02-24 Thread Tanu Kaskinen
--- src/modules/module-virtual-sink.c |5 - src/modules/module-virtual-source.c |5 - 2 files changed, 0 insertions(+), 10 deletions(-) diff --git a/src/modules/module-virtual-sink.c b/src/modules/module-virtual-sink.c index a45f4f5..bad159c 100644 ---

Re: [pulseaudio-discuss] command-line control - increase/decrease volume of default output

2011-02-24 Thread Colin Guthrie
'Twas brillig, and Ng Oon-Ee at 24/02/11 13:14 did gyre and gimble: This would have to be part of pacmd or separate? I thought this is what pactl was supposed to be for, but it seems development on that just stopped. And yes I forgot I had alsa's ctl bound to hardware, that would be a

Re: [pulseaudio-discuss] [PATCH 1/2] Add a target to the PA log feature

2011-02-24 Thread Becker, VincentX
From: Maarten Bosmans [mailto:mkbosm...@gmail.com] 2011/2/23 Becker, VincentX vincentx.bec...@intel.com: Thanks for your review Maarten. So you suggest to split this into several patches (2). One for the outer implementation and the other for the inner one. I will try to attend to the irc

Re: [pulseaudio-discuss] [PATCH 2/2] Improve and optimize PA log core

2011-02-24 Thread Becker, VincentX
This patch goes with previous one (0001-Add-a-new-log-target-to-a-file-descriptor-in-daemon-.patch) Vincent - Intel Corporation SAS (French simplified joint stock company) Registered headquarters: Les Montalets- 2, rue de Paris,

Re: [pulseaudio-discuss] [RFC] Alsa UCM integration.

2011-02-24 Thread pl bossart
The initial version of the UCM module is available at the following link: http://git.slimlogic.co.uk/cgi-bin/cgit.cgi/pulseaudio.git/log/?h=9.20-ucm_module I'm still working in the module, It is work in progress to verify the current verb when the stream is closed, also it is needed to add

Re: [pulseaudio-discuss] [RFC] Alsa UCM integration.

2011-02-24 Thread Colin Guthrie
'Twas brillig, and pl bossart at 24/02/11 20:20 did gyre and gimble: The initial version of the UCM module is available at the following link: http://git.slimlogic.co.uk/cgi-bin/cgit.cgi/pulseaudio.git/log/?h=9.20-ucm_module I'm still working in the module, It is work in progress to verify the

Re: [pulseaudio-discuss] [PATCH 1/2] Add a target to the PA log feature

2011-02-24 Thread Paul Menzel
Dear VincentX, please note in the subject what iteration your patch is, e. g. »[PATCH 1/2 v2]«. See `--subject-prefix` in `git help format-patch`. Am Donnerstag, den 24.02.2011, 16:30 + schrieb Becker, VincentX: From 55f84afd8575dadba697c746daa61ee07b333c57 Mon Sep 17 00:00:00 2001 From:

Re: [pulseaudio-discuss] [PATCH 1/2] Add a target to the PA log feature

2011-02-24 Thread Maarten Bosmans
2011/2/24 Becker, VincentX vincentx.bec...@intel.com: From: Maarten Bosmans [mailto:mkbosm...@gmail.com] 2011/2/23 Becker, VincentX vincentx.bec...@intel.com: Thanks for your review Maarten. So you suggest to split this into several patches (2). One for the outer implementation and the other for

Re: [pulseaudio-discuss] [PATCH 1/2] Add a target to the PA log feature

2011-02-24 Thread Colin Guthrie
'Twas brillig, and Paul Menzel at 24/02/11 22:14 did gyre and gimble: Could you add that indentation change in a separate patch? It makes it easier to review in my opinion. It is not necessary though. I think we'll try and avoid the majority of the indentation changes if possible. I appreciate

Re: [pulseaudio-discuss] [RFC] Alsa UCM integration.

2011-02-24 Thread Margarita Olaya
Pierre, On Thu, Feb 24, 2011 at 2:20 PM, pl bossart bossart.nos...@gmail.com wrote: The initial version of the UCM module is available at the following link: http://git.slimlogic.co.uk/cgi-bin/cgit.cgi/pulseaudio.git/log/?h=9.20-ucm_module I'm still working in the module, It is work in