Re: [pulseaudio-discuss] underrun behavior with alsa-plugins

2011-04-20 Thread David Henningsson
On 2011-04-19 18:12, Maarten Lankhorst wrote: Hi all, For wine I was investigating a bug with pulseaudio, it seems alsa-plugins' pulse driver ignores underruns. Hmm, doesn't wine come with a native pulse driver these days? This is probably because an underrun will force you to call

[pulseaudio-discuss] [PATCH] filter-apply: Make housekeeping optional

2011-04-20 Thread Arun Raghavan
Adds an autoclean option (defaults to TRUE) that controls whether module-filter-apply cleans up unused modules or not. This is useful in cases where you know that a filter will be used often and thus can avoid overhead from repeated module load/unload. --- src/modules/module-filter-apply.c | 14

Re: [pulseaudio-discuss] [PATCH v2] call-state-tracker: New component.

2011-04-20 Thread Colin Guthrie
'Twas brillig, and Tanu Kaskinen at 18/04/11 10:31 did gyre and gimble: For publishing APIs: /* Returns a negative error code if the extra api is already registered. */ int pa_extra_api_register(const char *name, void *api); void pa_extra_api_unregister(const_char *name); For consuming

Re: [pulseaudio-discuss] underrun behavior with alsa-plugins

2011-04-20 Thread Maarten Lankhorst
Hi David, Op 20-04-11 09:33, David Henningsson schreef: On 2011-04-19 18:12, Maarten Lankhorst wrote: Hi all, For wine I was investigating a bug with pulseaudio, it seems alsa-plugins' pulse driver ignores underruns. Hmm, doesn't wine come with a native pulse driver these days? Nope, but

Re: [pulseaudio-discuss] [PATCH v2] call-state-tracker: New component.

2011-04-20 Thread Tanu Kaskinen
On Wed, 2011-04-20 at 11:36 +0300, Colin Guthrie wrote: The api object header could be located in src/extra_apis - that would make the api not directly dependent on a particular module. If the API is not dependant on a particular module, what code calls pa_extra_api_register? I'd be

[pulseaudio-discuss] [PATCH] match: don't double free in case of missing table file

2011-04-20 Thread Tanu Kaskinen
From: Marc-André Lureau marcandre.lur...@gmail.com --- src/modules/module-match.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/modules/module-match.c b/src/modules/module-match.c index c8f2706..3eba149 100644 --- a/src/modules/module-match.c +++

Re: [pulseaudio-discuss] [PATCH] match: don't double free in case of missing table file

2011-04-20 Thread Colin Guthrie
'Twas brillig, and Tanu Kaskinen at 20/04/11 12:49 did gyre and gimble: From: Marc-André Lureau marcandre.lur...@gmail.com Thanks in my tree now. Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source:

Re: [pulseaudio-discuss] [PATCH v2] call-state-tracker: New component.

2011-04-20 Thread Colin Guthrie
'Twas brillig, and Tanu Kaskinen at 20/04/11 11:54 did gyre and gimble: On Wed, 2011-04-20 at 11:36 +0300, Colin Guthrie wrote: The api object header could be located in src/extra_apis - that would make the api not directly dependent on a particular module. If the API is not dependant on a

[pulseaudio-discuss] [PATCH] match: match rule earlier, in SINK_INPUT_NEW

2011-04-20 Thread Tanu Kaskinen
From: Marc-André Lureau marcandre.lur...@gmail.com --- src/modules/module-match.c | 35 +-- 1 files changed, 13 insertions(+), 22 deletions(-) diff --git a/src/modules/module-match.c b/src/modules/module-match.c index 3eba149..b3316d4 100644 ---

Re: [pulseaudio-discuss] [PATCH v2] call-state-tracker: New component.

2011-04-20 Thread Tanu Kaskinen
On Wed, 2011-04-20 at 15:19 +0300, Colin Guthrie wrote: OK, so the manager object is separate but kept in the core? Seems fine by me to keep things neatly separated. Yep. I thinking of taking a pop at this at some point soon (if you don't beat me to it), so can we decide on the name now?

[pulseaudio-discuss] [PATCH] core: Drop empty gaps in the memblockq when playing data from it.

2011-04-20 Thread Antti-Ville Jansson
It's possible that the memblockq of a sink input is rewound to a negative read index if the sink input is moved between sinks shortly after its creation. When this happens, pa_memblockq_peek() returns a memchunk whose 'memblock' field is NULL and whose 'length' field indicates the length of the

Re: [pulseaudio-discuss] underrun behavior with alsa-plugins

2011-04-20 Thread David Henningsson
On 2011-04-20 12:09, Maarten Lankhorst wrote: Hi David, Op 20-04-11 09:33, David Henningsson schreef: On 2011-04-19 18:12, Maarten Lankhorst wrote: Hi all, For wine I was investigating a bug with pulseaudio, it seems alsa-plugins' pulse driver ignores underruns. Hmm, doesn't wine come with

Re: [pulseaudio-discuss] [PATCH] core: Drop empty gaps in the memblockq when playing data from it.

2011-04-20 Thread Antti-Ville Jansson
The assert that this patch fixes can be reproduced with e.g. the following script: SAMPLE_PATH=/usr/share/sounds/alsa/ SAMPLE=Front_Left pactl remove-sample $SAMPLE 2 /dev/null pactl upload-sample $SAMPLE_PATH$SAMPLE.wav mod1=`pactl load-module module-null-sink sink_name=null1` mod2=`pactl

Re: [pulseaudio-discuss] [PATCH] core: Drop empty gaps in the memblockq when playing data from it.

2011-04-20 Thread Colin Guthrie
'Twas brillig, and Antti-Ville Jansson at 20/04/11 14:00 did gyre and gimble: The assert that this patch fixes can be reproduced with e.g. the following script: SAMPLE_PATH=/usr/share/sounds/alsa/ SAMPLE=Front_Left pactl remove-sample $SAMPLE 2 /dev/null pactl upload-sample

Re: [pulseaudio-discuss] [PATCH] match: match rule earlier, in SINK_INPUT_NEW

2011-04-20 Thread Colin Guthrie
Seems reasonable. In my tree now. Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/] Open Source: Mageia Contributor [http://www.mageia.org/] PulseAudio Hacker [http://www.pulseaudio.org/] Trac Hacker

Re: [pulseaudio-discuss] underrun behavior with alsa-plugins

2011-04-20 Thread Maarten Lankhorst
Hey, Op 20-04-11 15:18, David Henningsson schreef: However if I force underruns to occur,the state will stay running and it appears there is still some data left in the buffer, so sound stalls entirely. This is nothing I've heard of. Sadly all too common here, if I feed data and it

Re: [pulseaudio-discuss] review+pull-request: Passthrough support

2011-04-20 Thread Kelly Anderson
On 04/19/2011 02:03 PM, pl bossart wrote: I finally managed to figure out why eac3 wouldn't work in passthrough mode. Apparently my HDMI receiver will only lock on eac3 data if the AES0 control is set to 0x06 (non-audio, ie iec61937). ffmpeg -acodec copy -i csi_miami_5.1_256_spx.eac3 -f spdif

Re: [pulseaudio-discuss] review+pull-request: Passthrough support

2011-04-20 Thread pl bossart
So far I haven't been able to get anything except stereo working with passthrough.  It seems to me that selecting multiple channels in passthrough mode would be very similar to the necessary AES0 changes, so maybe we can get that fixed too. I've basically hit a wall by only being able to

Re: [pulseaudio-discuss] review+pull-request: Passthrough support

2011-04-20 Thread Arun Raghavan
On Tue, 2011-04-19 at 15:03 -0500, pl bossart wrote: I finally managed to figure out why eac3 wouldn't work in passthrough mode. Apparently my HDMI receiver will only lock on eac3 data if the AES0 control is set to 0x06 (non-audio, ie iec61937). ffmpeg -acodec copy -i

[pulseaudio-discuss] glib functions on PA

2011-04-20 Thread Margarita Olaya
Hi, The initial implementation of jack detection is using threads and simple file operations like open, close and read currently I'm looking into using pa_threads and glib functions. First step It is simple enough e.g change threads by pa_threads and for file operations I have u-fd =

Re: [pulseaudio-discuss] glib functions on PA

2011-04-20 Thread Arun Raghavan
On Wed, 2011-04-20 at 23:26 -0500, Margarita Olaya wrote: Hi, The initial implementation of jack detection is using threads and simple file operations like open, close and read currently I'm looking into using pa_threads and glib functions. First step It is simple enough e.g change threads

Re: [pulseaudio-discuss] glib functions on PA

2011-04-20 Thread Arun Raghavan
On Thu, 2011-04-21 at 10:13 +0530, Arun Raghavan wrote: On Wed, 2011-04-20 at 23:26 -0500, Margarita Olaya wrote: Hi, The initial implementation of jack detection is using threads and simple file operations like open, close and read currently I'm looking into using pa_threads and glib

Re: [pulseaudio-discuss] RFC: Filter module loader

2011-04-20 Thread Tanu Kaskinen
On Fri, 2011-04-15 at 20:55 +0200, Colin Guthrie wrote: Also, I had to apply this patch to equalizer-sink to prevent it from crashing the server on unload: diff --git a/src/modules/module-equalizer-sink.c b/src/modules/module-equalizer-sink.c index 0bbb23a..611f7dd 100644 ---

[pulseaudio-discuss] [PATCH] protocol-dbus: Fix some memory management bugs.

2011-04-20 Thread Tanu Kaskinen
There were several memory leaks. In addition to those, pa_dbus_protocol_add_interface() used a string from the caller as a key to a hashmap, instead of a copy of the string. This caused trouble when the caller freed the string while the key was still in use in the hashmap. ---

Re: [pulseaudio-discuss] glib functions on PA

2011-04-20 Thread Tanu Kaskinen
On Thu, 2011-04-21 at 10:13 +0530, Arun Raghavan wrote: On Wed, 2011-04-20 at 23:26 -0500, Margarita Olaya wrote: Hi, The initial implementation of jack detection is using threads and simple file operations like open, close and read currently I'm looking into using pa_threads and glib