'Twas brillig, and Maarten Bosmans at 13/01/11 10:17 did gyre and gimble:
> The change I would like to see reviewed, before merging are the read,
> write => pa_read, pa_write changes in fdsem.c
> https://github.com/mkbosmans/pulseaudio/commit/a02aad4471a07d862cdafc11a06b46c8b54aff55#diff-2
> This i
'Twas brillig, and Maarten Bosmans at 13/01/11 10:17 did gyre and gimble:
> 2011/1/11 Colin Guthrie :
>> 'Twas brillig, and Maarten Bosmans at 11/01/11 10:51 did gyre and gimble:
>>> I'll prepare a new patch series with all your points adressed.
>>
>> Sweet. Feel free to supply a remote from which
2011/1/11 Colin Guthrie :
> 'Twas brillig, and Maarten Bosmans at 11/01/11 10:51 did gyre and gimble:
>> I'll prepare a new patch series with all your points adressed.
>
> Sweet. Feel free to supply a remote from which I can pull if it's easier
> (doesn't matter much to me).
I've opened a GitHub a
'Twas brillig, and Maarten Bosmans at 11/01/11 10:51 did gyre and gimble:
> I'll prepare a new patch series with all your points adressed.
Sweet. Feel free to supply a remote from which I can pull if it's easier
(doesn't matter much to me).
I'm not 100% sure of setenv vs putenv but both appear to
2011/1/11 Colin Guthrie :
>> void pa_set_env(const char *key, const char *value) {
>> pa_assert(key);
>> pa_assert(value);
>>
>> /* This is not thread-safe */
>>
>> putenv(pa_sprintf_malloc("%s=%s", key, value));
>> }
>
> Hmm, that looks wrong too on first glance, but with a little
'Twas brillig, and Maarten Bosmans at 11/01/11 06:16 did gyre and gimble:
> Thanks for the review
>
> 2011/1/11 Colin Guthrie :
>> 'Twas brillig, and Maarten Bosmans at 06/01/11 01:39 did gyre and gimble:
>>> @@ -2565,7 +2569,11 @@ void pa_unset_env_recorded(void) {
>>> if (!s)
>>>
Thanks for the review
2011/1/11 Colin Guthrie :
> 'Twas brillig, and Maarten Bosmans at 06/01/11 01:39 did gyre and gimble:
>> @@ -2565,7 +2569,11 @@ void pa_unset_env_recorded(void) {
>> if (!s)
>> break;
>>
>> +#ifdef OS_IS_WIN32
>> + putenv(pa_sprintf_malloc("%s=",
'Twas brillig, and Maarten Bosmans at 06/01/11 01:39 did gyre and gimble:
> @@ -2565,7 +2569,11 @@ void pa_unset_env_recorded(void) {
> if (!s)
> break;
>
> +#ifdef OS_IS_WIN32
> +putenv(pa_sprintf_malloc("%s=", s));
> +#else
> unsetenv(s);
> +#endif
>
And disable building binaries for win32 that make no sense
---
src/Makefile.am | 22 --
src/pulsecore/authkey.c |2 +-
src/pulsecore/core-util.c | 26 ++
3 files changed, 43 insertions(+), 7 deletions(-)
diff --git a/src/Makefile.am
