On Sat, 2010-10-16 at 12:34 +0100, Colin Guthrie wrote:
'Twas brillig, and Tanu Kaskinen at 15/10/10 11:30 did gyre and gimble:
On Fri, 2010-10-15 at 13:00 +0300, Jyri Sarha wrote:
@@ -1459,7 +1493,8 @@ void pa_sink_set_volume(
* apply one to s-soft_volume */
'Twas brillig, and Tanu Kaskinen at 15/10/10 17:15 did gyre and gimble:
On Fri, 2010-10-15 at 16:45 +0100, Colin Guthrie wrote:
Yep, fixed. (I think I already fixed that, but maybe I just thought I did.)
You did fix this, but you apparently didn't apply the fix to the
upstream version of the
'Twas brillig, and Tanu Kaskinen at 15/10/10 11:30 did gyre and gimble:
On Fri, 2010-10-15 at 13:00 +0300, Jyri Sarha wrote:
@@ -1459,7 +1493,8 @@ void pa_sink_set_volume(
* apply one to s-soft_volume */
pa_cvolume_reset(s-soft_volume, s-sample_spec.channels);
-
Hi,
Review below:
'Twas brillig, and o...@iki.fi at 13/10/10 17:40 did gyre and gimble:
+PA_SINK_SYNC_VOLUME = 0x0200U,
+/** The HW volume changes are syncronized with SW volume.
+ * \since X.X.XX */
+
} pa_sink_flags_t;
Can you put 0.9.22 here? If needed I'll do a global
On Fri, 2010-10-15 at 13:00 +0300, Jyri Sarha wrote:
@@ -1459,7 +1493,8 @@ void pa_sink_set_volume(
* apply one to s-soft_volume */
pa_cvolume_reset(s-soft_volume, s-sample_spec.channels);
-s-set_volume(s);
+if (!(s-flags PA_SINK_SYNC_VOLUME))
+
'Twas brillig, and Tanu Kaskinen at 15/10/10 11:30 did gyre and gimble:
I'll offer virtual beer to one
who can explain why the code still works :).
In your test case (changing sink input volume) send_msg is TRUE. Thanks
for the virtual beer :)
I was just going to say perhaps send_msg ==
On Fri, 2010-10-15 at 16:45 +0100, Colin Guthrie wrote:
Yep, fixed. (I think I already fixed that, but maybe I just thought I did.)
You did fix this, but you apparently didn't apply the fix to the
upstream version of the patches - hopefully you didn't forget any other
fixes (I checked,
Hi,
Review below:
'Twas brillig, and o...@iki.fi at 13/10/10 17:40 did gyre and gimble:
+PA_SINK_SYNC_VOLUME = 0x0200U,
+/** The HW volume changes are syncronized with SW volume.
+ * \since X.X.XX */
+
} pa_sink_flags_t;
Can you put 0.9.22 here? If needed I'll do a global
From: Jyri Sarha jyri.sa...@nokia.com
To make concurrent use of SW and HW volume glitchles their application
needs to be synchronized. For accurate synchronization the HW volume
needs to be applied in IO thread. This patch adds infrastructure to
delay the applying of HW volume to match with SW
