Re: [pulseaudio-discuss] [PATCH 2/2] Move compile-time checks around pa_run_from_build_tree to core-util

2011-03-24 Thread Arun Raghavan
On Tue, 2011-03-22 at 16:06 +0100, Maarten Bosmans wrote: Is there a better way than #if defined(__linux__) !defined(__OPTIMIZE__) to check for a debug build? By default the CFLAGS contain -g -O2, so __OPTIMIZE__ will not be defined and running uninstalled does not work. Lennart might be

Re: [pulseaudio-discuss] [PATCH 2/2] Move compile-time checks around pa_run_from_build_tree to core-util

2011-03-24 Thread Colin Guthrie
'Twas brillig, and Maarten Bosmans at 22/03/11 15:06 did gyre and gimble: Is there a better way than #if defined(__linux__) !defined(__OPTIMIZE__) to check for a debug build? By default the CFLAGS contain -g -O2, so __OPTIMIZE__ will not be defined and running uninstalled does not work. Do

Re: [pulseaudio-discuss] [PATCH 2/2] Move compile-time checks around pa_run_from_build_tree to core-util

2011-03-24 Thread Colin Guthrie
'Twas brillig, and Maarten Bosmans at 22/03/11 15:02 did gyre and gimble: To make the code cleaner and have the checks all in one place. In my tree now. Thanks Col -- Colin Guthrie gmane(at)colin.guthr.ie http://colin.guthr.ie/ Day Job: Tribalogic Limited [http://www.tribalogic.net/]

Re: [pulseaudio-discuss] [PATCH 2/2] Move compile-time checks around pa_run_from_build_tree to core-util

2011-03-24 Thread Colin Guthrie
'Twas brillig, and Colin Guthrie at 24/03/11 09:02 did gyre and gimble: 'Twas brillig, and Maarten Bosmans at 22/03/11 15:06 did gyre and gimble: Is there a better way than #if defined(__linux__) !defined(__OPTIMIZE__) to check for a debug build? By default the CFLAGS contain -g -O2, so

Re: [pulseaudio-discuss] [PATCH 2/2] Move compile-time checks around pa_run_from_build_tree to core-util

2011-03-24 Thread Maarten Bosmans
2011/3/24 Colin Guthrie gm...@colin.guthr.ie: 'Twas brillig, and Colin Guthrie at 24/03/11 09:02 did gyre and gimble: 'Twas brillig, and Maarten Bosmans at 22/03/11 15:06 did gyre and gimble: Is there a better way than #if defined(__linux__) !defined(__OPTIMIZE__) to check for a debug build?

Re: [pulseaudio-discuss] [PATCH 2/2] Move compile-time checks around pa_run_from_build_tree to core-util

2011-03-24 Thread Arun Raghavan
On Thu, 2011-03-24 at 11:46 +0100, Maarten Bosmans wrote: [...] I think only compiling that on developer builds and inlining return FALSE for normal, e.g. distro builds makes sense. However __OPTIMIZE__ is not a good differentiator here. The callers all seem to be initialisation routines only,

Re: [pulseaudio-discuss] [PATCH 2/2] Move compile-time checks around pa_run_from_build_tree to core-util

2011-03-24 Thread Colin Guthrie
'Twas brillig, and Arun Raghavan at 24/03/11 11:04 did gyre and gimble: On Thu, 2011-03-24 at 11:46 +0100, Maarten Bosmans wrote: [...] I think only compiling that on developer builds and inlining return FALSE for normal, e.g. distro builds makes sense. However __OPTIMIZE__ is not a good

[pulseaudio-discuss] [PATCH 2/2] Move compile-time checks around pa_run_from_build_tree to core-util

2011-03-23 Thread Maarten Bosmans
To make the code cleaner and have the checks all in one place. --- src/daemon/daemon-conf.c | 11 +-- src/modules/alsa/alsa-mixer.c | 12 src/pulsecore/core-util.c |3 --- src/pulsecore/core-util.h |5 + 4 files changed, 10 insertions(+), 21

Re: [pulseaudio-discuss] [PATCH 2/2] Move compile-time checks around pa_run_from_build_tree to core-util

2011-03-23 Thread Maarten Bosmans
Is there a better way than #if defined(__linux__) !defined(__OPTIMIZE__) to check for a debug build? By default the CFLAGS contain -g -O2, so __OPTIMIZE__ will not be defined and running uninstalled does not work. Maarten ___ pulseaudio-discuss mailing