Re: [pulseaudio-discuss] [RFC] Allow read-only or non-existing sink input volume.

2011-02-28 Thread Colin Guthrie
'Twas brillig, and Tanu Kaskinen at 27/02/11 14:28 did gyre and gimble: On Sun, 2011-02-27 at 14:06 +, Colin Guthrie wrote: 'Twas brillig, and Tanu Kaskinen at 27/02/11 12:35 did gyre and gimble: I actually have started to feel that volume_readable and volume_writable would be better than

Re: [pulseaudio-discuss] [RFC] Allow read-only or non-existing sink input volume.

2011-02-27 Thread Tanu Kaskinen
On Wed, 2011-02-23 at 08:28 +0200, Tanu Kaskinen wrote: On Tue, 2011-02-22 at 21:25 +, Colin Guthrie wrote: 'Twas brillig, and Tanu Kaskinen at 22/02/11 16:35 did gyre and gimble: It would be nice if someone would test this with passthrough streams also, but personally I think it

Re: [pulseaudio-discuss] [RFC] Allow read-only or non-existing sink input volume.

2011-02-27 Thread Colin Guthrie
'Twas brillig, and Tanu Kaskinen at 27/02/11 12:35 did gyre and gimble: I actually have started to feel that volume_readable and volume_writable would be better than has_volume and read_only_volume in pa_sink_input_info. What are others' opinions? One argument for readable/writable is that

Re: [pulseaudio-discuss] [RFC] Allow read-only or non-existing sink input volume.

2011-02-27 Thread Tanu Kaskinen
On Sun, 2011-02-27 at 14:06 +, Colin Guthrie wrote: 'Twas brillig, and Tanu Kaskinen at 27/02/11 12:35 did gyre and gimble: I actually have started to feel that volume_readable and volume_writable would be better than has_volume and read_only_volume in pa_sink_input_info. What are

Re: [pulseaudio-discuss] [RFC] Allow read-only or non-existing sink input volume.

2011-02-27 Thread Maarten Bosmans
2011/2/27 Colin Guthrie gm...@colin.guthr.ie: 'Twas brillig, and Tanu Kaskinen at 27/02/11 12:35 did gyre and gimble: I actually have started to feel that volume_readable and volume_writable would be better than has_volume and read_only_volume in pa_sink_input_info. What are others' opinions?

Re: [pulseaudio-discuss] [RFC] Allow read-only or non-existing sink input volume.

2011-02-22 Thread Tanu Kaskinen
On Mon, 2011-02-14 at 13:41 +0200, Kaskinen Tanu wrote: There are two known cases where read-only or non-existing sink input volume is relevant: passthrough streams and the planned volume sharing logic. Passthrough streams don't have volume at all, and the volume sharing logic requires

Re: [pulseaudio-discuss] [RFC] Allow read-only or non-existing sink input volume.

2011-02-22 Thread Colin Guthrie
'Twas brillig, and Tanu Kaskinen at 22/02/11 16:35 did gyre and gimble: It would be nice if someone would test this with passthrough streams also, but personally I think it would be ok to commit this patch to master now. OK, I've applied this to master in my tree now after giving it a bit of a

Re: [pulseaudio-discuss] [RFC] Allow read-only or non-existing sink input volume.

2011-02-22 Thread Tanu Kaskinen
On Tue, 2011-02-22 at 21:25 +, Colin Guthrie wrote: 'Twas brillig, and Tanu Kaskinen at 22/02/11 16:35 did gyre and gimble: It would be nice if someone would test this with passthrough streams also, but personally I think it would be ok to commit this patch to master now. OK, I've

[pulseaudio-discuss] [RFC] Allow read-only or non-existing sink input volume.

2011-02-14 Thread Tanu Kaskinen
There are two known cases where read-only or non-existing sink input volume is relevant: passthrough streams and the planned volume sharing logic. Passthrough streams don't have volume at all, and the volume sharing logic requires read-only sink input volume. This commit is primarily working