Re: [pulseaudio-discuss] [RFC - MP3 passthrough over A2DP 2/2] mp3 passthrough: Bluetooth changes

2010-10-06 Thread pl bossart
Thanks Tanu for your review. Here are some replies on the comments not related to formatting. There's a nice idea on passing frame-aligned data in memchunks that looks interesting, this is valuable feedback. -Pierre +    uint64_t s_read_index, s_write_index; /* count in samples instead of

Re: [pulseaudio-discuss] [RFC - MP3 passthrough over A2DP 2/2] mp3 passthrough: Bluetooth changes

2010-10-05 Thread Tanu Kaskinen
Hi, Patch review below: On Tue, 2010-09-21 at 18:00 -0500, bossart.nos...@gmail.com wrote: From: Pierre-Louis Bossart pierre-louis.boss...@intel.com Signed-off-by: Pierre-Louis Bossart pierre-louis.boss...@intel.com diff --git a/src/modules/bluetooth/module-bluetooth-device.c

[pulseaudio-discuss] [RFC - MP3 passthrough over A2DP 2/2] mp3 passthrough: Bluetooth changes

2010-09-22 Thread bossart . nospam
From: Pierre-Louis Bossart pierre-louis.boss...@intel.com Signed-off-by: Pierre-Louis Bossart pierre-louis.boss...@intel.com diff --git a/src/modules/bluetooth/module-bluetooth-device.c b/src/modules/bluetooth/module-bluetooth-device.c index 61fe369..d12c4e3 100644 ---