Hi Paul,
On Wed, 2011-02-23 at 01:07 +0530, Arun Raghavan wrote:
[...]
The correct fix for this, imo, is in bluez (there is a new
sbc_primitives_armv6.h that can probably be used at least as a
template). We need to do an sbc-udpate on the PA side anyway, and can
pull this when we do.
Could
Since Maarten's declared war on warnings, thought I'd pitch in with a
couple of fixes too. :) The first one is a boo-boo from my Orc work, and
the second might be contentious to some (but is right imho).
Cheers,
Arun
___
pulseaudio-discuss mailing list
---
src/daemon/main.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/daemon/main.c b/src/daemon/main.c
index 533c4c3..f7aed51 100644
--- a/src/daemon/main.c
+++ b/src/daemon/main.c
@@ -95,6 +95,7 @@
#endif
#include pulsecore/cpu-arm.h
#include pulsecore/cpu-x86.h
While it seems to be common practice to just work around the cast to
integer and assume alignment is fine, let's play it safe and do it right
by memcpy'ing.
---
src/modules/bluetooth/ipc.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/modules/bluetooth/ipc.c
Here are the last (relatively) easy fixes for compiler warnings.
[PATCH 1/2] Get rid of some warnings: -Wunused-result
[PATCH 2/2] Get rid of some warnings: -Wunsafe-loop-optimizations
The war is not over yet, my friends. Prepare for the final battle and we shall
be victorious!
Maarten
modules/module-default-device-restore.c: In function ‘load’:
modules/module-default-device-restore.c:67: warning: ignoring return value of
‘fgets’,
declared with attribute warn_unused_result [-Wunused-result]
modules/module-default-device-restore.c:88: warning: ignoring return value of
‘fgets’,
pulsecore/core-util.c: In function ‘pa_hexstr’:
pulsecore/core-util.c:1858: warning: cannot optimize loop, the loop counter may
overflow [-Wunsafe-loop-optimizations]
modules/alsa/alsa-mixer.c: In function ‘pa_alsa_decibel_fix_dump’:
modules/alsa/alsa-mixer.c:3678: warning: cannot optimize
Can this go in fast? as it's annoying to have to patch this every time myself.
Maarten
2011/3/19 Arun Raghavan arun.ragha...@collabora.co.uk:
---
src/daemon/main.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/daemon/main.c b/src/daemon/main.c
index
Mostly warnings about unused stuff.
Furthermore, the first hunk is a fix for the change in 177948a6.
Finally, comment in AEC_dtd was translated and the code simplified slightly.
CC module_bluetooth_device_la-module-bluetooth-device.lo
modules/bluetooth/module-bluetooth-device.c: In function
With this and other patches floating on the list we're down to three warnings:
(this is with gcc 4.6.0, with 4.4.4 - which is standard on ubuntu
10.10 - I got more bogus warnings)
CC libpulsecommon_1.0_la-ipacl.lo
pulsecore/ipacl.c: In function ‘pa_ip_acl_check’:
pulsecore/ipacl.c:238:20:
With the approaching switch to freedesktop.org infrastructure, only
pulseaudio and and pavucontrol are going to be migrated, if I
understand it correctly. Of the other utils, paman and padevchooser
were already deprecated for several years. (I have closed all the
tickets as wontfix, to emphasize
On 03/16/11 10:48, Arun Raghavan wrote:
On Wed, 2011-03-16 at 11:19 +0530, Arun Raghavan wrote:
[...]
It will work, but not with paplay, only with the extended API when you
create a non-PCM stream. I will rationalise the check for passthrough
sink inputs in a bit, but for now, could you change
12 matches
Mail list logo
