Re: [pulseaudio-discuss] [PATCH 0/5] HW and SW volume syncronization in IO-thread

2010-10-14 Thread David Henningsson
On 2010-10-13 18:40, o...@iki.fi wrote: From: Jyri Sarhajyri.sa...@nokia.com The first patch in the set gives sink implementor a possibility to synchronize HW and SW volume usage in IO-thread. The remaining patches implement the synchronization for the alsa-sink and add the necessary module

[pulseaudio-discuss] Wanted: native English speakers for review: [PATCH 5/5] man: sync_volume parameters to manual page

2010-10-14 Thread Paul Menzel
Am Mittwoch, den 13.10.2010, 19:40 +0300 schrieb o...@iki.fi: From: Jyri Sarha jyri.sa...@nokia.com Signed-off-by: Jyri Sarha jyri.sa...@nokia.com Reviewed-by: Tanu Kaskinen tanu.kaski...@digia.com It would be great if some native English speakers could take a look at the following

Re: [pulseaudio-discuss] Wanted: native English speakers for review: [PATCH 5/5] man: sync_volume parameters to manual page

2010-10-14 Thread PETER ONION
--- On Thu, 14/10/10, Paul Menzel paulepan...@users.sourceforge.net wrote: The amount *of* usesc The number of usecs would be better. PeterO ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de

Re: [pulseaudio-discuss] [PATCH] AC3 passthrough support

2010-10-14 Thread Joakim Plate
To use this feature from other frameworks (gstreamer, etc), we will need a tagged release to #ifdef code related to AC3 passthough for backwards compatibility. Any idea when that might happen? (would also be nice to close the gap between git master and meego versions while we are at

Re: [pulseaudio-discuss] [PATCH 0/5] HW and SW volume syncronization in IO-thread

2010-10-14 Thread Jyri Sarha
On 2010-10-13 18:40, o...@iki.fi wrote: From: Jyri Sarhajyri.sa...@nokia.com ... Thank you for your work! This is the main reason I've been advocating against enabling flat-volumes by default in Ubuntu, so I'm glad to see something that addresses the issue. The basic problem is that we

Re: [pulseaudio-discuss] [PATCH 0/5] HW and SW volume syncronization in IO-thread

2010-10-14 Thread Jyri Sarha
On 2010-10-13 18:40, o...@iki.fi wrote: From: Jyri Sarhajyri.sa...@nokia.com ... ...rather than trying to add explicit delays just for the volume sync. Either that, or some kind of volume ramping. Just curious if you considered that solution as well? Ah, only after reading my reply from

Re: [pulseaudio-discuss] [PATCH 0/5] HW and SW volume syncronization in IO-thread

2010-10-14 Thread Jyri Sarha
On 2010-10-13 18:40, o...@iki.fi wrote: From: Jyri Sarhajyri.sa...@nokia.com ... Thank you for your work! This is the main reason I've been advocating against enabling flat-volumes by default in Ubuntu, so I'm glad to see something that addresses the issue. The basic problem is that we

Re: [pulseaudio-discuss] [PATCH 0/5] HW and SW volume syncronization in IO-thread

2010-10-14 Thread Jyri Sarha
On 2010-10-13 18:40, o...@iki.fi wrote: From: Jyri Sarhajyri.sa...@nokia.com ... ...rather than trying to add explicit delays just for the volume sync. Either that, or some kind of volume ramping. Just curious if you considered that solution as well? Ah, only after reading my reply from

Re: [pulseaudio-discuss] [PATCH] AC3 passthrough support

2010-10-14 Thread pl bossart
To use this feature from other frameworks (gstreamer, etc), we will need a tagged release to #ifdef code related to AC3 passthough for backwards compatibility. Any idea when that might happen? (would also be nice to close the gap between git master and meego versions while we are at

Re: [pulseaudio-discuss] [RFC - MP3 passthrough over A2DP 1/2] mp3 passthrough: core changes

2010-10-14 Thread Joakim Plate
Hi There's no real way you can extract timing information just by looking at the data. You either need to parse the frames (what I did for the BT work) or let the hardware report the number of samples it decoded and rendered. In both cases, you could find out what the average bit rate is

Re: [pulseaudio-discuss] [PATCH] AC3 passthrough support

2010-10-14 Thread Colin Guthrie
'Twas brillig, and Joakim Plate at 14/10/10 13:40 did gyre and gimble: To use this feature from other frameworks (gstreamer, etc), we will need a tagged release to #ifdef code related to AC3 passthough for backwards compatibility. Any idea when that might happen? (would also be nice to close

Re: [pulseaudio-discuss] Wanted: native English speakers for review: [PATCH 5/5] man: sync_volume parameters to manual page

2010-10-14 Thread Colin Guthrie
'Twas brillig, and PETER ONION at 14/10/10 12:42 did gyre and gimble: --- On Thu, 14/10/10, Paul Menzel paulepan...@users.sourceforge.net wrote: The amount *of* usesc The number of usecs would be better. I've tweaked the wording in my local application of this patch. I went for The

Re: [pulseaudio-discuss] [PATCH 1/5] core: Add infrastructure for synchronizing HW and SW volume changes

2010-10-14 Thread Colin Guthrie
Hi, Review below: 'Twas brillig, and o...@iki.fi at 13/10/10 17:40 did gyre and gimble: +PA_SINK_SYNC_VOLUME = 0x0200U, +/** The HW volume changes are syncronized with SW volume. + * \since X.X.XX */ + } pa_sink_flags_t; Can you put 0.9.22 here? If needed I'll do a global

Re: [pulseaudio-discuss] [PATCH 2/5] alsa: Take syncronized HW volume infra into use for alsa-sink

2010-10-14 Thread Colin Guthrie
Hi, Review below: 'Twas brillig, and o...@iki.fi at 13/10/10 17:40 did gyre and gimble: diff --git a/src/modules/alsa/alsa-sink.c b/src/modules/alsa/alsa-sink.c index 1108a79..ada5da9 100644 --- a/src/modules/alsa/alsa-sink.c +++ b/src/modules/alsa/alsa-sink.c @@ -1651,8 +1713,15 @@ static

Re: [pulseaudio-discuss] [PATCH 4/5] daemon-conf: Add sync volume parameters to daemon-conf

2010-10-14 Thread Colin Guthrie
'Twas brillig, and o...@iki.fi at 13/10/10 17:40 did gyre and gimble: From: Jyri Sarha jyri.sa...@nokia.com Signed-off-by: Jyri Sarha jyri.sa...@nokia.com Reviewed-by: Tanu Kaskinen tanu.kaski...@digia.com Reviewd-by: Colin Guthrie cguth...@mandriva.org -- Colin Guthrie

Re: [pulseaudio-discuss] [PATCH 3/5] udev-detect: Add sync_volume parameter

2010-10-14 Thread Colin Guthrie
'Twas brillig, and o...@iki.fi at 13/10/10 17:40 did gyre and gimble: From: Jyri Sarha jyri.sa...@nokia.com Signed-off-by: Jyri Sarha jyri.sa...@nokia.com Reviewed-by: Tanu Kaskinen tanu.kaski...@digia.com Reviewed-by: Colin Guthrie cguth...@mandriva.org -- Colin Guthrie

Re: [pulseaudio-discuss] [PATCH 5/5] man: sync_volume parameters to manual page

2010-10-14 Thread Colin Guthrie
'Twas brillig, and o...@iki.fi at 13/10/10 17:40 did gyre and gimble: From: Jyri Sarha jyri.sa...@nokia.com Signed-off-by: Jyri Sarha jyri.sa...@nokia.com Reviewed-by: Tanu Kaskinen tanu.kaski...@digia.com Please find attached a revised version of this patch... not sure if this is the best

Re: [pulseaudio-discuss] [RFC - MP3 passthrough over A2DP 1/2] mp3 passthrough: core changes

2010-10-14 Thread pl bossart
There's no real way you can extract timing information just by looking at the data. You either need to parse the frames (what I did for the BT work) or  let the hardware report the number of samples it decoded and rendered. In both cases, you could find out what the average bit rate is and

[pulseaudio-discuss] [PATCH] Explicitly link against pulse libraries

2010-10-14 Thread Luke Yelavich
From: Luke Yelavich luke.yelav...@canonical.com When building pulseaudio master using gcc 4.5.2 and binutils 2.20.51 plus latest snapshot from 2010-10-14, ld complained about missing symbols. This patch explicitly links more pulseaudio libraries to satisfy the linker. Signed-off-by: Luke

[pulseaudio-discuss] [PATCH] Explicitly link against pulse libraries

2010-10-14 Thread Luke Yelavich
From: Luke Yelavich luke.yelav...@canonical.com When building pulseaudio stable-queue using gcc 4.5.2 and binutils 2.20.51 plus latest snapshot from 2010-10-14, ld complained about missing symbols. This patch explicitly links more pulseaudio libraries to satisfy the linker. Signed-off-by: Luke