[pulseaudio-discuss] [PATCH 2/7] alsa-mixer: Use decibel fixes when getting and setting decibel volumes.

2011-03-04 Thread Tanu Kaskinen
From: Tanu Kaskinen ext-tanu.kaski...@nokia.com --- src/modules/alsa/alsa-mixer.c | 263 src/modules/alsa/alsa-mixer.h |8 +- 2 files changed, 215 insertions(+), 56 deletions(-) diff --git a/src/modules/alsa/alsa-mixer.c b/src/modules/alsa/alsa

[pulseaudio-discuss] [PATCH 3/7] pacat: Fix memory leak when draining the context.

2011-03-04 Thread Tanu Kaskinen
--- src/utils/pacat.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/utils/pacat.c b/src/utils/pacat.c index 6cd01d2..749593e 100644 --- a/src/utils/pacat.c +++ b/src/utils/pacat.c @@ -105,6 +105,7 @@ static void context_drain_complete(pa_context*c, void

[pulseaudio-discuss] [PATCH 4/7] alsa-mixer: Add a default case for a switch, so that the compiler won't complain about unhandled cases.

2011-03-04 Thread Tanu Kaskinen
--- src/modules/alsa/alsa-mixer.c | 32 +--- 1 files changed, 17 insertions(+), 15 deletions(-) diff --git a/src/modules/alsa/alsa-mixer.c b/src/modules/alsa/alsa-mixer.c index f71dfc3..6fbd560 100644 --- a/src/modules/alsa/alsa-mixer.c +++

[pulseaudio-discuss] [PATCH 5/7] alsa-card: Print the profile set configuration when loading the card.

2011-03-04 Thread Tanu Kaskinen
--- src/modules/alsa/module-alsa-card.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/modules/alsa/module-alsa-card.c b/src/modules/alsa/module-alsa-card.c index 3f8576d..43340ae 100644 --- a/src/modules/alsa/module-alsa-card.c +++

[pulseaudio-discuss] [PATCH 6/7] dbusiface-stream: Fix crash when there's no resampling used.

2011-03-04 Thread Tanu Kaskinen
--- src/modules/dbus/iface-stream.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/modules/dbus/iface-stream.c b/src/modules/dbus/iface-stream.c index a9eb373..6b46fa9 100644 --- a/src/modules/dbus/iface-stream.c +++ b/src/modules/dbus/iface-stream.c @@ -490,6

[pulseaudio-discuss] [PATCH 7/7] dbus: Always accept mono volumes when setting device or stream volume.

2011-03-04 Thread Tanu Kaskinen
pa_sink_set_volume() and friends accept mono volumes too, so no need to impose unneeded restrictions in the D-Bus API. --- src/modules/dbus/iface-device.c |9 - src/modules/dbus/iface-stream.c |9 - 2 files changed, 8 insertions(+), 10 deletions(-) diff --git

Re: [pulseaudio-discuss] [PATCH 2/7] alsa-mixer: Use decibel fixes when getting and setting decibel volumes.

2011-03-04 Thread Tanu Kaskinen
On Fri, 2011-03-04 at 17:42 +0200, Tanu Kaskinen wrote: +pa_log(decibel_fix_get_step(): searching for the closest step of %0.2f dB, rounding %s, *db_value / 100.0, (rounding 0) ? up : down); +pa_log(decibel_fix_get_step(): selected step %li (%0.2f dB), i + db_fix-min_step

Re: [pulseaudio-discuss] [RFC] Alsa UCM integration.

2011-03-03 Thread Tanu Kaskinen
On Tue, 2011-03-01 at 15:20 +, Liam Girdwood wrote: On Mon, 2011-02-28 at 22:34 +0200, Tanu Kaskinen wrote: What if one card has two playback devices - one for handsfree and one for a headset - and I want to play a ringtone to both simultaneously? What if one card has two playback

Re: [pulseaudio-discuss] [RFC] Alsa UCM integration.

2011-03-03 Thread Tanu Kaskinen
On Wed, 2011-03-02 at 20:52 -0600, Margarita Olaya wrote: On Tue, Mar 1, 2011 at 9:20 AM, Liam Girdwood l...@slimlogic.co.uk wrote: On Mon, 2011-02-28 at 22:34 +0200, Tanu Kaskinen wrote: On Sun, 2011-02-27 at 22:53 -0600, Margarita Olaya wrote: Hi Tanu, On Sat, Feb 26, 2011 at 2:07

Re: [pulseaudio-discuss] [PATCH] introspect: Client-side implementation for has_volume/read_only_volume

2011-03-02 Thread Tanu Kaskinen
On Wed, 2011-03-02 at 11:20 +, Colin Guthrie wrote: 'Twas brillig, and Arun Raghavan at 01/03/11 20:08 did gyre and gimble: This completes the client-side changes to the protocol extension introduced by commit 99ddca89cdca9b0b92ab9870764f9211e6a82e31 Thanks both. Applied. Am I

Re: [pulseaudio-discuss] [PATCH] introspect: Client-side implementation for has_volume/read_only_volume

2011-03-01 Thread Tanu Kaskinen
On Wed, 2011-03-02 at 00:43 +0530, Arun Raghavan wrote: This completes the client-side changes to the protocol extension Thanks for fixing this! I forgot also incrementing PA_PROTOCOL_VERSION in my patch, so you should fix that too. introduced by commit

Re: [pulseaudio-discuss] Problems trying to connecf HFP device

2011-03-01 Thread Tanu Kaskinen
On Tue, 2011-03-01 at 18:01 +, Colin Guthrie wrote: I'm not sure why there would be such a big pause at the connection stage. Does the big pause only happen when the BT device is connected? e.g. if it's not connected, the connection is quick? Yep, only when the device is connected.

Re: [pulseaudio-discuss] MacOS X Support

2011-03-01 Thread Tanu Kaskinen
On Tue, 2011-03-01 at 16:57 -0500, Stephen Lee wrote: Sorry for following up on my own email, but am I missing something obvious and being completely dumb? :) No :) On Sun, Feb 27, 2011 at 9:34 AM, Stephen Lee sl33...@gmail.com wrote: I git clone'd master yesterday, successfully

Re: [pulseaudio-discuss] [PATCH 1/6] Implement the volume sharing feature.

2011-02-28 Thread Tanu Kaskinen
On Mon, 2011-02-28 at 13:38 +0200, Colin Guthrie wrote: Hiya, Some quick comments but these are to go on top rather than change this as I've already merged it :) 'Twas brillig, and Tanu Kaskinen at 24/02/11 14:16 did gyre and gimble: When we have a filter sink that does some processing

Re: [pulseaudio-discuss] [RFC] Alsa UCM integration.

2011-02-28 Thread Tanu Kaskinen
On Sun, 2011-02-27 at 22:53 -0600, Margarita Olaya wrote: Hi Tanu, On Sat, Feb 26, 2011 at 2:07 AM, Tanu Kaskinen ta...@iki.fi wrote: On Fri, 2011-02-25 at 14:09 -0600, Margarita Olaya wrote: Make sense. But I am not sure the profiles as defined today in PulseAudio can work

Re: [pulseaudio-discuss] [RFC] Passthrough support

2011-02-28 Thread Tanu Kaskinen
On Mon, 2011-02-28 at 16:48 -0800, Christ Schlacta wrote: On 2/27/2011 23:29, Arun Raghavan wrote: On Sun, 2011-02-27 at 23:20 -0800, Christ Schlacta wrote: [...] mark settings as optional or required for negotiation. if one or the other can't support an Optional parameter, then it gets

[pulseaudio-discuss] [PATCH] Add src/*-symdef.h to .gitignore.

2011-02-27 Thread Tanu Kaskinen
--- src/.gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/.gitignore b/src/.gitignore index c93974b..1380e26 100644 --- a/src/.gitignore +++ b/src/.gitignore @@ -66,3 +66,4 @@ voltest start-pulseaudio-x11 start-pulseaudio-kde vector-test +*-symdef.h --

Re: [pulseaudio-discuss] [PATCH 1/5] core: Add infrastructure for synchronizing HW and SW volume changes

2011-02-27 Thread Tanu Kaskinen
On Sat, 2010-10-16 at 12:34 +0100, Colin Guthrie wrote: 'Twas brillig, and Tanu Kaskinen at 15/10/10 11:30 did gyre and gimble: On Fri, 2010-10-15 at 13:00 +0300, Jyri Sarha wrote: @@ -1459,7 +1493,8 @@ void pa_sink_set_volume( * apply one to s-soft_volume

[pulseaudio-discuss] [PATCH] sink: Add casts to some printf arguments to get rid of compiler warnings.

2011-02-27 Thread Tanu Kaskinen
--- src/pulsecore/sink.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/pulsecore/sink.c b/src/pulsecore/sink.c index ba7e599..915ee0f 100644 --- a/src/pulsecore/sink.c +++ b/src/pulsecore/sink.c @@ -2941,11 +2941,11 @@ void

Re: [pulseaudio-discuss] [RFC] Allow read-only or non-existing sink input volume.

2011-02-27 Thread Tanu Kaskinen
On Wed, 2011-02-23 at 08:28 +0200, Tanu Kaskinen wrote: On Tue, 2011-02-22 at 21:25 +, Colin Guthrie wrote: 'Twas brillig, and Tanu Kaskinen at 22/02/11 16:35 did gyre and gimble: It would be nice if someone would test this with passthrough streams also, but personally I think

Re: [pulseaudio-discuss] [RFC] Allow read-only or non-existing sink input volume.

2011-02-27 Thread Tanu Kaskinen
On Sun, 2011-02-27 at 14:06 +, Colin Guthrie wrote: 'Twas brillig, and Tanu Kaskinen at 27/02/11 12:35 did gyre and gimble: I actually have started to feel that volume_readable and volume_writable would be better than has_volume and read_only_volume in pa_sink_input_info. What

Re: [pulseaudio-discuss] [PATCH] sink: Don't send unnecessary PA_SINK_MESSAGE_SET_VOLUME_SYNCED messages.

2011-02-27 Thread Tanu Kaskinen
On Sun, 2011-02-27 at 14:15 +, Colin Guthrie wrote: diff --git a/src/pulsecore/sink.c b/src/pulsecore/sink.c index d713be1..4da36f3 100644 --- a/src/pulsecore/sink.c +++ b/src/pulsecore/sink.c @@ -1705,8 +1705,6 @@ void pa_sink_set_volume( pa_cvolume_reset(root_sink-soft_volume,

[pulseaudio-discuss] [PATCH] alsa-mixer: Fix path set building when using the element-output or element-input mapping options in profile set configuration.

2011-02-25 Thread Tanu Kaskinen
When creating synthesized paths, pa_alsa_path_set_new() created duplicate elements for each path, and one of the duplicate elements would be marked as required absent. That made path probing fail. While debugging this, I noticed also that pa_alsa_path_synthesize() didn't initialize p-last_element

[pulseaudio-discuss] [PATCH] alsa-card: Add a new modarg profile_set for giving the card a custom profile set configuration file.

2011-02-25 Thread Tanu Kaskinen
--- src/modules/alsa/module-alsa-card.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/src/modules/alsa/module-alsa-card.c b/src/modules/alsa/module-alsa-card.c index ebd2f8a..3f8576d 100644 --- a/src/modules/alsa/module-alsa-card.c +++

Re: [pulseaudio-discuss] Virtual Sink Template (was Re: [PATCH 6/6] virtual-sink: Fix a crash when moving the sink to a new master right after setup.)

2011-02-25 Thread Tanu Kaskinen
On Fri, 2011-02-25 at 11:14 +, Colin Guthrie wrote: Forgive my ignorance of how the virtual-sink.c works (I've really not looked) but my (perhaps incorrect) understanding was that it is basically a code template rather than a real sink. Is this just a wrong grasp of the situation? Well,

[pulseaudio-discuss] [PATCH 0/6] Volume sharing

2011-02-24 Thread Tanu Kaskinen
I used for testing the new functionality. Tanu Kaskinen (6): Implement the volume sharing feature. virtual-sink: Add a modarg for enabling volume sharing. virtual-sink: Add a modarg for forcing flat volume. virtual-sink/source: Use a more descriptive stream name. virtual-sink/source

[pulseaudio-discuss] [PATCH 1/6] Implement the volume sharing feature.

2011-02-24 Thread Tanu Kaskinen
When we have a filter sink that does some processing, currently the benefits of the flat volume feature are not really available. That's because if you have a music player that is connected to the filter sink, the hardware sink doesn't have any idea of the music player's stream volume. This

[pulseaudio-discuss] [PATCH 2/6] virtual-sink: Add a modarg for enabling volume sharing.

2011-02-24 Thread Tanu Kaskinen
--- src/modules/module-virtual-sink.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/src/modules/module-virtual-sink.c b/src/modules/module-virtual-sink.c index 40bab5a..ceb2697 100644 --- a/src/modules/module-virtual-sink.c +++

[pulseaudio-discuss] [PATCH 3/6] virtual-sink: Add a modarg for forcing flat volume.

2011-02-24 Thread Tanu Kaskinen
--- src/modules/module-virtual-sink.c | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/src/modules/module-virtual-sink.c b/src/modules/module-virtual-sink.c index ceb2697..e55e890 100644 --- a/src/modules/module-virtual-sink.c +++

[pulseaudio-discuss] [PATCH 4/6] virtual-sink/source: Use a more descriptive stream name.

2011-02-24 Thread Tanu Kaskinen
--- src/modules/module-virtual-sink.c |2 +- src/modules/module-virtual-source.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/module-virtual-sink.c b/src/modules/module-virtual-sink.c index e55e890..a45f4f5 100644 ---

[pulseaudio-discuss] [PATCH 5/6] virtual-sink/source: Remove an unused variable.

2011-02-24 Thread Tanu Kaskinen
--- src/modules/module-virtual-sink.c |5 - src/modules/module-virtual-source.c |5 - 2 files changed, 0 insertions(+), 10 deletions(-) diff --git a/src/modules/module-virtual-sink.c b/src/modules/module-virtual-sink.c index a45f4f5..bad159c 100644 ---

[pulseaudio-discuss] [PATCH] dbusiface-stream: Send the Device property in the GetAll handler.

2011-02-22 Thread Tanu Kaskinen
--- src/modules/dbus/iface-stream.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/modules/dbus/iface-stream.c b/src/modules/dbus/iface-stream.c index 681790b..cfba5ad 100644 --- a/src/modules/dbus/iface-stream.c +++ b/src/modules/dbus/iface-stream.c @@ -555,6 +555,7

Re: [pulseaudio-discuss] [RFC] Allow read-only or non-existing sink input volume.

2011-02-22 Thread Tanu Kaskinen
On Mon, 2011-02-14 at 13:41 +0200, Kaskinen Tanu wrote: There are two known cases where read-only or non-existing sink input volume is relevant: passthrough streams and the planned volume sharing logic. Passthrough streams don't have volume at all, and the volume sharing logic requires

Re: [pulseaudio-discuss] [RFC] Passthrough support

2011-02-22 Thread Tanu Kaskinen
On Wed, 2011-02-23 at 01:00 +0530, Arun Raghavan wrote: On Tue, 2011-02-22 at 13:27 -0600, pl bossart wrote: ok. Looks good. One last comment on proplists. If we don't define a set of mandatory elements, then it's going to be really hard to use this pa_stream_new_extended() routine. How

Re: [pulseaudio-discuss] [RFC] Allow read-only or non-existing sink input volume.

2011-02-22 Thread Tanu Kaskinen
On Tue, 2011-02-22 at 21:25 +, Colin Guthrie wrote: 'Twas brillig, and Tanu Kaskinen at 22/02/11 16:35 did gyre and gimble: It would be nice if someone would test this with passthrough streams also, but personally I think it would be ok to commit this patch to master now. OK, I've

Re: [pulseaudio-discuss] Build assembler errors on ARM OMAP3

2011-02-21 Thread Tanu Kaskinen
On Sun, 2011-02-20 at 22:50 +, Colin Guthrie wrote: 'Twas brillig, and Kurt Taylor at 18/02/11 22:29 did gyre and gimble: I submitted a ticket and patch that fixes these build errors - tested on a Beagleboard (OMAP3) with Linaro ARM Linux image. I did not test on other platforms due to

Re: [pulseaudio-discuss] [RFC] Passthrough support

2011-02-19 Thread Tanu Kaskinen
On Fri, 2011-02-18 at 15:11 +0530, Arun Raghavan wrote: Hello! On Tue, 2011-02-15 at 22:02 +0530, Arun Raghavan wrote: Hey folks, I've put up a draft proposed API changes to get passthrough support to the point where things Just Work™ for at least the common cases, based on previous

Re: [pulseaudio-discuss] pulseaudio duplicate trace in /var/log/syslog

2011-02-19 Thread Tanu Kaskinen
On Sat, 2011-02-19 at 12:33 +, Jon Grant wrote: Hello I have the following occurring every 5 seconds in syslog. I wanted to offer to submit a patch for review to remove some of the duplicate lines. Lines 4 and 5 are not duplicates. If you look at the PIDs, there are two pulseaudio

Re: [pulseaudio-discuss] PA Roadmap Planning and LAC Conference

2011-02-18 Thread Tanu Kaskinen
On Fri, 2011-02-18 at 11:15 -0600, Kurt Taylor wrote: Thanks for organizing this Colin! I will do my best to attend, but that is 5am (UTC-6) for me. It sounds like a few hours later would be better than the suggested 11:00 UTC. Arun would probably be the first person to be annoyed by the time

Re: [pulseaudio-discuss] [RFC] Passthrough support

2011-02-17 Thread Tanu Kaskinen
On Wed, 2011-02-16 at 19:17 +0530, Arun Raghavan wrote: Can you elaborate on what you had in mind regarding UIs? As for UIs, it would probably be nice to have some sort of (hidden by default) way to show supported format in a sink. Of course, pactl/pacmd would expose this data too. Other

[pulseaudio-discuss] [RFC] Implement the volume sharing feature.

2011-02-17 Thread Tanu Kaskinen
DON'T COMMIT. This is just a request for comments. Testing this patch isn't done properly yet. When we have a filter sink that does some processing, currently the benefits of the flat volume feature are not really available. That's because if you have a music player that is connected to the

Re: [pulseaudio-discuss] [RFC] Passthrough support

2011-02-17 Thread Tanu Kaskinen
On Thu, 2011-02-17 at 09:13 +, Colin Guthrie wrote: If the resulting set contains exactly one fixed format, then that is used for the stream. If the set contains more options than one fixed format, then the daemon decides the best format using some unspecified algorithm. If the set is

Re: [pulseaudio-discuss] [RFC] Passthrough support

2011-02-16 Thread Tanu Kaskinen
On Wed, 2011-02-16 at 10:10 +0200, Tanu Kaskinen wrote: pulsesink would respond to the query by checking the parameters of the created pa_stream object. If the pipeline building is a heavy process, the stream could be created in corked state. Forget about starting in corked state

Re: [pulseaudio-discuss] [RFC] Passthrough support

2011-02-16 Thread Tanu Kaskinen
On Wed, 2011-02-16 at 23:08 +, Colin Guthrie wrote: 'Twas brillig, and Arun Raghavan at 16/02/11 21:24 did gyre and gimble: On Wed, 2011-02-16 at 10:39 -0600, pl bossart wrote: - I am not sure I understand how/when the query would be used. Seems to me like a notification with the

Re: [pulseaudio-discuss] [RFC] Passthrough support

2011-02-16 Thread Tanu Kaskinen
On Thu, 2011-02-17 at 02:54 +0530, Arun Raghavan wrote: On Wed, 2011-02-16 at 10:39 -0600, pl bossart wrote: - I am not sure I understand how/when the query would be used. Seems to me like a notification with the formats exposed by the sink currently selected would be more usable. And if

Re: [pulseaudio-discuss] New feature in the works: volume sharing

2011-02-15 Thread Tanu Kaskinen
On Tue, 2011-02-15 at 09:00 +0200, David Henningsson wrote: I have a question: how about the volume store/restore module? Will it store and restore the outermost sink's volume, the innermost one, or both? Another thing is the pick-up of volume/mute changes in the driver - at least that's

Re: [pulseaudio-discuss] [RFC] Passthrough support

2011-02-15 Thread Tanu Kaskinen
On Tue, 2011-02-15 at 22:02 +0530, Arun Raghavan wrote: Hey folks, I've put up a draft proposed API changes to get passthrough support to the point where things Just Work™ for at least the common cases, based on previous discussion on-/off-list: http://pulseaudio.org/wiki/PassthroughSupport

Re: [pulseaudio-discuss] New feature in the works: volume sharing

2011-02-14 Thread Tanu Kaskinen
On Sun, 2011-02-13 at 22:05 +0200, Colin Guthrie wrote: With this push based approach, you do loose some individual granularity, but the net volume of the underlying h/w should be the same as your approach. What granularity would I lose? I think your suggested logic would be quite equivalent

[pulseaudio-discuss] [RFC] Allow read-only or non-existing sink input volume.

2011-02-14 Thread Tanu Kaskinen
There are two known cases where read-only or non-existing sink input volume is relevant: passthrough streams and the planned volume sharing logic. Passthrough streams don't have volume at all, and the volume sharing logic requires read-only sink input volume. This commit is primarily working

Re: [pulseaudio-discuss] Trying to get Pukseaudio playing nice with KDE 4.6 on Arch Linux

2011-02-13 Thread Tanu Kaskinen
On Sun, 2011-02-13 at 08:12 -0600, gkoda...@gmail.com wrote: I'm trying to get PulseAudio running nicely over Jack so I can run my regular Alsa apps at the same time that Jack is running, but I think my PulseAudio is incorrectly configured. I've started both pulsaudio-x11 and pulseaudio-kde.

Re: [pulseaudio-discuss] padevchooser quickly choose output device

2011-02-12 Thread Tanu Kaskinen
On Sat, 2011-02-12 at 22:14 -0800, Karl Ostmo wrote: In the left-click menu of the padevchooser applet, I see a submenu for Default Sink that lists these three items: * No Network Devices Found (greyed-out) * Default * Other... In the Output tab of my Sound Preferences application, I see

Re: [pulseaudio-discuss] New feature in the works: volume sharing

2011-02-09 Thread Tanu Kaskinen
On Thu, 2011-02-03 at 14:35 +0200, Tanu Kaskinen wrote: Hello, When we have a filter sink that does some processing, currently the benefits of the flat volume feature are not really available. That's because if you have a music player that is connected to the filter sink, the hardware sink

Re: [pulseaudio-discuss] Custom way to down/up mix

2011-02-09 Thread Tanu Kaskinen
On Tue, 2011-02-08 at 18:44 +0600, IL'dar AKHmetgaleev wrote: Can I costumize matrces which used to convert different number of channels to each other. No, unfortunately there's currently no support for using custom matrices. -- Tanu ___

[pulseaudio-discuss] [PATCH v2] core: Link virtual sinks and sources to their streams.

2011-02-07 Thread Tanu Kaskinen
This change doesn't add any functionality in itself, but it will be useful in the future for operating on chains of sinks or sources that are piggy-backing on each other. For example, the PA_PROP_DEVICE_MASTER_DEVICE property could be handled in the core so that each virtual device doesn't have

Re: [pulseaudio-discuss] [PATCH v2] core: Link virtual sinks and sources to their streams.

2011-02-07 Thread Tanu Kaskinen
On Mon, 2011-02-07 at 18:35 +0200, Kaskinen Tanu wrote: This change doesn't add any functionality in itself, but it will be useful in the future for operating on chains of sinks or sources that are piggy-backing on each other. For example, the PA_PROP_DEVICE_MASTER_DEVICE property could be

Re: [pulseaudio-discuss] Properties to suppress save/restore of stream volumes

2011-02-03 Thread Tanu Kaskinen
On Thu, 2011-02-03 at 10:37 +, Colin Guthrie wrote: I guess the real problem would be how to interface with xfade in gst such that gst applications would be essentially ignorant of how it's done, such that gst-on-alsa works as transparently (to the app) as gst-on-pulse. I'm skeptical

Re: [pulseaudio-discuss] Flat volumes and restoring the app volume

2011-01-31 Thread Tanu Kaskinen
On Mon, 2011-01-31 at 22:27 +0300, Gregory Petrosyan wrote: On Mon, Jan 31, 2011 at 1:45 PM, Colin Guthrie gm...@colin.guthr.ie wrote: ... Thanks a lot for the explanation! I am asking these, because I've managed to make an app restore the volume properly using ext-stream-restore.h,

Re: [pulseaudio-discuss] Make discoverable PA network sound devices available locally results in huge network traffic

2011-01-24 Thread Tanu Kaskinen
On Mon, 2011-01-24 at 17:02 +, Brian J. Murrell wrote: Tanu Kaskinen tanuk at iki.fi writes: I had a look at some point at the peak detection resampler... I think the peak detection flag that you mentioned earlier doesn't do anything else than force the resampler of the source output

Re: [pulseaudio-discuss] Make discoverable PA network sound devices available locally results in huge network traffic

2011-01-21 Thread Tanu Kaskinen
On Fri, 2011-01-21 at 17:13 +, Colin Guthrie wrote: 'Twas brillig, and Brian J. Murrell at 21/01/11 17:10 did gyre and gimble: A GUI widget would be more useful I think so that one could twiddle it without having to drop to a command line. Yeah fair point. But even more

[pulseaudio-discuss] Coding style question regarding curly braces

2011-01-20 Thread Tanu Kaskinen
Hi, When reviewing code, should I complain about excessive curly brackets in code like this? if (foo) { bar = 0; } Pulseaudio source code follows quite consistently the unwritten rule that you shouldn't use curly braces unless necessary, so I was surprised to notice that the

Re: [pulseaudio-discuss] How to capture one of multiple radios that these radios play at the same time?

2010-11-19 Thread Tanu Kaskinen
On Fri, 2010-11-19 at 13:48 +, Colin Guthrie wrote: You appear to be using the sink_input_index value before you even run the main loop... This value will just contain the default values and thus I suspect they all have 0's which ultimately maps to the default monitor source and no

[pulseaudio-discuss] [PATCH v2] alsa: Print dB values in addition to percentages in debug messages.

2010-11-18 Thread Tanu Kaskinen
How about this? There are a couple of bugs in sink_write_volume_cb, by the way. Another patch will be sent once this dB value printing patch is accepted. -- 8 -- --- src/modules/alsa/alsa-sink.c | 38 -- src/modules/alsa/alsa-source.c | 25

Re: [pulseaudio-discuss] How to capture one of multiple radios that these radios play at the same time?

2010-11-18 Thread Tanu Kaskinen
On Thu, 2010-11-18 at 21:29 -0500, Tsai Yu-Chin wrote: Thank you for your help. I refer to source code of pavucontrol and I program a simple code below: It seems that you pretty much correctly set up a record stream that records from a single playback stream. How do you play the three radios?

Re: [pulseaudio-discuss] [PATCH] combine: Handle reappearing slave sinks in non-automatic mode.

2010-11-12 Thread Tanu Kaskinen
On Fri, 2010-11-12 at 11:15 +0200, Colin Guthrie wrote: * If no slaves exist, just idle and wait for the necessary hooks before loading the actual combine sink. * If one of our watched slaves turns up, and we have not yet created our combine sink, then create it. * If all our slaves

Re: [pulseaudio-discuss] pa_mempool_blocksize_max

2010-11-09 Thread Tanu Kaskinen
On Tue, 2010-11-09 at 20:48 +, Tarantism wrote: Whilst trying to get to grips with memblocks and chunks, I came across this in rtp.c: if (ioctl(c-fd, FIONREAD, size) 0) { pa_log_warn(FIONREAD failed: %s, pa_cstrerror(errno)); goto fail; } if (size = 0)

Re: [pulseaudio-discuss] [PATCH] bluetooth: MP3 passthrough over A2DP

2010-11-08 Thread Tanu Kaskinen
On Sun, 2010-11-07 at 18:37 -0600, pl bossart wrote: Thanks Tanu, couple of comments on your review: - I did spent a lot of time correcting these spaces, but there's always some that go through. I would imagine that if you start from the beginning of the review mail and go through the

Re: [pulseaudio-discuss] [PATCH] bluetooth: MP3 passthrough over A2DP

2010-11-08 Thread Tanu Kaskinen
Whoops... On Mon, 2010-11-08 at 18:53 +0200, Tanu Kaskinen wrote: If that makes you happy I'll do the change, but this is clearly a wrong interpretation. You want to infer the length of a frame in ms by dividing the sampling rate by the number of sample points... Yes, but number

Re: [pulseaudio-discuss] [PATCH] bluetooth: MP3 passthrough over A2DP

2010-11-08 Thread Tanu Kaskinen
On Sun, 2010-11-07 at 18:37 -0600, pl bossart wrote: So, how about renaming this array to pcm_frames_per_mpeg_frame? If that makes you happy I'll do the change, but this is clearly a wrong interpretation. You want to infer the length of a frame in ms by dividing the sampling rate by the

Re: [pulseaudio-discuss] Avoiding 2ch upmixing to all speakers

2010-11-08 Thread Tanu Kaskinen
On Thu, 2010-11-04 at 22:47 +, Dom H wrote: I have a 4.1 system and pulse does a good job of mixing the missing centre into the fronts for 5.1 audio tracks, I'm recently switched from a digital out system with my external receiver doing all the decoding and mixing, to my HTPC doing the job

Re: [pulseaudio-discuss] High pitched sounds and Internal Speaker

2010-11-08 Thread Tanu Kaskinen
On Sun, 2010-11-07 at 03:59 +, M. Hamzah Khan wrote: Hi, I have an Intel HDA sound card in my machine. The machine has a built in speaker, which (without pulseaudio) I was able to disable by just unchecking the box for speaker in gnome-alsamixer. But when I do this while pulseaudio is

Re: [pulseaudio-discuss] [PATCH] bluetooth: MP3 passthrough over A2DP

2010-11-07 Thread Tanu Kaskinen
Hi, Patch review below. On Fri, 2010-10-22 at 18:48 -0500, Pierre-Louis Bossart wrote: This patch enables MP3 passthrough over A2DP, with the decoding taking place on the headset to reduce power consumption. This was only possible if PulseAudio was bypassed before with the a2dpsink element

Re: [pulseaudio-discuss] Exponential recovering from rewinds

2010-11-05 Thread Tanu Kaskinen
On Fri, 2010-11-05 at 09:15 -0400, David Henningsson wrote: Just following up on an idea brought to my attention at the Ubuntu/Linaro Developer Summit, and I'm not sure whether this is the original idea or if I refined it a little myself. Anyway. Since rewinds often come in chunks, and

Re: [pulseaudio-discuss] [RFC] disabling monitor source patch

2010-11-03 Thread Tanu Kaskinen
example for the previous item, or paragraph, or whatever, you know, the place where I was commenting on handle_sink_get_monitor_source() implementation... But hey, two examples are better than one anyway! -- Tanu Kaskinen ___ pulseaudio-discuss mailing list

Re: [pulseaudio-discuss] [PATCH] bluetooth: MP3 passthrough over A2DP

2010-11-01 Thread Tanu Kaskinen
On Sun, 2010-10-31 at 20:37 +, Colin Guthrie wrote: Has anyone (particularly Tanu) got any comments on this patch? I don't. I'll try to review the patch this week. -- Tanu ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de

Re: [pulseaudio-discuss] pax11publish -e -S

2010-10-24 Thread Tanu Kaskinen
that decides where to connect. If that's the case, what happens if you run paplay some-wav-file? Does that connect to the local server, or does it fail completely? Does it print error messages? -- Tanu Kaskinen ___ pulseaudio-discuss mailing list pulseaudio

Re: [pulseaudio-discuss] [PATCH 1/5] core: Add infrastructure for synchronizing HW and SW volume changes

2010-10-15 Thread Tanu Kaskinen
missing). -- Tanu Kaskinen Digia Plc ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH 1/5] core: Add infrastructure for synchronizing HW and SW volume changes

2010-10-15 Thread Tanu Kaskinen
this same problem that you found already before the first patch version, but it was against a different tree (non-public) than the official Pulseaudio master branch. As Jyri said, Yep, fixed. Go ahead and commit this second attempt :) -- Tanu Kaskinen

Re: [pulseaudio-discuss] udev detection for 1 card with multiple devices

2010-10-12 Thread Tanu Kaskinen
, though. The card may sometimes have some other index than zero, so use %f in place of the card number, e.g. hw:%f,3 - it will be replaced by the actual card index at runtime. -- Tanu Kaskinen ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail

Re: [pulseaudio-discuss] [RFC - MP3 passthrough over A2DP 2/2] mp3 passthrough: Bluetooth changes

2010-10-05 Thread Tanu Kaskinen
Hi, Patch review below: On Tue, 2010-09-21 at 18:00 -0500, bossart.nos...@gmail.com wrote: From: Pierre-Louis Bossart pierre-louis.boss...@intel.com Signed-off-by: Pierre-Louis Bossart pierre-louis.boss...@intel.com diff --git a/src/modules/bluetooth/module-bluetooth-device.c

Re: [pulseaudio-discuss] OpenWRT + pulseaudio-0.9.21

2010-10-03 Thread Tanu Kaskinen
using paplay /root/test.wav behave differently? I wasn't even aware of the play-file command in pacmd... It seems likely that the kernel has some bug, though. I don't know how to debug such stuff. -- Tanu Kaskinen ___ pulseaudio-discuss mailing list

Re: [pulseaudio-discuss] [RFC - MP3 passthrough over A2DP 1/2] mp3 passthrough: core changes

2010-09-23 Thread Tanu Kaskinen
that it will take for the next sample that enters the system to get out of the speakers. How would GET_TIME differ from GET_LATENCY, and why would it be better? -- Tanu Kaskinen ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https

Re: [pulseaudio-discuss] [RFC - MP3 passthrough over A2DP 1/2] mp3 passthrough: core changes

2010-09-22 Thread Tanu Kaskinen
source creation code with if (s-sample_spec.format != PA_MP3)... ok, I did a quick search for monitor in sink.c, and it turns out that you'll have to also add if (s-monitor_source) in many places. -- Tanu Kaskinen ___ pulseaudio-discuss mailing list

Re: [pulseaudio-discuss] Routing of audio to loudspeakers or headphones

2010-09-15 Thread Tanu Kaskinen
the asynchronous subscription system (see src/pulsecore/core-subscribe.h for the API). I would prefer the first alternative - the synchronous hook callbacks are easier to get right than the asynchronous subscription callbacks. -- Tanu Kaskinen

Re: [pulseaudio-discuss] Pulseaudio runs, but there's no sound

2010-09-12 Thread Tanu Kaskinen
a pulseaudio log with for example one mplayer run. -- Tanu Kaskinen ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] module-udev-detect.c:235: undefined reference to `pa_fopen_cloexec' during 'make install'

2010-09-05 Thread Tanu Kaskinen
incorrect caching going on, but I think I've tried creating a fresh clone, which didn't help. I don't know what fixes the problem, but it has always gone away after keeping some pause from PA development... -- Tanu Kaskinen ___ pulseaudio-discuss mailing list

Re: [pulseaudio-discuss] Two identical USB sound-cards - second card fails to load because card-name found in hashmap.

2010-08-30 Thread Tanu Kaskinen
did for loading the card itself. But as I said, I didn't have time to look too closely into it yet. I pushed a new patch to my repo. The patch should now solve the problem of identically named sinks and sources too. Please test :) -- Tanu Kaskinen

Re: [pulseaudio-discuss] Two identical USB sound-cards - second card fails to load because card-name found in hashmap.

2010-08-24 Thread Tanu Kaskinen
On Mon, 2010-08-23 at 10:01 +0100, Colin Guthrie wrote: 'Twas brillig, and Tanu Kaskinen at 23/08/10 07:31 did gyre and gimble: So, how to fix the bug? I'd just add a new module argument for module-alsa-card: namereg_fail. It could be used by module-udev-detect to override the normal logic

Re: [pulseaudio-discuss] Two identical USB sound-cards - second card fails to load because card-name found in hashmap.

2010-08-23 Thread Tanu Kaskinen
-alsa-card: namereg_fail. It could be used by module-udev-detect to override the normal logic for setting the flag. -- Tanu Kaskinen ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo

[pulseaudio-discuss] Pull request: Loopback stream identification and module proplist update function

2010-08-19 Thread Tanu Kaskinen
/pulseaudio.git master Tanu Kaskinen (2): loopback: Make stream names and roles configurable. core: New function: pa_module_update_proplist(). src/modules/module-loopback.c | 41 ++--- src/pulsecore/module.c|9 + src/pulsecore

Re: [pulseaudio-discuss] [PATCH] Do not use tsched watermark if tsched is disabled

2010-08-18 Thread Tanu Kaskinen
#g8f56faf60ea6b60839e131df88f080d7 -- Tanu Kaskinen ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] gst pulsesrc and default caps

2010-08-15 Thread Tanu Kaskinen
. It might make sense to add a possibility for clients to ask pulseaudio where would a stream with this property list be routed to? Any volunteers to implement that? -- Tanu Kaskinen ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de

Re: [pulseaudio-discuss] Volume control interactions

2010-08-15 Thread Tanu Kaskinen
should write such volumes to the stream restore database, but I think it would still make sense to actively prevent that in module-stream-restore. -- Tanu Kaskinen ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango

Re: [pulseaudio-discuss] gst pulsesrc and default caps

2010-08-15 Thread Tanu Kaskinen
Correcting myself: On Mon, 2010-08-16 at 06:42 +0300, Tanu Kaskinen wrote: I guess the problem is that pulsesrc doesn't know which source is going to be used before actually starts recording. No, that's not the problem. The problem is that pulsesrc doesn't use the proper flags when creating

Re: [pulseaudio-discuss] These ideas I've had for the better part of a month, forgive me for there length.

2010-08-13 Thread Tanu Kaskinen
? -- Tanu Kaskinen ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH] AC3 passthrough support

2010-08-12 Thread Tanu Kaskinen
On Fri, 2010-07-16 at 17:11 -0500, pl bossart wrote: Second version to address Tanu's feedback. Should be good enough by now for actual use. I guess I should have said this right away, but better late than never: this version looks good to me. Can we get this committed? -- Tanu Kaskinen

[pulseaudio-discuss] Pull request: Another D-Bus interface fix

2010-08-10 Thread Tanu Kaskinen
Hello, The following changes since commit 1552abf62820e063e933e54372bec25f8ea2f68a: udev: fix hex decoding (2010-07-19 01:27:22 +0200) are available in the git repository at: git://gitorious.org/~tanuk2/pulseaudio/pulseaudio.git master Tanu Kaskinen (1): dbusiface-core: Track sinks

Re: [pulseaudio-discuss] Anyone heard of RoarAudio?

2010-08-06 Thread Tanu Kaskinen
for streaming live content on the web? -- Tanu Kaskinen ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] Assert error in pulsecore/resampler.c:trivial_resample

2010-07-20 Thread Tanu Kaskinen
-i_ss.rate and r-o_ss.rate when the crash happens? [1] I'd make the assertion more specific, though, which actually makes it even easier to trigger: pa_assert_fp(o_index * fz + fz = pa_memblock_get_length(output-memblock) - output-index); -- Tanu Kaskinen

Re: [pulseaudio-discuss] [PATCH] AC3 passthrough support

2010-07-16 Thread Tanu Kaskinen
be pa_assert(!((data-flags PA_SINK_INPUT_PASSTHROUGH) data-volume_is_set)); somewhere in pa_sink_input_new, and checks in protocol-native.c to prevent that assertion from firing. That is, refuse to create passthrough streams that also have volume specified by the client. -- Tanu Kaskinen

Re: [pulseaudio-discuss] [PATCH] AC3 passthrough support

2010-07-16 Thread Tanu Kaskinen
.) Anyway, currently the patch doesn't ignore the initial stream volume, so if it's set, then the audio probably becomes corrupted. -- Tanu Kaskinen ___ pulseaudio-discuss mailing list pulseaudio-discuss@mail.0pointer.de https://tango.0pointer.de/mailman

<    1   2   3   4   >