Re: [pulseaudio-discuss] [PATCH] Add a target to the PA log feature and improve PA log core

2011-02-24 Thread Becker, VincentX
From: Maarten Bosmans [mailto:mkbosm...@gmail.com] 2011/2/23 Becker, VincentX vincentx.bec...@intel.com: Thanks for your review Maarten. So you suggest to split this into several patches (2). One for the outer implementation and the other for the inner one. I will try to attend to the irc

Re: [pulseaudio-discuss] [PATCH] Add a target to the PA log feature and improve PA log core

2011-02-24 Thread Maarten Bosmans
2011/2/24 Becker, VincentX vincentx.bec...@intel.com: From: Maarten Bosmans [mailto:mkbosm...@gmail.com] 2011/2/23 Becker, VincentX vincentx.bec...@intel.com: Thanks for your review Maarten. So you suggest to split this into several patches (2). One for the outer implementation and the other for

Re: [pulseaudio-discuss] [PATCH] Add a target to the PA log feature and improve PA log core

2011-02-23 Thread Maarten Bosmans
Here's my review of that patch. It will be handled in the meeting tomorrow, but I'm sure I've forgotten by then, so I sent it to the list. 2010/11/22 Becker, VincentX vincentx.bec...@intel.com: Hi all, Could you please review this patch ? This is a patch that adds a generic log target for PA

Re: [pulseaudio-discuss] [PATCH] Add a target to the PA log feature and improve PA log core

2011-02-23 Thread Maarten Bosmans
Here's my review of that patch. It will be handled in the meeting tomorrow, but I'm sure I've forgotten by then, so I sent it to the list. 2010/11/22 Becker, VincentX vincentx.bec...@intel.com: Hi all, Could you please review this patch ? This is a patch that adds a generic log target for PA

Re: [pulseaudio-discuss] [PATCH] Add a target to the PA log feature and improve PA log core

2011-02-23 Thread Becker, VincentX
-Original Message- From: Maarten Bosmans [mailto:mkbosm...@gmail.com] Sent: Wednesday, February 23, 2011 3:50 PM To: General PulseAudio Discussion Cc: Becker, VincentX Subject: Re: [pulseaudio-discuss] [PATCH] Add a target to the PA log feature and improve PA log core Here's my review of

Re: [pulseaudio-discuss] [PATCH] Add a target to the PA log feature and improve PA log core

2011-02-23 Thread Maarten Bosmans
2011/2/23 Becker, VincentX vincentx.bec...@intel.com: Thanks for your review Maarten. So you suggest to split this into several patches (2). One for the outer implementation and the other for the inner one. I will try to attend to the irc meeting tomorrow so I can catch your remarks in real

[pulseaudio-discuss] [PATCH] Add a target to the PA log feature and improve PA log core

2010-11-22 Thread Becker, VincentX
Hi all, Could you please review this patch ? This is a patch that adds a generic log target for PA log (log.c). This new target can be either a char device or a regular file. For our remote log device needs, it has been necessary to directly log Pulseaudio traces to a file descriptor. Also