Re: [pulseaudio-discuss] update-card-properties? Possible?

2016-08-15 Thread Tanu Kaskinen
On Mon, 2016-08-15 at 23:28 +1000, Bernd Wechner wrote: > I notice it's possible to alter sink properties with  > update-sink-properties but see no analog for card properties. >  > Specifically I find that pulse audio sets the device.description for  > cards, to "Built-in Audio" if it's on the

[pulseaudio-discuss] update-card-properties? Possible?

2016-08-15 Thread Bernd Wechner
I notice it's possible to alter sink properties with update-sink-properties but see no analog for card properties. Specifically I find that pulse audio sets the device.description for cards, to "Built-in Audio" if it's on the motherboard, but for USB sound devices takes the USB property

Re: [pulseaudio-discuss] [PATCH 1/3] Remove newline at end of log messages

2016-08-15 Thread Arun Raghavan
On Tue, 16 Aug 2016, at 11:17 AM, Peter Meerwald-Stadler wrote: > Signed-off-by: Peter Meerwald-Stadler > --- > src/daemon/main.c| 14 +++--- > src/modules/alsa/alsa-util.c | 16 >

Re: [pulseaudio-discuss] [PATCH] sink-input, source-output: Fix logging, don't overwrite old_value when value == 0

2016-08-15 Thread Tanu Kaskinen
On Mon, 2016-08-15 at 19:11 +0200, Peter Meerwald-Stadler wrote: > --- >  src/pulsecore/sink-input.c|   10 -- >  src/pulsecore/source-output.c |   10 -- >  2 files changed, 8 insertions(+), 12 deletions(-) Looks good to me. --  Tanu

[pulseaudio-discuss] [PATCH] sink-input, source-output: Fix logging, don't overwrite old_value when value == 0

2016-08-15 Thread Peter Meerwald-Stadler
--- src/pulsecore/sink-input.c| 10 -- src/pulsecore/source-output.c | 10 -- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/src/pulsecore/sink-input.c b/src/pulsecore/sink-input.c index 1ed5dda..435e63e 100644 --- a/src/pulsecore/sink-input.c +++

Re: [pulseaudio-discuss] [PATCH 3/3] bluetooth: Fix dead code

2016-08-15 Thread Arun Raghavan
On Tue, 16 Aug 2016, at 11:17 AM, Peter Meerwald-Stadler wrote: > CID 1353115 > > Signed-off-by: Peter Meerwald-Stadler > --- > src/modules/bluetooth/module-bluez4-discover.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git

Re: [pulseaudio-discuss] [PATCH v6 14/25] source.c, sink.c: Implement pa_{source, sink}_get_raw_latency_within_thread() calls

2016-08-15 Thread Tanu Kaskinen
On Sun, 2016-06-05 at 21:05 +0200, Georg Chini wrote: > In certain situations, the reported sink or source latency may become > negative. What are those certain situations? > This does not indicate that the latency is indeed negative but can be > considered > merely an offset error. The current

Re: [pulseaudio-discuss] [PATCH v2 00/12] patches addressing some Coverity issues

2016-08-15 Thread Peter Meerwald-Stadler
> > the remaining patches will go to next after review > Also ack'ed. patches were forgotten since September 2015... applied them now > > Peter Meerwald (12): > > modules: Fix unchecked return in module-card-restore > > core: Assert that memblockq's base is != 0 > > tests: Assert

[pulseaudio-discuss] [PATCH 3/3] bluetooth: Fix dead code

2016-08-15 Thread Peter Meerwald-Stadler
CID 1353115 Signed-off-by: Peter Meerwald-Stadler --- src/modules/bluetooth/module-bluez4-discover.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/modules/bluetooth/module-bluez4-discover.c b/src/modules/bluetooth/module-bluez4-discover.c index

[pulseaudio-discuss] [PATCH 1/3] Remove newline at end of log messages

2016-08-15 Thread Peter Meerwald-Stadler
Signed-off-by: Peter Meerwald-Stadler --- src/daemon/main.c| 14 +++--- src/modules/alsa/alsa-util.c | 16 src/modules/bluetooth/backend-native.c | 2 +- src/modules/bluetooth/bluez4-util.c |

[pulseaudio-discuss] [PATCH 2/3] bluetooth: Don't free modargs twice

2016-08-15 Thread Peter Meerwald-Stadler
CID1353139 Signed-off-by: Peter Meerwald-Stadler --- src/modules/bluetooth/module-bluez5-device.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/modules/bluetooth/module-bluez5-device.c b/src/modules/bluetooth/module-bluez5-device.c index