Re: [pulseaudio-discuss] [PATCH v2 2/5] oss: don't fail resume if trigger() fails

On 13.03.2018 18:40, Tanu Kaskinen wrote: The previous code made the SET_STATE message fail if trigger() failed. However, trigger() was called after pa_sink/source_process_msg(), which meant that the main thread that sent the SET_STATE thought that resuming failed, but nothing was undone in the

Re: [pulseaudio-discuss] [PATCH v2 4/5] pass pa_suspend_cause_t to set_state_in_io_thread() callbacks

On 13.03.2018 18:40, Tanu Kaskinen wrote: The suspend cause isn't yet used by any of the callbacks. The alsa sink and source will use it to sync the mixer when the SESSION suspend cause is removed. Currently the syncing is done in pa_sink/source_suspend(), and I want to change that, because

[pulseaudio-discuss] [PATCH] Fix memory leaks

The returned string of the dbus_message_iter_get_signature() must be freed with dbus_free(). --- src/modules/module-stream-restore.c | 8 +++- src/pulsecore/dbus-util.c | 8 +++- src/pulsecore/protocol-dbus.c | 6 +- 3 files changed, 19 insertions(+), 3 deletions(-)

Re: [pulseaudio-discuss] [PATCH v2 5/5] fix a call to pa_sink_suspend() from an incorrect thread

On 13.03.2018 18:40, Tanu Kaskinen wrote: The alsa sink calls pa_sink_suspend() from the set_port() callback. pa_sink_suspend() can only be called from the main thread, but the set_port() callback was often called from the IO thread. That caused an assertion to be hit in pa_sink_suspend() when

Re: [pulseaudio-discuss] [PATCH] Fix memory leaks

> The returned string of the dbus_message_iter_get_signature() must be > freed with dbus_free(). > --- > src/modules/module-stream-restore.c | 8 +++- > src/pulsecore/dbus-util.c | 8 +++- > 2 files changed, 14 insertions(+), 2 deletions(-) > > diff --git

Re: [pulseaudio-discuss] [PATCH v2 3/5] replace sink/source SET_STATE handlers with callbacks

On 13.03.2018 18:40, Tanu Kaskinen wrote: There are no behaviour changes, the code from almost all the SET_STATE handlers is moved with minimal changes to the newly introduced set_state_in_io_thread() callback. The only exception is module-tunnel, which has to call pa_sink_render() after

Re: [pulseaudio-discuss] [PATCH 2/3] bluetooth: Remove BlueZ 4 support

Hi Tanu. On Thu, Mar 15, 2018 at 10:26 PM, Tanu Kaskinen wrote: > On Fri, 2018-03-09 at 14:12 +0200, Luiz Augusto von Dentz wrote: >> From: Luiz Augusto von Dentz >> >> BlueZ 4 is no longer supported by BlueZ community for a long long time, >> also by

Re: [pulseaudio-discuss] [PATCH 1/3] bluetooth: ofono: Use Acquire method if available

Hi Tanu, On Thu, Mar 15, 2018 at 9:54 PM, Tanu Kaskinen wrote: > On Fri, 2018-03-09 at 14:12 +0200, Luiz Augusto von Dentz wrote: >> From: Luiz Augusto von Dentz >> >> Attempt to use Acquire method if available. > > Quoting my previous review: > > "After

Re: [pulseaudio-discuss] [PATCH v2 4/5] pass pa_suspend_cause_t to set_state_in_io_thread() callbacks

On 16.03.2018 19:26, Tanu Kaskinen wrote: On Fri, 2018-03-16 at 11:15 +0100, Georg Chini wrote: On 13.03.2018 18:40, Tanu Kaskinen wrote: The suspend cause isn't yet used by any of the callbacks. The alsa sink and source will use it to sync the mixer when the SESSION suspend cause is removed.

Re: [pulseaudio-discuss] [PATCH v2 4/5] pass pa_suspend_cause_t to set_state_in_io_thread() callbacks

On Fri, 2018-03-16 at 11:15 +0100, Georg Chini wrote: > On 13.03.2018 18:40, Tanu Kaskinen wrote: > > The suspend cause isn't yet used by any of the callbacks. The alsa sink > > and source will use it to sync the mixer when the SESSION suspend cause > > is removed. Currently the syncing is done in

Re: [pulseaudio-discuss] [PATCH 1/3] bluetooth: ofono: Use Acquire method if available

On Fri, 2018-03-16 at 15:33 +0200, Luiz Augusto von Dentz wrote: > Hi Tanu, > > On Thu, Mar 15, 2018 at 9:54 PM, Tanu Kaskinen wrote: > > On Fri, 2018-03-09 at 14:12 +0200, Luiz Augusto von Dentz wrote: > > > From: Luiz Augusto von Dentz > > > > > >

Re: [pulseaudio-discuss] Timing interval for Bluetooth Wideband speech

On Thu, 2018-03-15 at 14:49 +0530, Sathish Narasimman wrote: > Hi, > > I would like to know the PulseAudio module that is responsible for pushing > the audio for every 1 millisecond. > > For NBS the packets are pushed with 48bytes and 1milli sec interval. Where does this 1 ms interval come