Re: [pulseaudio-discuss] [PATCH] bluetooth: Add support for transport created by external profile

2012-11-12 Thread Luiz Augusto von Dentz
Hi Tanu, On Thu, Nov 8, 2012 at 3:52 PM, Tanu Kaskinen ta...@iki.fi wrote: On Wed, 2012-11-07 at 17:56 +0200, Luiz Augusto von Dentz wrote: --- a/src/modules/bluetooth/bluetooth-util.h +++ b/src/modules/bluetooth/bluetooth-util.h @@ -72,6 +72,7 @@ typedef enum pa_bluetooth_transport_hook

Re: [pulseaudio-discuss] [PATCH v1 0/3] bluetooth: Headset port availability

2012-11-26 Thread Luiz Augusto von Dentz
like to see some good reasoning to do these changes, how we gonna play out with port availability if we only have one that map for both profiles? What about if one of the profiles disconnects /became unavailable? Does that mean that all profiles has the same priority? -- Luiz Augusto von Dentz

Re: [pulseaudio-discuss] [PATCH v1 0/3] bluetooth: Headset port availability

2012-11-27 Thread Luiz Augusto von Dentz
Hi Mikel, On Tue, Nov 27, 2012 at 9:12 AM, Mikel Astiz mikel.astiz@gmail.com wrote: Hi Luiz, On Mon, Nov 26, 2012 at 9:17 PM, Luiz Augusto von Dentz luiz.de...@gmail.com wrote: Hi Mikel, On Mon, Nov 26, 2012 at 7:32 PM, Mikel Astiz mikel.astiz@gmail.com wrote: From: Mikel Astiz

Re: [pulseaudio-discuss] [PATCH 00/13] Fix reading of freed memory

2013-02-13 Thread Luiz Augusto von Dentz
| 17 +- 64 files changed, 521 insertions(+), 794 deletions(-) -- 1.7.10.4 It looks pretty good to me. -- Luiz Augusto von Dentz ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org

Re: [pulseaudio-discuss] [PATCH 1/3] bluetooth: Add 'bluez.alias' property

2013-04-30 Thread Luiz Augusto von Dentz
it is resolved, Alias in the other hand is always set, it defaults to BT address, and the user can overwrite with whatever it wants which should reflect in the card's name. -- Luiz Augusto von Dentz ___ pulseaudio-discuss mailing list pulseaudio-discuss

Re: [pulseaudio-discuss] [RFC next v4 00/16] bluetooth: BlueZ 5 development patches

2013-04-30 Thread Luiz Augusto von Dentz
from my side. -- Luiz Augusto von Dentz ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH] todo: Add plans for the bluetooth modules

2013-06-26 Thread Luiz Augusto von Dentz
with that at least is doesn't conflict with anything. -- Luiz Augusto von Dentz ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH] introspect: Expose card profile available flag

2013-07-15 Thread Luiz Augusto von Dentz
Hi Tanu, On Mon, Jul 15, 2013 at 1:25 PM, Tanu Kaskinen tanu.kaski...@linux.intel.com wrote: On Fri, 2013-07-12 at 18:18 +0300, Luiz Augusto von Dentz wrote: From: Luiz Augusto von Dentz luiz.von.de...@intel.com Available flag can be used by clients to disable the selection of profiles

[pulseaudio-discuss] [PATCH 1/2 v2] introspect: Expose card profile available flag

2013-07-15 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz luiz.von.de...@intel.com Available flag can be used by clients to disable the selection of profiles unavailable. Update protocol to 29 --- v2: Add fixes and update pactl as suggested by Tanu PROTOCOL| 9 + configure.ac

[pulseaudio-discuss] [PATCH 2/2 v2] pactl: Print available flag of card profiles

2013-07-15 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz luiz.von.de...@intel.com --- src/utils/pactl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/utils/pactl.c b/src/utils/pactl.c index b6d943e..f081110 100644 --- a/src/utils/pactl.c +++ b/src/utils/pactl.c @@ -575,7 +575,8 @@ static void

[pulseaudio-discuss] [PATCH] card: Only set active_profile with available profile

2013-10-30 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz luiz.von.de...@intel.com If the profile available flag is set to PA_AVAILABLE_NO it means the profile shall not be use. --- src/pulsecore/card.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/pulsecore/card.c b/src/pulsecore/card.c index

Re: [pulseaudio-discuss] [PATCH] card: Only set active_profile with available profile

2013-11-01 Thread Luiz Augusto von Dentz
Hi David, On Thu, Oct 31, 2013 at 11:22 AM, David Henningsson david.hennings...@canonical.com wrote: On 10/30/2013 11:58 AM, Luiz Augusto von Dentz wrote: From: Luiz Augusto von Dentz luiz.von.de...@intel.com If the profile available flag is set to PA_AVAILABLE_NO it means the profile shall

Re: [pulseaudio-discuss] [PATCH] card: Only set active_profile with available profile

2013-11-01 Thread Luiz Augusto von Dentz
Hi David, On Fri, Nov 1, 2013 at 11:31 AM, David Henningsson david.hennings...@canonical.com wrote: On 11/01/2013 10:18 AM, Luiz Augusto von Dentz wrote: Hi David, On Thu, Oct 31, 2013 at 11:22 AM, David Henningsson david.hennings...@canonical.com wrote: On 10/30/2013 11:58 AM, Luiz Augusto

[pulseaudio-discuss] [PATCH v2] card: Only set active_profile with available profile

2013-11-03 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz luiz.von.de...@intel.com When a card is being created and no profile has been assigned pa_card_new will attempt to select one from the list but it does that without checking the available flag which can lead to select profiles not available. --- v2: Add better

[pulseaudio-discuss] [PATCH] introspect: Fix ABI break introduce by b98a2e1

2013-11-04 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz luiz.von.de...@intel.com The size of pa_card_profile_info cannot change even if it just a field appended to end because it is appended to an array this may lead clients to access invalid data. To fix a new struct called pa_card_profile_info2 is introduced and shall

[pulseaudio-discuss] [PATCH] introspect: Fix ABI break introduced by b98a2e1

2013-11-04 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz luiz.von.de...@intel.com The size of pa_card_profile_info cannot change even if it just a field appended to end because each entry is appended to a contiguous memory and accessed by offset this may lead clients to access invalid data. To fix a new struct called

[pulseaudio-discuss] [RFC 1/2] card: Rank profiles based on available flag

2013-11-12 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz luiz.von.de...@intel.com This makes pa_card_new to rank profiles based on their available flag and only consider their priority in case they have the same rank. --- src/pulsecore/card.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git

[pulseaudio-discuss] [RFC 2/2] bluetooth: Rank profiles based on available flag

2013-11-12 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz luiz.von.de...@intel.com This makes module-bluetooth-policy to rank profiles based on their available flag and only consider their priority in case profiles have the same rank. --- src/modules/bluetooth/module-bluetooth-policy.c | 17 + 1 file changed

Re: [pulseaudio-discuss] card: Only set active_profile with available profile

2013-11-17 Thread Luiz Augusto von Dentz
: src/pulsecore/card.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) New commits: commit f434087e42bca15fae938f6cc01d2875c4c7728b Author: Luiz Augusto von Dentz luiz.von.de...@intel.com Date: Sun Nov 3 15:05:34 2013 +0200 card: Only set active_profile with available

Re: [pulseaudio-discuss] [PATCH 5/5] bluetooth: Set device_info_valid to -1 when the device's adapter disappears

2013-11-17 Thread Luiz Augusto von Dentz
without the adapter. Note the adapter will only disappear if it is really unplugged, if the adapter is just powered down it will continue to be present, so Im not really sure what is benefit of having a invalid devices around. -- Luiz Augusto von Dentz

Re: [pulseaudio-discuss] [RFC 2/2] bluetooth: Rank profiles based on available flag

2013-11-18 Thread Luiz Augusto von Dentz
Hi Tanu, On Mon, Nov 18, 2013 at 9:36 AM, Tanu Kaskinen tanu.kaski...@linux.intel.com wrote: On Tue, 2013-11-12 at 13:02 +0200, Luiz Augusto von Dentz wrote: From: Luiz Augusto von Dentz luiz.von.de...@intel.com This makes module-bluetooth-policy to rank profiles based on their available

Re: [pulseaudio-discuss] card: Only set active_profile with available profile

2013-11-18 Thread Luiz Augusto von Dentz
Hi Tanu, On Mon, Nov 18, 2013 at 9:25 AM, Tanu Kaskinen tanu.kaski...@linux.intel.com wrote: On Sun, 2013-11-17 at 17:53 +0200, Luiz Augusto von Dentz wrote: Hi Colin, Tanu, On Sun, Nov 17, 2013 at 3:17 PM, Colin Guthrie gm...@colin.guthr.ie wrote: 'Twas brillig, and Tanu Kaskinen at 16/11

Re: [pulseaudio-discuss] [RFC 2/2] bluetooth: Rank profiles based on available flag

2013-11-18 Thread Luiz Augusto von Dentz
Hi Tanu, On Mon, Nov 18, 2013 at 4:32 PM, Tanu Kaskinen tanu.kaski...@linux.intel.com wrote: On Mon, 2013-11-18 at 16:20 +0200, Luiz Augusto von Dentz wrote: Hi Tanu, On Mon, Nov 18, 2013 at 9:36 AM, Tanu Kaskinen tanu.kaski...@linux.intel.com wrote: On Tue, 2013-11-12 at 13:02 +0200, Luiz

Re: [pulseaudio-discuss] card: Only set active_profile with available profile

2013-11-19 Thread Luiz Augusto von Dentz
Hi Tanu, On Tue, Nov 19, 2013 at 9:37 AM, Tanu Kaskinen tanu.kaski...@linux.intel.com wrote: On Mon, 2013-11-18 at 16:51 +0200, Luiz Augusto von Dentz wrote: Hi Tanu, On Mon, Nov 18, 2013 at 9:25 AM, Tanu Kaskinen tanu.kaski...@linux.intel.com wrote: On Sun, 2013-11-17 at 17:53 +0200, Luiz

Re: [pulseaudio-discuss] [PATCH v3 1/2] bluetooth: Fix Media Endpoint for HandsfreeGateway

2011-08-29 Thread Luiz Augusto von Dentz
(%s profile=\hfgw\, args);             pa_log_debug(Loading module-bluetooth-device %s, args); -- 1.7.1 Looks good, ack. -- Luiz Augusto von Dentz ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http

Re: [pulseaudio-discuss] [PATCH v3 2/2] bluetooth: Do not unload module-bluetooth-device on ERR or HUP

2011-08-29 Thread Luiz Augusto von Dentz
, PA_MESSAGE_SHUTDOWN);  finish: -- 1.7.1 IMO in such cases we should set the profile to Off to indicate the profile is not working properly, then the ui can either retry or switch to another profile e.g. A2DP. -- Luiz Augusto von Dentz ___ pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH v3 1/2] bluetooth: Fix Media Endpoint for HandsfreeGateway

2011-08-29 Thread Luiz Augusto von Dentz
Hi Colin, On Mon, Aug 29, 2011 at 11:54 AM, Colin Guthrie gm...@colin.guthr.ie wrote: 'Twas brillig, and Luiz Augusto von Dentz at 29/08/11 09:49 did gyre and gimble: Looks good, ack. As I don't know this code well, can you give me an indication of the likelihood of this change causing

Re: [pulseaudio-discuss] [PATCH 1/4] bluetooth/sbc: Use __asm__ keyword

2011-09-05 Thread Luiz Augusto von Dentz
to servers problems (we use kernel.org), once that got fixed I will try to get this upstream. -- Luiz Augusto von Dentz ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio

Re: [pulseaudio-discuss] [PATCH v3 2/2] bluetooth: Do not unload module-bluetooth-device on ERR or HUP

2011-09-08 Thread Luiz Augusto von Dentz
this workaround. -- Luiz Augusto von Dentz ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] Bluetooth Headset Problem

2011-09-08 Thread Luiz Augusto von Dentz
make sure you have /etc/bluetooth/audio.conf to use PCM routing instead of HCI (default), the signalling part seems ok meaning the SCO link is connected so it appears something is wrong with bto configuration, usually SCO sample spec is 8khz. -- Luiz Augusto von Dentz

Re: [pulseaudio-discuss] Setting Bluetooth headset connection to *both* A2DP _AND_ HSP at the same time?

2011-09-14 Thread Luiz Augusto von Dentz
to a2dp. -- Luiz Augusto von Dentz ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

[pulseaudio-discuss] [PATCH 1/2] sbc: overflow bugfix and audio decoding quality improvement

2011-10-20 Thread Luiz Augusto von Dentz
From: Siarhei Siamashka siarhei.siamas...@nokia.com The (((audio_sample 1) | 1) frame-scale_factor[ch][sb]) part of expression frame-sb_sample[blk][ch][sb] = (((audio_sample 1) | 1) frame-scale_factor[ch][sb]) / levels[ch][sb] - (1 frame-scale_factor[ch][sb]) in

[pulseaudio-discuss] [PATCH 2/2] sbc: Reduce for-loop induced indentation in sbc_unpack_frame

2011-10-20 Thread Luiz Augusto von Dentz
From: Johan Hedberg johan.hedb...@intel.com --- src/modules/bluetooth/sbc/sbc.c | 36 1 files changed, 20 insertions(+), 16 deletions(-) diff --git a/src/modules/bluetooth/sbc/sbc.c b/src/modules/bluetooth/sbc/sbc.c index ad391bd..c5015ab 100644 ---

Re: [pulseaudio-discuss] [PATCH] When BT profile is changed, bt transport is released

2011-11-02 Thread Luiz Augusto von Dentz
because the 1.0 release. -- Luiz Augusto von Dentz ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [RFC 3/5] bluetooth: Avoid using IPC mechanism to BlueZ

2011-11-18 Thread Luiz Augusto von Dentz
summit, the reason why I didn't push them is because we still have unix socket as default in audio.conf but Im about to deprecated it in favor of Media, this means next version onward will have Media as default mechanism then we can apply this changes. -- Luiz Augusto von Dentz

Re: [pulseaudio-discuss] [RFC 0/5] bluetooth: Use BlueZ's media API only

2011-11-18 Thread Luiz Augusto von Dentz
is because I want PA to depend on the new version of BlueZ which should have Media API enabled by default, but due to kernel.org problems we were delayed quite a bit, if distros don't want to upgrade it is their call but I don't think this should stop us from syncing this work. -- Luiz Augusto von

Re: [pulseaudio-discuss] [PATCH 1/3] bluetooth: Do not switch to profile unless Playing

2011-11-25 Thread Luiz Augusto von Dentz
was thinking of another patch to fix this second problem. That sounds a better place to fix this, basically if we have a profile in Playing state it should have the highest priority which should prevent the profile switching. -- Luiz Augusto von Dentz

Re: [pulseaudio-discuss] [PATCH 3/3] bluetooth: Fix property reply handling for hfgw

2011-11-25 Thread Luiz Augusto von Dentz
if (dbus_message_has_interface(p-message, org.bluez.HandsfreeGateway)) { -                if (parse_audio_property(y, d-hfgw_state, arg_i) 0) +                if (parse_audio_property(y, d-hfgw_state, dict_i) 0)                     goto finish;             } -- 1.7.6.4 Ack. -- Luiz Augusto von Dentz

Re: [pulseaudio-discuss] [RFC] bluetooth: Add support for org.bluez.Adapter and org.bluez.FMRadio.

2011-12-09 Thread Luiz Augusto von Dentz
the maemo6 plugin which should only be loaded for its platform. This way we also put pressure in having the hardware/driver exposing everything properly, otherwise it has to do its dirty work themselves. -- Luiz Augusto von Dentz ___ pulseaudio-discuss

Re: [pulseaudio-discuss] [RFC 0/3] Automatically enable loopback on sources

2012-01-24 Thread Luiz Augusto von Dentz
? Im not sure this will always be static which apparently is what it implicates by being in module-bluetooth-discover, lets say in some conditions the audio should not be send back to loopback or loopback is not the default sink/source. -- Luiz Augusto von Dentz

Re: [pulseaudio-discuss] [RFC 0/3] Automatically enable loopback on sources

2012-01-25 Thread Luiz Augusto von Dentz
a decision based on intent role, but anyways IMO the routing decisions should not be in module-bluetooth-discover. -- Luiz Augusto von Dentz ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [pulseaudio-discuss] [RFC 01/12] bluetooth: MP3 passthrough over A2DP

2012-02-16 Thread Luiz Augusto von Dentz
, that way is much easier to extend with other codec support latter. Also lets avoid the use unix socket since it is considered deprecated. -- Luiz Augusto von Dentz ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http

[pulseaudio-discuss] [PATCH] bluetooth: Fix calling many times Audio.GetProperties for the same device

2012-02-20 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz luiz.von.de...@intel.com Audio.GetProperties is been called for as many times as there are UUIDs instead of just once when the UUIDs are discovered. --- src/modules/bluetooth/bluetooth-util.c | 17 - 1 files changed, 12 insertions(+), 5 deletions

Re: [pulseaudio-discuss] [PATCH] bluetooth: Release transport when the pa_rtpoll_run loop finishes.

2012-05-23 Thread Luiz Augusto von Dentz
) +                bt_transport_release(u); +            else +                stop_stream_fd(u);             goto finish; +        }         pollfd = u-rtpoll_item ? pa_rtpoll_item_get_pollfd(u-rtpoll_item, NULL) : NULL; -- 1.7.0.4 Looks good, ack. -- Luiz Augusto von Dentz

Re: [pulseaudio-discuss] [PATCH] Add profile argument to module-bluetooth-discover

2012-05-23 Thread Luiz Augusto von Dentz
requiring any user interaction to configure them after being turned on. I guess we need the policy module to handle this case, the policy should be if there is no voice/call default A2DP otherwise HFP should be used. -- Luiz Augusto von Dentz

Re: [pulseaudio-discuss] Using mutiple bluetooth headsets at the same time

2012-06-04 Thread Luiz Augusto von Dentz
as modules so you could add mode via configuration, but right now it is hardcoded. -- Luiz Augusto von Dentz ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH v2] bluetooth: Fix bluetooth.nrec property not updated

2012-06-15 Thread Luiz Augusto von Dentz
); -- 1.7.9.5 Looks good, ack. -- Luiz Augusto von Dentz ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

[pulseaudio-discuss] [PATCH 1/2] bluetooth: Fix using deprecated method org.bluez.Manager.ListAdapters

2012-07-06 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz luiz.von.de...@intel.com It has been deprecated for quite some time and is now removed from BlueZ's tree so it would not work with upcoming releases anymore. To fix this the code now uses org.bluez.Manager.GetProperties and look for 'Adapters' property since

[pulseaudio-discuss] [PATCH 2/2] bluetooth: Fix using deprecated method org.bluez.Adapter.ListDevices

2012-07-06 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz luiz.von.de...@intel.com It has been deprecated for quite some time and is now removed from BlueZ's tree so it would not work with upcoming releases anymore. To fix this the code now uses org.bluez.Adapter.GetProperties and look for 'Devices' property since

Re: [pulseaudio-discuss] [PATCH] modules: Allow bluetooth SBC to disable SIMD optimizations with PULSE_NO_SIMD

2012-07-20 Thread Luiz Augusto von Dentz
how to keep the history. -- Luiz Augusto von Dentz ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [RFC v1 1/3] bluetooth: Replace deprecated ListAdapters()

2012-07-27 Thread Luiz Augusto von Dentz
(ai) == DBUS_TYPE_OBJECT_PATH +pa_streq(key, Adapters)) { I guess it is more efficient if you do pa_streq(key, Adapters) before dbus_message_iter_recurse. -- Luiz Augusto von Dentz ___ pulseaudio-discuss mailing list pulseaudio

Re: [pulseaudio-discuss] [PATCH v1 2/4] bluetooth: Do not switch to profile unless Playing

2012-07-27 Thread Luiz Augusto von Dentz
is created, this include setting up loopback and switching profiles. Now regarding the problem of requesting the stream I though this would be fixed by Acquire with '?', or this is a different matter? -- Luiz Augusto von Dentz ___ pulseaudio-discuss mailing

Re: [pulseaudio-discuss] [PATCH v0 3/5] bluetooth: Do not switch to profile unless Playing

2012-08-01 Thread Luiz Augusto von Dentz
. In case of being switched by the policy it should probably pass '?' so we avoid the race condition where for some reason the phone has disconnected SCO while we were attempting to acquire it, in the same way the policy can release the SCO connection by setting the profile to 'off'. -- Luiz Augusto

Re: [pulseaudio-discuss] [PATCH] bluetooth: Remove ipc.[ch] files in the bluetooth module

2012-08-01 Thread Luiz Augusto von Dentz
: a2dp-sbc.blocks = SBC_BLK_16; break; default: -- 1.7.9.5 I though this was part of Mikel's patches, but apparently he forgot about this. Ack. -- Luiz Augusto von Dentz ___ pulseaudio-discuss mailing list pulseaudio-discuss

[pulseaudio-discuss] [PATCH 2/3] bluetooth: Set initial profile priority based on profile state

2012-08-17 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz luiz.von.de...@intel.com This means only profiles on PA_BT_AUDIO_STATE_PLAYING state will have bigger priority than 'Off'. --- src/modules/bluetooth/module-bluetooth-device.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/modules

[pulseaudio-discuss] [PATCH 3/3] bluetooth: Don't force any profile on discovery module

2012-08-17 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz luiz.von.de...@intel.com Let device module figure out the priority based on the state of the profiles. Note that most likely all profiles will be in PA_BT_AUDIO_STATE_CONNECTED state so 'Off' will be the initial profile then it is up to the policy module to switch

Re: [pulseaudio-discuss] [PATCH 2/3] bluetooth: Set initial profile priority based on profile state

2012-08-17 Thread Luiz Augusto von Dentz
Hi Mikel, On Fri, Aug 17, 2012 at 6:07 PM, Mikel Astiz mikel.astiz@gmail.com wrote: Hi Luiz, On Fri, Aug 17, 2012 at 4:21 PM, Luiz Augusto von Dentz luiz.de...@gmail.com wrote: From: Luiz Augusto von Dentz luiz.von.de...@intel.com This means only profiles on PA_BT_AUDIO_STATE_PLAYING

Re: [pulseaudio-discuss] [PATCH v0 12/20] bluetooth: Acquire transport when becomes available

2012-08-22 Thread Luiz Augusto von Dentz
this for port availability to trigger acquire? -- Luiz Augusto von Dentz ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH v0 16/20] bluetooth: Remove profile argument from bluetooth-device

2012-08-23 Thread Luiz Augusto von Dentz
without module-bluetooth-discovery. -- Luiz Augusto von Dentz ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH v2 00/22] Revisiting Bluetooth modules

2012-09-06 Thread Luiz Augusto von Dentz
wait until we have it implement in BlueZ. -- Luiz Augusto von Dentz ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH 1/3] bluetooth: Remove built-in/static SBC codec

2012-09-06 Thread Luiz Augusto von Dentz
Hi Tanu, On Thu, Sep 6, 2012 at 3:29 PM, Tanu Kaskinen ta...@iki.fi wrote: On Fri, 2012-08-17 at 17:21 +0300, Luiz Augusto von Dentz wrote: @@ -2087,4 +2066,4 @@ coverage: @echo endif -.PHONY: massif update-all update-ffmpeg update-sbc update-map-file coverage +.PHONY: massif

[pulseaudio-discuss] [PATCH 1/4] bluetooth: Add basic support for HEADSET profiles

2014-08-13 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@openbossa.org This commit adds basic support for devices implementing HSP Headset Unit, HSP Audio Gateway, HFP Handsfree Unit, HFP Audio Gateway to the BlueZ 5 bluetooth audio devices driver module (module-bluez5-device). ---

[pulseaudio-discuss] [PATCH 4/4] bluetooth: Create oFono backend

2014-08-13 Thread Luiz Augusto von Dentz
From: Jo??o Paulo Rechi Vita jprv...@openbossa.org --- configure.ac | 4 +- src/modules/bluetooth/backend-ofono.c | 143 ++ 2 files changed, 145 insertions(+), 2 deletions(-) create mode 100644 src/modules/bluetooth/backend-ofono.c

[pulseaudio-discuss] [PATCH 2/4] bluetooth: Add BlueZ 5 headset profile names in policy module

2014-08-13 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@gmail.com --- src/modules/bluetooth/module-bluetooth-policy.c | 27 - 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/src/modules/bluetooth/module-bluetooth-policy.c b/src/modules/bluetooth/module-bluetooth-policy.c

Re: [pulseaudio-discuss] [PATCH 4/4] bluetooth: Create oFono backend

2014-08-18 Thread Luiz Augusto von Dentz
Hi Tanu, On Sun, Aug 17, 2014 at 1:04 PM, Tanu Kaskinen tanu.kaski...@linux.intel.com wrote: On Wed, 2014-08-13 at 15:23 +0300, Luiz Augusto von Dentz wrote: From: João Paulo Rechi Vita jprv...@openbossa.org --- configure.ac | 4 +- src/modules/bluetooth/backend

[pulseaudio-discuss] [PATCH v2 1/4] bluetooth: Add basic support for HEADSET profiles

2014-08-19 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@openbossa.org This commit adds basic support for devices implementing HSP Headset Unit, HSP Audio Gateway, HFP Handsfree Unit, HFP Audio Gateway to the BlueZ 5 bluetooth audio devices driver module (module-bluez5-device). ---

[pulseaudio-discuss] [PATCH v2 2/4] bluetooth: Add BlueZ 5 headset profile names in policy module

2014-08-19 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@gmail.com --- src/modules/bluetooth/module-bluetooth-policy.c | 27 - 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/src/modules/bluetooth/module-bluetooth-policy.c b/src/modules/bluetooth/module-bluetooth-policy.c

[pulseaudio-discuss] [PATCH v2 3/4] bluetooth: Create NULL backend

2014-08-19 Thread Luiz Augusto von Dentz
From: Jo??o Paulo Rechi Vita jprv...@openbossa.org --- configure.ac | 16 src/Makefile.am | 3 ++- src/modules/bluetooth/backend-null.c | 37 src/modules/bluetooth/bluez5-util.c | 5 +

[pulseaudio-discuss] [PATCH v2 4/4] bluetooth: Create oFono backend

2014-08-19 Thread Luiz Augusto von Dentz
From: Jo??o Paulo Rechi Vita jprv...@openbossa.org --- configure.ac | 6 +- src/modules/bluetooth/backend-ofono.c | 143 ++ 2 files changed, 146 insertions(+), 3 deletions(-) create mode 100644 src/modules/bluetooth/backend-ofono.c

Re: [pulseaudio-discuss] [PATCH v2 1/4] bluetooth: Add basic support for HEADSET profiles

2014-08-21 Thread Luiz Augusto von Dentz
Hi Tanu, On Thu, Aug 21, 2014 at 2:29 PM, Tanu Kaskinen tanu.kaski...@linux.intel.com wrote: On Thu, 2014-08-21 at 14:12 +0300, Luiz Augusto von Dentz wrote: Hi Tanu, On Wed, Aug 20, 2014 at 2:40 PM, Tanu Kaskinen tanu.kaski...@linux.intel.com wrote: On Tue, 2014-08-19 at 15:54 +0300, Luiz

[pulseaudio-discuss] [PATCH v3 1/5] bluetooth: Add basic support for HEADSET profiles

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@openbossa.org This commit adds basic support for devices implementing HSP Headset Unit, HSP Audio Gateway, HFP Handsfree Unit, HFP Audio Gateway to the BlueZ 5 bluetooth audio devices driver module (module-bluez5-device). ---

[pulseaudio-discuss] [PATCH v3 4/5] bluetooth: Create NULL backend

2014-08-22 Thread Luiz Augusto von Dentz
From: Jo??o Paulo Rechi Vita jprv...@openbossa.org --- configure.ac | 16 src/Makefile.am | 3 ++- src/modules/bluetooth/backend-null.c | 37 src/modules/bluetooth/bluez5-util.c | 5 +

[pulseaudio-discuss] [PATCH v3 3/5] bluetooth: Add BlueZ 5 headset profile names in policy module

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@gmail.com --- src/modules/bluetooth/module-bluetooth-policy.c | 27 - 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/src/modules/bluetooth/module-bluetooth-policy.c b/src/modules/bluetooth/module-bluetooth-policy.c

[pulseaudio-discuss] [PATCH 03/17] bluetooth: Register/Unregister Handsfree Audio Agent with oFono

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@openbossa.org Register as a HandsfreeAudioAgent with oFono during backend initialization and unregiter during backend finalization. This commit also adds a check when receiving method calls or signals to make sure the sender matches with the D-Bus service we're

[pulseaudio-discuss] [PATCH 04/17] bluetooth: List HandsfreeAudioCard objects from oFono

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@openbossa.org --- src/modules/bluetooth/backend-ofono.c | 54 ++- 1 file changed, 53 insertions(+), 1 deletion(-) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index

[pulseaudio-discuss] [PATCH 09/17] bluetooth: Handle CardAdded signal

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@openbossa.org --- src/modules/bluetooth/backend-ofono.c | 40 +-- 1 file changed, 29 insertions(+), 11 deletions(-) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index

[pulseaudio-discuss] [PATCH 07/17] bluetooth: Implement transport release for hf_audio_agent transports

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@openbossa.org --- src/modules/bluetooth/backend-ofono.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index 5fb99de..f9157e3 100644 ---

[pulseaudio-discuss] [PATCH 16/17] bluetooth: Fix crash while disconnecting

2014-08-22 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz luiz.von.de...@intel.com Transport can be NULL in case the device could not be found. --- src/modules/bluetooth/backend-ofono.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth

[pulseaudio-discuss] [PATCH 01/17] bluetooth: Monitor D-Bus signals

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@openbossa.org --- src/modules/bluetooth/backend-ofono.c | 49 --- 1 file changed, 45 insertions(+), 4 deletions(-) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index

[pulseaudio-discuss] [PATCH 06/17] bluetooth: Implement transport acquire for hf_audio_agent transports

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@openbossa.org --- src/modules/bluetooth/backend-ofono.c | 66 ++- 1 file changed, 65 insertions(+), 1 deletion(-) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index

[pulseaudio-discuss] [PATCH 05/17] bluetooth: Parse HandsfreeAudioCard properties

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@openbossa.org --- src/modules/bluetooth/backend-ofono.c | 110 +- 1 file changed, 108 insertions(+), 2 deletions(-) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index

[pulseaudio-discuss] [PATCH 13/17] bluetooth: Suspend the source/sink the HFP-oFono stream fd HUP

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@openbossa.org --- src/modules/bluetooth/module-bluez5-device.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/modules/bluetooth/module-bluez5-device.c b/src/modules/bluetooth/module-bluez5-device.c index 5398a1b..7ea4b55 100644 ---

[pulseaudio-discuss] [PATCH 02/17] bluetooth: Create hf_dbus_send_and_add_to_pending() for oFono backend

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@openbossa.org --- src/modules/bluetooth/backend-ofono.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index f5fe472..925b98b 100644 ---

[pulseaudio-discuss] [PATCH 14/17] bluetooth: Allow policy module to pick 'off' profile

2014-08-22 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz luiz.von.de...@intel.com This allow 'off' profile to be choosen when no other profile is available which is considered better since it requires less resources than other profiles. --- src/modules/bluetooth/module-bluetooth-policy.c | 9 - 1 file changed, 4

[pulseaudio-discuss] [PATCH 15/17] bluetooth: Add pa_bluetooth_transport_set_state

2014-08-22 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz luiz.von.de...@intel.com --- src/modules/bluetooth/backend-ofono.c | 15 --- src/modules/bluetooth/bluez5-util.c | 10 +- src/modules/bluetooth/bluez5-util.h | 1 + 3 files changed, 10 insertions(+), 16 deletions(-) diff --git a/src/modules

[pulseaudio-discuss] [PATCH 12/17] bluetooth: Implement org.ofono.HandsfreeAudioAgent.NewConnection()

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@openbossa.org --- src/modules/bluetooth/backend-ofono.c | 31 +-- 1 file changed, 29 insertions(+), 2 deletions(-) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index 1fd56a1..56a1944

[pulseaudio-discuss] [PATCH 08/17] bluetooth: Track oFono service

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@openbossa.org --- src/modules/bluetooth/backend-ofono.c | 36 +++ 1 file changed, 36 insertions(+) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index f9157e3..404a6b5 100644 ---

[pulseaudio-discuss] [PATCH 17/17] bluetooth: Only create backend instance once objects are listed

2014-08-22 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz luiz.von.de...@intel.com This makes sure the devices are discovered before the backend start creating new transports. --- src/modules/bluetooth/bluez5-util.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/modules/bluetooth/bluez5-util.c b

[pulseaudio-discuss] [PATCH 10/17] bluetooth: Handle CardRemoved signal

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@openbossa.org --- src/modules/bluetooth/backend-ofono.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index e07db01..a499711 100644 ---

[pulseaudio-discuss] [PATCH 11/17] bluetooth: Implement org.ofono.HandsfreeAudioAgent.Release()

2014-08-22 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@openbossa.org --- src/modules/bluetooth/backend-ofono.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index a499711..1fd56a1 100644 ---

Re: [pulseaudio-discuss] [PATCH 4/4] backend-null: add HSP profile support

2014-09-02 Thread Luiz Augusto von Dentz
, PA_BLUETOOTH_PROFILE_HEADSET_HEAD_UNIT); + +pa_xfree(backend); } -- 1.9.3 ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss -- Luiz Augusto von Dentz

Re: [pulseaudio-discuss] [PATCH 06/17] bluetooth: Implement transport acquire for hf_audio_agent transports

2014-09-08 Thread Luiz Augusto von Dentz
Hi Tanu, On Fri, Sep 5, 2014 at 4:03 PM, Tanu Kaskinen tanu.kaski...@linux.intel.com wrote: On Fri, 2014-08-22 at 17:04 +0300, Luiz Augusto von Dentz wrote: From: João Paulo Rechi Vita jprv...@openbossa.org --- src/modules/bluetooth/backend-ofono.c | 66

[pulseaudio-discuss] [PATCH 3/3] bluetooth: Add pa_bluetooth_transport_unlink

2014-09-08 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz luiz.von.de...@intel.com --- src/modules/bluetooth/bluez5-util.c | 4 src/modules/bluetooth/bluez5-util.h | 1 + 2 files changed, 5 insertions(+) diff --git a/src/modules/bluetooth/bluez5-util.c b/src/modules/bluetooth/bluez5-util.c index 3c0d6e1..e14b1fa

[pulseaudio-discuss] [PATCH 2/3] bluetooth: Add pa_bluetooth_transport_set_state

2014-09-08 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz luiz.von.de...@intel.com --- src/modules/bluetooth/bluez5-util.c | 12 +++- src/modules/bluetooth/bluez5-util.h | 1 + 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/modules/bluetooth/bluez5-util.c b/src/modules/bluetooth/bluez5-util.c

[pulseaudio-discuss] [PATCH 1/3] bluetooth: Only create backend instance once objects are listed

2014-09-08 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz luiz.von.de...@intel.com This makes sure the devices are discovered before the backend start creating new transports. --- src/modules/bluetooth/bluez5-util.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/modules/bluetooth/bluez5-util.c b

Re: [pulseaudio-discuss] [PATCH 1/3] bluetooth: Only create backend instance once objects are listed

2014-09-08 Thread Luiz Augusto von Dentz
Hi Tanu, On Mon, Sep 8, 2014 at 12:46 PM, Tanu Kaskinen tanu.kaski...@linux.intel.com wrote: On Mon, 2014-09-08 at 12:14 +0300, Luiz Augusto von Dentz wrote: From: Luiz Augusto von Dentz luiz.von.de...@intel.com This makes sure the devices are discovered before the backend start creating new

[pulseaudio-discuss] [PATCH v2] bluetooth: Only create backend instance once objects are listed

2014-09-08 Thread Luiz Augusto von Dentz
From: Luiz Augusto von Dentz luiz.von.de...@intel.com This makes sure the devices are discovered before the backend start creating new transports. --- src/modules/bluetooth/bluez5-util.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/modules/bluetooth/bluez5

[pulseaudio-discuss] [PATCH v2 07/14] bluetooth: Implement transport release for hf_audio_agent transports

2014-09-10 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@openbossa.org --- src/modules/bluetooth/backend-ofono.c | 16 1 file changed, 16 insertions(+) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index 1ba40b1..8b2cea2 100644 ---

[pulseaudio-discuss] [PATCH v2 02/14] bluetooth: Create hf_dbus_send_and_add_to_pending() for oFono backend

2014-09-10 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@openbossa.org --- src/modules/bluetooth/backend-ofono.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/backend-ofono.c index 99da783..1a4416e 100644 ---

[pulseaudio-discuss] [PATCH v2 13/14] bluetooth: Suspend the source/sink the HFP-oFono stream fd HUP

2014-09-10 Thread Luiz Augusto von Dentz
From: João Paulo Rechi Vita jprv...@openbossa.org --- src/modules/bluetooth/module-bluez5-device.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/modules/bluetooth/module-bluez5-device.c b/src/modules/bluetooth/module-bluez5-device.c index fdf4078..d5d97c1 100644 ---

  1   2   3   >