Re: [pulseaudio-discuss] strange pulse / jack behaviour

2012-10-31 Thread Tanu Kaskinen
On Mon, 2012-10-29 at 20:59 +1100, Patrick Shirkey wrote: Hi, Does anyone have any thoughts on why the following is happening? Using Debian wheezy on an intel board with built in HDA chipset. (Notebook sound card) I was unable to start jack. It seemed like the problem might have been

Re: [pulseaudio-discuss] strange pulse / jack behaviour

2012-10-31 Thread Tanu Kaskinen
On Thu, 2012-11-01 at 03:58 +1100, Patrick Shirkey wrote: On Thu, 1 Nov 2012 03:08:09 +1100 Patrick Shirkey pshir...@boosthardware.com wrote: 3: The current situation is that I cannot run jackd (jack2 -1.9.9) with dbus enabled in qjackctl misc settings window because I get an error :

Re: [pulseaudio-discuss] a question about audio synchronization between local sink and tunnel sink

2012-11-01 Thread Tanu Kaskinen
On Mon, 2012-10-29 at 22:25 +, Sun, Xiaodong wrote: Tanu, I changed module-tunnel.c function send_data() like this: ... if (!latency_updated) pa_sink_render_noise(u-sink, u-requested_bytes, memchunk); else pa_sink_render(u-sink,

Re: [pulseaudio-discuss] a question about audio synchronization between local sink and tunnel sink

2012-11-01 Thread Tanu Kaskinen
On Thu, 2012-11-01 at 15:00 +0200, Tanu Kaskinen wrote: On Mon, 2012-10-29 at 22:25 +, Sun, Xiaodong wrote: 2. Even we can get stable initial sink latency, if new sink's latency is bigger than the other sink's, we use pa_memblockq_drop() to skip some samples in new sink's output

Re: [pulseaudio-discuss] a question about audio synchronization between local sink and tunnel sink

2012-11-03 Thread Tanu Kaskinen
On Fri, 2012-11-02 at 01:02 +, Sun, Xiaodong wrote: Tanu, This is pa_sink_render_noise(): void pa_sink_render_noise(pa_sink*s, size_t length, pa_memchunk *result) { pa_mix_info info[MAX_MIX_CHANNELS]; unsigned n; size_t block_size_max; pa_sink_assert_ref(s);

Re: [pulseaudio-discuss] [PATCH] man pulse-daemon.conf: Correct typoes

2012-11-03 Thread Tanu Kaskinen
On Wed, 2012-10-31 at 18:50 +0100, Wieland Hoffmann wrote: --- man/pulse-daemon.conf.5.xml.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/man/pulse-daemon.conf.5.xml.in b/man/pulse-daemon.conf.5.xml.in index a824178..49f9f22 100644 ---

Re: [pulseaudio-discuss] [PATCH] stream: Return error in case a client peeks to early

2012-11-04 Thread Tanu Kaskinen
On Sat, 2012-11-03 at 19:51 +0100, David Henningsson wrote: 2012-11-03 17:19, Colin Guthrie skrev: 'Twas brillig, and Tanu Kaskinen at 05/10/12 13:58 did gyre and gimble: On Wed, 2012-10-03 at 08:50 +0200, David Henningsson wrote: On 10/02/2012 10:38 PM, Tanu Kaskinen wrote: On Mon, 2012

Re: [pulseaudio-discuss] [PATCH] stream: Return error in case a client peeks to early

2012-11-05 Thread Tanu Kaskinen
On Sun, 2012-11-04 at 23:09 +0100, David Henningsson wrote: On 11/04/2012 02:22 PM, Tanu Kaskinen wrote: On Sat, 2012-11-03 at 19:51 +0100, David Henningsson wrote: Returning NULL seems to be the right thing to do here, even if gnome-control-center does not handle that very well IIRC. So we

[pulseaudio-discuss] [PATCH] pulse: Fix hole handling in pa_stream_peek().

2012-11-07 Thread Tanu Kaskinen
Previously, if there was a hole in a recording stream, pa_stream_peek() would crash. Holes could be handled silently inside pa_stream_peek() by generating silence (wouldn't work for compressed streams, though) or by skipping any holes. However, I think it's better to let the caller decide how the

Re: [pulseaudio-discuss] [PATCH 4/5] mainloop: Write to the wakeup pipe unconditionally when waking up the mainloop.

2012-11-07 Thread Tanu Kaskinen
Ping! This old patch should fix a recently reported bug: https://bugs.freedesktop.org/show_bug.cgi?id=56735 This patch seems to depend on patches 1 and 3 in the series -- Tanu On Mon, 2012-04-02 at 15:01 +0300, Tanu Kaskinen wrote: If the mainloop is just about to enter polling, but m-state

Re: [pulseaudio-discuss] [PATCH] pulse: Fix hole handling in pa_stream_peek().

2012-11-07 Thread Tanu Kaskinen
On Wed, 2012-11-07 at 14:21 +0100, David Henningsson wrote: On 11/07/2012 09:36 AM, Tanu Kaskinen wrote: Previously, if there was a hole in a recording stream, pa_stream_peek() would crash. Holes could be handled silently inside pa_stream_peek() by generating silence (wouldn't work

[pulseaudio-discuss] [PATCH v2 0/4] Handling holes in recording streams.

2012-11-07 Thread Tanu Kaskinen
Changes in v2: - Split the patch into four parts. - Simplified buffer allocation in pacat by taking advantage of realloc's behavior when the input pointer is null. - Made the silence buffer in pacat a global variable to reduce repeated allocation and freeing of the buffer. Tanu Kaskinen

[pulseaudio-discuss] [PATCH v2 1/4] pulse: Fix hole handling in pa_stream_peek().

2012-11-07 Thread Tanu Kaskinen
Previously, if there was a hole in a recording stream, pa_stream_peek() would crash. Holes could be handled silently inside pa_stream_peek() by generating silence (wouldn't work for compressed streams, though) or by skipping any holes. However, I think it's better to let the caller decide how the

Re: [pulseaudio-discuss] [PATCH] bluetooth: Add support for transport created by external profile

2012-11-08 Thread Tanu Kaskinen
On Wed, 2012-11-07 at 17:56 +0200, Luiz Augusto von Dentz wrote: --- a/src/modules/bluetooth/bluetooth-util.h +++ b/src/modules/bluetooth/bluetooth-util.h @@ -72,6 +72,7 @@ typedef enum pa_bluetooth_transport_hook { struct pa_bluetooth_transport { pa_bluetooth_discovery *y; +

Re: [pulseaudio-discuss] [PATCH v2 4/4] pacat: Handle holes in recording streams.

2012-11-09 Thread Tanu Kaskinen
On Thu, 2012-11-08 at 22:27 +0530, Arun Raghavan wrote: On Wed, 2012-11-07 at 16:52 +0200, Tanu Kaskinen wrote: [...] -if (buffer) { +/* If there is a hole in the stream, we generate silence, except + * if it's a passthrough stream in which case we

Re: [pulseaudio-discuss] jackdbus module, pulse fails to conform on device reservation API

2012-11-09 Thread Tanu Kaskinen
On Tue, 2012-11-06 at 15:58 -0500, Ian Malone wrote: method call sender=:1.110 - dest=org.freedesktop.ReserveDevice1.Audio1 serial=6 path=/org/freedesktop/ReserveDevice1/Audio1; interface=org.freedesktop.ReserveDevice1; member=RequestRelease int32 2147483647 error sender=:1.35 -

Re: [pulseaudio-discuss] jackdbus module, pulse fails to conform on device reservation API

2012-11-09 Thread Tanu Kaskinen
On Fri, 2012-11-09 at 11:15 +, Ian Malone wrote: Some more data on this, I can actually attach a third audio interface to this machine. I've tried that and looked at this with d-feet. Part of the behaviour seems to be coupled with what happens when you restart pulse. With three devices you

Re: [pulseaudio-discuss] [PATCH pavucontrol] mainwindow: Show the availability of the ports and profiles.

2012-11-09 Thread Tanu Kaskinen
On Thu, 2012-11-08 at 23:38 +0100, poljar (Damir Jelić) wrote: From: poljar (Damir Jelić) poljari...@gmail.com If we know if a certain port is available/unavailable, we can print that out, as a help to the user (and as debugging for ourselves). A profile is also available/unavailable if all

Re: [pulseaudio-discuss] [PATCH v2 0/3] Bluetooth: Late UUID support

2012-11-09 Thread Tanu Kaskinen
On Sun, 2012-11-04 at 18:47 +0100, Mikel Astiz wrote: Hi, On Fri, Oct 26, 2012 at 8:23 AM, Mikel Astiz mikel.astiz@gmail.com wrote: From: Mikel Astiz mikel.as...@bmw-carit.de v2 simplifies patch v1 3/6 (now patch v2 1/3) as proposed by Tanu: - Use assertion instead of returning

Re: [pulseaudio-discuss] [PATCH pavucontrol] mainwindow: Show the availability of the ports and profiles.

2012-11-09 Thread Tanu Kaskinen
On Fri, 2012-11-09 at 19:29 +0100, David Henningsson wrote: On 11/09/2012 07:17 PM, Tanu Kaskinen wrote: On Thu, 2012-11-08 at 23:38 +0100, poljar (Damir Jelić) wrote: +if (hasNo !hasYes !hasOther) +desc += (unplugged); +else if (hasYes !hasNo !hasOther

Re: [pulseaudio-discuss] [PATCH pavucontrol] mainwindow: Show the availability of the ports and profiles.

2012-11-10 Thread Tanu Kaskinen
On Sat, 2012-11-10 at 22:54 +0100, David Henningsson wrote: On 11/09/2012 08:26 PM, Tanu Kaskinen wrote: On Fri, 2012-11-09 at 19:29 +0100, David Henningsson wrote: On 11/09/2012 07:17 PM, Tanu Kaskinen wrote: On Thu, 2012-11-08 at 23:38 +0100, poljar (Damir Jelić) wrote

Re: [pulseaudio-discuss] [PATCH] bluetooth: Add support for transport created by external profile

2012-11-12 Thread Tanu Kaskinen
On Mon, 2012-11-12 at 11:16 +0200, Luiz Augusto von Dentz wrote: Hi Tanu, On Thu, Nov 8, 2012 at 3:52 PM, Tanu Kaskinen ta...@iki.fi wrote: On Wed, 2012-11-07 at 17:56 +0200, Luiz Augusto von Dentz wrote: --- a/src/modules/bluetooth/bluetooth-util.h +++ b/src/modules/bluetooth/bluetooth

Re: [pulseaudio-discuss] What does unknown as a port availability status mean? And how do I get rid of it?

2012-11-13 Thread Tanu Kaskinen
On Wed, 2012-11-14 at 00:44 +1030, Jordan Windsor wrote: ports: analog-output: Analog Output (priority 9900, available: unknown) properties: analog-output-headphones: Headphones (priority 9000, available: yes) properties: active port: analog-output-headphones At the bottom you can see the

Re: [pulseaudio-discuss] [PATCH v1] bluetooth: Add support for transport created by external profile

2012-11-13 Thread Tanu Kaskinen
On Mon, 2012-11-12 at 12:26 +0200, Luiz Augusto von Dentz wrote: From: Luiz Augusto von Dentz luiz.von.de...@intel.com With BlueZ 5 it is possible to have profile registered by a third party process which does not share the same bus id as bluetoothd so it is necessary to store the sender of

Re: [pulseaudio-discuss] [RFC 1/2] bluetooth: Add MediaTransport volume management

2012-11-13 Thread Tanu Kaskinen
On Mon, 2012-11-12 at 16:19 +0100, Frédéric Danis wrote: With BlueZ 5 volume updates for HFP will go through transport interface. Note that this is backward compatible. --- src/modules/bluetooth/bluetooth-util.c | 62 +++ src/modules/bluetooth/bluetooth-util.h

Re: [pulseaudio-discuss] [RFC 2/2] bluetooth: Add inband ringtone property

2012-11-13 Thread Tanu Kaskinen
On Mon, 2012-11-12 at 16:19 +0100, Frédéric Danis wrote: --- src/modules/bluetooth/module-bluetooth-device.c | 37 +++ 1 file changed, 37 insertions(+) diff --git a/src/modules/bluetooth/module-bluetooth-device.c b/src/modules/bluetooth/module-bluetooth-device.c

Re: [pulseaudio-discuss] jackdbus module, pulse fails to conform on device reservation API

2012-11-13 Thread Tanu Kaskinen
On Sun, 2012-11-11 at 12:21 -0500, Ian Malone wrote: On 10 November 2012 05:25, Ian Malone ibmal...@gmail.com wrote: On 9 November 2012 17:34, Tanu Kaskinen ta...@iki.fi wrote: On Tue, 2012-11-06 at 15:58 -0500, Ian Malone wrote: method call sender=:1.110 - dest

Re: [pulseaudio-discuss] What does unknown as a port availability status mean? And how do I get rid of it?

2012-11-14 Thread Tanu Kaskinen
On Wed, 2012-11-14 at 13:19 +0800, Raymond Yau wrote: ports: analog-output: Analog Output (priority 9900, available: unknown) properties: analog-output-headphones: Headphones (priority 9000, available: yes) properties: active port: analog-output-headphones At the bottom you

Re: [pulseaudio-discuss] [PATCH 0/5] A bunch of pa_mainloop_wakeup() related fixes

2012-11-15 Thread Tanu Kaskinen
On Thu, 2012-11-15 at 18:11 +0530, Arun Raghavan wrote: On 2 April 2012 17:31, Tanu Kaskinen tanu.kaski...@digia.com wrote: Coverity warned about an unchecked pa_write() return value, which is fixed in the last patch of this series. While figuring out what pa_mainloop_wakeup() was supposed

[pulseaudio-discuss] [PATCH] bluetooth: Unload the device module when the device becomes disconnected.

2012-11-18 Thread Tanu Kaskinen
The bug was most likely introduced in this commit: http://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?id=ea45f2c7951a81b2f43029892535d6a6280eb97e BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=57239 --- src/modules/bluetooth/bluetooth-util.c | 10 +++---

Re: [pulseaudio-discuss] [PATCH] bluetooth: Unload the device module when the device becomes disconnected.

2012-11-19 Thread Tanu Kaskinen
On Mon, 2012-11-19 at 09:32 +0100, Mikel Astiz wrote: Hi Tanu, On Sun, Nov 18, 2012 at 10:55 PM, Tanu Kaskinen ta...@iki.fi wrote: The bug was most likely introduced in this commit: http://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?id=ea45f2c7951a81b2f43029892535d6a6280eb97e Yes

Re: [pulseaudio-discuss] [PATCH] bluetooth: Unload the device module when the device becomes disconnected.

2012-11-19 Thread Tanu Kaskinen
On Mon, 2012-11-19 at 11:52 +0100, Mikel Astiz wrote: Thanks for feedback. So, the module should be unloaded when no audio profiles are connected. Do you see any reason why the checks have to be as complex as they are now in module-bluetooth-discovery: check for dead, device connected,

Re: [pulseaudio-discuss] [PATCH 0/3] rtp: Configurable source IP

2012-11-19 Thread Tanu Kaskinen
On Mon, 2012-11-19 at 17:46 +0530, Arun Raghavan wrote: On Sat, 2012-11-17 at 23:31 +, Robin H. Johnson wrote: From: Robin H. Johnson robb...@gentoo.org On a multi-homed system, the user may wish RTP to be used only on specific interfaces. The default binding of 0.0.0.0 for the

[pulseaudio-discuss] [PATCH pavucontrol] mainwindow: Don't clear the updating flag in updateCard() too early.

2012-11-19 Thread Tanu Kaskinen
The prepareMenu() call can change the active profile selection, which in turn will cause a set card profile command to be sent to the server if the updating flag is not set, so the updating flag needs to be set when calling prepareMenu() from updateCard(). This caused a problem with disconnecting

Re: [pulseaudio-discuss] gnome-shell hangs, waiting for pulse-audio

2012-11-20 Thread Tanu Kaskinen
On Sat, 2012-11-03 at 23:55 +0100, Henrik /KaarPoSoft wrote: On 11/03/12 23:36, Colin Guthrie wrote: 'Twas brillig, and Henrik /KaarPoSoft at 03/11/12 23:07 did gyre and gimble: On 11/03/12 19:20, Colin Guthrie wrote: 'Twas brillig, and Henrik /KaarPoSoft at 10/09/12 21:13 did gyre and

Re: [pulseaudio-discuss] jackdbus module, pulse fails to conform on device reservation API

2012-11-20 Thread Tanu Kaskinen
On Mon, 2012-11-19 at 21:45 +0100, Brendan Jones wrote: On 11/13/2012 08:20 PM, Tanu Kaskinen wrote: On Sun, 2012-11-11 at 12:21 -0500, Ian Malone wrote: On 10 November 2012 05:25, Ian Malone ibmal...@gmail.com wrote: On 9 November 2012 17:34, Tanu Kaskinen ta...@iki.fi wrote: On Tue

Re: [pulseaudio-discuss] pulseaudio daemon not responging

2012-11-20 Thread Tanu Kaskinen
On Mon, 2012-11-19 at 15:41 +0200, Stefan Stefanov wrote: Hello I'm CRUX linux user. Til now my system works with alsa only, I decided to try pulseaudio. I spend several days trying to make pulseaudio works, but without any success. Pulseaudio daemon starts without errors, but it doesn't

[pulseaudio-discuss] [PATCH v2 0/5] Unloading bluetooth device module instances

2012-11-20 Thread Tanu Kaskinen
and only if bluetoothd always sends the update for the Audio interface only after both HSP and A2DP are connected. Tanu Kaskinen (5): bluetooth: Ignore Device.Connected and the whole org.bluez.Audio interface. bluetooth: Add any_audio_profile_connected field to pa_bluetooth_device

[pulseaudio-discuss] [PATCH v2 1/5] bluetooth: Ignore Device.Connected and the whole org.bluez.Audio interface.

2012-11-20 Thread Tanu Kaskinen
The Device.Connected property and the Audio interface were only used for tracking whether a device module should be loaded, but that information is already included in the individual profile state properties. The Device.Connected property and the Audio interface can therefore be completely ignored

[pulseaudio-discuss] [PATCH v2 3/5] bluetooth: Add a pa_bluetooth_discovery pointer to pa_bluetooth_device.

2012-11-20 Thread Tanu Kaskinen
This simplifies some function argument lists. --- src/modules/bluetooth/bluetooth-util.c | 36 +--- src/modules/bluetooth/bluetooth-util.h |1 + 2 files changed, 20 insertions(+), 17 deletions(-) diff --git a/src/modules/bluetooth/bluetooth-util.c

[pulseaudio-discuss] [PATCH v2 4/5] bluetooth: Run the discovery hook only when necessary.

2012-11-20 Thread Tanu Kaskinen
This is a minor optimization too, but the main benefit is that it's makes the code easier to understand (I hope), since run_callback() won't be called at times when it's not needed. --- src/modules/bluetooth/bluetooth-util.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff

[pulseaudio-discuss] [PATCH v2 5/5] bluetooth: Unload the device module when there are no audio profiles connected.

2012-11-20 Thread Tanu Kaskinen
Without this patch, device modules will be left around after the device has been disconnected and when they are reconnected, the discovery module will load duplicate device module instances. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=57239 --- src/modules/bluetooth/bluetooth-util.c

[pulseaudio-discuss] [PATCH reserve] Call change_cb() only when there's an actual change.

2012-11-20 Thread Tanu Kaskinen
Calling change_cb() whenever anything happens in the ownership of the bus name caused trouble in PulseAudio in this scenario: 1. PulseAudio is using a device and owns the corresponding service name. 2. Another application requests device release. 3. PulseAudio releases the device. 4. Change in

Re: [pulseaudio-discuss] jackdbus module, pulse fails to conform on device reservation API

2012-11-20 Thread Tanu Kaskinen
On Tue, 2012-11-20 at 12:45 +0200, Tanu Kaskinen wrote: On Mon, 2012-11-19 at 21:45 +0100, Brendan Jones wrote: I'm seeing this in virtual box under KDE (also Fedora 18 / pulseaudio 2.1). On my real desktop, if I configure qjackctl to autostart on logon and in turn autostart jack I do

Re: [pulseaudio-discuss] jackdbus module, pulse fails to conform on device reservation API

2012-11-20 Thread Tanu Kaskinen
On Tue, 2012-11-20 at 17:59 +, Ian Malone wrote: On 20 November 2012 17:37, Tanu Kaskinen ta...@iki.fi wrote: On Tue, 2012-11-20 at 12:45 +0200, Tanu Kaskinen wrote: On Mon, 2012-11-19 at 21:45 +0100, Brendan Jones wrote: I'm seeing this in virtual box under KDE (also Fedora 18

Re: [pulseaudio-discuss] jackdbus module, pulse fails to conform on device reservation API

2012-11-20 Thread Tanu Kaskinen
On Tue, 2012-11-20 at 20:43 +0200, Tanu Kaskinen wrote: On Tue, 2012-11-20 at 17:59 +, Ian Malone wrote: Thanks, I'll give it a go. I think handling the already_owner case in reserve.c as well might be worthwhile since there may be other ways to get to that state. I think it's a bug

Re: [pulseaudio-discuss] pulseaudio daemon not responging

2012-11-21 Thread Tanu Kaskinen
On Wed, 2012-11-21 at 10:53 +, Colin Guthrie wrote: 'Twas brillig, and Stefan Stefanov at 21/11/12 07:35 did gyre and gimble: Colin ask me to post output from pulseaudio -v. Here is the result as attachment. So, the attachment looks mostly OK, things start up sink is stated etc.

Re: [pulseaudio-discuss] pulseaudio daemon not responging

2012-11-22 Thread Tanu Kaskinen
On Thu, 2012-11-22 at 00:22 +0200, Stefan Stefanov wrote: Ok. Here is a report after simple debugging with traps like pa_log(test); The call stack: pa_alsa_sink_new - alsa-sink.c pa_sink_put(u-sink) - sink.c pa_assert_se(sink_set_state(s, PA_SINK_IDLE) == 0) - sink.c - it hangs here.

Re: [pulseaudio-discuss] gnome-shell hangs, waiting for pulse-audio

2012-11-22 Thread Tanu Kaskinen
On Wed, 2012-11-21 at 21:07 +, Stefan P. wrote: Hello, Yesterday I installed pulseaudio-2.99.2, and since then, the freeze has not happened again! Great! Henrik, is it possible for you to try 2.99.2 too? For what it's worth, last time when I said I can't reproduce this I did have other

Re: [pulseaudio-discuss] pulseaudio daemon not responging

2012-11-22 Thread Tanu Kaskinen
On Thu, 2012-11-22 at 15:15 +0200, Stefan Stefanov wrote: #2 0xb7b1f665 in sem_wait () from /usr/lib/libpthread-stubs.so.0 I think libpthread-stubs.so.0 isn't a very good implementation for sem_wait()... I don't have any straightforward advice for what to do, but maybe you'll find this thread

Re: [pulseaudio-discuss] [PATCH v2 3/5] bluetooth: Add a pa_bluetooth_discovery pointer to pa_bluetooth_device.

2012-11-22 Thread Tanu Kaskinen
On Tue, 2012-11-20 at 16:48 +0200, Tanu Kaskinen wrote: This simplifies some function argument lists. I pushed this patch, the other patches will be reworked by Mikel. -- Tanu ___ pulseaudio-discuss mailing list pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH pavucontrol] mainwindow: Don't clear the updating flag in updateCard() too early.

2012-11-22 Thread Tanu Kaskinen
On Tue, 2012-11-20 at 21:59 +, Colin Guthrie wrote: 'Twas brillig, and Tanu Kaskinen at 19/11/12 13:29 did gyre and gimble: The prepareMenu() call can change the active profile selection, which in turn will cause a set card profile command to be sent to the server if the updating flag

Re: [pulseaudio-discuss] pulseaudio daemon not responging

2012-11-22 Thread Tanu Kaskinen
On Thu, 2012-11-22 at 20:38 +0200, Stefan Stefanov wrote: http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/11000 Exactly the same problem as mine. 1. Build of pulseaudio failed without libpthread-stubs.so with no such file ... 2. I noticed that in crux linux, sem_wait() resides

Re: [pulseaudio-discuss] Bluetooth ports

2012-11-22 Thread Tanu Kaskinen
On Thu, 2012-11-22 at 16:55 +0100, David Henningsson wrote: First, sorry for not being into all the bluetooth details and relying on you to sort it all out correctly... ...now, I'm testing PulseAudio 2.99.2 and things do not show up as I expect them to. In PulseAudio 2.x, there were no

Re: [pulseaudio-discuss] [PATCH v3 4/5] bluetooth: Run the discovery hook only when necessary

2012-11-22 Thread Tanu Kaskinen
On Thu, 2012-11-22 at 15:20 +0100, Mikel Astiz wrote: From: Tanu Kaskinen ta...@iki.fi This is a minor optimization too, but the main benefit is that it's makes the code easier to understand (I hope), since run_callback() won't be called at times when it's not needed. This patch doesn't

Re: [pulseaudio-discuss] [PATCH v3 0/5] Unloading bluetooth device module instances

2012-11-22 Thread Tanu Kaskinen
-letter: Currently, when a bluetooth device is disconnected, pulseaudio doesn't unload the device module. The last patch fixes that. The preceding patches do some refactoring so that the final patch can be as nice as it is. Mikel Astiz (1): bluetooth: Rename former device_use_audio() Tanu

Re: [pulseaudio-discuss] Bluetooth regression: a2dp not selectable

2012-11-23 Thread Tanu Kaskinen
On Fri, 2012-11-23 at 16:40 +0100, David Henningsson wrote: Under PulseAudio 2.1 I can select a2dp without problem. Under PulseAudio 2.99.2, when I execute pactl set-card-profile 1 a2dp I get Failure: Input/Output Error back (as the output from pactl), and I see the following in

Re: [pulseaudio-discuss] Property list requirements

2012-11-23 Thread Tanu Kaskinen
On Fri, 2012-11-23 at 10:50 -0800, Mike Gran wrote: Hello- What properties in the property list are necessary? For example, if I make a simple program that creates an audio source with a single mono channel, I end up having to make property lists for these two functions -

Re: [pulseaudio-discuss] [PATCH v0] bluetooth: Merge headset ports into one

2012-11-23 Thread Tanu Kaskinen
On Fri, 2012-11-23 at 13:41 +0100, Mikel Astiz wrote: From: Mikel Astiz mikel.as...@bmw-carit.de Merge the former hsp-output and a2dp-output ports into one single port, in order to fix the regression of having several independent entries in the UI. I'm not sure if this is anything serious,

Re: [pulseaudio-discuss] gnome-shell hangs, waiting for pulse-audio

2012-11-23 Thread Tanu Kaskinen
On Fri, 2012-11-23 at 00:00 +0100, Henrik /KaarPoSoft wrote: On 11/22/12 13:39, Tanu Kaskinen wrote: Henrik, is it possible for you to try 2.99.2 too? For what it's worth, last time when I said I can't reproduce this I did have other windows open, but I retested with the gnome-terminal

Re: [pulseaudio-discuss] [PATCH] virtual-surround: check if resampled memblock is not equal to input

2012-11-24 Thread Tanu Kaskinen
On Sat, 2012-11-24 at 12:32 +0100, Niels Ole Salscheider wrote: Since commit e32a408b3cdd46857fdf12210c1bf5bdbf3a96f8, we silence the input memblock in order to give the resampler enough input samples, if necessary. But if there is no need to resample the hrir, the resampled memblock is

Re: [pulseaudio-discuss] jackdbus module, pulse fails to conform on device reservation API

2012-11-24 Thread Tanu Kaskinen
On Wed, 2012-11-21 at 03:04 -0500, Ian Malone wrote: On 20 November 2012 14:01, Tanu Kaskinen ta...@iki.fi wrote: On Tue, 2012-11-20 at 20:43 +0200, Tanu Kaskinen wrote: On Tue, 2012-11-20 at 17:59 +, Ian Malone wrote: Thanks, I'll give it a go. I think handling the already_owner case

Re: [pulseaudio-discuss] jackdbus module, pulse fails to conform on device reservation API

2012-11-24 Thread Tanu Kaskinen
On Mon, 2012-11-19 at 21:45 +0100, Brendan Jones wrote: I'm seeing this in virtual box under KDE (also Fedora 18 / pulseaudio 2.1). I guess it should be quite easy to reproduce this if I'd try this with virtual box with the same setup as you. I've never used virtual box (or any other virtual

Re: [pulseaudio-discuss] [PATCH 2/2] sinkwidget: Move format selection options to 'Advanced' expander

2012-11-24 Thread Tanu Kaskinen
On Tue, 2012-11-20 at 20:08 +0530, Arun Raghavan wrote: There's no reason to present this for all S/PDIF and HDMI cases. The user can select it when required. This change only modifies the glade file. I think the logic for enabling and disabling the advanced options needs to be updated too.

Re: [pulseaudio-discuss] [PATCH v2 1/2 pavucontrol] mainwindow: Show the availability of the ports and profiles.

2012-11-24 Thread Tanu Kaskinen
On Fri, 2012-11-16 at 00:12 +0100, poljar (Damir Jelić) wrote: diff --git a/src/mainwindow.cc b/src/mainwindow.cc index 1041eab..63e02e8 100644 --- a/src/mainwindow.cc +++ b/src/mainwindow.cc @@ -254,12 +254,31 @@ static void set_icon_name_fallback(Gtk::Image *i, const char *name,

Re: [pulseaudio-discuss] [PATCH v2 pavucontrol] mainwindow: Show the availability of the ports and profiles.

2012-11-24 Thread Tanu Kaskinen
On Fri, 2012-11-16 at 00:12 +0100, poljar (Damir Jelić) wrote: Hi. Here comes the second version of this patch. This version fixes the issues pointed out by Tanu: - don't add all ports of a card to the sink/source - make the strings translatable I also attached a second patch which

Re: [pulseaudio-discuss] [PATCH v2 1/2 pavucontrol] mainwindow: Show the availability of the ports and profiles.

2012-11-24 Thread Tanu Kaskinen
On Sat, 2012-11-24 at 16:06 +0100, Damir Jelić wrote: On Sat, Nov 24, 2012 at 04:29:05PM +0200, Tanu Kaskinen wrote: On Fri, 2012-11-16 at 00:12 +0100, poljar (Damir Jelić) wrote: diff --git a/src/mainwindow.cc b/src/mainwindow.cc index 1041eab..63e02e8 100644 --- a/src/mainwindow.cc

Re: [pulseaudio-discuss] [PATCH 1/3] sink_input: new volume_factor system

2012-11-24 Thread Tanu Kaskinen
On Wed, 2012-11-14 at 15:19 -0200, Flavio Ceolin wrote: This patch makes possible to set more than one volume factor. The real value of the volume_factor will be the multiplication of these values. Please avoid breaking compilation between patches. Patches 1/3 and 2/3 should be squashed,

Re: [pulseaudio-discuss] gnome-shell hangs, waiting for pulse-audio

2012-11-26 Thread Tanu Kaskinen
() in src/pulsecore/protocol-native.c). The hang seems to happen when trying to play the second sample. -- Tanu From 67d2513751b59ae62168fe95f1ceaa372e1fb4f2 Mon Sep 17 00:00:00 2001 From: Tanu Kaskinen ta...@iki.fi Date: Sun, 25 Nov 2012 21:41:39 +0200 Subject: [PATCH] Special logging configuration

Re: [pulseaudio-discuss] gnome-shell hangs, waiting for pulse-audio

2012-11-26 Thread Tanu Kaskinen
On Sun, 2012-11-25 at 22:25 +0200, Tanu Kaskinen wrote: So gnome-shell doesn't want to log to syslog? I've attached a pulseaudio patch that makes gnome-shell log to files under /tmp. Btw, I now noticed that running gnome-shell --replace restarts gnome-shell and makes the log from the new

Re: [pulseaudio-discuss] [PATCH v0] bluetooth: Merge headset ports into one

2012-11-26 Thread Tanu Kaskinen
On Sun, 2012-11-25 at 12:28 +0100, Mikel Astiz wrote: Hi Tanu, On Fri, Nov 23, 2012 at 8:26 PM, Tanu Kaskinen ta...@iki.fi wrote: On Fri, 2012-11-23 at 13:41 +0100, Mikel Astiz wrote: From: Mikel Astiz mikel.as...@bmw-carit.de Merge the former hsp-output and a2dp-output ports into one

Re: [pulseaudio-discuss] [PATCH v0] bluetooth: Merge headset ports into one

2012-11-26 Thread Tanu Kaskinen
On Mon, 2012-11-26 at 15:06 +0100, Mikel Astiz wrote: Hi Tanu, On Mon, Nov 26, 2012 at 2:52 PM, Tanu Kaskinen ta...@iki.fi wrote: module-bluetooth-policy has all information it needs available from bluetooth-util, doesn't it? It doesn't necessarily need to even care about the port

Re: [pulseaudio-discuss] [PATCH v1 0/3] bluetooth: Headset port availability

2012-11-28 Thread Tanu Kaskinen
On Wed, 2012-11-28 at 16:25 +0200, Luiz Augusto von Dentz wrote: Hi David, On Wed, Nov 28, 2012 at 12:14 PM, David Henningsson david.hennings...@canonical.com wrote: On 11/27/2012 02:35 PM, Luiz Augusto von Dentz wrote: Hi Mikel, On Tue, Nov 27, 2012 at 9:12 AM, Mikel Astiz

Re: [pulseaudio-discuss] [PATCH v1 0/3] bluetooth: Headset port availability

2012-11-28 Thread Tanu Kaskinen
On Wed, 2012-11-28 at 16:42 +0200, Tanu Kaskinen wrote: On Wed, 2012-11-28 at 16:25 +0200, Luiz Augusto von Dentz wrote: Hi David, On Wed, Nov 28, 2012 at 12:14 PM, David Henningsson david.hennings...@canonical.com wrote: On 11/27/2012 02:35 PM, Luiz Augusto von Dentz wrote: Hi

Re: [pulseaudio-discuss] [PATCH v0] bluetooth: Fix unacquired transports during sink resume

2012-11-28 Thread Tanu Kaskinen
On Wed, 2012-11-28 at 19:20 +0100, Mikel Astiz wrote: From: Mikel Astiz mikel.as...@bmw-carit.de The sink can be resumed while the source is still in PA_SOURCE_INIT. This is the case if a module such as module-stream-restore routes the audio to the sink during pa_sink_put(), leading to an

Re: [pulseaudio-discuss] [PATCH v1 0/3] bluetooth: Headset port availability

2012-11-28 Thread Tanu Kaskinen
On Mon, 2012-11-26 at 18:32 +0100, Mikel Astiz wrote: From: Mikel Astiz mikel.as...@bmw-carit.de This patchset extends the previous patch (resent unmodified here) with the policy change suggested by Tanu. It seems no conclusion was reached about the names etc. but I believe this is the

Re: [pulseaudio-discuss] [PATCH v0 1/2] bluetooth: Do not setup stream before thread starts

2012-12-01 Thread Tanu Kaskinen
On Thu, 2012-11-29 at 14:28 +0100, Mikel Astiz wrote: From: Mikel Astiz mikel.as...@bmw-carit.de bt_transport_acquire() might get called from the main thread, in case the IO thread hasn't been started yet. In this case, we should not call setup_stream() since this is going to be called in

Re: [pulseaudio-discuss] [PATCH v0 2/2] bluetooth: Request headset audio during profile switch

2012-12-01 Thread Tanu Kaskinen
On Thu, 2012-11-29 at 14:28 +0100, Mikel Astiz wrote: From: Mikel Astiz mikel.as...@bmw-carit.de When a headset is having a profile switch, we can either leave the SCO state unmodified (as it was before this patch) or we can alternatively request it (as older versions of PA). This patch

Re: [pulseaudio-discuss] [PATCH v2 1/3] sink_input: new volume_factor system

2012-12-01 Thread Tanu Kaskinen
On Thu, 2012-11-29 at 11:04 -0200, Flavio Ceolin wrote: Implement setting of more than one volume factor. The real value of the volume_factor will be the multiplication of these values. Thanks, applied to my next branch. I did a few small fixes and cosmetic changes, see below: +static

Re: [pulseaudio-discuss] [PATCH v2 2/3] modargs: Adding pa_modargs_get_value_volume()

2012-12-01 Thread Tanu Kaskinen
On Thu, 2012-11-29 at 11:04 -0200, Flavio Ceolin wrote: This function gets a pa_volume_t from a string. Thanks, applied to my next branch. -- Tanu ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org

Re: [pulseaudio-discuss] [PATCH v2 3/3] module-ducking: Applying the ducking effect for specified streams

2012-12-01 Thread Tanu Kaskinen
On Thu, 2012-11-29 at 11:04 -0200, Flavio Ceolin wrote: This module works pretty similar to the module-role-cork. It should be used as an alternative to that module. Basically it decreases the volume of the streams specified in ducking_roles in the presence of at least one stream specified in

Re: [pulseaudio-discuss] [PATCH v0] bluetooth: Fix unacquired transports during sink resume

2012-12-01 Thread Tanu Kaskinen
On Thu, 2012-11-29 at 14:33 +0100, Mikel Astiz wrote: Hi Tanu, On Thu, Nov 29, 2012 at 4:55 AM, Tanu Kaskinen ta...@iki.fi wrote: On Wed, 2012-11-28 at 19:20 +0100, Mikel Astiz wrote: From: Mikel Astiz mikel.as...@bmw-carit.de The sink can be resumed while the source is still

Re: [pulseaudio-discuss] Why are we checking various sample rates?

2012-12-01 Thread Tanu Kaskinen
On Fri, 2012-11-30 at 09:59 +0100, David Henningsson wrote: Hi, I'm researching a bug where some set of USB speakers stopped working, probably in 2.x. The peculiar thing about this sound card is that seems to only work at a sample rate of 46875 Hz. So in 2.x, the probe fails with E:

Re: [pulseaudio-discuss] gnome-shell hangs, waiting for pulse-audio

2012-12-01 Thread Tanu Kaskinen
On Wed, 2012-11-28 at 02:35 +0100, Henrik /KaarPoSoft wrote: On 11/26/12 16:42, Henrik /KaarPoSoft wrote: Tanu, again: Thanks for your help. I tried the patch and various other changes to log.c, but getting no useful logging, and sometimes segfaults instead (as you also noted). My

Re: [pulseaudio-discuss] [PATCH v0 1/2] bluetooth: Do not setup stream before thread starts

2012-12-02 Thread Tanu Kaskinen
On Sun, 2012-12-02 at 10:02 +0100, Mikel Astiz wrote: Hi Tanu, On Sun, Dec 2, 2012 at 12:45 AM, Tanu Kaskinen ta...@iki.fi wrote: On Thu, 2012-11-29 at 14:28 +0100, Mikel Astiz wrote: From: Mikel Astiz mikel.as...@bmw-carit.de bt_transport_acquire() might get called from the main

Re: [pulseaudio-discuss] [PATCH v0 2/2] bluetooth: Request headset audio during profile switch

2012-12-02 Thread Tanu Kaskinen
On Sun, 2012-12-02 at 10:36 +0100, Mikel Astiz wrote: Hi Tanu, On Sun, Dec 2, 2012 at 1:10 AM, Tanu Kaskinen ta...@iki.fi wrote: On Thu, 2012-11-29 at 14:28 +0100, Mikel Astiz wrote: From: Mikel Astiz mikel.as...@bmw-carit.de When a headset is having a profile switch, we can either

Re: [pulseaudio-discuss] jackdbus module, pulse fails to conform on device reservation API

2012-12-02 Thread Tanu Kaskinen
On Wed, 2012-11-28 at 23:24 +0100, Brendan Jones wrote: On 11/24/2012 02:06 PM, Tanu Kaskinen wrote: On Mon, 2012-11-19 at 21:45 +0100, Brendan Jones wrote: I'm seeing this in virtual box under KDE (also Fedora 18 / pulseaudio 2.1). I guess it should be quite easy to reproduce this if I'd

Re: [pulseaudio-discuss] [PATCH v0] bluetooth: Fix unacquired transports during sink resume

2012-12-03 Thread Tanu Kaskinen
On Mon, 2012-12-03 at 10:57 +0100, Mikel Astiz wrote: On Sun, Dec 2, 2012 at 4:05 AM, Tanu Kaskinen ta...@iki.fi wrote: On Thu, 2012-11-29 at 14:33 +0100, Mikel Astiz wrote: On Thu, Nov 29, 2012 at 4:55 AM, Tanu Kaskinen ta...@iki.fi wrote: so that INIT-IDLE transitions will work too

Re: [pulseaudio-discuss] [PATCH v1 0/3] Request audio-stream (SCO) on profile switch?

2012-12-03 Thread Tanu Kaskinen
On Mon, 2012-12-03 at 11:03 +0100, Mikel Astiz wrote: From: Mikel Astiz mikel.as...@bmw-carit.de This second proposal is similar to v0 with the following improvements as suggested by Tanu: 1. setup_stream() is called directly from thread_func() to avoid a race condition. 2. The profile

Re: [pulseaudio-discuss] gnome-shell hangs, waiting for pulse-audio

2012-12-03 Thread Tanu Kaskinen
On Sun, 2012-12-02 at 20:20 +0100, Henrik /KaarPoSoft wrote: On 12/02/12 05:49, Tanu Kaskinen wrote: The original backtrace only has the trace for one thread, the thread where the libpulse mainloop runs isn't shown. Could you take a backtrace again, this time with thread apply all bt

Re: [pulseaudio-discuss] gnome-shell hangs, waiting for pulse-audio

2012-12-03 Thread Tanu Kaskinen
On Tue, 2012-12-04 at 03:47 +0200, Tanu Kaskinen wrote: Hmm... I checked when the operation state is set to DONE, and it's not done until after calling the callback. So, if the kernel schedules the main thread after the pa_threaded_mainloop_signal() call, but before the operation state is set

Re: [pulseaudio-discuss] [PATCH v1 0/3] bluetooth: Headset port availability

2012-12-03 Thread Tanu Kaskinen
On Sun, 2012-12-02 at 22:33 +0200, Janos Kovacs wrote: Hi, On Wed, Nov 28, 2012 at 9:51 PM, Tanu Kaskinen ta...@iki.fi wrote: I've changed my mind about the last point. Ports are not really that close to the ideal routing endpoint concept. For example, on cellular phones, pulseaudio

Re: [pulseaudio-discuss] [PATCH v0] bluetooth: Fix unacquired transports during sink resume

2012-12-04 Thread Tanu Kaskinen
On Tue, 2012-12-04 at 08:18 +0100, Mikel Astiz wrote: Hi Tanu, On Tue, Dec 4, 2012 at 1:43 AM, Tanu Kaskinen ta...@iki.fi wrote: On Mon, 2012-12-03 at 10:57 +0100, Mikel Astiz wrote: On Sun, Dec 2, 2012 at 4:05 AM, Tanu Kaskinen ta...@iki.fi wrote: On Thu, 2012-11-29 at 14:33 +0100

Re: [pulseaudio-discuss] gnome-shell hangs, waiting for pulse-audio

2012-12-04 Thread Tanu Kaskinen
On Tue, 2012-12-04 at 11:49 +0100, Henrik /KaarPoSoft wrote: On 12/04/12 04:32, Tanu Kaskinen wrote: On Tue, 2012-12-04 at 03:47 +0200, Tanu Kaskinen wrote: Hmm... I checked when the operation state is set to DONE, and it's not done until after calling the callback. So, if the kernel

Re: [pulseaudio-discuss] [PATCH next v0 3/8] bluetooth: Use ceil() to round up volume

2012-12-06 Thread Tanu Kaskinen
On Wed, 2012-12-05 at 17:23 +0100, Mikel Astiz wrote: From: Mikel Astiz mikel.as...@bmw-carit.de The code can be simplified since it's just trying to round up the result of the division. Note that the resulting behavior is slightly different, specially when the volume is 0. In this case, it

Re: [pulseaudio-discuss] [PATCH next v0 6/8] bluetooth: Add transport hashmap to discovery

2012-12-06 Thread Tanu Kaskinen
On Wed, 2012-12-05 at 17:23 +0100, Mikel Astiz wrote: @@ -913,16 +916,10 @@ static DBusHandlerResult filter_cb(DBusConnection *bus, DBusMessage *m, void *us return DBUS_HANDLER_RESULT_NOT_YET_HANDLED; } else if (dbus_message_is_signal(m, org.bluez.MediaTransport,

Re: [pulseaudio-discuss] [PATCH next v0 7/8] bluetooth: Use transport array instead of hashmap for devices

2012-12-06 Thread Tanu Kaskinen
On Wed, 2012-12-05 at 17:23 +0100, Mikel Astiz wrote: @@ -169,13 +168,15 @@ static void device_free(pa_bluetooth_device *d) { pa_assert(d); -while ((t = pa_hashmap_steal_first(d-transports))) { +for (i = 0; i PA_BLUETOOTH_PROFILE_COUNT; i ++) { Extra space in i ++. +

[pulseaudio-discuss] [PATCH] bluetooth: Check if BlueZ tries to set the configuration twice for the same transport.

2012-12-06 Thread Tanu Kaskinen
--- src/modules/bluetooth/bluetooth-util.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/modules/bluetooth/bluetooth-util.c b/src/modules/bluetooth/bluetooth-util.c index 0daf1c9..39c5c5e 100644 --- a/src/modules/bluetooth/bluetooth-util.c +++

Re: [pulseaudio-discuss] [PATCH next v0 0/8] Bluetooth cleanup refactoring

2012-12-06 Thread Tanu Kaskinen
On Wed, 2012-12-05 at 17:23 +0100, Mikel Astiz wrote: From: Mikel Astiz mikel.as...@bmw-carit.de Disclaimer: these patches are intended for the next branch and they don't even apply to the current upstream master. There are two main changes in the bluetooth roadmap: 1. Refactor the hooks

Re: [pulseaudio-discuss] [PATCH v1 0/3] bluetooth: Headset port availability

2012-12-06 Thread Tanu Kaskinen
On Wed, 2012-12-05 at 09:31 +0100, Mikel Astiz wrote: On Wed, Nov 28, 2012 at 9:51 PM, Tanu Kaskinen ta...@iki.fi wrote: I've changed my mind about the last point. Ports are not really that close to the ideal routing endpoint concept. For example, on cellular phones, pulseaudio may

  1   2   3   4   5   6   7   8   9   10   >