Re: [pulseaudio-discuss] [PATCH] bluez5-device: Fix memory leak in sco_process_render()

2018-04-10 Thread Georg Chini
On 10.04.2018 13:04, Raman Shishniou wrote: Hello, On 04/10/2018 01:38 PM, Georg Chini wrote: On 10.04.2018 10:21, Raman Shishniou wrote: Hello, On 04/09/2018 07:15 PM, Georg Chini wrote: sco_process_render does not unref the memblock when it encounters an error. This patch fixes the

Re: [pulseaudio-discuss] [PATCH] bluez5-device: Fix memory leak in sco_process_render()

2018-04-10 Thread Raman Shishniou
Hello, On 04/10/2018 01:38 PM, Georg Chini wrote: > On 10.04.2018 10:21, Raman Shishniou wrote: >> Hello, >> >> On 04/09/2018 07:15 PM, Georg Chini wrote: >>> sco_process_render does not unref the memblock when it encounters an error. >>> >>> This patch fixes the issue. It also changes the return

Re: [pulseaudio-discuss] [PATCH] bluez5-device: Fix memory leak in sco_process_render()

2018-04-10 Thread Georg Chini
On 10.04.2018 10:21, Raman Shishniou wrote: Hello, On 04/09/2018 07:15 PM, Georg Chini wrote: sco_process_render does not unref the memblock when it encounters an error. This patch fixes the issue. It also changes the return value to 1 in the case of EAGAIN. Because the data was already

Re: [pulseaudio-discuss] [PATCH] bluez5-device: Fix memory leak in sco_process_render()

2018-04-10 Thread Raman Shishniou
Hello, On 04/09/2018 07:15 PM, Georg Chini wrote: > sco_process_render does not unref the memblock when it encounters an error. > > This patch fixes the issue. It also changes the return value to 1 in the case > of EAGAIN. Because the data was already rendered and cannot be re-sent, we > have to

[pulseaudio-discuss] [PATCH] bluez5-device: Fix memory leak in sco_process_render()

2018-04-09 Thread Georg Chini
sco_process_render does not unref the memblock when it encounters an error. This patch fixes the issue. It also changes the return value to 1 in the case of EAGAIN. Because the data was already rendered and cannot be re-sent, we have to discard the block. ---