Re: [pulseaudio-tickets] [PulseAudio] #927: [PATCH] Fixing pulseaudio to build together with git xcb-util

2011-05-01 Thread PulseAudio 
#927: [PATCH] Fixing pulseaudio to build together with git xcb-util
-+--
  Reporter:  mgrela  |   Owner:  lennart 
  Type:  defect  |  Status:  closed  
 Milestone:  1.0 |   Component:  module-x11-*
Resolution:  fixed   |Keywords:  
-+--

Comment(by arnau):

 Hi,

 Replying to [comment:9 mgrela]:
 > I apologize for my carelessness when creating the initial patch. This
 taught me to pay more attention to detail. It's good to see "many-eyes-
 make-bugs-shallow" at work :).

 No problem at all. Thanks for your initial patch!

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
[email protected]
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #927: [PATCH] Fixing pulseaudio to build together with git xcb-util

2011-05-01 Thread PulseAudio 
#927: [PATCH] Fixing pulseaudio to build together with git xcb-util
-+--
  Reporter:  mgrela  |   Owner:  lennart 
  Type:  defect  |  Status:  closed  
 Milestone:  1.0 |   Component:  module-x11-*
Resolution:  fixed   |Keywords:  
-+--

Comment(by arnau):

 Hi

 Replying to [comment:8 coling]:
 > If a bug still exists then it's certainly OK (and indeed actively
 encouraged!) to reopen the bug! (doubly so when you attach a patch!!)

 Ok, I was just wondering if I should have opened a new bug rather than
 reopening this one.


 > This looks good, I've applied the patch now (adb16f9ff) with a slightly
 tweaked commit message. Hopefully this is fully fixed now :D
 >

 Thanks for being so responsive! I have not been able to test the patch as
 I'm not using pulseaudio myself but it's building without any warning so I
 guess that's ok.

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
[email protected]
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #927: [PATCH] Fixing pulseaudio to build together with git xcb-util

2011-04-30 Thread PulseAudio 
#927: [PATCH] Fixing pulseaudio to build together with git xcb-util
-+--
  Reporter:  mgrela  |   Owner:  lennart 
  Type:  defect  |  Status:  closed  
 Milestone:  1.0 |   Component:  module-x11-*
Resolution:  fixed   |Keywords:  
-+--

Comment(by mgrela):

 I apologize for my carelessness when creating the initial patch. This
 taught me to pay more attention to detail. It's good to see "many-eyes-
 make-bugs-shallow" at work :).

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
[email protected]
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #927: [PATCH] Fixing pulseaudio to build together with git xcb-util

2011-04-30 Thread PulseAudio 
#927: [PATCH] Fixing pulseaudio to build together with git xcb-util
-+--
  Reporter:  mgrela  |   Owner:  lennart 
  Type:  defect  |  Status:  closed  
 Milestone:  1.0 |   Component:  module-x11-*
Resolution:  fixed   |Keywords:  
-+--
Changes (by coling):

  * status:  reopened => closed
  * resolution:  => fixed


Comment:

 If a bug still exists then it's certainly OK (and indeed actively
 encouraged!) to reopen the bug! (doubly so when you attach a patch!!)

 This looks good, I've applied the patch now (adb16f9ff) with a slightly
 tweaked commit message. Hopefully this is fully fixed now :D

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
[email protected]
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #927: [PATCH] Fixing pulseaudio to build together with git xcb-util

2011-04-30 Thread PulseAudio 
#927: [PATCH] Fixing pulseaudio to build together with git xcb-util
-+--
  Reporter:  mgrela  |   Owner:  lennart 
  Type:  defect  |  Status:  reopened
 Milestone:  1.0 |   Component:  module-x11-*
Resolution:  |Keywords:  
-+--
Changes (by arnau):

 * cc: [email protected] (added)
  * status:  closed => reopened
  * resolution:  fixed =>


Comment:

 Hello,

 I'm reopening this bug as the issue is not completely fixed, hope that's
 ok.

 The patch above fixes building with xcb-util >= 0.3.8, but the reply is
 never checked (possible SIGSEGV if the reply is NULL) nor freed (memory
 leak at each call of the functions). Indeed, xcb_atom_get() used to do
 that.

 Also, xcb-atom was only meaningful for xcb_atom_get() and STRING, so it
 could be removed now and the build should check for xcb >= 1.6 as
 XCB_ATOM_STRING was introduced from this version.

 I have added a patch addressing these issues. Could you please consider
 applying it? Thanks!

 Cheers,
 Arnaud Fontaine

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
[email protected]
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #927: [PATCH] Fixing pulseaudio to build together with git xcb-util

2011-04-28 Thread PulseAudio 
#927: [PATCH] Fixing pulseaudio to build together with git xcb-util
-+--
  Reporter:  mgrela  |   Owner:  lennart 
  Type:  defect  |  Status:  closed  
 Milestone:  1.0 |   Component:  module-x11-*
Resolution:  fixed   |Keywords:  
-+--
Changes (by coling):

  * status:  new => closed
  * resolution:  => fixed
  * milestone:  => 1.0


Comment:

 OK, I've applied the patch in my tree and it compiles up fine with my
 version of XCB, so I'm happy enough!

 Assuming it doesn't have any runtime problems, I'll push this next time I
 push.

 I'll thus close this bug for now as fixed.

 I might even push this into stable-queue, as if it compiles fine with
 older xcb (as mine appears to be) then I can't see any reason not to.

 Many thanks for the patch and the clarifications :)

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
[email protected]
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #927: [PATCH] Fixing pulseaudio to build together with git xcb-util

2011-04-27 Thread PulseAudio 
#927: [PATCH] Fixing pulseaudio to build together with git xcb-util
-+--
  Reporter:  mgrela  |   Owner:  lennart 
  Type:  defect  |  Status:  new 
 Milestone:  |   Component:  module-x11-*
Resolution:  |Keywords:  
-+--

Comment(by mgrela):

 I took the code from an old example on accessing atoms on the xcb page:

 [http://xcb.freedesktop.org/tutorial/]

 Seeing that, I assumed this is the usual way to do it under xcb. I also
 checked, that the xcb_intern_atom* symbols exist since libxcb-1.0. I tried
 to compile pulseaudio with an external libxcb using X11_CFLAGS and
 X11_LIBS but it used the system libxcb anyway.

 As for the "intern" in the symbol name I think it's just a tribute to
 [http://tronche.com/gui/x/xlib/window-information/XInternAtom.html
 XInternAtom] function from libX11 which performed the same operation. I
 can ask on IRC if there are still some doubts.

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
[email protected]
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #927: [PATCH] Fixing pulseaudio to build together with git xcb-util

2011-04-27 Thread PulseAudio 
#927: [PATCH] Fixing pulseaudio to build together with git xcb-util
-+--
  Reporter:  mgrela  |   Owner:  lennart 
  Type:  defect  |  Status:  new 
 Milestone:  |   Component:  module-x11-*
Resolution:  |Keywords:  
-+--
Changes (by mpiechotka):

 * cc: [email protected] (added)


-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
[email protected]
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #927: [PATCH] Fixing pulseaudio to build together with git xcb-util

2011-04-27 Thread PulseAudio 
#927: [PATCH] Fixing pulseaudio to build together with git xcb-util
-+--
  Reporter:  mgrela  |   Owner:  lennart 
  Type:  defect  |  Status:  new 
 Milestone:  |   Component:  module-x11-*
Resolution:  |Keywords:  
-+--

Old description:

> Hi,
>
> I recently tried to build pulseaudio with most recent xcb-util from git
> on my Gentoo box. It failed with the following error:
>
>   CC libpulsecommon_0.9.22_la-x11prop.lo
> pulsecore/x11prop.c: In function 'pa_x11_set_prop':
> pulsecore/x11prop.c:60:9: warning: implicit declaration of function
> 'xcb_atom_get' [-Wimplicit-function-declaration]
> pulsecore/x11prop.c:61:70: error: 'STRING' undeclared (first use in this
> function)
> pulsecore/x11prop.c:61:70: note: each undeclared identifier is reported
> only once for each function it appears in
> pulsecore/x11prop.c: In function 'pa_x11_get_prop':
> pulsecore/x11prop.c:104:53: error: 'STRING' undeclared (first use in this
> function)
> make[3]: *** [libpulsecommon_0.9.22_la-x11prop.lo] Error 1
>
> I've made a patch to change the call to the missing xcb_atom_get to
> something that xcb can manage. I also updated the STRING constants as
> they were obsoleted some time ago. I'm attaching the patch in the hope
> you will find it useful and include it in the main code.
>
> Best regards,
> Maciej Grela

New description:

 Hi,

 I recently tried to build pulseaudio with most recent xcb-util from git on
 my Gentoo box. It failed with the following error:

 {{{
   CC libpulsecommon_0.9.22_la-x11prop.lo
 pulsecore/x11prop.c: In function 'pa_x11_set_prop':
 pulsecore/x11prop.c:60:9: warning: implicit declaration of function
 'xcb_atom_get' [-Wimplicit-function-declaration]
 pulsecore/x11prop.c:61:70: error: 'STRING' undeclared (first use in this
 function)
 pulsecore/x11prop.c:61:70: note: each undeclared identifier is reported
 only once for each function it appears in
 pulsecore/x11prop.c: In function 'pa_x11_get_prop':
 pulsecore/x11prop.c:104:53: error: 'STRING' undeclared (first use in this
 function)
 make[3]: *** [libpulsecommon_0.9.22_la-x11prop.lo] Error 1
 }}}

 I've made a patch to change the call to the missing xcb_atom_get to
 something that xcb can manage. I also updated the STRING constants as they
 were obsoleted some time ago. I'm attaching the patch in the hope you will
 find it useful and include it in the main code.

 Best regards,
 Maciej Grela

--

Comment(by coling):

 Thanks for the patch.

 Can I ask a few questions about the code (I did the conversion to XCB but
 am by no means an XCB expert!):
  * The use of the word "intern" in the API names makes me think these are
 not meant to be access via external apps and this is just a short term fix
 for a larger problem? Am I reading too much into the names and this is
 actually named this way for other reasons?
  * Does this still compile with older XCB? If not then we need to do some
 #if magic or similar as not supporting older XCB is not an option at this
 stage.

 Cheers for any info you can provide :)

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
[email protected]
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #927: [PATCH] Fixing pulseaudio to build together with git xcb-util

2011-04-26 Thread PulseAudio 
#927: [PATCH] Fixing pulseaudio to build together with git xcb-util
-+--
  Reporter:  mgrela  |   Owner:  lennart 
  Type:  defect  |  Status:  new 
 Milestone:  |   Component:  module-x11-*
Resolution:  |Keywords:  
-+--

Comment(by candrews):

 I can confirm that this patch applies and fixes the problem.

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
[email protected]
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

Re: [pulseaudio-tickets] [PulseAudio] #927: [PATCH] Fixing pulseaudio to build together with git xcb-util

2011-03-29 Thread PulseAudio 
#927: [PATCH] Fixing pulseaudio to build together with git xcb-util
-+--
  Reporter:  mgrela  |   Owner:  lennart 
  Type:  defect  |  Status:  new 
 Milestone:  |   Component:  module-x11-*
Resolution:  |Keywords:  
-+--

Comment(by mgrela):

 Sorry about the garbled output, I forgot to add code markers:

 {{{
   CC libpulsecommon_0.9.22_la-x11prop.lo
 pulsecore/x11prop.c: In function 'pa_x11_set_prop':
 pulsecore/x11prop.c:60:9: warning: implicit declaration of function
 'xcb_atom_get' [-Wimplicit-function-declaration]
 pulsecore/x11prop.c:61:70: error: 'STRING' undeclared (first use in this
 function)
 pulsecore/x11prop.c:61:70: note: each undeclared identifier is reported
 only once for each function it appears in
 pulsecore/x11prop.c: In function 'pa_x11_get_prop':
 pulsecore/x11prop.c:104:53: error: 'STRING' undeclared (first use in this
 function)
 make[3]: *** [libpulsecommon_0.9.22_la-x11prop.lo] Error 1
 }}}

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
[email protected]
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets

[pulseaudio-tickets] [PulseAudio] #927: [PATCH] Fixing pulseaudio to build together with git xcb-util

2011-03-29 Thread PulseAudio 
#927: [PATCH] Fixing pulseaudio to build together with git xcb-util
+---
 Reporter:  mgrela  |   Owner:  lennart 
 Type:  defect  |  Status:  new 
Milestone:  |   Component:  module-x11-*
 Keywords:  |  
+---
 Hi,

 I recently tried to build pulseaudio with most recent xcb-util from git on
 my Gentoo box. It failed with the following error:

   CC libpulsecommon_0.9.22_la-x11prop.lo
 pulsecore/x11prop.c: In function 'pa_x11_set_prop':
 pulsecore/x11prop.c:60:9: warning: implicit declaration of function
 'xcb_atom_get' [-Wimplicit-function-declaration]
 pulsecore/x11prop.c:61:70: error: 'STRING' undeclared (first use in this
 function)
 pulsecore/x11prop.c:61:70: note: each undeclared identifier is reported
 only once for each function it appears in
 pulsecore/x11prop.c: In function 'pa_x11_get_prop':
 pulsecore/x11prop.c:104:53: error: 'STRING' undeclared (first use in this
 function)
 make[3]: *** [libpulsecommon_0.9.22_la-x11prop.lo] Error 1

 I've made a patch to change the call to the missing xcb_atom_get to
 something that xcb can manage. I also updated the STRING constants as they
 were obsoleted some time ago. I'm attaching the patch in the hope you will
 find it useful and include it in the main code.

 Best regards,
 Maciej Grela

-- 
Ticket URL: 
PulseAudio 
The PulseAudio Sound Server
___
pulseaudio-tickets mailing list
[email protected]
https://tango.0pointer.de/mailman/listinfo/pulseaudio-tickets