Jira (BOLT-923) Orchestrator Client gem seems to be unsupported on Windows

2018-10-11 Thread Glenn Sarti (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Glenn Sarti created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet Task Runner /  BOLT-923  
 
 
  Orchestrator Client gem seems to be unsupported on Windows   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2018/10/11 10:43 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Glenn Sarti  
 

  
 
 
 
 

 
 While doing some investigation into an a bolt rspec issue I came across this in the orchestrator_client gem; https://github.com/puppetlabs/orchestrator_client-ruby/blob/6278274e54ed02d0683578bc6ff62c72a37b7460/lib/orchestrator_client/config.rb#L15-L17  
 
 
 
 
  def puppetlabs_root   
 
 
"/etc/puppetlabs"   
 
 
  end 
  
 
 
 
  This means that the orchestrator client can never get the system cacert or system config files on a Windows system. Only the user level files would even be found. Is this by design or is the orchestrator gem not Windows compatible? Raised - https://github.com/puppetlabs/orchestrator_client-ruby/issues/17 in the gem for this.  
 

  
 
 
 
 

Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019

2018-10-11 Thread Glenn Sarti (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Glenn Sarti commented on  FACT-1889  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Windows operating system facts should resolve correctly for Server 2019   
 

  
 
 
 
 

 
 I think I disagree with Branan Riley although I may have misinterpreted. IMO we should not have two different ways of detecting OS versions running at the same time i.e. Having Facter 3.13 "proper way" and puppet 5.5 and 6.0 using the hacky way. (perhaps I read that wrong, in which case forgive me Branan) In my mind we have two issues; 1. Detecting the correct version (This is an implementation concern) 2. Displaying that information to the user as a series of facts (This is a UX concern) and we should be able to address these separately and simultaneously. Phase 1: IMO we should be implementing the work in FACT-1881 to do the detection of the Windows OS (BUT NOT displaying this as a fact. That comes later). We could then output the results of the ReleaseID etc. as Debug statements for the time being. This means we would have a better/stable way to detect the plethora of Windows OS versions out there. We would then use the new detection method to output the SAME fact information we currently have (A standard refactor). This will reduce Branan's feel of major surgery (which I agree with BTW) and give confidence for going forward Phase 2: Introduce detecting Windows Server 2019 into the existing factset, similar to what Enis proposed above. This means facter will now somewhat detect Server 2019 and get us over the line for 2019 support This will fix Problem 1, I stated above (Implementation concern) Phase 3: While Phase 1/2 are going on, this gives us time to reconsider the fact structure to accommodate the windows OS stuff we implemented in Phase 1. And we can then implement it either as a breaking change (Facter 4.x) or as a backwards-compatible change (Facter 3.y) This will then fix Problem 2, the UX concern. What do you think? Ping John O'Connor  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
  

Jira (PUP-9115) custom facts don't get compiled

2018-10-11 Thread Eric Thompson (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Eric Thompson updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9115  
 
 
  custom facts don't get compiled   
 

  
 
 
 
 

 
Change By: 
 Eric Thompson  
 
 
Component/s: 
 Puppet Server  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9212) add acceptance tests for vault lookup

2018-10-11 Thread Tony Vu (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tony Vu assigned an issue to Tony Vu  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9212  
 
 
  add acceptance tests for vault lookup   
 

  
 
 
 
 

 
Change By: 
 Tony Vu  
 
 
Assignee: 
 Tony Vu  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (BOLT-191) Ability to upload directories or recursively upload files in plans

2018-10-11 Thread Michael Smith (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Smith updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet Task Runner /  BOLT-191  
 
 
  Ability to upload directories or recursively upload files in plans   
 

  
 
 
 
 

 
Change By: 
 Michael Smith  
 
 
Release Notes: 
 New Feature  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (BOLT-191) Ability to upload directories or recursively upload files in plans

2018-10-11 Thread Michael Smith (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Smith updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet Task Runner /  BOLT-191  
 
 
  Ability to upload directories or recursively upload files in plans   
 

  
 
 
 
 

 
Change By: 
 Michael Smith  
 
 
Fix Version/s: 
 BOLT Next  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9212) add acceptance tests for vault lookup

2018-10-11 Thread Tony Vu (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tony Vu commented on  PUP-9212  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: add acceptance tests for vault lookup   
 

  
 
 
 
 

 
 Most of the vox pupili modules have acceptance tests, so we should have at least one to exercise the function. I don't know about setting it up in a pipeline, that doesn't seem to be the norm for anything else the pupili maintain, so that part of the description is probably unnecessary.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9211) Module paths with common root cause incorrect name location validation errors.

2018-10-11 Thread Kris Bosland (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Kris Bosland commented on  PUP-9211  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Module paths with common root cause incorrect name location validation errors.   
 

  
 
 
 
 

 
 John Bollinger, I have created PUP-9215 that nested dirs in the modulepath should be an error.  Thanks!  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9190) Puppet should ignore empty init.pp

2018-10-11 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9190  
 
 
  Puppet should ignore empty init.pp   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Fix Version/s: 
 PUP 5.5.7  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (BOLT-922) Bolt suppresses errors from transport

2018-10-11 Thread Michael Smith (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Smith assigned an issue to Michael Smith  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet Task Runner /  BOLT-922  
 
 
  Bolt suppresses errors from transport   
 

  
 
 
 
 

 
Change By: 
 Michael Smith  
 
 
Assignee: 
 Michael Smith  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (BOLT-380) Support ed25519 out-of-the-box

2018-10-11 Thread Michael Smith (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Smith assigned an issue to Michael Smith  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet Task Runner /  BOLT-380  
 
 
  Support ed25519 out-of-the-box   
 

  
 
 
 
 

 
Change By: 
 Michael Smith  
 
 
Assignee: 
 Michael Smith  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9190) Puppet should ignore empty init.pp

2018-10-11 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-9190  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Puppet should ignore empty init.pp   
 

  
 
 
 
 

 
 Merged to 5.5.x in https://github.com/puppetlabs/puppet/commit/f1f7b2322dc2f9b58b3315f3833d484a09981348  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PDB-4141) Fix jdk-support-status regexes in 6.0.x

2018-10-11 Thread Rob Browning (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Rob Browning created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 PuppetDB /  PDB-4141  
 
 
  Fix jdk-support-status regexes in 6.0.x   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Affects Versions: 
 PDB 6.0.1  
 
 
Assignee: 
 Rob Browning  
 
 
Created: 
 2018/10/11 2:07 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Rob Browning  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet 

Jira (PUP-9190) Puppet should ignore empty init.pp

2018-10-11 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9190  
 
 
  Puppet should ignore empty init.pp   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 Puppet6 will error if a module contains an empty init.pp. The [module documentation|https://puppet.com/docs/puppet/5.3/modules_fundamentals.html   ] says, "init.pp: Contains a class definition. The init.pp class, if used, is the main class of the module. This class's name must match the module's name."So the init.pp file is optional, but we don't specify whether the file can exist, but be empty or if it only contains a defined type.We discovered in MODULES-7854 that some people may have empty {{init.pp}} and puppet should be more lenient. For now, we removed the empty init.pp from the rspec-puppet's module fixtures./cc [~henrik.lindberg], [~kris.bosland], [~ben.ford], [~chuck], [~eric.sorenson]  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe 

Jira (PDB-4140) Drop testing of oraclejdk > 8

2018-10-11 Thread Rob Browning (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Rob Browning created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 PuppetDB /  PDB-4140  
 
 
  Drop testing of oraclejdk > 8   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Rob Browning  
 
 
Created: 
 2018/10/11 1:18 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Rob Browning  
 

  
 
 
 
 

 
 Given that we're about to only test 8 and 11, and that as of at least 11 oraclejdk effectively is openjdk, stop testing oraclejdk for versions newer than 8.    
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
   

Jira (PDB-4139) Adjust 6.0.x travis test set to reflect no longer being the master branch

2018-10-11 Thread Rob Browning (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Rob Browning created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 PuppetDB /  PDB-4139  
 
 
  Adjust 6.0.x travis test set to reflect no longer being the master branch   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Rob Browning  
 
 
Created: 
 2018/10/11 1:11 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Rob Browning  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to 

Jira (FACT-1881) Include additional OS release facts for Windows 10

2018-10-11 Thread Branan Riley (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Branan Riley commented on  FACT-1881  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Include additional OS release facts for Windows 10   
 

  
 
 
 
 

 
 I'm definitely in favor of figuring out a better way to report modern Windows versions, since they don't map cleanly to the abstraction we currently have. I don't think that now is the right time to do it, and we should probably go for a more minmal (even if kinda hacky) approach for FACT-1889. My main concern is that a) it's potentially a big refactor for a z, and b) given the tight timeline for the next 5.5 and 6.0 releases at this point, and the need to still figure out how to map this new data to the old facts for backwards compatibility, we might not actually get the darned thing done in time. I'm also a little bit concerned about adding a bunch of new platform-specific facts when I haven't heard any user/customer demand for them (although it doesn't hurt to be proactive about this)  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019

2018-10-11 Thread Casey Williams (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Casey Williams assigned an issue to Casey Williams  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1889  
 
 
  Windows operating system facts should resolve correctly for Server 2019   
 

  
 
 
 
 

 
Change By: 
 Casey Williams  
 
 
Assignee: 
 Casey Williams  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019

2018-10-11 Thread Branan Riley (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Branan Riley commented on  FACT-1889  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Windows operating system facts should resolve correctly for Server 2019   
 

  
 
 
 
 

 
 FACT-1881 feels like pretty major surgery to me. I think we should consider how to implement it (in a backwards-compatible way) for puppet-agent 6.1 (facter 3.13?), but we'll probably want to stick with the hackier method for the 5.5 and 6.0 series  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (BOLT-922) Bolt suppresses errors from transport

2018-10-11 Thread Michael Smith (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Smith assigned an issue to Unassigned  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet Task Runner /  BOLT-922  
 
 
  Bolt suppresses errors from transport   
 

  
 
 
 
 

 
Change By: 
 Michael Smith  
 
 
Assignee: 
 Michael Smith  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019

2018-10-11 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1889  
 
 
  Windows operating system facts should resolve correctly for Server 2019   
 

  
 
 
 
 

 
Change By: 
 Enis Inan  
 
 
Team: 
 Platform OS  
 
 
Sprint: 
 Platform OS Kanban  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1881) Include additional OS release facts for Windows 10

2018-10-11 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1881  
 
 
  Include additional OS release facts for Windows 10   
 

  
 
 
 
 

 
Change By: 
 Enis Inan  
 
 
Summary: 
 Include additional  Windows 10  OS  release  info  facts  for Windows 10  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019

2018-10-11 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan commented on  FACT-1889  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Windows operating system facts should resolve correctly for Server 2019   
 

  
 
 
 
 

 
 Modifying https://github.com/puppetlabs/facter/blob/2ad48c341831ac261c9ef16e94f94e74735959c2/lib/src/facts/win... to do something like:  
 
 
 
 
 if consumerrel {  
 
 
   result.release = "10"  
 
 
 } elseif (buildno >= 17623) {  
 
 
   result.release = "2019"  
 
 
 } else {  
 
 
   result.release = "2016"  
 
 
 }
  
 
 
 
  would work. I've (informally) tested this on our Windows Server 2016 and Windows Server 2019 machines. Note that 17623 is the lowest build number for the Windows Server 2019 series based on https://en.wikipedia.org/wiki/Windows_Server_2019. Also confirmed with John O'Connor that this is the correct approach for this ticket until we finish FACT-1881, whereby we could consider cleaning this up.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

Jira (FACT-1881) Include additional Windows 10 release info facts

2018-10-11 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1881  
 
 
  Include additional Windows 10 release info facts   
 

  
 
 
 
 

 
Change By: 
 Enis Inan  
 
 
Affects Version/s: 
 FACT 3.11.4  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1881) Include additional Windows 10 release info facts

2018-10-11 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1881  
 
 
  Include additional Windows 10 release info facts   
 

  
 
 
 
 

 
Change By: 
 Enis Inan  
 
 
Summary: 
 Include additional Windows  operating system versions fact should include build numbers for Windows  10  / resolve correctly on Server 2019  release info facts  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019

2018-10-11 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1889  
 
 
  Windows operating system facts should resolve correctly for Server 2019   
 

  
 
 
 
 

 
Change By: 
 Enis Inan  
 
 
Affects Version/s: 
 FACT 3.11.4  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019

2018-10-11 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1889  
 
 
  Windows operating system facts should resolve correctly for Server 2019   
 

  
 
 
 
 

 
Change By: 
 Enis Inan  
 

  
 
 
 
 

 
 Some assumptions were made in FACT-1492 about how Windows version numbers should resolve (currently codified [here|https://github.com/puppetlabs/facter/blob/2ad48c341831ac261c9ef16e94f94e74735959c2/lib/src/facts/windows/operating_system_resolver.cc#L103-L104]). Now that Windows 2019 server is out, we should update those assumptions to use the build number, which lets us distinguish between Windows 2016 and Windows 2019.  We can get the build number from [RtlGetVersion|https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/content/wdm/nf-wdm-rtlgetversion], which we already do so [here|https://github.com/puppetlabs/facter/blob/3.11.x/lib/src/facts/windows/kernel_resolver.cc#L17-L42]  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet 

Jira (FACT-1881) Windows operating system versions fact should include build numbers for Windows 10 / resolve correctly on Server 2019

2018-10-11 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1881  
 
 
  Windows operating system versions fact should include build numbers for Windows 10 / resolve correctly on Server 2019   
 

  
 
 
 
 

 
Change By: 
 Enis Inan  
 
 
Issue Type: 
 Bug New Feature  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1881) Windows operating system versions fact should include build numbers for Windows 10 / resolve correctly on Server 2019

2018-10-11 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan commented on  FACT-1881  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Windows operating system versions fact should include build numbers for Windows 10 / resolve correctly on Server 2019   
 

  
 
 
 
 

 
 Created https://tickets.puppetlabs.com/browse/FACT-1889 and updated this ticket's title as it is now discussing a possible feature addition.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1881) Windows operating system versions fact should include build numbers for Windows 10 / resolve correctly on Server 2019

2018-10-11 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1881  
 
 
  Windows operating system versions fact should include build numbers for Windows 10 / resolve correctly on Server 2019   
 

  
 
 
 
 

 
Change By: 
 Enis Inan  
 

  
 
 
 
 

 
 Some assumptions were made in FACT-1492 about how Windows version numbers should resolve (currently codified [here|https://github.com/puppetlabs/facter/blob/2ad48c341831ac261c9ef16e94f94e74735959c2/lib/src/facts/windows/operating_system_resolver.cc#L103-L104]) *update* Probably going to go for the needs must solution here and differentiate on build numbers to get this ticket resolved quickly.I.e. test for build number >= {{10.0.17763}} (or possibly {{10.0.17623}} first tech preview March 20 2018). However, medium term, the Windows Version resolver should really take into account the new Semi-Annual release model, as these version numbers are more readily identifiable.Windows 10/2016+ versioning has changed in that the Kernel Major/Minor versions are set at {{10.0}} and the build number is defined {{ReleaseID}} under the Key {{HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion}}This allows Microsoft to follow a "Semi-Annual" release model with:* Spring Major Feature Updates, with a build number of the form {{YY03}} and* Fall Minor Feature Update, with a build number of the form {{YY09}}Windows 10 follows with Semi-Annual model, with the Server versions releasing less frequently.See the [current build history| https://en.wikipedia.org/wiki/Windows_10_version_history].It is recommended that Facter adds the Build Number ({{ReleaseID}} and also returns some other attributes from this key as follows:* {{ReleaseID}} - The 4 digit Windows Build Version of the form YYMM* {{InstallationType}} - Differentiates Server, Server Core, Client (Desktop), e.g. (Server|Server Core|Client )* {{EditionID}} - Server or Desktop Edition variant - (ServerStandard|Professional|Enterprise)* {{ProductName}} - Textual Product Name  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
   

Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019

2018-10-11 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1889  
 
 
  Windows operating system facts should resolve correctly for Server 2019   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2018/10/11 12:36 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Enis Inan  
 

  
 
 
 
 

 
 Some assumptions were made in FACT-1492 about how Windows version numbers should resolve (currently codified here). Now that Windows 2019 server is out, we should update those assumptions to use the build number, which lets us distinguish between Windows 2016 and Windows 2019.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 
 

Jira (FACT-1881) Windows operating system versions fact should include build numbers for Windows 10 / resolve correctly on Server 2019

2018-10-11 Thread John O'Connor (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 John O'Connor updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1881  
 
 
  Windows operating system versions fact should include build numbers for Windows 10 / resolve correctly on Server 2019   
 

  
 
 
 
 

 
Change By: 
 John O'Connor  
 

  
 
 
 
 

 
 Some assumptions were made in FACT-1492 about how Windows version numbers should resolve (currently codified [here|https://github.com/puppetlabs/facter/blob/2ad48c341831ac261c9ef16e94f94e74735959c2/lib/src/facts/windows/operating_system_resolver.cc#L103-L104]) *update* Probably going to go for the needs must solution here and differentiate on build numbers to get this ticket resolved quickly.I.e. test for build number >= {{10.0.17763}} (or possibly {{10.0.17623}} first tech preview March 20 2018).However, medium term, the Windows  Version resolver should really take into account the new Semi-Annual release model, as these version numbers are more readily identifiable.Windows  10/2016+ versioning has changed in that the Kernel Major/Minor versions are set at {{10.0}} and the build number is defined {{ReleaseID}} under the Key {{HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion}}This allows Microsoft to follow a "Semi-Annual" release model with:* Spring Major Feature Updates, with a build number of the form {{YY03}} and* Fall Minor Feature Update, with a build number of the form {{YY09}}Windows 10 follows with Semi-Annual model, with the Server versions releasing less frequently.See the [current build history| https://en.wikipedia.org/wiki/Windows_10_version_history].It is recommended that Facter adds the Build Number ({{ReleaseID}} and also returns some other attributes from this key as follows:* {{ReleaseID}} - The 4 digit Windows Build Version of the form YYMM* {{InstallationType}} - Differentiates Server, Server Core, Client (Desktop), e.g. (Server|Server Core|Client )* {{EditionID}} - Server or Desktop Edition variant - (ServerStandard|Professional|Enterprise)* {{ProductName}} - Textual Product Name  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

 

Jira (PDB-4138) Test merge 6.0.x

2018-10-11 Thread gepetto-bot (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 gepetto-bot created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 PuppetDB /  PDB-4138  
 
 
  Test merge 6.0.x   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2018/10/11 12:12 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 gepetto-bot  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.

Jira (BOLT-922) Bolt suppresses errors from transport

2018-10-11 Thread Michael Smith (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Smith assigned an issue to Michael Smith  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet Task Runner /  BOLT-922  
 
 
  Bolt suppresses errors from transport   
 

  
 
 
 
 

 
Change By: 
 Michael Smith  
 
 
Assignee: 
 Michael Smith  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (BOLT-922) Bolt suppresses errors from transport

2018-10-11 Thread Michael Smith (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Smith created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet Task Runner /  BOLT-922  
 
 
  Bolt suppresses errors from transport   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2018/10/11 11:44 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Michael Smith  
 

  
 
 
 
 

 
 Found with BOLT-920. If the ed25519 gem isn't installed, then we should be seeing  
 
 
 
 
 #  
 
 
 net-ssh requires the following gems for ed25519 support:  
 
 
  * ed25519 (>= 1.2, < 2.0)  
 
 
  * bcrypt_pbkdf (>= 1.0, < 2.0)  
 
 
 See https://github.com/net-ssh/net-ssh/issues/565 for more information  
 
 
 Gem::LoadError : "ed25519 is not part of the bundle. Add it to your Gemfile."  
 
 
 >
  
   

Jira (BOLT-922) Bolt suppresses errors from transport

2018-10-11 Thread Michael Smith (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Smith updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet Task Runner /  BOLT-922  
 
 
  Bolt suppresses errors from transport   
 

  
 
 
 
 

 
Change By: 
 Michael Smith  
 
 
Affects Version/s: 
 BOLT 1.0.0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (BOLT-920) Bolt unable to connect with ecdsa key

2018-10-11 Thread Michael Smith (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Smith commented on  BOLT-920  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Bolt unable to connect with ecdsa key   
 

  
 
 
 
 

 
 SSH 7.8 switched ssh-keygen to outputting keys in the OpenSSH format (rather than OpenSSL's PEM format). This breaks net-ssh for everything except ed25519 keys due to https://github.com/net-ssh/net-ssh/blob/v5.0.2/lib/net/ssh/key_factory.rb#L112. Issue at https://github.com/net-ssh/net-ssh/issues/633.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (BOLT-380) Support ed25519 out-of-the-box

2018-10-11 Thread Michael Smith (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Smith commented on  BOLT-380  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Support ed25519 out-of-the-box   
 

  
 
 
 
 

 
 The move to net-ssh 5.0.2 breaks our ability to use Bolt with Beaker. We need to allow net-ssh 4.0 compatibility.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9212) add acceptance tests for vault lookup

2018-10-11 Thread Eric Thompson (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Eric Thompson commented on  PUP-9212  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: add acceptance tests for vault lookup   
 

  
 
 
 
 

 
 Tony Vu,Patrick Carlisle do we still want to do this?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (BOLT-755) Bolt should support multi-file tasks

2018-10-11 Thread Michael Smith (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Smith updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet Task Runner /  BOLT-755  
 
 
  Bolt should support multi-file tasks   
 

  
 
 
 
 

 
Change By: 
 Michael Smith  
 

  
 
 
 
 

 
 When task metadata specifies files that the task depends on bolt should package those and upload them to the target before executing the task.Changes * Copy the files into the correct location in installdir on the target after determining the implementation to use. * pass the path to the installdir as _installdir to the task Questions * Should bolt use the directory upload functionality or just copy files one by one?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit 

Jira (BOLT-191) Ability to upload directories or recursively upload files in plans

2018-10-11 Thread Michael Smith (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Smith commented on  BOLT-191  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Ability to upload directories or recursively upload files in plans   
 

  
 
 
 
 

 
 puppetlabs-bolt_shim needs a release as part of this work.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8676) Add cache support to 4.x function API

2018-10-11 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg commented on  PUP-8676  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Add cache support to 4.x function API   
 

  
 
 
 
 

 
 Josh Cooper How should we proceed with this? The basic cache for 4.x functions is in place. Do you want to add nice support for HttpPool ? Perhaps open a new ticket for that? The work as per the description in this ticket is otherwise finished and in the 6.0. (Suggest closing this as Fixed).  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8640) Resolve Deferred values at catalog apply time

2018-10-11 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg commented on  PUP-8640  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Resolve Deferred values at catalog apply time   
 

  
 
 
 
 

 
 This ticket is stale - the real work took place elsewhere. Closing as fixed.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (BOLT-921) Formatting issues in Bolt docs

2018-10-11 Thread David Kramer (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 David Kramer updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet Task Runner /  BOLT-921  
 
 
  Formatting issues in Bolt docs   
 

  
 
 
 
 

 
Change By: 
 David Kramer  
 
 
Sprint: 
 Bolt Kanban  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (BOLT-614) I want to know how to write multi-implementation tasks so they are backwards compatible with PE 2018.1

2018-10-11 Thread Michael Smith (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Smith updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet Task Runner /  BOLT-614  
 
 
  I want to know how to write multi-implementation tasks so they are backwards compatible with PE 2018.1   
 

  
 
 
 
 

 
Change By: 
 Michael Smith  
 
 
Fix Version/s: 
 BOLT Next  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (BOLT-614) I want to know how to write multi-implementation tasks so they are backwards compatible with PE 2018.1

2018-10-11 Thread Michael Smith (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Smith updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet Task Runner /  BOLT-614  
 
 
  I want to know how to write multi-implementation tasks so they are backwards compatible with PE 2018.1   
 

  
 
 
 
 

 
Change By: 
 Michael Smith  
 
 
Fix Version/s: 
 BOLT Next  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (BOLT-918) support tty in bolt-server

2018-10-11 Thread Alex Dreyer (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Alex Dreyer updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet Task Runner /  BOLT-918  
 
 
  support tty in bolt-server   
 

  
 
 
 
 

 
Change By: 
 Alex Dreyer  
 
 
Fix Version/s: 
 BOLT Next  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (BOLT-918) support tty in bolt-server

2018-10-11 Thread Alex Dreyer (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Alex Dreyer updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet Task Runner /  BOLT-918  
 
 
  support tty in bolt-server   
 

  
 
 
 
 

 
Change By: 
 Alex Dreyer  
 
 
Release Notes: 
 Not Needed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (BOLT-920) Bolt unable to connect with ecdsa key

2018-10-11 Thread Michael Smith (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Smith updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet Task Runner /  BOLT-920  
 
 
  Bolt unable to connect with ecdsa key   
 

  
 
 
 
 

 
Change By: 
 Michael Smith  
 
 
Sprint: 
 Bolt Ready for Grooming  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9198) Add support for RHEL 8 in package providers

2018-10-11 Thread Geoff Nichols (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Geoff Nichols updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9198  
 
 
  Add support for RHEL 8 in package providers   
 

  
 
 
 
 

 
Change By: 
 Geoff Nichols  
 
 
Labels: 
 linux redhat type_and_provider  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9198) Add support for RHEL 8 in package providers

2018-10-11 Thread Geoff Nichols (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Geoff Nichols updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9198  
 
 
  Add support for RHEL 8 in package providers   
 

  
 
 
 
 

 
Change By: 
 Geoff Nichols  
 
 
Sprint: 
 Platform OS Kanban  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1881) Windows operating system versions fact should include build numbers for Windows 10 / resolve correctly on Server 2019

2018-10-11 Thread John O'Connor (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 John O'Connor updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1881  
 
 
  Windows operating system versions fact should include build numbers for Windows 10 / resolve correctly on Server 2019   
 

  
 
 
 
 

 
Change By: 
 John O'Connor  
 

  
 
 
 
 

 
 Some assumptions were made in FACT-1492 about how Windows version numbers should resolve (currently codified [here|https://github.com/puppetlabs/facter/blob/2ad48c341831ac261c9ef16e94f94e74735959c2/lib/src/facts/windows/operating_system_resolver.cc#L103-L104])Windows 10/2016+ versioning has changed in that the Kernel Major/Minor versions are set at {{10.0}} and the build number is defined {{ReleaseID}} under the Key {{HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion}}This allows Microsoft to follow a "Semi-Annual" release model with:* Spring Major Feature Updates, with a build number of the form {{YY03}} and* Fall Minor Feature Update, with a build number of the form {{YY09}}Windows 10 follows with Semi-Annual model, with the Server versions releasing less frequently.See the [current build history| https://en.wikipedia.org/wiki/Windows_10_version_history].It is recommended that Facter adds the Build Number ({{ReleaseID}} and also returns some other attributes from this key as follows: * {{ReleaseID}} - The 4 digit Windows Build Version of the form YYMM  * {{InstallationType}} - Differentiates Server, Server Core, Client (Desktop), e.g. (Server|Server Core|Client )* {{EditionID}} - Server or Desktop Edition variant - (ServerStandard|Professional|Enterprise)* {{ProductName}} - Textual Product Name  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
  

Jira (FACT-1881) Windows operating system versions fact should include build numbers for Windows 10 / resolve correctly on Server 2019

2018-10-11 Thread John O'Connor (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 John O'Connor updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1881  
 
 
  Windows operating system versions fact should include build numbers for Windows 10 / resolve correctly on Server 2019   
 

  
 
 
 
 

 
Change By: 
 John O'Connor  
 

  
 
 
 
 

 
 Some assumptions were made in FACT-1492 about how Windows version numbers should resolve (currently codified [here|https://github.com/puppetlabs/facter/blob/2ad48c341831ac261c9ef16e94f94e74735959c2/lib/src/facts/windows/operating_system_resolver.cc#L103-L104])Windows 10/2016+ versioning has changed in that the Kernel Major/Minor versions are set at {{10.0}} and the build number is defined {{ReleaseID}} under the Key {{HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion}}This allows Microsoft to follow a "Semi-Annual" release model with:* Spring Major Feature Updates, with a build number of the form {{YY03}} and* Fall Minor Feature Update, with a build number of the form {{YY09}}Windows 10 follows with Semi-Annual model, with the Server versions releasing less frequently.See the [current build history| https://en.wikipedia.org/wiki/Windows_10_version_history].It is recommended that Facter  update its   adds the Build Number ({{ReleaseID}} and also returns some other attributes from this key as follows:  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   

Jira (FACT-1881) Windows operating system versions fact should include build numbers for Windows 10 / resolve correctly on Server 2019

2018-10-11 Thread John O'Connor (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 John O'Connor updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1881  
 
 
  Windows operating system versions fact should include build numbers for Windows 10 / resolve correctly on Server 2019   
 

  
 
 
 
 

 
Change By: 
 John O'Connor  
 

  
 
 
 
 

 
 Some assumptions were made in FACT-1492 about how Windows version numbers should resolve (currently codified [here|https://github.com/puppetlabs/facter/blob/2ad48c341831ac261c9ef16e94f94e74735959c2/lib/src/facts/windows/operating_system_resolver.cc#L103-L104])Windows 10/2016+ versioning has changed in that the Kernel Major/Minor versions are set at {{10.0}} and the build number is defined {{ReleaseID}} under the Key {{HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion}}This allows Microsoft to follow a "Semi-Annual" release model with:* Spring Major Feature Updates, with a build number of the form {{YY03}} and* Fall Minor Feature Update, with a build number of the form {{YY09}}Windows 10 follows with Semi-Annual model, with the Server versions releasing less frequently.See the [current build history| https://en.wikipedia.org/wiki/Windows_10_version_history]. It is recommended that Facter  should be updated to address these details.  update its   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 
  

Jira (FACT-1881) Windows operating system versions fact should include build numbers for Windows 10 / resolve correctly on Server 2019

2018-10-11 Thread John O'Connor (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 John O'Connor updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1881  
 
 
  Windows operating system versions fact should include build numbers for Windows 10 / resolve correctly on Server 2019   
 

  
 
 
 
 

 
Change By: 
 John O'Connor  
 

  
 
 
 
 

 
 Some assumptions were made in FACT-1492 about how Windows version numbers should resolve (currently codified [here|https://github.com/puppetlabs/facter/blob/2ad48c341831ac261c9ef16e94f94e74735959c2/lib/src/facts/windows/operating_system_resolver.cc#L103-L104])Windows 10/2016+ versioning has changed in that the Kernel Major/Minor versions are set at {{10.0}} and  additional parameters are  the build number is  defined  in  {{ReleaseID}} under  theKey {{HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion}}  Those assumptions are codified in https://github.com/puppetlabs/facter/blob/2ad48c341831ac261c9ef16e94f94e74735959c2/lib/src/facts/windows/operating_system_resolver.cc#L103 This allows Microsoft to follow a "Semi - L104 Annual" release model with:  The story around Windows versioning has changed * Spring Major Feature Updates, with  a  bit  build number of the form {{YY03}} and* Fall Minor Feature Update ,  such that there are many versions  with a build number  of  the form {{YY09}}  Windows 10  follows  with  different build numbers  Semi-Annual model, with the Server versions releasing less frequently .   See  the [current build history|  https://en.wikipedia.org/wiki/Windows_10_version_history  for the current history ] . Furthermore, Windows 2019 now exists and it appears that it will follow a similar format going forward. Facter should be updated to address these details.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 
   

Jira (FACT-1881) Windows operating system versions fact should include build numbers for Windows 10 / resolve correctly on Server 2019

2018-10-11 Thread John O'Connor (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 John O'Connor updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1881  
 
 
  Windows operating system versions fact should include build numbers for Windows 10 / resolve correctly on Server 2019   
 

  
 
 
 
 

 
Change By: 
 John O'Connor  
 

  
 
 
 
 

 
 Some assumptions were made in FACT-1492 about how Windows version numbers should resolve  (currently codified [here|https://github . com/puppetlabs/facter/blob/2ad48c341831ac261c9ef16e94f94e74735959c2/lib/src/facts/windows/operating_system_resolver.cc#L103-L104])  Windows 10/2016+ versioning has changed in that the Kernel Major/Minor versions are set at {{10.0}} and additional parameters are defined in the  Those assumptions are codified in https://github.com/puppetlabs/facter/blob/2ad48c341831ac261c9ef16e94f94e74735959c2/lib/src/facts/windows/operating_system_resolver.cc#L103-L104The story around Windows versioning has changed a bit, such that there are many versions of Windows 10 with different build numbers. See https://en.wikipedia.org/wiki/Windows_10_version_history for the current history.Furthermore, Windows 2019 now exists and it appears that it will follow a similar format going forward.Facter should be updated to address these details.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

Jira (PUP-9218) Refactor the crontab filetype

2018-10-11 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9218  
 
 
  Refactor the crontab filetype   
 

  
 
 
 
 

 
Change By: 
 Enis Inan  
 

  
 
 
 
 

 
 The [crontab|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/filetype.rb#L169] filetype is quite old, with its class declaration outdated. Its current implementation uses `%x` instead of `Puppet::Util::Execution.execute` when executing some of the crontab commands, which is bad because any failures are swallowed. For example in [read|http://example.com], any potential FileReadErrors are swallowed, which could lead to the behavior in PUP-9217 to occur. In [remove|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/filetype.rb#L194], Puppet would have no idea whether removing the crontab entry succeeded or failed. Currently, {{remove}} is not being used anywhere so we have not yet run into any issues here; however, it would be good to fix this in case we ever do need to use it in the future.The work in this ticket consists of updating the crontab filetype to use `Puppet::Util::Execution.execute` , and . It would also be nice  to make it consistent with how `suntab` and `aixtab` are implemented, if possible, since it seems like the only difference between the three commands are their error messages.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   

Jira (PUP-9088) Build Puppet Agent for Ubuntu 18.10

2018-10-11 Thread Mihai Buzgau (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9088  
 
 
  Build Puppet Agent for Ubuntu 18.10   
 

  
 
 
 
 

 
Change By: 
 Mihai Buzgau  
 
 
Sprint: 
 PR - 2018-08-29, PR - 2018-09-12, PR - 2018-09-26 , PR - 2018-10-10  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9218) Refactor the crontab filetype

2018-10-11 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9218  
 
 
  Refactor the crontab filetype   
 

  
 
 
 
 

 
Change By: 
 Enis Inan  
 

  
 
 
 
 

 
 The [crontab|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/filetype.rb#L169] filetype is quite old, with its class declaration outdated. Its current implementation uses `%x` instead of `Puppet::Util::Execution.execute` when executing some of the crontab commands, which is bad because any failures are swallowed. For example in [read|http://example.com], any potential FileReadErrors are swallowed, which could lead to the behavior in PUP-9217 to occur. In [remove|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/filetype.rb#L194], Puppet would have no idea whether removing the crontab entry succeeded or failed. Currently, {{remove}} is not being used anywhere so we have not yet run into any issues here; however, it would be good to fix this in case we ever do need to use it in the future.The work in this ticket consists of updating the crontab filetype to use `Puppet::Util::Execution.execute`, and to make it consistent with how `suntab` and `aixtab` are implemented,  if possible,  since it seems like the only difference between the three commands are their error messages.  It should be possible, then, to extract the duplicate logic between these three types into a more generic method.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 
   

Jira (PUP-9218) Refactor the crontab filetype

2018-10-11 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9218  
 
 
  Refactor the crontab filetype   
 

  
 
 
 
 

 
Change By: 
 Enis Inan  
 
 
Team: 
 Platform OS  
 
 
Sprint: 
 Platform OS Kanban  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9218) Refactor the crontab filetype

2018-10-11 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan assigned an issue to Enis Inan  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9218  
 
 
  Refactor the crontab filetype   
 

  
 
 
 
 

 
Change By: 
 Enis Inan  
 
 
Assignee: 
 Enis Inan  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9218) Refactor the crontab filetype

2018-10-11 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9218  
 
 
  Refactor the crontab filetype   
 

  
 
 
 
 

 
Change By: 
 Enis Inan  
 

  
 
 
 
 

 
 The [crontab|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/filetype.rb#L169] filetype is quite old, with its class declaration outdated. Its current implementation uses `%x` instead of `Puppet::Util::Execution.execute` when executing some of the crontab commands, which is bad because any failures are swallowed. For example in [read|http://example.com], any potential FileReadErrors are swallowed, which could lead to the behavior in PUP-9217 to occur. In [remove| http://example.com] https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/filetype.rb#L194], Puppet would have no idea whether removing the crontab entry succeeded or failed. Currently, {{remove}} is not being used anywhere so we have not yet run into any issues here; however, it would be good to fix this in case we ever do need to use it in the future.The work in this ticket consists of updating crontab to use `Puppet::Util::Execution.execute`, and to make it consistent with how `suntab` and `aixtab` are implemented, since it seems like the only difference between the three commands are their error messages. It should be possible, then, extract the duplicate logic between these three types into a more generic method.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 
  

Jira (PUP-9218) Refactor the crontab filetype

2018-10-11 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9218  
 
 
  Refactor the crontab filetype   
 

  
 
 
 
 

 
Change By: 
 Enis Inan  
 

  
 
 
 
 

 
 The [crontab|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/filetype.rb#L169] filetype is quite old, with its class declaration outdated. Its current implementation uses `%x` instead of `Puppet::Util::Execution.execute` when executing some of the crontab commands, which is bad because any failures are swallowed. For example in [read|http://example.com], any potential FileReadErrors are swallowed, which could lead to the behavior in PUP-9217 to occur. In [remove|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/filetype.rb#L194], Puppet would have no idea whether removing the crontab entry succeeded or failed. Currently, {{remove}} is not being used anywhere so we have not yet run into any issues here; however, it would be good to fix this in case we ever do need to use it in the future.The work in this ticket consists of updating  the  crontab  filetype  to use `Puppet::Util::Execution.execute`, and to make it consistent with how `suntab` and `aixtab` are implemented, since it seems like the only difference between the three commands are their error messages. It should be possible, then, extract the duplicate logic between these three types into a more generic method.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 
  

Jira (PUP-9218) Refactor the crontab filetype

2018-10-11 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9218  
 
 
  Refactor the crontab filetype   
 

  
 
 
 
 

 
Change By: 
 Enis Inan  
 

  
 
 
 
 

 
 The [crontab|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/filetype.rb#L169] filetype is quite old, with its class declaration outdated. Its current implementation uses `%x` instead of `Puppet::Util::Execution.execute` when executing some of the crontab commands, which is bad because any failures are swallowed. For example in [read|http://example.com], any potential FileReadErrors are swallowed, which could lead to the behavior in PUP-9217 to occur. In [remove|https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/filetype.rb#L194], Puppet would have no idea whether removing the crontab entry succeeded or failed. Currently, {{remove}} is not being used anywhere so we have not yet run into any issues here; however, it would be good to fix this in case we ever do need to use it in the future.The work in this ticket consists of updating the crontab filetype to use `Puppet::Util::Execution.execute`, and to make it consistent with how `suntab` and `aixtab` are implemented, since it seems like the only difference between the three commands are their error messages. It should be possible, then,  to  extract the duplicate logic between these three types into a more generic method.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 
 

Jira (PUP-9218) Refactor the crontab filetype

2018-10-11 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9218  
 
 
  Refactor the crontab filetype   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2018/10/10 11:12 PM  
 
 
Fix Versions: 
 PUP 5.5.7, PUP 6.0.3  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Enis Inan  
 

  
 
 
 
 

 
 The crontab filetype is quite old, with its class declaration outdated. Its current implementation uses `%x` instead of `Puppet::Util::Execution.execute` when executing some of the crontab commands, which is bad because any failures are swallowed. For example in read, any potential FileReadErrors are swallowed, which could lead to the behavior in PUP-9217 to occur. In removehttps://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/filetype.rb#L194], Puppet would have no idea whether removing the crontab entry succeeded or failed. Currently, remove is not being used anywhere so we have not yet run into any issues here; however, it would be good to fix this in case we ever do need to use it in the future. The work in this ticket consists of updating crontab to use `Puppet::Util::Execution.execute`, and to make it consistent with how `suntab` and `aixtab` are implemented, since it seems like the only difference between the three commands are their error messages. It should be possible, then, extract the duplicate logic between these three types into a more generic method.  
 

  
 
 
 
 

 
 
 

 

Jira (PUP-9218) Refactor the crontab filetype

2018-10-11 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9218  
 
 
  Refactor the crontab filetype   
 

  
 
 
 
 

 
Change By: 
 Enis Inan  
 
 
Priority: 
 Normal Major  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.