Jira (PUP-9309) Remove unused AST class SubLocatedExpression
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9309 Remove unused AST class SubLocatedExpression Change By: Josh Cooper Summary: Remove unused AST class SublocatedExpression SubLocatedExpression Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.284713.1542018073000.18713.1597813560037%40Atlassian.JIRA.
Jira (PUP-9405) Remove Future Feature flag for @prefetch_failed_providers in transaction.rb
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9405 Remove Future Feature flag for @prefetch_failed_providers in transaction.rb Change By: Josh Cooper Sprint: Platform Core KANBAN Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.290960.1546996315000.18697.1597801260026%40Atlassian.JIRA.
Jira (PUP-9405) Remove Future Feature flag for @prefetch_failed_providers in transaction.rb
Title: Message Title Josh Cooper assigned an issue to Josh Cooper Puppet / PUP-9405 Remove Future Feature flag for @prefetch_failed_providers in transaction.rb Change By: Josh Cooper Assignee: Josh Cooper Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.290960.1546996315000.18696.1597801200099%40Atlassian.JIRA.
Jira (PUP-9405) Remove Future Feature flag for @prefetch_failed_providers in transaction.rb
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9405 Remove Future Feature flag for @prefetch_failed_providers in transaction.rb Change By: Josh Cooper Release Notes: Bug Fix Release Notes Summary: If a providers' prefetch method raises a LoadError or StandardError, the resources associated with the provider will be marked as failed, but unrelated resources will be applied. Previously this behavior was controlled by the future_features flag, and was disabled by default. Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.290960.1546996315000.18695.1597801200044%40Atlassian.JIRA.
Jira (PUP-9405) Remove Future Feature flag for @prefetch_failed_providers in transaction.rb
Title: Message Title Josh Cooper commented on PUP-9405 Re: Remove Future Feature flag for @prefetch_failed_providers in transaction.rb There's a lot of history with this issue. I think the desired behavior is: It should be possible to install a dependency needed by a provider that implements prefetch in a single agent run. If prefetch fails: the overall report status should be marked as failed. the error message should indicate which resource type and provider failed. all resources associated with the provider should be marked as failed. any resources that depend on the failed resource(s) should be marked as skipped due to the failure. unrelated resources should continue to be applied. Here are my notes about how we got here: Redmine-6907 prefetch was called on all providers before their dependencies (commands, etc) were installed, so you couldn't install a dependency needed by a provider implementing prefetch in the same run. Puppet was changed to lazily prefetch, but in doing so swallowed all StandardErrors. This caused puppet to think no resources were present, and it would try to create them, even though they might already exist. This was common for REST providers managing remote resources. PUP-3656 prefetch was modified to only rescue LoadError and MissingCommand. The thinking was there must be something wrong with the provider if it raises an error other than LoadError or MissingCommand. If a provider raised a different exception, then the entire transaction was aborted. However, none of the resources associated with the provider were marked as failed, and neither was the overall report status. This caused puppet to report success even though there were prefetch errors (eg packages). PUP-7630 All exceptions were rescued. Exceptions other than LoadError and MissingCommand caused the resource to be marked as failed. But failed resources for other reasons were not logged or marked as failed. PUP-8962 Modified to only rescue StandardError not Exception. Always log the failed provider before re-raising. future_features flag was added but not enabled prior to Puppet 6.0. PUP-8288 Due to PUP-7630, puppet could rescue provider exceptions (other than MissingCommand and LoadError) and never mark the resource as failed. So the overall report status was "success". This ticket changed puppet so it assumed the transaction failed, and only marked success if the transaction finished For this ticket, I think we should rescue LoadError and StandardError, log the error with resource type and provider, record that prefetch failed, mark all directly affected resources as failed, etc.
Jira (PUP-10472) Remove Puppet.define_settings
Title: Message Title Josh Cooper commented on PUP-10472 Re: Remove Puppet.define_settings Merged to main in https://github.com/puppetlabs/puppet/commit/71754e9f61cebfe7dbee8ac50b9284754c078208 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.356936.1588031208000.18686.1597795980025%40Atlassian.JIRA.
Jira (PUP-10472) Remove Puppet.define_settings
Title: Message Title Josh Cooper assigned an issue to Josh Cooper Puppet / PUP-10472 Remove Puppet.define_settings Change By: Josh Cooper Assignee: Josh Cooper Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.356936.1588031208000.18277.1597772760231%40Atlassian.JIRA.
Jira (PUP-10472) Remove Puppet.define_settings
Title: Message Title Josh Cooper updated an issue Puppet / PUP-10472 Remove Puppet.define_settings Change By: Josh Cooper Sprint: Platform Core KANBAN Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.356936.1588031208000.18276.1597772760187%40Atlassian.JIRA.
Jira (PUP-9346) Change default value of hostcsr setting
Title: Message Title Josh Cooper commented on PUP-9346 Re: Change default value of hostcsr setting Passed CI in de6de62149 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.287916.1544223816000.18150.1597768560363%40Atlassian.JIRA.
Jira (PUP-8446) Remove "puppet man" face application
Title: Message Title Josh Cooper commented on PUP-8446 Re: Remove "puppet man" face application Passed CI in de6de62149 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.236111.1518213204000.18142.1597768500180%40Atlassian.JIRA.
Jira (PUP-6645) Remove the hiera_xxx functions
Title: Message Title Josh Cooper updated an issue Puppet / PUP-6645 Remove the hiera_xxx functions Change By: Josh Cooper Team: Froyo Coremunity Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.148538.1471963467000.18140.1597768380026%40Atlassian.JIRA.
Jira (PUP-10603) File Resource HTTP GET - Misuse of URL encoding
Title: Message Title Josh Cooper updated an issue Puppet / PUP-10603 File Resource HTTP GET - Misuse of URL encoding Change By: Josh Cooper Release Notes: Bug Fix Release Notes Summary: Puppet 6.16.0 introduced a regression when using http file sources and the URL request path or query contained special characters. This restores the behavior that existed previously. In order to specify a path or query that contains a space (for example), then it must be URL encoded in the manifest, e.g. source => 'http://example.com/path%20to%file?q=a%20b' Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.367500.1595969611000.18101.1597766940320%40Atlassian.JIRA.
Jira (PUP-10603) File Resource HTTP GET - Misuse of URL encoding
Title: Message Title Josh Cooper commented on PUP-10603 Re: File Resource HTTP GET - Misuse of URL encoding Merged to main in https://github.com/puppetlabs/puppet/commit/3443d720839e1f1ba87f5d2f2339dbbace5a21b9 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.367500.1595969611000.18091.1597766760193%40Atlassian.JIRA.
Jira (PUP-10489) Remove deprecated method from DirectoryService
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-10489 Remove deprecated method from DirectoryService Change By: Mihai Buzgau Sprint: PR NW - Triage 2020-09-01 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.357608.1588683093000.17905.1597762440187%40Atlassian.JIRA.
Jira (PUP-10488) Remove deprecated method from Puppet::Provider::NameService
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-10488 Remove deprecated method from Puppet::Provider::NameService Change By: Mihai Buzgau Sprint: PR NW - Triage 2020-09-01 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.357606.1588681832000.17904.1597762440142%40Atlassian.JIRA.
Jira (PUP-10625) Bump minimum required version to Ruby 2.5
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-10625 Bump minimum required version to Ruby 2.5 Change By: Mihai Buzgau Sprint: PR NW - Triage 2020-09-01 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.369498.1597739569000.17900.1597762380077%40Atlassian.JIRA.
Jira (PUP-10624) Puppet::Agent::Locker#running? deprecation warning
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-10624 Puppet::Agent::Locker#running? deprecation warning Change By: Mihai Buzgau Sprint: PR NW - Triage 2020-09-01 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.369496.1597738847000.17897.1597762320120%40Atlassian.JIRA.
Jira (PUP-10623) Audit acceptance tests and remove confines to EOL platforms
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-10623 Audit acceptance tests and remove confines to EOL platforms Change By: Mihai Buzgau Sprint: NW - 2020-09-01 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.369282.1597675533000.17894.1597762260026%40Atlassian.JIRA.
Jira (PUP-10622) Segmentation fault on start whith high-entropy ASLR
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-10622 Segmentation fault on start whith high-entropy ASLR Change By: Mihai Buzgau Sprint: PR - Triage Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.369265.1597654705000.17893.1597762140056%40Atlassian.JIRA.
Jira (PUP-10621) Windows 2019 French Puppet Acceptance Test failures
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-10621 Windows 2019 French Puppet Acceptance Test failures Change By: Mihai Buzgau Sprint: PR - Triage Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.369258.1597577205000.17890.1597762020124%40Atlassian.JIRA.
Jira (PUP-10620) Spurious Acceptance test failure: enable_password_changes_special_users.rb
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-10620 Spurious Acceptance test failure: enable_password_changes_special_users.rb Change By: Mihai Buzgau Sprint: PR - Triage Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.369257.1597576613000.17887.1597761960072%40Atlassian.JIRA.
Jira (PUP-10610) Change disable_i18n to true by default
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-10610 Change disable_i18n to true by default Change By: Mihai Buzgau Sprint: PR - Triage Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.368587.1596752428000.17876.1597761780038%40Atlassian.JIRA.
Jira (PUP-10610) Change disable_i18n to true by default
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-10610 Change disable_i18n to true by default Change By: Mihai Buzgau Sprint: PR NW - Triage 2020-09-01 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.368587.1596752428000.17877.1597761780084%40Atlassian.JIRA.
Jira (PUP-10474) Remove deprecated Puppet::Resource methods
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-10474 Remove deprecated Puppet::Resource methods Change By: Mihai Buzgau Sprint: NW - 2020-09-01 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.356947.158803264.17875.1597761720025%40Atlassian.JIRA.
Jira (PUP-10387) Remove puppet module build, generate and search actions
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-10387 Remove puppet module build, generate and search actions Change By: Mihai Buzgau Sprint: NW - 2020-09-01 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.350961.1585070066000.17874.1597761660028%40Atlassian.JIRA.
Jira (PDB-4682) PuppetDB sync status doesn't get updated when finished
Title: Message Title Austin Boyd updated an issue PuppetDB / PDB-4682 PuppetDB sync status doesn't get updated when finished Change By: Austin Boyd Zendesk Ticket Count: 1 Zendesk Ticket IDs: 39812 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.354044.1585853662000.17849.1597759500042%40Atlassian.JIRA.
Jira (PDB-4675) Deadlock when creating/inserting into a new report partition
Title: Message Title Austin Boyd updated an issue PuppetDB / PDB-4675 Deadlock when creating/inserting into a new report partition Change By: Austin Boyd Zendesk Ticket Count: 1 Zendesk Ticket IDs: 39812 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.350469.1584566547000.17850.1597759500095%40Atlassian.JIRA.
Jira (PDB-4682) PuppetDB sync status doesn't get updated when finished
Title: Message Title Austin Boyd updated an issue PuppetDB / PDB-4682 PuppetDB sync status doesn't get updated when finished Change By: Austin Boyd Labels: jira_escalated Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.354044.1585853662000.17847.1597759260046%40Atlassian.JIRA.
Jira (PDB-4675) Deadlock when creating/inserting into a new report partition
Title: Message Title Austin Boyd updated an issue PuppetDB / PDB-4675 Deadlock when creating/inserting into a new report partition Change By: Austin Boyd Labels: jira_escalated Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.350469.1584566547000.17848.1597759260091%40Atlassian.JIRA.
Jira (FACT-2747) Add missing legacy facts on all platforms
Title: Message Title Bogdan Irimie commented on FACT-2747 Re: Add missing legacy facts on all platforms Added `blockdevice` legacy facts blockdevice_sda_model => Virtual disk blockdevice_sda_size => 75161927680 blockdevice_sda_vendor => VMware blockdevice_sr0_model => VMware IDE CDR00 blockdevice_sr0_size => 1073741312 blockdevice_sr0_vendor => NECVMWar blockdevice_sr1_model => VMware IDE CDR01 blockdevice_sr1_size => 1073741312 blockdevice_sr1_vendor => NECVMWar blockdevices => sr0,sda,sr1
Jira (PUP-10625) Bump minimum required version to Ruby 2.5
Title: Message Title Mihai Buzgau created an issue Puppet / PUP-10625 Bump minimum required version to Ruby 2.5 Issue Type: Task Assignee: Unassigned Created: 2020/08/18 1:32 AM Priority: Normal Reporter: Mihai Buzgau On Platform 7 we will no longer support versions of Ruby that have gone end of life: 2.3 and 2.4. To achieve this we need to do the following on the Puppet main stream: update the Puppet gemspec: https://github.com/puppetlabs/puppet/blob/main/.gemspec#L21 update the Travis configuration: https://github.com/puppetlabs/puppet/blob/main/.travis.yml update project_data: https://github.com/puppetlabs/puppet/blob/main/ext/project_data.yaml#L17 Add Comment
Jira (PUP-10624) Puppet::Agent::Locker#running? deprecation warning
Title: Message Title Mihai Buzgau created an issue Puppet / PUP-10624 Puppet::Agent::Locker#running? deprecation warning Issue Type: Task Assignee: Unassigned Created: 2020/08/18 1:20 AM Priority: Normal Reporter: Mihai Buzgau Puppet::Agent::Locker#running? is still being used. We do not plan to remove it from Platform 7. We need to remove the deprecation warning from Puppet 6.x. Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
