Jira (PUP-11699) RSpec test failures when using Ruby 3.2 & OpenSSL 3

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper assigned an issue to Josh Cooper  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11699  
 
 
  RSpec test failures when using Ruby 3.2 & OpenSSL 3   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Assignee: 
 Josh Cooper  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.478065.1673308664000.71151.1673336820032%40Atlassian.JIRA.


Jira (PUP-11699) RSpec test failures when using Ruby 3.2 & OpenSSL 3

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-11699  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: RSpec test failures when using Ruby 3.2 & OpenSSL 3   
 

  
 
 
 
 

 
 Making note of incompatibilities: 1. EC#public_key= was removed as keys are now immutable. From the docs, "Feature removed without replacement.* Keys are now immutable once created - all components must be specified at once." 2. Previously, the public key didn't have to be set on the OpenSSL::X509::CertificateRequest before signing.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.478065.1673308664000.71150.1673336760053%40Atlassian.JIRA.


Jira (PUP-11698) Test against Ruby 3.2 & OpenSSL 3 on Windows

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11698  
 
 
  Test against Ruby 3.2 & OpenSSL 3 on Windows   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 This ticket is blocked on PUP-11699, to ensure rspec tests pass when using Ruby 3.2 and OpenSSL 3.0 on Ubuntu.For this ticket, add ruby 3.2.0 to the  is resolved  rspec GH action ,  Currently getting these test failures on puppet#main with Ruby 3.2.0  similar to what was done in https: / OpenSSL3 /github . 0 on Windows.  com/puppetlabs/facter/commit/335d8757bf4bad08d1194a595108382b1a39bd91   Note the setup-ruby  github  action will automatically install OpenSSL3 when using Ruby 3.2, see https://github.com/ruby/setup-ruby/blob/319066216501fbd5e2d568f14b7d68c19fb67a5d/windows.js#L107-L111 For this ticket, resolve these There are likely some Windows-specific rspec  failures  and add ruby  when running Ruby  3.2  to the GH action for Windows  and OpenSSL ,  similar  which will need  to  what was done in https://github  be fixed . com/puppetlabs/facter/commit/335d8757bf4bad08d1194a595108382b1a39bd91 {noformat}C:\Users\Administrator\puppet>git rev-parse HEAD178ff2e2e0508edd90b577b0d79cbe55f172da1cC:\Users\Administrator\puppet>bundle exec rspec spec... 1) apply http report processor rejects an HTTPS report server whose root cert is not the puppet CA Failure/Error:   expect { apply.command_line.args = ['-e', 'notify { "hi": }'] apply.run   }.to exit_with(0).and output(/Applied catalog/).to_stdout.and output(/Report processor failed: certificate verify failed \[self signed certificate in certificate chain for CN=Unknown CA\]/).to_stderr   expected block to output /Report processor failed: certificate verify failed \[self signed certificate in certificate chain for CN=Unknown CA\]/ to stderr, but output "\e[1;31mError: Report processor failed: certificate verify failed [self-signed certificate in certificate chain for CN=Unknown CA]\e[0m\n" # ./spec/integration/application/apply_spec.rb:627:in `block (4 levels) in ' # ./spec/lib/puppet_spec/https.rb:81:in `block in start_server' # ./spec/lib/puppet_spec/https.rb:41:in `pipe' # ./spec/lib/puppet_spec/https.rb:41:in `start_server' # ./spec/integration/application/apply_spec.rb:622:in `block (3 levels) in ' # ./spec/spec_helper.rb:180:in `block (2 levels) in '  2) Puppet::HTTP::Client when verifying an HTTPS server raises if the server's CA is unknown Failure/Error:   expect { client.get(URI("https://127.0.0.1:#{port}"), options: {ssl_context: alt_context})   }.to raise_error(Puppet::SSL::CertVerifyError, %r{certificate verify failed.* .self signed certificate in certificate chain for CN=Test CA.})   expected Puppet::SSL::CertVerifyError with message matching /certificate verify failed.* .self signed certificate in certificate chain for CN=Test CA./, got # with backtrace: # ./lib/puppet/ssl/verifier.rb:65:in `handle_connection_error' # ./lib/puppet/http/pool.rb:66:in `rescue in start'   

Jira (PUP-11698) Test against Ruby 3.2 & OpenSSL 3 on Windows

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11698  
 
 
  Test against Ruby 3.2 & OpenSSL 3 on Windows   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 This ticket is blocked on PUP-11699, to ensure rspec tests pass when using Ruby 3.2 and OpenSSL 3.0 on Ubuntu.For this ticket, add ruby 3.2.0 to the is resolved, Currently getting these test failures on puppet#main with Ruby 3.2.0/OpenSSL3.0 on Windows. Note the setup-ruby github action will automatically install OpenSSL3 when using Ruby 3.2, see https://github.com/ruby/setup-ruby/blob/319066216501fbd5e2d568f14b7d68c19fb67a5d/windows.js#L107-L111For this ticket, resolve these failures and add ruby 3.2 to the GH action for Windows, similar to what was done in https://github.com/puppetlabs/facter/commit/335d8757bf4bad08d1194a595108382b1a39bd91{noformat}C:\Users\Administrator\puppet>git rev-parse HEAD178ff2e2e0508edd90b577b0d79cbe55f172da1cC:\Users\Administrator\puppet>bundle exec rspec spec... 1) apply http report processor rejects an HTTPS report server whose root cert is not the puppet CA Failure/Error:   expect { apply.command_line.args = ['-e', 'notify { "hi": }'] apply.run   }.to exit_with(0).and output(/Applied catalog/).to_stdout.and output(/Report processor failed: certificate verify failed \[self signed certificate in certificate chain for CN=Unknown CA\]/).to_stderr   expected block to output /Report processor failed: certificate verify failed \[self signed certificate in certificate chain for CN=Unknown CA\]/ to stderr, but output "\e[1;31mError: Report processor failed: certificate verify failed [self-signed certificate in certificate chain for CN=Unknown CA]\e[0m\n" # ./spec/integration/application/apply_spec.rb:627:in `block (4 levels) in ' # ./spec/lib/puppet_spec/https.rb:81:in `block in start_server' # ./spec/lib/puppet_spec/https.rb:41:in `pipe' # ./spec/lib/puppet_spec/https.rb:41:in `start_server' # ./spec/integration/application/apply_spec.rb:622:in `block (3 levels) in ' # ./spec/spec_helper.rb:180:in `block (2 levels) in '  2) Puppet::HTTP::Client when verifying an HTTPS server raises if the server's CA is unknown Failure/Error:   expect { client.get(URI("https://127.0.0.1:#{port}"), options: {ssl_context: alt_context})   }.to raise_error(Puppet::SSL::CertVerifyError, %r{certificate verify failed.* .self signed certificate in certificate chain for CN=Test CA.})   expected Puppet::SSL::CertVerifyError with message matching /certificate verify failed.* .self signed certificate in certificate chain for CN=Test CA./, got # with backtrace: # ./lib/puppet/ssl/verifier.rb:65:in `handle_connection_error' # ./lib/puppet/http/pool.rb:66:in `rescue in start' # ./lib/puppet/http/pool.rb:62:in `start' # ./lib/puppet/http/pool.rb:107:in `borrow' # ./lib/puppet/http/pool.rb:22:in `with_connection' # ./lib/puppet/http/client.rb:149:in `connect' # ./lib/puppet/http/client.rb:366:in 

Jira (PUP-11699) RSpec test failures when using Ruby 3.2 & OpenSSL 3

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11699  
 
 
  RSpec test failures when using Ruby 3.2 & OpenSSL 3   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Team: 
 Phoenix  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.478065.1673308664000.71092.1673308740027%40Atlassian.JIRA.


Jira (PUP-11699) RSpec test failures when using Ruby 3.2 & OpenSSL 3

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11699  
 
 
  RSpec test failures when using Ruby 3.2 & OpenSSL 3   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2023/01/09 3:57 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Josh Cooper  
 

  
 
 
 
 

 
 On Ubuntu 22.04:  
 
 
 
 
 # apt-get install autoconf bison patch build-essential rustc libssl-dev libyaml-dev libreadline6-dev zlib1g-dev libgmp-dev libncurses5-dev libffi-dev libgdbm6 libgdbm-dev libdb-dev uuid-dev  
 
 
 # git clone https://github.com/rbenv/ruby-build  
 
 
 # cd ruby-build  
 
 
 # /ruby-build 3.2.0 /usr/local  
 
 
 # /usr/local/bin/ruby --version  
 
 
 ruby 3.2.0 (2022-12-25 revision a528908271) [x86_64-linux]  
 
 
   

Jira (PUP-11698) Test against Ruby 3.2 & OpenSSL 3 on Windows

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11698  
 
 
  Test against Ruby 3.2 & OpenSSL 3 on Windows   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 Currently getting these test failures on puppet#main with Ruby 3.2.0/OpenSSL3.0 on Windows.Note the setup-ruby github action will automatically install OpenSSL3 when using Ruby 3.2, see https://github.com/ruby/setup-ruby/blob/319066216501fbd5e2d568f14b7d68c19fb67a5d/windows.js#L107-L111   For this ticket, resolve these failures and add ruby 3.2 to the GH action for Windows, similar to what was done in https://github.com/puppetlabs/facter/commit/335d8757bf4bad08d1194a595108382b1a39bd91{noformat}C:\Users\Administrator\puppet>git rev-parse HEAD178ff2e2e0508edd90b577b0d79cbe55f172da1cC:\Users\Administrator\puppet>bundle exec rspec spec... 1) apply http report processor rejects an HTTPS report server whose root cert is not the puppet CA Failure/Error:   expect { apply.command_line.args = ['-e', 'notify { "hi": }'] apply.run   }.to exit_with(0).and output(/Applied catalog/).to_stdout.and output(/Report processor failed: certificate verify failed \[self signed certificate in certificate chain for CN=Unknown CA\]/).to_stderr   expected block to output /Report processor failed: certificate verify failed \[self signed certificate in certificate chain for CN=Unknown CA\]/ to stderr, but output "\e[1;31mError: Report processor failed: certificate verify failed [self-signed certificate in certificate chain for CN=Unknown CA]\e[0m\n" # ./spec/integration/application/apply_spec.rb:627:in `block (4 levels) in ' # ./spec/lib/puppet_spec/https.rb:81:in `block in start_server' # ./spec/lib/puppet_spec/https.rb:41:in `pipe' # ./spec/lib/puppet_spec/https.rb:41:in `start_server' # ./spec/integration/application/apply_spec.rb:622:in `block (3 levels) in ' # ./spec/spec_helper.rb:180:in `block (2 levels) in '  2) Puppet::HTTP::Client when verifying an HTTPS server raises if the server's CA is unknown Failure/Error:   expect { client.get(URI("https://127.0.0.1:#{port}"), options: {ssl_context: alt_context})   }.to raise_error(Puppet::SSL::CertVerifyError, %r{certificate verify failed.* .self signed certificate in certificate chain for CN=Test CA.})   expected Puppet::SSL::CertVerifyError with message matching /certificate verify failed.* .self signed certificate in certificate chain for CN=Test CA./, got # with backtrace: # ./lib/puppet/ssl/verifier.rb:65:in `handle_connection_error' # ./lib/puppet/http/pool.rb:66:in `rescue in start' # ./lib/puppet/http/pool.rb:62:in `start' # ./lib/puppet/http/pool.rb:107:in `borrow' # ./lib/puppet/http/pool.rb:22:in `with_connection' # ./lib/puppet/http/client.rb:149:in `connect' # ./lib/puppet/http/client.rb:366:in `execute_streaming' # ./lib/puppet/http/client.rb:203:in `get' # ./spec/integration/http/client_spec.rb:54:in `block (5 levels) in ' # 

Jira (PUP-11698) Test against Ruby 3.2 & OpenSSL 3 on Windows

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11698  
 
 
  Test against Ruby 3.2 & OpenSSL 3 on Windows   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Summary: 
 Test against Ruby 3.2  & OpenSSL 3  on Windows  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.478063.167330118.71088.1673308140057%40Atlassian.JIRA.


Jira (PDB-5572) Run puppetserver in its own jvm in the :integration tests

2023-01-09 Thread Rob Browning (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Rob Browning created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 PuppetDB /  PDB-5572  
 
 
  Run puppetserver in its own jvm in the :integration tests   
 

  
 
 
 
 

 
Issue Type: 
  Task  
 
 
Assignee: 
 Rob Browning  
 
 
Created: 
 2023/01/09 2:29 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Rob Browning  
 

  
 
 
 
 

 
 ...so that we're not conflating dependencies anymore (and so that we can continue to test 6.x server against 7.x pdb).  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
   

Jira (PUP-11698) Test against Ruby 3.2 on Windows

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11698  
 
 
  Test against Ruby 3.2 on Windows   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Team: 
 Phoenix  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.478063.167330118.71043.1673301240211%40Atlassian.JIRA.


Jira (PUP-11684) Change default value of "exclude_unchanged_resources"

2023-01-09 Thread Michael Hashizume (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Hashizume assigned an issue to Michael Hashizume  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11684  
 
 
  Change default value of "exclude_unchanged_resources"   
 

  
 
 
 
 

 
Change By: 
 Michael Hashizume  
 
 
Assignee: 
 Michael Hashizume  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.475865.1669953024000.71027.1673300400113%40Atlassian.JIRA.


Jira (PUP-11348) Remove Windows ENV patches on Ruby 3

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11348  
 
 
  Remove Windows ENV patches on Ruby 3   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 Ruby on Windows now stores environment variables and values as UTF-8, see [https://bugs.ruby-lang.org/issues/9715#note-8] so we should be able to remove the various monkey patches and workarounds in puppet, such as {{Puppet::Util.get_env}} Puppet should be able to: * manage registry entries with non-ascii characters  * manage users with umlat, C:\Users\Jöhn  * execute process with non-ascii in the command line as a non-ascii user  * get/set environment variables with rune characters: [https://bugs.ruby-lang.org/issues/8822#note-6]See related info in :https://tickets.puppetlabs.com/browse/PUP-5726?focusedCommentId=261201=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-261201 https://tickets.puppetlabs.com/browse/PUP-5768?focusedCommentId=273221=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-273221 And{code:puppet} exec { 'tomcat-configure-service':  command  => "powershell.exe Get-ChildItem Env:",  onlyif   => 'powershell.exe exit 0',provider => windows,  logoutput => true,  #notify => $tomcat_service,  tag  => 'tomcat-configure-service', }{code}{noformat}set USERNAME=Jöhnset USERPROFILE=C:\Users\JöhnC:\> puppet apply manifests\bug_swedish_userprofile.pp --test{noformat}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

Jira (PUP-11348) Remove Windows ENV patches on Ruby 3

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11348  
 
 
  Remove Windows ENV patches on Ruby 3   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 Ruby on Windows now stores environment variables and values as UTF-8, see [https://bugs.ruby-lang.org/issues/9715#note-8] so we should be able to remove the various monkey patches and workarounds in puppet, such as {{Puppet::Util.get_env}} Puppet should be able to:* manage registry entries with non-ascii characters * manage users with umlat, C:\Users\ John Jöhn  * execute process with non-ascii in the command line  as a non-ascii user  * get/set environment variables with rune characters:  [  https://bugs.ruby-lang.org/issues/8822#note-6 ]See related info in :https://tickets.puppetlabs.com/browse/PUP-5726?focusedCommentId=261201=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-261201And{code:puppet} exec { 'tomcat-configure-service':  command  => "powershell.exe Get-ChildItem Env:",  onlyif   => 'powershell.exe exit 0',provider => windows,  logoutput => true,  #notify => $tomcat_service,  tag  => 'tomcat-configure-service', }{code}{noformat}set USERNAME=Jöhnset USERPROFILE=C:\Users\JöhnC:\> puppet apply manifests\bug_swedish_userprofile.pp --test{noformat}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   

Jira (PUP-11348) Remove Windows ENV patches on Ruby 3

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11348  
 
 
  Remove Windows ENV patches on Ruby 3   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 Ruby on Windows now stores environment variables and values as UTF-8, see [https://bugs.ruby-lang.org/issues/9715#note-8] so we should be able to remove the various monkey patches and workarounds in puppet, such as {{Puppet::Util.get_env}}    Puppet should be able to:* manage registry entries with non-ascii characters   * manage users with umlat, C:\Users\John * execute process with non-ascii in the command line * get/set environment variables with rune characters: https://bugs.ruby-lang.org/issues/8822#note-6  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit 

Jira (FACT-1581) Facter 3 & 4 report an error when JSON external facts are empty

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  FACT-1581  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Facter 3 & 4 report an error when JSON external facts are empty   
 

  
 
 
 
 

 
 Puppet 6/Facter 3 will be EOL at the end of February, so we won't have plans on fixing that version. The issue also occurs in Puppet 7/Facter 4:    
 
 
 
 
 # facter --version 4.2.14  
 
 
    
 
 
 # cat /opt/puppetlabs/facter/facts.d/packages.json  
 
 
    
 
 
 # facter os.name  
 
 
 [2023-01-09 20:12:41.840516 ] ERROR Facter - Failed to handle /opt/puppetlabs/facter/facts.d/packages.json as LegacyFacter::Util::Parser::JsonParser facts: 783: unexpected token at ''  
 
 
 backtrace:  
 
 
 /opt/puppetlabs/puppet/lib/ruby/2.7.0/json/common.rb:156:in `parse'  
 
 
 /opt/puppetlabs/puppet/lib/ruby/2.7.0/json/common.rb:156:in `parse'  
 
 
 /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/custom_facts/util/parser.rb:146:in `parse_results'  
 
 
 /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/custom_facts/util/parser.rb:60:in `results'  
 
 
 /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/custom_facts/util/directory_loader.rb:117:in 

Jira (FACT-1581) Facter 3 & 4 report an error when JSON external facts are empty

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1581  
 
 
  Facter 3 & 4 report an error when JSON external facts are empty   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Summary: 
 Facter  reports  3 & 4 report  an error when JSON external facts are empty  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.178831.1488836584000.70938.1673295240152%40Atlassian.JIRA.


Jira (FACT-1581) Facter 3 & 4 report an error when JSON external facts are empty

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1581  
 
 
  Facter 3 & 4 report an error when JSON external facts are empty   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Component/s: 
 Facter 4  
 
 
Component/s: 
 Facter 3  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.178831.1488836584000.70939.1673295240201%40Atlassian.JIRA.


Jira (FACT-3076) Custom facts cannot reference external facts

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  FACT-3076  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Custom facts cannot reference external facts   
 

  
 
 
 
 

 
 Since Puppet 6/Facter 3 will be EOL at the end of February and Puppet 7/Facter 4 support the requested functionality, I'm going to close this as won't do.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.417351.1632831868000.70929.1673295060293%40Atlassian.JIRA.


Jira (FACT-2134) Facter should distinguish between CentOS 8 and CentOS 8 Stream

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  FACT-2134  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Facter should distinguish between CentOS 8 and CentOS 8 Stream   
 

  
 
 
 
 

 
 As described in https://github.com/puppetlabs/facter/pull/2291#issuecomment-790406132 there is a way to distinguish these without introducing a breaking change, so I'm going to close this.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.336204.1574351826000.70913.1673294880083%40Atlassian.JIRA.


Jira (FACT-3112) Stack trace on invalid facts.d entry

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  FACT-3112  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Stack trace on invalid facts.d entry   
 

  
 
 
 
 

 
 Since we haven't heard back, I'm going to close this. Feel free to reopen if you have steps to reproduce using a puppet-agent package built by Puppet.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.442439.1648713055000.70910.1673294700040%40Atlassian.JIRA.


Jira (FACT-3111) Facter 3 and 4 handle external facts with nil values differently

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3111  
 
 
  Facter 3 and 4 handle external facts with nil values differently   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Epic Link: 
 PUP-11658  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.442430.1648682189000.70908.1673294640032%40Atlassian.JIRA.


Jira (FACT-2980) Facter 4 outputs the processors.speed fact differently on Linux

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2980  
 
 
  Facter 4 outputs the processors.speed fact differently on Linux   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Epic Link: 
 PUP-11658  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.391203.1615892875000.70907.1673294580158%40Atlassian.JIRA.


Jira (FACT-2985) Facter 4 outputs os.distro.description differently on Debian 9

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  FACT-2985  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Facter 4 outputs os.distro.description differently on Debian 9   
 

  
 
 
 
 

 
 We don't have plans on changing Facter 4, so I'm going to close this.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.391212.1615903779000.70906.1673294580110%40Atlassian.JIRA.


Jira (FACT-3089) Processor ISA fact on Linux reports wrong data if the string contains a period

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3089  
 
 
  Processor ISA fact on Linux reports wrong data if the string contains a period   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Epic Link: 
 PUP-11658  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.421525.1635492732000.70905.1673294580055%40Atlassian.JIRA.


Jira (FACT-3136) Bug in gce.project.attributes.sshKeys

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3136  
 
 
  Bug in gce.project.attributes.sshKeys   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Epic Link: 
 PUP-11658  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.454867.1657650158000.70903.1673294520107%40Atlassian.JIRA.


Jira (FACT-3114) operatingsystemrelease/operatingsystemmajrelease missing on Arch Linux

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3114  
 
 
  operatingsystemrelease/operatingsystemmajrelease missing on Arch Linux   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Epic Link: 
 PUP-11658  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.444551.1650549319000.70904.1673294520156%40Atlassian.JIRA.


Jira (FACT-3173) Facter option store does not reset after Facter is reset

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3173  
 
 
  Facter option store does not reset after Facter is reset   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Epic Link: 
 PUP-11658  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.478001.1672966539000.70902.1673294520058%40Atlassian.JIRA.


Jira (FACT-2772) Facter 4 fails to guard against recursion (FACT-1373)

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2772  
 
 
  Facter 4 fails to guard against recursion (FACT-1373)   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Epic Link: 
 PUP-11658  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370195.1598387754000.70900.1673294460046%40Atlassian.JIRA.


Jira (FACT-3151) Facter fails on the `/etc/os-release` that contains the '#`

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3151  
 
 
  Facter fails on the `/etc/os-release` that contains the '#`   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Epic Link: 
 PUP-11658  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.469451.1664227327000.70901.1673294460101%40Atlassian.JIRA.


Jira (FACT-2916) Block mechanism is slow when there are custom facts that depend on other custom facts

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  FACT-2916  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Block mechanism is slow when there are custom facts that depend on other custom facts   
 

  
 
 
 
 

 
 This may be related to FACT-3080. Keeping it open until we can investigate.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.383064.1610550761000.70899.1673294400161%40Atlassian.JIRA.


Jira (FACT-3170) Facter resolves facts multiple times when providers are confined based on facts, especially on Windows

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3170  
 
 
  Facter resolves facts multiple times when providers are confined based on facts, especially on Windows   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Summary: 
 Debug output Facter resolves facts multiple times when providers are confined based  on  facts, especially on  Windows  nodes shows the same Facter logs repeated  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.477181.1671137416000.70893.1673294160124%40Atlassian.JIRA.


Jira (FACT-3170) Facter resolves facts multiple times when providers are confined based on facts, especially on Windows

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3170  
 
 
  Facter resolves facts multiple times when providers are confined based on facts, especially on Windows   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Issue Type: 
 Improvement Bug  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.477181.1671137416000.70894.1673294160173%40Atlassian.JIRA.


Jira (FACT-3165) facter --debug reports wrong location of a resolved fact.

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3165  
 
 
  facter --debug reports wrong location of a resolved fact.   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 When a fact is defined in multiple files, running `facter --debug` reports the wrong location it was resolved from.Steps to reproduce:{{$ grep '' *}}{{one.rb:Facter.add("foo") do}}{{one.rb: setcode do}}{{one.rb:         "one"}}{{one.rb: end}}{{one.rb:end}}{{zero.rb:Facter.add("foo") do}}{{zero.rb:        setcode do}}{{zero.rb:                "zero"}}{{zero.rb:        end}}{{zero.rb:end}}{{$ facter foo --debug --custom-dir $PWD 2>&1 | grep -e zero -e one}}{{[2022-10-28 10:45:17.906705 ] DEBUG Facter::Util::Fact - custom fact foo got resolved from: ["/tmp/x/{color:#ff}*zero*{color}.rb", 1]}}{{[2022-10-28 10:45:17.907721 ] DEBUG Facter::FactManager - fact "foo" has resolved to: *{color:#ff8b00}one{color}*}}{{*{color:#ff8b00}{{one}}{color}*}}Facter 3 doesn't have this issue . Given : {noformat}# cat one.rb Facter.add("foo") do$stderr.puts "registering one.rb"setcode do  "one"endend# cat two.rb Facter.add("foo") do$stderr.puts "registering two.rb"setcode do  "two"endend# facter foo --debug --custom-dir $PWD 2>&1 | grep -e one.rb -e two.rb -e foo2023-01-09 19:25:42.635880 INFO  puppetlabs.facter - executed with command line: foo --debug --custom-dir /root.2023-01-09 19:25:42.687218 INFO  puppetlabs.facter - requested queries: foo.2023-01-09 19:25:42.687824 INFO  puppetlabs.facter - loading custom facts from /root/one.rb.registering one.rb2023-01-09 19:25:42.688119 INFO  puppetlabs.facter - loading custom facts from /root/two.rb.2023-01-09 19:25:42.688309 DEBUG puppetlabs.facter - fact "foo" has resolved to "one".registering two.rbregistering two.rb{noformat}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

   

Jira (FACT-3165) facter --debug reports wrong location of a resolved fact.

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3165  
 
 
  facter --debug reports wrong location of a resolved fact.   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Labels: 
 regresion  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.473610.1666921663000.70882.1673293860065%40Atlassian.JIRA.


Jira (FACT-3165) facter --debug reports wrong location of a resolved fact.

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3165  
 
 
  facter --debug reports wrong location of a resolved fact.   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 When a fact is defined in multiple files, running `facter --debug` reports the wrong location it was resolved from.Steps to reproduce:   {{$ grep '' *}}{{one.rb:Facter.add("foo") do}}{{one.rb: setcode do}}{{one.rb:         "one"}}{{one.rb: end}}{{one.rb:end}}{{zero.rb:Facter.add("foo") do}}{{zero.rb:        setcode do}}{{zero.rb:                "zero"}}{{zero.rb:        end}}{{zero.rb:end}}{{$ facter foo --debug --custom-dir $PWD 2>&1 | grep -e zero -e one}}{{[2022-10-28 10:45:17.906705 ] DEBUG Facter::Util::Fact - custom fact foo got resolved from: ["/tmp/x/{color:#ff}*zero*{color}.rb", 1]}}{{[2022-10-28 10:45:17.907721 ] DEBUG Facter::FactManager - fact "foo" has resolved to: *{color:#ff8b00}one{color}*}}{{*{color:#ff8b00}{{one}}{color}*}} Facter 3 doesn't have this issue:  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 

Jira (FACT-2772) Facter 4 fails to guard against recursion (FACT-1373)

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2772  
 
 
  Facter 4 fails to guard against recursion (FACT-1373)   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Summary: 
 Facter  in puppet 6.18.0-1  4  fails to  prevent external facts from calling facter recursively  guard against recursion  (FACT-1373)  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370195.1598387754000.70845.1673291400111%40Atlassian.JIRA.


Jira (FACT-2772) Facter 4 fails to guard against recursion (FACT-1373)

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2772  
 
 
  Facter 4 fails to guard against recursion (FACT-1373)   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Team: 
 Night's Watch Phoenix  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370195.1598387754000.70846.1673291400162%40Atlassian.JIRA.


Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2772  
 
 
  Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Labels: 
 regression  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370195.1598387754000.70841.1673290620181%40Atlassian.JIRA.


Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  FACT-2772  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)   
 

  
 
 
 
 

 
 Facter 3 correctly detects recursive invocations. It can be triggered by removing --no-custom-facts --no-external-facts from the external fact.  
 
 
 
 
 # facter --version  
 
 
 3.14.24 (commit 91ed8a2de5c9d686345859fe12ea2914415758f0)  
 
 
    
 
 
 # head -3 /opt/puppetlabs/facter/facts.d/fact.sh  
 
 
 #!/usr/bin/env ruby  
 
 
 require 'json'  
 
 
 osfamily = %x(/opt/puppetlabs/bin/facter os.family).strip  
 
 
    
 
 
 # puppet facts show packages  
 
 
 Warning: Facter: external fact file "/opt/puppetlabs/facter/facts.d/fact.sh" had output on stderr: 2023-01-09 18:48:52.300856 WARN  puppetlabs.facter - external fact file "/opt/puppetlabs/facter/facts.d/fact.sh" had output on stderr: 2023-01-09 18:48:51.842723 WARN  puppetlabs.facter - Facter was called recursively, skipping external facts. Add '--no-external-facts' to silence this warning
  
 
 
 
  Facter 4 does not guard against recursion:  
 
 
  

Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2772  
 
 
  Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Component/s: 
 Facter 4  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370195.1598387754000.70840.1673290620134%40Atlassian.JIRA.


Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2772  
 
 
  Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 After updating puppet to verision 6.18.0-1, the following script, located in `/opt/puppetlabs/facter/facts.d/` recurses into oblivion {noformat}  #!/usr/bin/env rubyrequire 'json'osfamily = %x(/opt/puppetlabs/bin/facter --no-custom- fact facts  --no-external-facts os.family).strip@data = "">  packages: {}}def parse_redhat  packagelist = %x(rpm -qa --qf '%{NAME};%{VERSION}-%{RELEASE}\n').split("\n")  packagelist.each do |package|pname   = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip  endenddef parse_debian  packagelist = %x(dpkg-query -W -f='${binary:Package};${Version}\n').split("\n")  packagelist.each do |package|pname   = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip  endendif osfamily == 'RedHat'  parse_redhatendif osfamily == 'Debian'  parse_debianendputs @data.to_json{noformat} I created this ticket after I talked to the slack community puppet guy Josh ([https://puppetcommunity.slack.com/archives/C0W298S9G/p1598386635326500)]{quote}"@kervyn facter 3.x (which is the default in puppet 6) has logic to prevent external facts from calling facter recursively (FACT-1373) but it seems that's not working as expected. Can you file a FACT ticket and link the 1373?"{quote}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent 

Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2772  
 
 
  Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 After updating puppet to verision 6.18.0-1, the following script, located in `/opt/puppetlabs/facter/facts.d/` recurses into oblivion { code:shell noformat }  #!/usr/bin/env rubyrequire 'json'  osfamily = %x(/opt/puppetlabs/bin/facter --no-custom-fact --no-external-facts os.family).strip@data = "">  packages: {}}def parse_redhat  packagelist = %x(rpm -qa --qf '%{NAME};%{VERSION}-%{RELEASE}\n').split("\n")  packagelist.each do |package|pname   = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip  endenddef parse_debian  packagelist = %x(dpkg-query -W -f='${binary:Package};${Version}\n').split("\n")  packagelist.each do |package|pname   = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip  end endif endif  osfamily == 'RedHat'  parse_redhatendif osfamily == 'Debian'  parse_debian endputs endputs  @data.to_json{ code noformat } I created this ticket after I talked to the slack community puppet guy Josh ([https://puppetcommunity.slack.com/archives/C0W298S9G/p1598386635326500)]{quote}"@kervyn facter 3.x (which is the default in puppet 6) has logic to prevent external facts from calling facter recursively (FACT-1373) but it seems that's not working as expected. Can you file a FACT ticket and link the 1373?"{quote}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 

Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2772  
 
 
  Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 After updating puppet to verision 6.18.0-1, the following script, located in `/opt/puppetlabs/facter/facts.d/` recurses into oblivion {code: java shell }  #!/usr/bin/env rubyrequire 'json'osfamily = %x(/opt/puppetlabs/bin/facter --no-custom-fact --no-external-facts os.family).strip@data = "">  packages: {}}  def parse_redhat  packagelist = %x(rpm -qa --qf '%{NAME};%{VERSION}-%{RELEASE}\n').split("\n")  packagelist.each do |package|pname   = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip  endenddef parse_debian  packagelist = %x(dpkg-query -W -f='${binary:Package};${Version}\n').split("\n")  packagelist.each do |package|pname   = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip  endendif osfamily == 'RedHat'  parse_redhatendif osfamily == 'Debian'  parse_debianendputs @data.to_json{code} I created this ticket after I talked to the slack community puppet guy Josh ([https://puppetcommunity.slack.com/archives/C0W298S9G/p1598386635326500)]{quote}"@kervyn facter 3.x (which is the default in puppet 6) has logic to prevent external facts from calling facter recursively (FACT-1373) but it seems that's not working as expected. Can you file a FACT ticket and link the 1373?"{quote}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent 

Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2772  
 
 
  Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 After updating puppet to verision 6.18.0-1, the following script, located in `/opt/puppetlabs/facter/facts.d/` recurses into oblivion {code:shell}  #!/usr/bin/env rubyrequire 'json'osfamily = %x(/opt/puppetlabs/bin/facter --no-custom-fact --no-external-facts os.family).strip@data = "">  packages: {}}def parse_redhat  packagelist = %x(rpm -qa --qf '%{NAME};%{VERSION}-%{RELEASE}\n').split("\n")  packagelist.each do |package|pname   = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip  endenddef parse_debian  packagelist = %x(dpkg-query -W -f='${binary:Package};${Version}\n').split("\n")  packagelist.each do |package|pname   = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip  endendif osfamily == 'RedHat'  parse_redhatendif osfamily == 'Debian'  parse_debianendputs @data.to_json{code} I created this ticket after I talked to the slack community puppet guy Josh ([https://puppetcommunity.slack.com/archives/C0W298S9G/p1598386635326500)]{quote}"@kervyn facter 3.x (which is the default in puppet 6) has logic to prevent external facts from calling facter recursively (FACT-1373) but it seems that's not working as expected. Can you file a FACT ticket and link the 1373?"{quote}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by 

Jira (FACT-3173) Facter option store does not reset after Facter is reset

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3173  
 
 
  Facter option store does not reset after Facter is reset   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Acceptance Criteria: 
 Facter's OptionStore is reset when Facter. rest reset  or Facter.clear is called  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.478001.1672966539000.70798.1673287380161%40Atlassian.JIRA.


Jira (FACT-3173) Facter option store does not reset after Facter is reset

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3173  
 
 
  Facter option store does not reset after Facter is reset   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Labels: 
 regression  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.478001.1672966539000.70797.1673287380113%40Atlassian.JIRA.


Jira (FACT-3173) Facter option store does not reset after Facter is reset

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3173  
 
 
  Facter option store does not reset after Facter is reset   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Component/s: 
 Facter 4  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.478001.1672966539000.70796.1673287380060%40Atlassian.JIRA.


Jira (FACT-2980) Facter 4 outputs the processors.speed fact differently on Linux

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2980  
 
 
  Facter 4 outputs the processors.speed fact differently on Linux   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Labels: 
 doc_reviewed known-issue-added  regression  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.391203.1615892875000.70794.1673287200196%40Atlassian.JIRA.


Jira (FACT-2772) Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2772  
 
 
  Facter in puppet 6.18.0-1 fails to prevent external facts from calling facter recursively (FACT-1373)   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 After updating puppet to verision 6.18.0-1, the following script, located in ` / opt/puppetlabs/facter/facts.d/` recurses into oblivion {code:java}#!/usr/bin/env rubyrequire 'json'osfamily = %x(/opt/puppetlabs/bin/facter --no-custom-fact --no-external-facts os.family).strip@data = "">  packages: {}}def parse_redhat  packagelist = %x(rpm -qa --qf '%{NAME};%{VERSION}-%{RELEASE}\n').split("\n")  packagelist.each do |package|pname   = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip  endenddef parse_debian  packagelist = %x(dpkg-query -W -f='${binary:Package};${Version}\n').split("\n")  packagelist.each do |package|pname   = package.split(';').firstversion = package.split(';').last@data[:packages][pname] = version.strip  endendif osfamily == 'RedHat'  parse_redhatendif osfamily == 'Debian'  parse_debianendputs @data.to_json{code} I created this ticket after I talked to the slack community puppet guy Josh ([https://puppetcommunity.slack.com/archives/C0W298S9G/p1598386635326500)]{quote}"@kervyn facter 3.x (which is the default in puppet 6) has logic to prevent external facts from calling facter recursively (FACT-1373) but it seems that's not working as expected. Can you file a FACT ticket and link the 1373?"{quote}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by 

Jira (FACT-3111) Facter 3 and 4 handle external facts with nil values differently

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3111  
 
 
  Facter 3 and 4 handle external facts with nil values differently   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Labels: 
 regression  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.442430.1648682189000.70791.1673286900101%40Atlassian.JIRA.


Jira (FACT-3114) operatingsystemrelease/operatingsystemmajrelease missing on Arch Linux

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3114  
 
 
  operatingsystemrelease/operatingsystemmajrelease missing on Arch Linux   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Labels: 
 regression  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.444551.1650549319000.70790.1673286900046%40Atlassian.JIRA.


Jira (FACT-3151) Facter fails on the `/etc/os-release` that contains the '#`

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3151  
 
 
  Facter fails on the `/etc/os-release` that contains the '#`   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 

  
 
 
 
 

 
 {color:#0e101a}Facter fails on the `/etc/os-release` that contains the comment `#`.{color}     {color:#0e101a}According to the {color}[{color:#4a6ee0}https://www.man7.org/linux/man-pages/man5/os-release.5.html{color}]{color:#0e101a}, the comments are allowed in the /etc/os-release files. In EuroLinux 9 that fail contain a comment:{color} ``` {code:java}# We keep it for build scripts only  {code} ```     {color:#0e101a}I will fix that in the Distro, but IMO the parser should respect the rules{color}.    Best,  Alex     *Update*Facter 4 raises an exception if /etc/os-release contains a comment: {code:java}   # facter --version4.2.14# head -2 / etc/os-release # This is a commentNAME="Red Hat Enterprise Linux"# facter osTraceback (most recent call last): 26: from / opt/puppetlabs/puppet/ bin/facter:5:in `' 25: from /opt/puppetlabs/puppet/ lib/ruby/ 2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require' 24: from /opt/puppetlabs/puppet/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require' 23: from /opt/puppetlabs/puppet/lib/ruby/ vendor_ruby/facter/ framework/cli/cli_launcher.rb:6:in `' 22: from /opt/puppetlabs/puppet/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require' 21: from /opt/puppetlabs/puppet/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require' 20: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter.rb:7:in `' 19: from /opt/puppetlabs/puppet/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require' 18: from /opt/puppetlabs/puppet/lib/ruby/2.7.0/rubygems/core_ext/kernel_require.rb:83:in `require' 17: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/core/file_loader.rb:54:in `' 16: from /opt/puppetlabs/puppet/lib/ruby/2.7.0/singleton.rb:123:in `instance' 15: from /opt/puppetlabs/puppet/lib/ruby/2.7.0/singleton.rb:123:in `synchronize' 14: from /opt/puppetlabs/puppet/lib/ruby/2.7.0/singleton.rb:125:in `block in instance' 13: from /opt/puppetlabs/puppet/lib/ruby/2.7.0/singleton.rb:125:in `new' 12: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/detector/os_detector.rb:13:in `initialize' 11: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/detector/os_detector.rb:26:in `detect' 10: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/detector/os_detector.rb:77:in `detect_distro'  9: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/detector/os_detector.rb:77:in `each'  8: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/framework/detector/os_detector.rb:78:in `block in detect_distro'  7: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/ resolvers/ base_resolver.rb:24:in `resolve'  6: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/resolvers/base_resolver.rb:24:in `synchronize'  5: from /opt/puppetlabs/puppet/lib/ruby/vendor_ruby/facter/resolvers/base_resolver.rb:26:in `block in resolve'  

Jira (FACT-3151) Facter fails on the `/etc/os-release` that contains the '#`

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3151  
 
 
  Facter fails on the `/etc/os-release` that contains the '#`   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Labels: 
 regression  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.469451.1664227327000.70789.1673286840147%40Atlassian.JIRA.


Jira (FACT-3136) Bug in gce.project.attributes.sshKeys

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3136  
 
 
  Bug in gce.project.attributes.sshKeys   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Labels: 
 regression  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.454867.1657650158000.70785.1673286060051%40Atlassian.JIRA.


Jira (FACT-3089) Processor ISA fact on Linux reports wrong data if the string contains a period

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3089  
 
 
  Processor ISA fact on Linux reports wrong data if the string contains a period   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Labels: 
 regression  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.421525.1635492732000.70786.1673286060126%40Atlassian.JIRA.


Jira (FACT-3162) Facter 4 reports os.name as "SLES_SAP" on Suse Linux for SAP instead of just "SUSE"

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3162  
 
 
  Facter 4 reports os.name as "SLES_SAP" on Suse Linux for SAP instead of just "SUSE"   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Labels: 
 jira_escalated  regression  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.472894.1666383285000.70780.1673285833376%40Atlassian.JIRA.


Jira (FACT-3170) Debug output on Windows nodes shows the same Facter logs repeated

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3170  
 
 
  Debug output on Windows nodes shows the same Facter logs repeated   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Labels: 
 jira_escalated  regression  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.477181.1671137416000.70506.1673285760232%40Atlassian.JIRA.


Jira (FACT-3172) Facter incorrectly filter IPv6 unique-local unicast addresses

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3172  
 
 
  Facter incorrectly filter IPv6 unique-local unicast addresses   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Release Notes: 
 Bug Fix  
 
 
Release Notes Summary: 
 Facter now correctly excludes IPv6 unique-local unicast addresses (fc00::/7) correctly. Fix contributed by https://github.com/smortex  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.477768.1672455676000.70499.1673284620224%40Atlassian.JIRA.


Jira (FACT-3171) Facter incorrectly filter IPv6 link-local unicast addresses

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3171  
 
 
  Facter incorrectly filter IPv6 link-local unicast addresses   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Release Notes: 
 Bug Fix  
 
 
Release Notes Summary: 
 Facter now excludes IPv6 link-local unicast addresses (fe80::/10) correctly. Fix contributed by https://github.com/smortex  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.477767.1672454812000.70495.1673284500512%40Atlassian.JIRA.


Jira (FACT-3153) Test against Ruby 3.2 on Windows

2023-01-09 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3153  
 
 
  Test against Ruby 3.2 on Windows   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Release Notes: 
 Not Needed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.470006.1664472016000.70486.1673284320328%40Atlassian.JIRA.


Jira (HI-638) Allow Puppet function calls from hiera data

2023-01-09 Thread Martin Alfke (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Martin Alfke created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Hiera /  HI-638  
 
 
  Allow Puppet function calls from hiera data   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2023/01/09 7:58 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Martin Alfke  
 

  
 
 
 
 

 
 In combination with stdlib::manage I want to be able to use Puppet functions from hiera data.   e.g.    
 
 
 
 
 stlib::manage::create_reosurces:  
 
 
   file:  
 
 
     '/etc/motd':  
 
 
     ensure: file  
 
 
     content: %{epp('profile/motd.epp')}
  
 
 
 
    Actual result:  
 
 
 
 
   

Jira (PUP-11697) rpm package installation: confusing error message when there is no such package

2023-01-09 Thread Konrad Bucheli (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Konrad Bucheli created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-11697  
 
 
  rpm package installation: confusing error message when there is no such package   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2023/01/09 2:08 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Konrad Bucheli  
 

  
 
 
 
 

 
 Puppet Agent Version: 7.21.0 Puppet Server Version: 7.9.2 OS Name/Version: RHEL 8.7 Desired Behavior: Error message states that there is no such package. Actual Behavior:  
 
 
 
 
 package {'nc':}
  
 
 
 
  results when applying in  
 
 
 
 
 Error: /Stage[main]/Role::Workstation/Package[nc]: Could not evaluate: no implicit conversion of Array into Hash
  
 
 
 
  which looks like an error in the code, but  
 
 
 
 
 # dnf info nc