Jira (PUP-10607) Add intentional_change, noop_pending_(intentional/corrective) readers to the report processor API
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10607
Add intentional_change, noop_pending_(intentional/corrective) readers to the report processor API
Change By:
Enis Inan
These are already documented event types in https://puppet.com/docs/pe/2019.8/analyze_changes_across_runs.html#event_types so they're available at the event level. The work here involves making these parameters available as a global summary (so at the report processor level). Note that {{intentional_change}} is the [corrective_change|https://github.com/puppetlabs/puppet/blob/6.17.0/lib/puppet/transaction/report.rb#L126]-reader analogue for intentional changes.{{noop_pending_(intentional/corrective)}} are more fine-grained readers of the [noop_pending|https://github.com/puppetlabs/puppet/blob/6.17.0/lib/puppet/transaction/report.rb#L81] reader. For example, {{noop_pending_intentional}} is true if there are any intentional changes that weren't applied because of noop.
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Jira (PUP-10607) Add intentional_change, noop_pending_(intentional/corrective) readers to the report processor API
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10607
Add intentional_change, noop_pending_(intentional/corrective) readers to the report processor API
Change By:
Enis Inan
These are already documented event types in https://puppet.com/docs/pe/2019.8/analyze_changes_across_runs.html#event_types so they're available at the event level. The work here involves making these parameters available as a global summary (so at the report processor level).Note that {{intentional_change}} is the [corrective_change|https://github.com/puppetlabs/puppet/blob/6.17.0/lib/puppet/transaction/report.rb#L126]-reader analogue for intentional changes.{{noop_pending_(intentional/corrective)}} are more fine-grained readers of the [noop_pending|https://github.com/puppetlabs/puppet/blob/6.17.0/lib/puppet/transaction/report.rb#L81] parameter reader . For example, {{noop_pending_intentional}} is true if there are any intentional changes that weren't applied because of noop.
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Jira (PUP-10607) Add intentional_change, noop_pending_(intentional/corrective) readers to the report processor API
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10607
Add intentional_change, noop_pending_(intentional/corrective) readers to the report processor API
Change By:
Enis Inan
These are already documented event types in https://puppet.com/docs/pe/2019.8/analyze_changes_across_runs.html#event_types so they're available at the event level. The work here involves making these parameters available as a global summary (so at the report processor level). Note that {{intentional_change}} is the [corrective_change|https://github.com/puppetlabs/puppet/blob/6.17.0/lib/puppet/transaction/report.rb#L126]-reader analogue for intentional changes.{{noop_pending_(intentional/corrective)}} are more fine-grained readers of the [noop_pending|https://github.com/puppetlabs/puppet/blob/6.17.0/lib/puppet/transaction/report.rb#L81] parameter. For example, {{noop_pending_intentional}} is true if there are any intentional changes that weren't applied because of noop.
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Jira (PUP-10607) Add intentional_change, noop_pending_(intentional/corrective) readers to the report processor API
Title: Message Title Enis Inan created an issue Puppet / PUP-10607 Add intentional_change, noop_pending_(intentional/corrective) readers to the report processor API Issue Type: New Feature Assignee: Unassigned Created: 2020/08/05 11:32 AM Priority: Normal Reporter: Enis Inan These are already documented event types in https://puppet.com/docs/pe/2019.8/analyze_changes_across_runs.html#event_types so they're available at the event level. The work here involves making these parameters available as a global summary (so at the report processor level). Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Jira (PUP-10478) Add getvar Hiera backend
Title: Message Title Enis Inan commented on PUP-10478 Re: Add getvar Hiera backend Maggie Dreyer We implemented getvar in the CMDB module – https://github.com/puppetlabs/puppetlabs-servicenow_cmdb_integration/blob/master/lib/puppet/functions/servicenow_cmdb_integration/getvar.rb – so it's not urgent. But it would probably be nice-to-have to facilitate Hiera lookups on the trusted['external'] variable. /cc Reid Vandewiele Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.357322.1588196554000.3773.1595981640219%40Atlassian.JIRA.
Jira (PUP-5216) Add Password Expiration for Windows User management
Title: Message Title Enis Inan assigned an issue to Unassigned Puppet / PUP-5216 Add Password Expiration for Windows User management Change By: Enis Inan Assignee: Enis Inan Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.97351.1441830485000.104503.1594333440083%40Atlassian.JIRA.
Jira (PUP-10528) Extend the trusted_external_command setting to support specifying directories
Title: Message Title Enis Inan commented on PUP-10528 Re: Extend the trusted_external_command setting to support specifying directories Josh Cooper Done. Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359569.159008843.81917.1591684560131%40Atlassian.JIRA.
Jira (PUP-10528) Extend the trusted_external_command setting to support specifying directories
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10528
Extend the trusted_external_command setting to support specifying directories
Change By:
Enis Inan
Release Notes Summary:
The ` trusted_external_command ` setting can now be set to a directory. If it's set to a directory, then for each executable file in the directory, the external trusted facts will be stored in the {{ }} key of the {{ trusted['external'] }} hash. For example, if the files foo.rb and bar.sh are in the directory, then {{ trusted['external'] }} will be the hash { {{ 'foo' => , 'bar' => } }} .
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359569.159008843.81916.1591684560087%40Atlassian.JIRA.
Jira (PUP-10528) Extend the trusted_external_command setting to support specifying directories
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10528
Extend the trusted_external_command setting to support specifying directories
Change By:
Enis Inan
Release Notes:
New Feature
Release Notes Summary:
The {{trusted_external_command}} setting can now be set to a directory. If it's set to a directory, then for each executable file in the directory, the external trusted facts will be stored in the {{}} key of the {{trusted['external']}} hash. For example, if the files foo.rb and bar.sh are in the directory, then {{trusted['external']}} will be the hash {{{ 'foo' => , 'bar' => }}}.
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit
Jira (PUP-10528) Extend the trusted_external_command setting to support specifying directories
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10528
Extend the trusted_external_command setting to support specifying directories
Change By:
Enis Inan
Release Notes Summary:
The {{ ` trusted_external_command }} ` setting can now be set to a directory. If it's set to a directory, then for each executable file in the directory, the external trusted facts will be stored in the {{}} key of the {{trusted['external']}} hash. For example, if the files foo.rb and bar.sh are in the directory, then {{trusted['external']}} will be the hash {{{ 'foo' => , 'bar' => }}}.
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359569.159008843.81914.1591684500115%40Atlassian.JIRA.
Jira (PUP-10525) puppet apply should set trusted['external']
Title: Message Title Enis Inan commented on PUP-10525 Re: puppet apply should set trusted['external'] Reid Vandewiele Is there a practical reason why we can't move it over to main? Something like "if we move it to main, then it won't work in this scenario"? Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359456.1590012226000.68085.1590105060023%40Atlassian.JIRA.
Jira (PUP-10528) Extend the trusted_external_command setting to support specifying directories
Title: Message Title Enis Inan assigned an issue to Enis Inan Puppet / PUP-10528 Extend the trusted_external_command setting to support specifying directories Change By: Enis Inan Assignee: Enis Inan Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359569.159008843.67938.1590097020095%40Atlassian.JIRA.
Jira (PUP-10528) Extend the trusted_external_command setting to support specifying directories
Title: Message Title Enis Inan created an issue Puppet / PUP-10528 Extend the trusted_external_command setting to support specifying directories Issue Type: Task Assignee: Unassigned Created: 2020/05/21 12:13 PM Priority: Normal Reporter: Enis Inan If trusted_external_command points to a directory, then for each file in the directory, If the file's executable, we can assume it's a trusted external command. That means we'll execute it, fetch its data, and store it in trusted['external'][]. Add Comment This message was sent
Jira (PUP-10525) puppet apply should set trusted['external']
Title: Message Title Enis Inan commented on PUP-10525 Re: puppet apply should set trusted['external'] Yes, as part of https://github.com/puppetlabs/puppetlabs-servicenow_integration where we have a servicenow.rb script that returns the external data. Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359456.1590012226000.67440.1590055980026%40Atlassian.JIRA.
Jira (PUP-10525) puppet apply should set trusted['external']
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10525
puppet apply should set trusted['external']
Change By:
Enis Inan
This way, if I set {{trusted_external_command}} in {{puppet.conf}}, then I can easily test that {{trusted['external']}} is set properly fetched via something like{code}puppet apply -e 'notify { "$trusted['external']": }'{code}It also maintains consistency with facts and other trusted facts, since those are also set in {{puppet apply}}.
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359456.1590012226000.67124.1590012420079%40Atlassian.JIRA.
Jira (PUP-10525) puppet apply should set trusted['external']
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10525
puppet apply should set trusted['external']
Change By:
Enis Inan
This way, if I set {{trusted_external_command}} in {{puppet.conf}}, then I can easily test that {{trusted['external']}} is set via something like {code}puppet apply -e notify \ { "$trusted['external']": \ }{code}.It also maintains consistency with facts and other trusted facts, since those are set in {{puppet apply}}.
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359456.1590012226000.67120.1590012360060%40Atlassian.JIRA.
Jira (PUP-10525) puppet apply should set trusted['external']
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10525
puppet apply should set trusted['external']
Change By:
Enis Inan
This way, if I set {{trusted_external_command}} in {{puppet.conf}}, then I can easily test that {{trusted['external']}} is set via something like{code}puppet apply -e 'notify { "$trusted['external']": }'{code}It also maintains consistency with facts and other trusted facts, since those are also set in {{puppet apply}}.
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359456.1590012226000.67122.1590012360147%40Atlassian.JIRA.
Jira (PUP-10525) puppet apply should set trusted['external']
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10525
puppet apply should set trusted['external']
Change By:
Enis Inan
This way, if I set {{trusted_external_command}} in {{puppet.conf}}, then I can easily test that {{trusted['external']}} is set via something like {code} puppet apply -e ' notify { "$trusted['external']": } ' {code} . It also maintains consistency with facts and other trusted facts, since those are set in {{puppet apply}}.
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359456.1590012226000.67121.1590012360103%40Atlassian.JIRA.
Jira (PUP-10525) puppet apply should set trusted['external']
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10525
puppet apply should set trusted['external']
Change By:
Enis Inan
This way, if I set {{trusted_external_command}} in {{puppet.conf}}, then I can easily test that {{trusted['external']}} is set via something like {{puppet apply -e notify \{ "$trusted['external']": \} }}.It also maintains consistency with facts and other trusted facts, since those are set in {{puppet apply}}.
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359456.1590012226000.67117.1590012300395%40Atlassian.JIRA.
Jira (PUP-10525) puppet apply should set trusted['external']
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10525
puppet apply should set trusted['external']
Change By:
Enis Inan
This way, if I set { { trusted_external_command} } in { { puppet.conf} } , then I can easily test that { { trusted['external']} } is set via something like { { puppet apply -e notify { "$trusted['external']": }} } .It also maintains consistency with facts and other trusted facts, since those are set in { { puppet apply} } .
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359456.1590012226000.67114.1590012300264%40Atlassian.JIRA.
Jira (PUP-10525) puppet apply should set trusted['external']
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10525
puppet apply should set trusted['external']
Change By:
Enis Inan
This way, if I set {{trusted_external_command}} in {{puppet.conf}}, then I can easily test that {{trusted['external']}} is set via something like {{puppet apply -e notify \ { "$trusted['external']": \ } }}.It also maintains consistency with facts and other trusted facts, since those are set in {{puppet apply}}.
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359456.1590012226000.67115.1590012300307%40Atlassian.JIRA.
Jira (PUP-10525) puppet apply should set trusted['external']
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10525
puppet apply should set trusted['external']
Change By:
Enis Inan
This way, if I set {{trusted_external_command}} in {{puppet.conf}}, then I can easily test that {{trusted['external']}} is set via something like { { code} puppet apply -e notify \{ "$trusted['external']": \} {code } } .It also maintains consistency with facts and other trusted facts, since those are set in {{puppet apply}}.
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359456.1590012226000.67118.1590012300439%40Atlassian.JIRA.
Jira (PUP-10525) puppet apply should set trusted['external']
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10525
puppet apply should set trusted['external']
Change By:
Enis Inan
This way, if I set {{trusted_external_command}} in {{puppet.conf}}, then I can easily test that {{trusted['external']}} is set via something like {{puppet apply -e notify \{ "$trusted['external']": \}}}.It also maintains consistency with facts and other trusted facts, since those are set in {{puppet apply}}.
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359456.1590012226000.67116.1590012300351%40Atlassian.JIRA.
Jira (PUP-10525) puppet apply should set trusted['external']
Title: Message Title
Enis Inan created an issue
Puppet / PUP-10525
puppet apply should set trusted['external']
Issue Type:
Task
Assignee:
Unassigned
Created:
2020/05/20 3:03 PM
Priority:
Normal
Reporter:
Enis Inan
This way, if I set {trusted_external_command} in {puppet.conf} , then I can easily test that {trusted['external']} is set via something like {puppet apply -e notify { "$trusted['external']": }}. It also maintains consistency with facts and other trusted facts, since those are set in {puppet apply} .
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Jira (PUP-10478) Add getvar Hiera backend
Title: Message Title Enis Inan updated an issue Puppet / PUP-10478 Add getvar Hiera backend Change By: Enis Inan Epic Link: PIE-241 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.357322.1588196554000.51244.158819790%40Atlassian.JIRA.
Jira (PUP-10478) Add getvar Hiera backend
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10478
Add getvar Hiera backend
Change By:
Enis Inan
Configuring this would look something like{code}- name: "ServiceNow hiera data" lookup_key: getvar path: trusted.external.servicenow.hiera_data{code}where {{path}} resolves to a {{Hash}} value whose key you're looking up. The allowable paths are {{ trusted.* path }} and must start with {{ facts.*}} (so the {{ trusted}} or {{facts}} hashes or anything in since those hashes) are the top-level variables that we've deemed safe to use . All other paths will raise an error. This is People who want to prevent people from using ( use other, unsafe ) top- scope level variables to get Hiera data (bad practice). However, we will still support unsafe access can do so via an {{unsafe}} option. Configuring that would look something like{code}- name: "unsafe hiera data" lookup_key: getvar path: foo.bar unsafe: true{code}
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
Jira (PUP-10478) Add getvar Hiera backend
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10478
Add getvar Hiera backend
Change By:
Enis Inan
Configuring this would look something like{code}- name: "ServiceNow hiera data" lookup_key: getvar path: trusted.external.servicenow.hiera_data{code}where {{path}} resolves to a {{Hash}} value whose key you're looking up. The allowable paths are {{trusted.*}} and {{facts.*}} (so anything in the {{trusted}} or {{facts}} hash hashes or anything in those hashes ). All other paths will raise an error. This is to prevent people from using (unsafe) top-scope variables to get Hiera data (bad practice). However, we will still support unsafe access via an {{unsafe}} option. Configuring that would look something like{code}- name: "unsafe hiera data" lookup_key: getvar path: foo.bar unsafe: true{code}
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this
Jira (PUP-10478) Add getvar Hiera backend
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10478
Add getvar Hiera backend
Change By:
Enis Inan
Configuring this would look something like{code}- name: "ServiceNow hiera data" lookup_key: getvar path: trusted.external.servicenow.hiera_data{code}where {{path}} resolves to a {{Hash}} value whose key you're looking up. The allowable {{path}}s are {{trusted.*}} and {{facts.*}} (so anything in the {{trusted}} or {{facts}} hash). All other paths will raise an error. This is to prevent people from using (unsafe) top-scope variables to get Hiera data (bad practice). However, we will still support unsafe access via an {{unsafe}} option. Configuring that would look something like{code} - name: "unsafe hiera data" lookup_key: getvar path: foo.bar unsafe: true{code}
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails
Jira (PUP-10478) Add getvar Hiera backend
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10478
Add getvar Hiera backend
Change By:
Enis Inan
Configuring this would look something like{code}- name: "ServiceNow hiera data" lookup_key: getvar path: trusted.external.servicenow.hiera_data{code}where {{path}} resolves to a {{Hash}} value whose key you're looking up. The allowable {{path}}s paths are {{trusted.*}} and {{facts.*}} (so anything in the {{trusted}} or {{facts}} hash). All other paths will raise an error. This is to prevent people from using (unsafe) top-scope variables to get Hiera data (bad practice). However, we will still support unsafe access via an {{unsafe}} option. Configuring that would look something like{code}- name: "unsafe hiera data" lookup_key: getvar path: foo.bar unsafe: true{code}
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving
Jira (PUP-10478) Add getvar Hiera backend
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10478
Add getvar Hiera backend
Change By:
Enis Inan
Configuring this would look something like{code}- name: "ServiceNow hiera data" lookup_key: getvar path: trusted.external.servicenow.hiera_data{code}where {{path}} resolves to a {{Hash}} value whose key you're looking up. The allowable {{path}}s are {{trusted.*}} and {{facts.*}} (so anything in the {{trusted}} or {{facts}} hash). All other paths will raise an error. This is to prevent people from using (unsafe) top-scope variables to get Hiera data (bad practice). However, we will still support unsafe access via an {{unsafe}} option. Configuring that would look something like{code} - name: "unsafe hiera data"lookup_key: getvarpath: foo.barunsafe: true{code}
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving
Jira (PUP-10478) Add getvar Hiera backend
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10478
Add getvar Hiera backend
Change By:
Enis Inan
Configuring this would look something like{code} - name: "ServiceNow hiera data" lookup_key: getvar path: trusted.external.servicenow.hiera_data{code}where {{path}} resolves to a {{Hash}} value whose key you're looking up. The allowable {{path}}s are {{trusted.*}} and {{facts.*}} (so anything in the {{trusted}} or {{facts}} hash). All other paths will raise an error. This is to prevent people from using (unsafe) top-scope variables to get Hiera data (bad practice). However, we will still support unsafe access via an {{unsafe}} option. Configuring that would look something like ``` {code} - name: "unsafe hiera data"lookup_key: getvarpath: foo.barunsafe: true ``` {code}
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and
Jira (PUP-10478) Add getvar Hiera backend
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-10478
Add getvar Hiera backend
Change By:
Enis Inan
Configuring this would look something like{code}- name: "ServiceNow hiera data" lookup_key: getvar path: trusted.external.servicenow.hiera_data{code}where {{path}} resolves to a {{Hash}} value whose key you're looking up. The allowable {{path}}s are {{trusted.*}} and {{facts.*}} (so anything in the {{trusted}} or {{facts}} hash). All other paths will raise an error. This is to prevent people from using (unsafe) top-scope variables to get Hiera data (bad practice). However, we will still support unsafe access via an {{unsafe}} option. Configuring that would look something like{code} - name: "unsafe hiera data"lookup_key: getvarpath: foo.barunsafe: true{code}
Add Comment
This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving
Jira (PUP-10478) Add getvar lookup-key Hiera backend
Title: Message Title
Enis Inan created an issue
Puppet / PUP-10478
Add getvar lookup-key Hiera backend
Issue Type:
Task
Assignee:
Unassigned
Created:
2020/04/29 2:42 PM
Fix Versions:
PUP 6.15.0
Priority:
Normal
Reporter:
Enis Inan
Configuring this would look something like
- name: "ServiceNow hiera data"
lookup_key: getvar
path: trusted.external.servicenow.hiera_data
where path resolves to a Hash value whose key you're looking up. The allowable path}}s are {{trusted. and facts. (so anything in the trusted or facts hash). All other paths will raise an error. This is to prevent people from using (unsafe) top-scope variables to get Hiera data (bad practice). However, we will still support unsafe access via an unsafe option. Configuring that would look something like ```
name: "unsafe hiera data" lookup_key: getvar path: foo.bar unsafe: true ```
Jira (PUP-10478) Add getvar Hiera backend
Title: Message Title Enis Inan updated an issue Puppet / PUP-10478 Add getvar Hiera backend Change By: Enis Inan Summary: Add getvar lookup-key Hiera backend Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.357322.1588196554000.51215.1588196581000%40Atlassian.JIRA.
Jira (FACT-1477) SELinux fact not being correctly detected
Title: Message Title Enis Inan assigned an issue to Unassigned Facter / FACT-1477 SELinux fact not being correctly detected Change By: Enis Inan Assignee: Enis Inan Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5216) Add Password Expiration for Windows User management
Title: Message Title Enis Inan commented on PUP-5216 Re: Add Password Expiration for Windows User management Geoff Nichols I'll move it over to Blocked since I won't be looking at this for some time. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2175) Consider Adding Provider To The Default Output of `puppet resource package`
Title: Message Title Enis Inan commented on PUP-2175 Re: Consider Adding Provider To The Default Output of `puppet resource package` Geoff Nichols I marked this as Resolved. Nick Walker This went out with the 6.1.0 Puppet release. I'm surprised it wasn't marked with that fix version then. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2175) Consider Adding Provider To The Default Output of `puppet resource package`
Title: Message Title Enis Inan updated an issue Puppet / PUP-2175 Consider Adding Provider To The Default Output of `puppet resource package` Change By: Enis Inan Fix Version/s: PUP 6.2.0 Fix Version/s: PUP 6.1.0 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2175) Consider Adding Provider To The Default Output of `puppet resource package`
Title: Message Title Enis Inan updated an issue Puppet / PUP-2175 Consider Adding Provider To The Default Output of `puppet resource package` Change By: Enis Inan Fix Version/s: PUP 6.2.0 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2175) Consider Adding Provider To The Default Output of `puppet resource package`
Title: Message Title Enis Inan updated an issue Puppet / PUP-2175 Consider Adding Provider To The Default Output of `puppet resource package` Change By: Enis Inan Release Notes Summary: `puppet resource ` now includes the package provider as part of its output. Release Notes: New Feature Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Enis Inan updated an issue Puppet / PUP-9336 Ensure provider suitability is always lazily evaluated Change By: Enis Inan Release Notes Summary: The upstart daemon-check confine in the upstart provider has been fixed so that it is now evaluated when provider suitability's being checked. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9435) Windows - Group resource member parameter outputs an array of SID's instead of Names
Title: Message Title Enis Inan assigned an issue to Enis Inan Puppet / PUP-9435 Windows - Group resource member parameter outputs an array of SID's instead of Names Change By: Enis Inan Assignee: Enis Inan Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9435) Windows - Group resource member parameter outputs an array of SID's instead of Names
Title: Message Title Enis Inan updated an issue Puppet / PUP-9435 Windows - Group resource member parameter outputs an array of SID's instead of Names Change By: Enis Inan Team: Platform OS Sprint: Platform OS Kanban Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9371) Fix the confine caching to work at the provider level instead of the resource-instance level
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-9371
Fix the confine caching to work at the provider level instead of the resource-instance level
Change By:
Enis Inan
[Puppet::Confine.valid?|https://github.com/puppetlabs/puppet/blob/6.1.0/lib/puppet/confine.rb#L66-L78] ensures that any potentially cached values are reset after each call. We see this pattern in [Puppet::Confine::Variable|https://github.com/puppetlabs/puppet/blob/6.1.0/lib/puppet/confine/variable.rb#L38-L48]. Unfortunately, { { valid?} } is called for each resource instance per https://github.com/puppetlabs/puppet/blob/16220673acaa03f708f6b6410a659b4ba737ab7a/lib/puppet/graph/relationship_graph.rb#L115-L116 and https://github.com/puppetlabs/puppet/blob/16220673acaa03f708f6b6410a659b4ba737ab7a/lib/puppet/confiner.rb#L43-L45 so this would mean that cached values would get reset for every resource instance. Thus, they would not persist at the provider level (technically the provider-class level), which is undesirable and defeats the purpose of caching.We should re-architect how caching works for confinements so that it persists for the entire transaction instead of on every {{valid?}} call (i.e. instead of on a per-resource case).
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9371) Fix the confine caching to work at the provider level instead of the resource-instance level
Title: Message Title
Enis Inan created an issue
Puppet / PUP-9371
Fix the confine caching to work at the provider level instead of the resource-instance level
Issue Type:
Improvement
Assignee:
Unassigned
Created:
2018/12/20 2:48 PM
Priority:
Normal
Reporter:
Enis Inan
Puppet::Confine.valid? ensures that any potentially cached values are reset after each call. We see this pattern in Puppet::Confine::Variable. Unfortunately, {valid?} is called for each resource instance per https://github.com/puppetlabs/puppet/blob/16220673acaa03f708f6b6410a659b4ba737ab7a/lib/puppet/graph/relationship_graph.rb#L115-L116 and https://github.com/puppetlabs/puppet/blob/16220673acaa03f708f6b6410a659b4ba737ab7a/lib/puppet/confiner.rb#L43-L45 so this would mean that cached values would get reset for every resource instance. Thus, they would not persist at the provider level (technically the provider-class level), which is undesirable and defeats the purpose of caching. We should re-architect how caching works for confinements so that it persists for the entire transaction instead of on every valid? call (i.e. instead of on a per-resource case).
Add Comment
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Enis Inan updated an issue Puppet / PUP-9336 Ensure provider suitability is always lazily evaluated Change By: Enis Inan Sprint: Platform OS Kanban Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Enis Inan assigned an issue to Enis Inan Puppet / PUP-9336 Ensure provider suitability is always lazily evaluated Change By: Enis Inan Assignee: Enis Inan Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-9336
Ensure provider suitability is always lazily evaluated
Change By:
Enis Inan
[Puppet::Provider::Service::Upstart|https://github.com/puppetlabs/puppet/blob/c6ee7ddcb80f2ec4be03edcafade20d1853a4aee/lib/puppet/provider/service/upstart.rb#L30-L35] had a confine added that is run when the provider is loaded.{code:ruby} confine :true => begininitctl('version', '--quiet')true rescuefalse end{code}This causes issues with running tests under things like JRuby, and also means that it is not possible for the provider to become suitable during the course of a transaction. Instead of using a begin/rescue/end block which will be evaluated during the provider definition, this should be something that will be evaluated only when checking if the provider is suitable. This probably means creating a new type of [Puppet::Confine|https://github.com/puppetlabs/puppet/tree/c6ee7ddcb80f2ec4be03edcafade20d1853a4aee/lib/puppet/confine] that is capable of taking a block to be lazily evaluated as the only existing one that does any sort of "call this code later" goes through the feature machinery. We could also modify the existing {{true}} and {{false}} confines to ( optionally ) accept a block.
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-9336
Ensure provider suitability is always lazily evaluated
Change By:
Enis Inan
[Puppet::Provider::Service::Upstart|https://github.com/puppetlabs/puppet/blob/c6ee7ddcb80f2ec4be03edcafade20d1853a4aee/lib/puppet/provider/service/upstart.rb#L30-L35] had a confine added that is run when the provider is loaded.{code:ruby} confine :true => begininitctl('version', '--quiet')true rescuefalse end{code}This causes issues with running tests under things like JRuby, and also means that it is not possible for the provider to become suitable during the course of a transaction. Instead of using a begin/rescue/end block which will be evaluated during the provider definition, this should be something that will be evaluated only when checking if the provider is suitable. This probably means creating a new type of [Puppet::Confine|https://github.com/puppetlabs/puppet/tree/c6ee7ddcb80f2ec4be03edcafade20d1853a4aee/lib/puppet/confine] that is capable of taking a block to be lazily evaluated as the only existing one that does any sort of "call this code later" goes through the feature machinery. We could also modify the existing {{true}} and {{false}} confines to (optionally) accept a block.
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Enis Inan commented on PUP-9336 Re: Ensure provider suitability is always lazily evaluated Jacob Helwig Yeah that makes sense. Cool, I'll add that into the description. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title
Enis Inan commented on PUP-9336
Re: Ensure provider suitability is always lazily evaluated
Couldn't we modify the boolean confines {true} and {false} to optionally take in a block and case the value on that? This would look something like:
confine :true,
OR
confine :true,
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To
Jira (PUP-9337) Puppet sets permissions for Puppet files every run
Title: Message Title Enis Inan commented on PUP-9337 Re: Puppet sets permissions for Puppet files every run I've detected this as well while trying to repro https://tickets.puppetlabs.com/browse/PA-1165. Good to see there's a ticket for it. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9331) Puppet Runs fail if leftovers in /var/spool/cron are present
Title: Message Title Enis Inan commented on PUP-9331 Re: Puppet Runs fail if leftovers in /var/spool/cron are present Sebastian Thanks for double checking! Hopefully once PUP-9217 lands, we should be able to handle these errors in a better way. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9331) Puppet Runs fail if leftovers in /var/spool/cron are present
Title: Message Title Enis Inan commented on PUP-9331 Re: Puppet Runs fail if leftovers in /var/spool/cron are present This is due to https://github.com/puppetlabs/puppet/commit/420049f20622fa7988f80555ca9c7d3c816024f5 and is what the `suntab` and `aixtab` filetypes have been doing (see e.g. https://github.com/puppetlabs/puppet/blob/6.0.4/lib/puppet/util/filetype.rb#L242-L253). The change does not fail the Puppet run (e.g. return a failure exit code) – it only reports an error message. Thus, the previous functionality is still there. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title Enis Inan commented on PUP-9300 Re: Text Fragmentation in Exception Message Erwin Hom I favor #3 as well for the same reasons; two colons is annoying but not that bad. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title Enis Inan commented on PUP-9300 Re: Text Fragmentation in Exception Message Erwin Hom Yes, "Reason for Failure:" does sound better. And no problem, glad I could help. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title
Enis Inan commented on PUP-9300
Re: Text Fragmentation in Exception Message
Erwin Hom It's phrased that way due to https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/error.rb#L14 so the exception will really read as
Failed to send the %{control_signal} signal to the service. Its current state is %{current_state}. Failed with:
Maybe we could phrase it as
Failed to send the %{control_signal} signal to the service. Its current state is %{current_state}. Failure reason:
?
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9240) Solaris SMF service has to support non global zone
Title: Message Title Enis Inan assigned an issue to Enis Inan Puppet / PUP-9240 Solaris SMF service has to support non global zone Change By: Enis Inan Assignee: Enis Inan Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9267) The members property's 'retrieve' and 'should' methods should return arrays
Title: Message Title Enis Inan commented on PUP-9267 Re: The members property's 'retrieve' and 'should' methods should return arrays Kenn Hussey Done Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9267) The members property's 'retrieve' and 'should' methods should return arrays
Title: Message Title Enis Inan updated an issue Puppet / PUP-9267 The members property's 'retrieve' and 'should' methods should return arrays Change By: Enis Inan Release Notes Summary: The members property's been fixed to have the same API for retrieve and should as it did prior to 5.5.7's breaking changes while also reporting the right change notification. Specifically, providers can now return an array for the members property getter and accept an array for the members property setter (as before). Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts
Title: Message Title Enis Inan commented on FACT-1873 Re: Custom facts that aren't suitable should not override built-in facts Kenn Hussey Done Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts
Title: Message Title Enis Inan updated an issue Facter / FACT-1873 Custom facts that aren't suitable should not override built-in facts Change By: Enis Inan Release Notes Summary: Custom facts conflicting with built-in facts properly fall-back to the built-in value if no custom facts resolve while also ensuring that built-in facts have precedence over 0-weight custom facts. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9267) The members property's 'retrieve' and 'should' methods should return arrays
Title: Message Title Enis Inan updated an issue Puppet / PUP-9267 The members property's 'retrieve' and 'should' methods should return arrays Change By: Enis Inan Fix Version/s: PUP 5.5.z Fix Version/s: PUP 5.5.8 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9267) The members property's 'retrieve' and 'should' methods should return arrays
Title: Message Title Enis Inan assigned an issue to Enis Inan Puppet / PUP-9267 The members property's 'retrieve' and 'should' methods should return arrays Change By: Enis Inan Assignee: Enis Inan Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9265) group resource: members parameter: array values broken
Title: Message Title Enis Inan commented on PUP-9265 Re: group resource: members parameter: array values broken Jason Edgecombe Thank you for your quick responses. I've filed https://tickets.puppetlabs.com/browse/PUP-9267 to fix this as that is the root cause of the issue. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9267) The members property's 'retrieve' and 'should' methods should return arrays
Title: Message Title Enis Inan updated an issue Puppet / PUP-9267 The members property's 'retrieve' and 'should' methods should return arrays Change By: Enis Inan Summary: The group type changed the data format in its members property ' s ' retrieve' and 'should' methods should return arrays Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9267) The group type changed the data format in its 'retrieve' and 'should' methods
Title: Message Title Enis Inan created an issue Puppet / PUP-9267 The group type changed the data format in its 'retrieve' and 'should' methods Issue Type: Bug Assignee: Unassigned Created: 2018/10/25 3:08 PM Priority: Normal Reporter: Enis Inan https://github.com/puppetlabs/puppet/commit/da5c2df7e22f92e0bfbadf602930fe6b4c77885f refactored the members property to match the groups property of the User resource. This changed how the members property's data is internally represented. Specifically, retrieve and should now return a comma-separated string instead of an array. The core group providers were updated with this change; however, custom providers like e.g. https://github.com/onyxpoint/puppet-gpasswd broke. The work in this ticket should modify the members property to return the previous data representation instead (i.e. retrieve and should return an array as before). Add Comment
Jira (PUP-9265) group resource: members parameter: array values broken
Title: Message Title Enis Inan commented on PUP-9265 Re: group resource: members parameter: array values broken Jason Edgecombe Interesting. I cannot reproduce the issue on Ubuntu 16.04 x86_64 using the manifest specified in the ticket description. However, there is this snippet when using the --debug flag: Notice: Compiled catalog for i9ck5m9dpexp8z8.delivery.puppetlabs.net in environment production in 0.01 seconds Debug: /Group[foo]: Provider groupadd does not support features manages_members; not managing attribute members Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send
Jira (PUP-9265) group resource: members parameter: array values broken
Title: Message Title Enis Inan commented on PUP-9265 Re: group resource: members parameter: array values broken Jason Edgecombe Klemens Nanni What's the group provider that Puppet's using when applying the manifest? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9265) group resource: members parameter: array values broken
Title: Message Title Enis Inan updated an issue Puppet / PUP-9265 group resource: members parameter: array values broken Change By: Enis Inan Sprint: Platform OS Kanban Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9264) Puppet errors when deleting a Windows user with no user profile and when managehome=true
Title: Message Title Enis Inan updated an issue Puppet / PUP-9264 Puppet errors when deleting a Windows user with no user profile and when managehome=true Change By: Enis Inan Labels: type_and_provider windows Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9264) Puppet errors when deleting a Windows user with no user profile and when managehome=true
Title: Message Title Enis Inan created an issue Puppet / PUP-9264 Puppet errors when deleting a Windows user with no user profile and when managehome=true Issue Type: Bug Assignee: Unassigned Created: 2018/10/24 2:26 PM Priority: Normal Reporter: Enis Inan When Puppet attempts to delete a user with no user profile, the Windows user provider errors the run with an unreadable error message. For example, running puppet resource user jimmy ensure=absent password=foo managehome=true when the user jimmy existed but did not have a user profile results in Error: Could not set 'absent' on ensure: (in OLE method `Delete': ) OLE error code:80070002 in SWbemServicesEx The system cannot find the file specified.
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Enis Inan commented on FACT-1889 Re: Windows operating system facts should resolve correctly for Server 2019 This will be resolved once it passes master CI. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Enis Inan updated an issue Facter / FACT-1889 Windows operating system facts should resolve correctly for Server 2019 Change By: Enis Inan Fix Version/s: FACT 3.12.1 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9150) cwd option in Puppet::Util::Execution.execute should work with different Windows path types
Title: Message Title Enis Inan commented on PUP-9150 Re: cwd option in Puppet::Util::Execution.execute should work with different Windows path types Moving this back to Ready for Engineering in case other people want to pick it up – I assigned it to myself originally due to the research Qs to Ethan. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9150) cwd option in Puppet::Util::Execution.execute should work with different Windows path types
Title: Message Title
Enis Inan commented on PUP-9150
Re: cwd option in Puppet::Util::Execution.execute should work with different Windows path types
As another note, the use of Dir.chdir here does correctly work for the different Windows path types. However, it is not thread-safe per https://bugs.ruby-lang.org/issues/9785 and https://github.com/onelogin/ruby-saml/issues/180. Thus, it would be better to pass in the cwd to Process.create. However, passing the cwd to Process.create would still execute the command even if the process does not have permissions to access the cwd – the execution just wouldn't do anything. Here's an example, which was produced on a Win 10 Pro x86_64 VM.
Create a directory with no permissions
Try to execute a command inside that working directory when Dir.chdir is used
irb(main):006:0> Puppet::Util::Execution.execute('cmd.exe /c echo %CD%', cwd: 'C:\Users\Administrator\Documents\NO_PERMS')
Errno::EACCES: Permission denied @ dir_chdir - C:\Users\Administrator\Documents\NO_PERMS
from C:/ProgramFiles64Folder/PuppetLabs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/windows/process.rb:29:in `chdir'
from C:/ProgramFiles64Folder/PuppetLabs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/windows/process.rb:29:in `execute'
from C:/ProgramFiles64Folder/PuppetLabs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/execution.rb:391:in `block in execute_windows'
from C:/ProgramFiles64Folder/PuppetLabs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util.rb:129:in `withenv'
from C:/ProgramFiles64Folder/PuppetLabs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/execution.rb:390:in `execute_windows'
Jira (PUP-9150) cwd option in Puppet::Util::Execution.execute should work with different Windows path types
Title: Message Title Enis Inan updated an issue Puppet / PUP-9150 cwd option in Puppet::Util::Execution.execute should work with different Windows path types Change By: Enis Inan Attachment: screenshot-1.png Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Enis Inan commented on FACT-1889 Re: Windows operating system facts should resolve correctly for Server 2019 Geoff Nichols Done. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1415) Replace Facter 3.x Windows Operating System kernel query with Windows Kernel API call RtlGetVersion
Title: Message Title Enis Inan commented on FACT-1415 Re: Replace Facter 3.x Windows Operating System kernel query with Windows Kernel API call RtlGetVersion Geoff Nichols Done. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Enis Inan updated an issue Facter / FACT-1889 Windows operating system facts should resolve correctly for Server 2019 Change By: Enis Inan Release Notes Summary: Facter now correctly distinguishes between Windows Server 2016 and Windows Server 2019. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1415) Replace Facter 3.x Windows Operating System kernel query with Windows Kernel API call RtlGetVersion
Title: Message Title Enis Inan updated an issue Facter / FACT-1415 Replace Facter 3.x Windows Operating System kernel query with Windows Kernel API call RtlGetVersion Change By: Enis Inan Release Notes: Not Needed Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9250) pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d
Title: Message Title Enis Inan commented on PUP-9250 Re: pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d Geoff Nichols Done. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9250) pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d
Title: Message Title Enis Inan updated an issue Puppet / PUP-9250 pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d Change By: Enis Inan Release Notes Summary: Puppet::Util.safe_posix_fork now ensures that the child process' stdin, stdout, and stderr streams are redirected to the passed-in files by referencing the corresponding STDIN, STDOUT and STDERR ruby constants instead of the mutable global variables $stdin, $stdout and $stderr. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9250) pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d
Title: Message Title
Enis Inan commented on PUP-9250
Re: pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d
I've also verified that this is not an issue on Windows, i.e. the custom fact works properly there:
Facter.add('custom_fact') do
setcode do
require 'puppet'
x = Puppet::Util::Execution.execute('cmd.exe /c echo EXECUTE')
'custom_fact'
end
end
PS C:\cygwin64\root> C:\ProgramFiles64Folder\PuppetLabs\Puppet\bin\facter.bat --custom-dir CUSTOM_FACTS/ --json --debug --query custom_fact 2>$null
{
"custom_fact": "custom_fact"
}
Jira (PUP-9250) pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d
Title: Message Title Enis Inan commented on PUP-9250 Re: pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d Moved this to a PUP ticket since the issue's with Puppet. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9250) pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d
Title: Message Title Enis Inan moved an issue Puppet / PUP-9250 pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d Change By: Enis Inan Key: FACT PUP - 1892 9250 Project: Facter Puppet Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1892) pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d
Title: Message Title Enis Inan updated an issue Facter / FACT-1892 pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d Change By: Enis Inan Comment: Nevermind on the STDOUT => STDERR redirection. I realized my custom fact was using STDOUT instead of $stdout (apologies for being an idiot there). Changing it to $stdout.puts shows that FACT-1870 is doing the right thing.Looks like the issue is just the safe_posix_fork stuff I mentioned earlier. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1892) pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d
Title: Message Title
Enis Inan updated an issue
Facter / FACT-1892
pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d
Change By:
Enis Inan
Comment:
There's several things going on here. Here's my custom fact:{code}Facter.add('custom_fact') do setcode dorequire 'puppet'Puppet::Util::Execution.execute('echo THIS_SHOULD_NOT_PRINT')STDOUT.puts("STDOUT")'custom_fact' endend{code}Invoking facter:{code}[root@v4wf528eg09c0we ~]# facter --custom-dir CUSTOM_FACTS/ --json --debug --query custom_fact 2>/dev/nullCALLING EXECUTE, SHOULD NOT PRINTSTDOUT{ "custom_fact": "custom_fact"}{code}When reverting the changes for FACT-1870, here's what's displayed{code}[root@v4wf528eg09c0we ~]# facter --custom-dir CUSTOM_FACTS/ --json --debug --query custom_fact 2>/dev/nullSTDOUT{ "custom_fact": "custom_fact"}{code}It looks like STDOUT isn't being redirected to STDERR, and whatever's happening is also messing up Puppet::Util::Execution.execute (the latter is why all of that rpm output was there when running the task).
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To
Jira (FACT-1892) pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d
Title: Message Title
Enis Inan updated an issue
Facter / FACT-1892
pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d
Change By:
Enis Inan
Comment:
Redirecting STDOUT to STDERR messes up Puppet::Util::Execution{code}enis:facter enis.inan$ irb2.4.2 :001 > require 'puppet' => true2.4.2 :002 > x = Puppet::Util::Execution.execute("echo CALLED_EXECUTE") => "CALLED_EXECUTE\n"2.4.2 :003 > x => "CALLED_EXECUTE\n"2.4.2 :004 > $stdout = $stderr => #>2.4.2 :005 > x = Puppet::Util::Execution.execute("echo CALLED_EXECUTE")CALLED_EXECUTE => ""2.4.2 :006 > x => ""{code}And{code}enis:facter enis.inan$ irb 2>/dev/null2.4.2 :001 > require 'puppet' => true2.4.2 :002 > x = Puppet::Util::Execution.execute("echo CALLED_EXECUTE") => "CALLED_EXECUTE\n"2.4.2 :003 > x => "CALLED_EXECUTE\n"2.4.2 :004 > $stderr.puts("SHOULD NOT PRINT") => nil2.4.2 :005 > $stdout = $stderr2.4.2 :006 > x = Puppet::Util::Execution.execute("echo CALLED_EXECUTE")CALLED_EXECUTE2.4.2 :007 > x{code}(even when stderr is redirected to /dev/null, execute still prints something when it is not supposed to).
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
--
You received this message because you are subscribed to the Google
Jira (FACT-1892) pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d
Title: Message Title Enis Inan commented on FACT-1892 Re: pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d Nevermind on the STDOUT => STDERR redirection. I realized my custom fact was using STDOUT instead of $stdout. Changing it to $stdout.puts shows that FACT-1870 is doing the right thing. Looks like the issue is just the safe_posix_fork stuff I mentioned earlier. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1892) pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d
Title: Message Title Enis Inan commented on FACT-1892 Re: pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d Figured out what's going on for Puppet::Util::Execution.execute. Looking at safe_posix_fork, we reopen $stdin, $stdout, and $stderr. Also note that the child process inherits the parent's STDOUT stream. When $stdout = $stderr, we do not reopen the STDOUT. Thus, the child process will not be writing to our passed-in stdout but to the parent's stdout instead. Fixing that part to open the STDOUT and STDERR constants instead produces the right behavior. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1892) pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d
Title: Message Title
Enis Inan commented on FACT-1892
Re: pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d
Redirecting STDOUT to STDERR messes up Puppet::Util::Execution
enis:facter enis.inan$ irb
2.4.2 :001 > require 'puppet'
=> true
2.4.2 :002 > x = Puppet::Util::Execution.execute("echo CALLED_EXECUTE")
=> "CALLED_EXECUTE\n"
2.4.2 :003 > $stdout = $stderr
=> #>
2.4.2 :004 > x = Puppet::Util::Execution.execute("echo CALLED_EXECUTE")
CALLED_EXECUTE
=> ""
2.4.2 :005 > x
=> ""
And
Jira (FACT-1892) pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d
Title: Message Title
Enis Inan commented on FACT-1892
Re: pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d
There's several things going on here. Here's my custom fact:
Facter.add('custom_fact') do
setcode do
require 'puppet'
Puppet::Util::Execution.execute('echo THIS_SHOULD_NOT_PRINT')
STDOUT.puts("STDOUT")
'custom_fact'
end
end
Invoking facter:
[root@v4wf528eg09c0we ~]# facter --custom-dir CUSTOM_FACTS/ --json --debug --query custom_fact 2>/dev/null
CALLING EXECUTE, SHOULD NOT PRINT
STDOUT
Jira (FACT-1892) pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d
Title: Message Title Enis Inan commented on FACT-1892 Re: pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d Made this a facter ticket because that's what is causing this issue, specifically https://github.com/puppetlabs/facter/pull/1751/commits/4a7ddb9d4ece7af89ecf9546507fe11216d1be5b#diff-cfd7b7fce6a29f4dc809ee437588d58dR335 (I think that commit inadvertently redirected stderr to stdout) Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1892) pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d
Title: Message Title Enis Inan moved an issue Facter / FACT-1892 pe-task's facter_task is failing with the promotion of puppet-agent 5.5.6.180.g8b5d99d Change By: Enis Inan Key: PE FACT - 25380 1892 Project: Puppet Enterprise [Internal] Facter Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2175) Consider Adding Provider To The Default Output of `puppet resource package`
Title: Message Title Enis Inan assigned an issue to Enis Inan Puppet / PUP-2175 Consider Adding Provider To The Default Output of `puppet resource package` Change By: Enis Inan Assignee: Enis Inan Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts
Title: Message Title Enis Inan updated an issue Facter / FACT-1873 Custom facts that aren't suitable should not override built-in facts Change By: Enis Inan Affects Version/s: FACT 3.11.3 Affects Version/s: FACT 3.11.4 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9150) cwd option in Puppet::Util::Execution.execute should work with different Windows path types
Title: Message Title Enis Inan assigned an issue to Enis Inan Puppet / PUP-9150 cwd option in Puppet::Util::Execution.execute should work with different Windows path types Change By: Enis Inan Assignee: Enis Inan Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Enis Inan assigned an issue to Enis Inan Facter / FACT-1889 Windows operating system facts should resolve correctly for Server 2019 Change By: Enis Inan Assignee: Enis Inan Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9233) Issues with Cron resource type creating duplicate crons
Title: Message Title Enis Inan commented on PUP-9233 Re: Issues with Cron resource type creating duplicate crons Moving this back to blocked because I'm unable to repro. MODULES-7778 (and there's likely still some ongoing discussion left about this in that ticket). Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
