Jira (PUP-4200) puppet-lint reports incorrect line numbers

2015-03-13 Thread Todd Lewis (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Todd Lewis created an issue 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 Puppet /  PUP-4200 
 
 
 
  puppet-lint reports incorrect line numbers  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 2015/03/13 2:28 PM 
 
 
 

Environment:
 
 
RedHat EL6 on x86_64 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Todd Lewis 
 
 
 
 
 
 
 
 
 
 
puppet-lint reports incorrect line numbers for issues it finds if there are multi-line string constants preceding the issue. For example, if the .pp file being examined has a 6 line string starting on line 100 and a 46 line string starting on line 150, then a problem with line 250 is reported as being on line 200. Also, the --with-context option will show the text of line 200 rather than the text of line 250 where the actual error is. 
In short, multi-line strings throws puppet-lint's error reporting off.That is, line counting gets thrown off by N-1 for each N-line string.  
Our puppet-lint --version returns puppet-lint 1.1.0 if that helps. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
  

Jira (PUP-1343) Service provider in RedHat will not create K?? stop scripts

2014-12-29 Thread Todd Lewis (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Todd Lewis commented on  PUP-1343 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Service provider in RedHat will not create K?? stop scripts  
 
 
 
 
 
 
 
 
 
 
There's a telling assumption in Jason Antman's comment above (https://tickets.puppetlabs.com/browse/PUP-1343?focusedCommentId=37304page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-37304): this should be the job of a package or whatever else installs the service/init script. At our site, that whatever else is puppet. We're using puppet to install locally built packages along with their init scripts, and we're hoping/expecting to be able to have puppet ensure that the appropriate K?? and S?? links are in place. If they aren't, for whatever reason, it should be ease to have puppet fix that. As it is, we get puppet-created S?? links without the corresponding K?? links, and apparently no way to get them without coding raw chkconfig commands. It seems strange to me that in all the things puppet can do, there's no way to simply express service blah should have S?? and K?? links; fix that if they are missing. 
This probably gets cleaner under systemd, as 'enable' and 'disable' map more directly to puppet directives, and are completely orthogonal to 'start' and 'stop'. We're not there yet though. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1343) Service provider in RedHat will not create K?? stop scripts

2014-06-04 Thread Todd Lewis (JIRA)
Title: Message Title










 

 Todd Lewis commented on an issue


















  Re: Service provider in RedHat will not create K?? stop scripts 










Having just gotten bitten by the lack of K?? stop scripts, I'm keen to see this resolved. Consider: if it's not okay for puppet to create K?? stop scripts, then why is it okay for it to create S?? start scripts with service enable? Clean shutdown of services should be an easy option, and it's clearly missing.












   

 Add Comment

























 Puppet /  PUP-1343



  Service provider in RedHat will not create K?? stop scripts 







 When a service is set to be enabled the provider/service/redhat.rb provider will run /sbin/chkconfig $name on which will only create the links for starting the service but will not for stopping it. The correct command is /sbin/chkconfig --add $name.   This is important for those services that require stopping cleanly before other services.  















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send